Commits · 3150bf387025639b618a4fe841e5d93b67388c3d · Linshizhi / V8

16 Jul, 2014 1 commit

X87: Drop unnecessary receiver validity checks from {Load,Store}IC_Normal · 3150bf38

weiliang.lin@intel.com authored Jul 16, 2014

port r22391

original commit message:
   Drop unnecessary receiver validity checks from {Load,Store}IC_Normal.

   Since these builtins are used as handlers after a map check/dispatch, they don't need to check the receiver again.

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/396833004

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22416 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3150bf38

15 Jul, 2014 22 commits

MIPS: Minor fixes to r22396 · f7df8a41

akos.palfi@imgtec.com authored Jul 15, 2014

BUG=
R=akos.palfi@imgtec.com

Review URL: https://codereview.chromium.org/394913002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22413 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f7df8a41

MIPS: Fix r19500 register usage to match to ASSERT. · 71bfbf49

akos.palfi@imgtec.com authored Jul 15, 2014

BUG=
R=akos.palfi@imgtec.com

Review URL: https://codereview.chromium.org/395863002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22412 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71bfbf49

MIPS: Drop unnecessary receiver validity checks from {Load,Store}IC_Normal. · 1578cfee

akos.palfi@imgtec.com authored Jul 15, 2014

Port r22391 (fe86010)

Original commit message:
Since these builtins are used as handlers after a map check/dispatch, they don't need to check the receiver again.

BUG=
R=akos.palfi@imgtec.com

Review URL: https://codereview.chromium.org/396663004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1578cfee

MIPS64: Reland r22082 "Replace HeapNumber as doublebox with an explicit MutableHeapNumber. · db477d7f

dusan.milosavljevic@rt-rk.com authored Jul 15, 2014

Port r22129 (676bb14).

TEST=
BUG=
R=balazs.kilvady@imgtec.com, paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/395803002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db477d7f

Revert "Remove failure tag.". · 8e1ece25

hpayer@chromium.org authored Jul 15, 2014

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/398473002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8e1ece25

Remove failure tag. · 46135f28

hpayer@chromium.org authored Jul 15, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/397613002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

46135f28

Fix assertion failure. Use Vector instead of List in code deserializer. · 23eebeed

yangguo@chromium.org authored Jul 15, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/390353002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

23eebeed

Allow embedding of ConsString objects into code. · 5874bd08

mstarzinger@chromium.org authored Jul 15, 2014

R=yangguo@chromium.org
BUG=v8:2803
LOG=N

Review URL: https://codereview.chromium.org/395713002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5874bd08

X87: Use the same registers for StoreIC and KeyedStoreIC. · 1ca4454a

weiliang.lin@intel.com authored Jul 15, 2014

port r22387

original commit message:
  Use the same registers for StoreIC and KeyedStoreIC.

  Based on https://codereview.chromium.org/389283002 ("Use register parameters in ElementsTransitionGenerator") which must land first.

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/391933002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22405 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1ca4454a

Enum RegisterInfo renamed to ParameterIndices. · 0827316d

mvstanton@chromium.org authored Jul 15, 2014

"Info" is information-poor.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/385953004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0827316d

Do not dump user source code in the code serializer. · ed744ffa

yangguo@chromium.org authored Jul 15, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/390303002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22403 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed744ffa

X87: Use register parameters in ElementsTransitionGenerator · 2aad6f00

weiliang.lin@intel.com authored Jul 15, 2014

port r22384

original commit message:
 Use register parameters in ElementsTransitionGenerator
x

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/395633010

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aad6f00

Unify the IsShortcutCandidate predicate. · ee515106

mstarzinger@chromium.org authored Jul 15, 2014

R=yangguo@chromium.org
BUG=v8:2803
LOG=N

Review URL: https://codereview.chromium.org/390193007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ee515106

Fix up internalized strings after deserializing user code. · fd578116

yangguo@chromium.org authored Jul 15, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/387343002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd578116

MIPS: Use the same registers for StoreIC and KeyedStoreIC. · fb812df5

akos.palfi@imgtec.com authored Jul 15, 2014

Port r22387 (ff76c666)

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/390263002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fb812df5

MIPS: Use register parameters in ElementsTransitionGenerator. · d6fcb81a

akos.palfi@imgtec.com authored Jul 15, 2014

Port r22384 (52caca20)

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/393693003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22396 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d6fcb81a

X87: Clean up and update const / var · 23887bf9

weiliang.lin@intel.com authored Jul 15, 2014

port r22379

original commit message:
This CL simplifies var / const by ensuring the behavior is consistent in itself,
and with regular JS semantics; between regular var/const and eval-ed var/const.

Legacy const is changed so that a declaration declares a configurable, but non-writable, slot,
 and the initializer reconfigures it (when possible) to non-configurable non-writable. This
 avoids the need for "the hole" as marker value in JSContextExtensionObjects and GlobalObjects.
Undefined is used instead.

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/397573002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

23887bf9

Remove sequential sweeping mode and perform lazy sweeping when no sweeper threads are active. · 9180b1a3

hpayer@chromium.org authored Jul 15, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/396443004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9180b1a3

fix the vtune support bug. · 319e5226

danno@chromium.org authored Jul 15, 2014

During https://code.google.com/p/v8/source/detail?r=19925 checkin context bound scripts (Script)
and context unbound scripts (UnboundScript) are Distinguished.

And then Sven Panne helped to fix the vtune support compilation
error in https://code.google.com/p/v8/source/detail?r=20955.

The problem is that there is runtime error for vtune
support.
In our original implementation, we encapsulated and passed v8::internal::Script
to V8 API. It will leads to type check error for current V8::Script definition.

So I changed the Handle<Script> definition in JitCodeEvent
to Handle<UnboundScript>
 and add the corresponding change in log.cc.

If you do NOT prefer to change in include/v8.h. I think I can change the definition of
CodeEventLogger::LogRecordedBuffer(...) so that the we can pass the correct
type (JSFunction) as V8::Script to V8 API.

BUG=
R=danno@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/334263018

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

319e5226

Fix flags for test cases involving arrow functions · 5de6d47a

marja@chromium.org authored Jul 15, 2014

There are a lot of tests in cctest/test-parsing/ErrorsArrowFunctions,
so it is quite slow. This patch removes some flags to make it faster.
Removing three flags that don't affect the test brings down the run
time one order of magnitude, which is fast enough even for debug/ASAN
bots.

Also, remove the unneeded kArrowFunctions flag from
cctest/test-parsing/NoErrorsYieldSloppyAllModes

BUG=
R=marja@chromium.org

Review URL: https://codereview.chromium.org/387383002

Patch from Adrián Pérez de Castro <aperez@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5de6d47a

Drop unnecessary receiver validity checks from {Load,Store}IC_Normal. · 23cf6223

jkummerow@chromium.org authored Jul 15, 2014

Since these builtins are used as handlers after a map check/dispatch, they don't need to check the receiver again.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/390053002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

23cf6223

Removed some copy-n-paste from StackFrame::Foo API entries. · cd098005

svenpanne@chromium.org authored Jul 15, 2014

BUG=v8:3436
LOG=y
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/388183002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cd098005

14 Jul, 2014 17 commits

Use the same registers for StoreIC and KeyedStoreIC. · 086290ba

mvstanton@chromium.org authored Jul 14, 2014

Based on https://codereview.chromium.org/389283002 ("Use register parameters in ElementsTransitionGenerator") which must land first.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/390013002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22387 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

086290ba

MIPS: Remove ASSERT since there are tons of different ASSIGN variants · acffe8c7

kilvadyb@homejinni.com authored Jul 14, 2014

Port r22382 (84a841f)

BUG=
R=akos.palfi@imgtec.com

Review URL: https://codereview.chromium.org/395503002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

acffe8c7

MIPS: This CL simplifies var / const by ensuring the behavior is consistent in... · ea1d4db8

kilvadyb@homejinni.com authored Jul 14, 2014

MIPS: This CL simplifies var / const by ensuring the behavior is consistent in itself, and with regular JS semantics; between regular var/const and eval-ed var/const.

Port r22379 (fb62653)

Original commit message:
Legacy const is changed so that a declaration declares a configurable, but non-writable, slot, and the initializer reconfigures it (when possible) to non-configurable non-writable. This avoids the need for "the hole" as marker value in JSContextExtensionObjects and GlobalObjects. Undefined is used instead.

BUG=
R=akos.palfi@imgtec.com

Review URL: https://codereview.chromium.org/389373004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22385 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea1d4db8

Use register parameters in ElementsTransitionGenerator. · 490c6171

mvstanton@chromium.org authored Jul 14, 2014

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/389283002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22384 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

490c6171

Remove PropertyAttributes from SetProperty · 6466ff39

verwaest@chromium.org authored Jul 14, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/390833003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6466ff39

Remove ASSERT since there are tons of different ASSIGN variants · e3a269b7

verwaest@chromium.org authored Jul 14, 2014

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/385173009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22382 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e3a269b7

Replace AddProperty by AddNamedProperty to speed up the common case · 1d55a634

verwaest@chromium.org authored Jul 14, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/384003003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d55a634

Fix d8 object printing (symbols, accessors) · 3fade8e4

rossberg@chromium.org authored Jul 14, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/388243002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22380 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3fade8e4

This CL simplifies var / const by ensuring the behavior is consistent in... · aa7198df

verwaest@chromium.org authored Jul 14, 2014

This CL simplifies var / const by ensuring the behavior is consistent in itself, and with regular JS semantics; between regular var/const and eval-ed var/const.

Legacy const is changed so that a declaration declares a configurable, but non-writable, slot, and the initializer reconfigures it (when possible) to non-configurable non-writable. This avoids the need for "the hole" as marker value in JSContextExtensionObjects and GlobalObjects. Undefined is used instead.

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/379893002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aa7198df

Reland "Include symbol properties in Object.{create,defineProperties}" · 942fe191

rossberg@chromium.org authored Jul 14, 2014

Second try; implementation that doesn't rely on external arrays.

R=mstarzinger@chromium.org
BUG=v8:3440

Review URL: https://codereview.chromium.org/391713002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

942fe191

Fix error message about read-only symbol properties. · cb3e2beb

mstarzinger@chromium.org authored Jul 14, 2014

R=rossberg@chromium.org
BUG=v8:3441
LOG=Y

Review URL: https://codereview.chromium.org/390783003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb3e2beb

Revert "Remove sequential sweeping mode and perform lazy sweeping when no... · f28f6102

titzer@chromium.org authored Jul 14, 2014

Revert "Remove sequential sweeping mode and perform lazy sweeping when no sweeper threads are active."

Reason: broke win64 build

This reverts commit 221bfdd2da2b6f3c1cbe77c5d197f1ea626b0bd2.

TBR=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/393523002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f28f6102

Revert "Include symbol properties in Object.{create,defineProperties}" · f2536bf7

rossberg@chromium.org authored Jul 14, 2014

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/394443002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f2536bf7

Remove sequential sweeping mode and perform lazy sweeping when no sweeper threads are active. · 030df48c

hpayer@chromium.org authored Jul 14, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/384373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22372 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

030df48c

Serialize builtins by referencing canonical ones. · ba8bbee6

yangguo@chromium.org authored Jul 14, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/383173002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ba8bbee6

Include symbol properties in Object.{create,defineProperties} · 5c8d0d18

rossberg@chromium.org authored Jul 14, 2014

R=mstarzinger@chromium.org
BUG=v8:3440
LOG=Y

Review URL: https://codereview.chromium.org/391683002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c8d0d18

Unify LookupIterator::GetRoot and Objects::GetRootMap · 71295754

jochen@chromium.org authored Jul 14, 2014

BUG=none
R=verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/388193002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71295754