- 01 Apr, 2015 10 commits
-
-
mike authored
The removed assertion consistently passes not because the invoked `close` method internally throws a `TypeError` but because the `close` method does not exist. The ES6 specification does not define a `close` method on the GeneratorPrototype, so this test is a tautology. BUG=None LOG=N R=arv Review URL: https://codereview.chromium.org/1046963002 Cr-Commit-Position: refs/heads/master@{#27567}
-
mike authored
The modified assertions targeted the property descriptor for the template object's first "cooked" value. The code immediately preceeding these statements asserts these values. Update the assertions to instead target the property descriptor for the template object's first "raw" value (which are otherwise untested). BUG= Review URL: https://codereview.chromium.org/1049523003 Cr-Commit-Position: refs/heads/master@{#27566}
-
jochen authored
Revert of Add CHECKs when updating pointers from the slots and store buffers (patchset #3 id:40001 of https://codereview.chromium.org/1035763002/) Reason for revert: Got one dev-channel with this. Should be enough. Original issue's description: > Add CHECKs when updating pointers from the slots and store buffers > > We want to verify that we always overwrite heap objects with heap > objects, and non-heap objects with non-heap objects > > BUG=chromium:452095 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/58fbcfac8ae82b1241f07e1b8ea81a5973514c11 > Cr-Commit-Position: refs/heads/master@{#27479} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452095 Review URL: https://codereview.chromium.org/1052713002 Cr-Commit-Position: refs/heads/master@{#27565}
-
kozyatinskiy authored
Revert of Correctly compute line numbers in functions from the function constructor. (patchset #5 id:80001 of https://codereview.chromium.org/701093003/) Reason for revert: Locations from New Function are broken in DevTools. Original issue's description: > Correctly compute line numbers in functions from the function constructor. > > R=aandrey@chromium.org > BUG=chromium:109362 > LOG=Y > > Committed: https://code.google.com/p/v8/source/detail?r=25289 TBR=aandrey@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:109362 LOG=Y Review URL: https://codereview.chromium.org/1053563002 Cr-Commit-Position: refs/heads/master@{#27564}
-
hablich authored
[-h] [-g GIT_DIR] hash positional arguments: hash Hash of the commit to be searched. optional arguments: -h, --help show this help message and exit -g GIT_DIR, --git-dir GIT_DIR The path to your git working directory. BUG= Review URL: https://codereview.chromium.org/1033043002 Cr-Commit-Position: refs/heads/master@{#27563}
-
erikcorry authored
Revert of Fix JSON parser Handle leak (patchset #3 id:40001 of https://codereview.chromium.org/1041483004/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Fix JSON parser Handle leak > > R=verwaest@chromium.org > BUG=v8:3976 > LOG=y > > Committed: https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa > Cr-Commit-Position: refs/heads/master@{#27512} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3976 Review URL: https://codereview.chromium.org/1052593002 Cr-Commit-Position: refs/heads/master@{#27562}
-
erikcorry authored
Revert of Relax assert a little to fix flake on regress-3976 (patchset #1 id:1 of https://codereview.chromium.org/1045763002/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Relax assert a little to fix flake on regress-3976 > > R=verwaest@chromium.org > NOTRY=true > BUG= > > Committed: https://crrev.com/b20edd7772892ff8b2b280b35e521fbc2cc4a5f6 > Cr-Commit-Position: refs/heads/master@{#27515} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1050033003 Cr-Commit-Position: refs/heads/master@{#27561}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#27560}
-
halton.huo authored
This commit is to fix the linking error: ../../v8/src/base/platform/platform-posix.cc:418: error: undefined reference to '__android_log_vprint' Review URL: https://codereview.chromium.org/1037193003 Cr-Commit-Position: refs/heads/master@{#27559}
-
arv authored
This reverts commit 992751d0. The final spec for Object.getPrototypeOf calls ToObject on the parameter, which means that it should only throw for null and undefined. For other non object values the prototype of the wrapper should be used. Difference from last time: Updated .status and will disable Blink side tests as needed. BUG=v8:3964 LOG=N R=adamk, rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1051523003 Cr-Commit-Position: refs/heads/master@{#27558}
-
- 31 Mar, 2015 26 commits
-
-
adamk authored
It triggers once per context that calls observe (or attempts to access any observation metadata, e.g. through Object.getNotifier). Review URL: https://codereview.chromium.org/1048213002 Cr-Commit-Position: refs/heads/master@{#27557}
-
dusan.milosavljevic authored
TEST=test-assembler-mips/MIPS16 BUG= Review URL: https://codereview.chromium.org/1047223002 Cr-Commit-Position: refs/heads/master@{#27556}
-
akos.palfi authored
Port 7c347c54 BUG= Review URL: https://codereview.chromium.org/1049793002 Cr-Commit-Position: refs/heads/master@{#27555}
-
kozyatinskiy authored
In DevTools we've already used sourceURL in inline scripts. This CL makes the behavior of the V8 in the same for Error.stack property and v8::StackTrace. BUG=v8:3920 LOG=Y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1044173002 Cr-Commit-Position: refs/heads/master@{#27554}
-
paul.lind authored
Lack of sign extension on simulator builds gives bad value for RETRY and EXCEPTION codes. TEST=mjsunit/regexp-stack-overflow, regress-crbug-467047 BUG=v8:3992 LOG=n Review URL: https://codereview.chromium.org/1040753003 Cr-Commit-Position: refs/heads/master@{#27553}
-
michael_dawson authored
Port 7c347c54 Original commit message: A bug allows JSObject literals with elements to have the elements in the boilerplate modified. R=mbrandy@us.ibm.com BUG=466993 LOG=N Review URL: https://codereview.chromium.org/1046223002 Cr-Commit-Position: refs/heads/master@{#27552}
-
balazs.kilvady authored
Add missing parts of the port to MIPS/MIPS64 implementations. BUG= Review URL: https://codereview.chromium.org/1047213002 Cr-Commit-Position: refs/heads/master@{#27551}
-
jochen authored
Embedders should use IdleNotificationDeadline() BUG=none R=hpayer@chromium.org LOG=y Review URL: https://codereview.chromium.org/1019793008 Cr-Commit-Position: refs/heads/master@{#27550}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1050543002 Cr-Commit-Position: refs/heads/master@{#27549}
-
arv authored
The spec settled on ToBoolean instead of only using not undefined. BUG=v8:3827 LOG=N R=adamk Review URL: https://codereview.chromium.org/1045113002 Cr-Commit-Position: refs/heads/master@{#27548}
-
michael_dawson authored
Port 8dad78cd Original commit message: This adds the basics necessary to support float32 operations in TurboFan. The actual functionality required to detect safe float32 operations will be added based on this later. Therefore this does not affect production code except for some cleanup/refactoring. In detail, this patchset contains the following features: - Add support for float32 operations to arm, arm64, ia32 and x64 backends. - Add float32 machine operators. - Add support for float32 constants to simplified lowering. - Handle float32 representation for phis in simplified lowering. In addition, contains the following (related) cleanups: - Fix/unify naming of backend instructions. - Use AVX comparisons when available. - Extend ArchOpcodeField to 9 bits (required for arm64). - Refactor some code duplication in instruction selectors. BUG=v8:3589 LOG=N R=mbrandy@us.ibm.com Review URL: https://codereview.chromium.org/1049253004 Cr-Commit-Position: refs/heads/master@{#27547}
-
mstarzinger authored
This ensures that all expressions that throw actually mark the current environment as dead in the AstGraphBuilder. This prevents live ranges from being unnecessarily increased by paths that don't fall-through. Note that we can do that because Runtime::kThrowFoo never returns. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1049203002 Cr-Commit-Position: refs/heads/master@{#27546}
-
arv authored
We have been shipping harmony numeric literals since M41 R=rossberg@chromium.org LOG=Y Review URL: https://codereview.chromium.org/1024603002 Cr-Commit-Position: refs/heads/master@{#27545}
-
ulan authored
BUG=chromium:450824 LOG=NO TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1048013003 Cr-Commit-Position: refs/heads/master@{#27544}
-
arv authored
Second try. Disabled the tests that were failing due to https://github.com/tc39/test262/issues/215 This updates test262 to revision d24fd10 (2015/03/11). The files moved around in the test repo and a lot of new tests are failing. BUG=None LOG=N R=adamk, rossberg Review URL: https://codereview.chromium.org/1040093003 Cr-Commit-Position: refs/heads/master@{#27543}
-
jarin authored
BUG=chromium:472078 LOG=n R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1047173002 Cr-Commit-Position: refs/heads/master@{#27542}
-
mstarzinger authored
This changes the IrOpcode::kThrow operator to have kNoThrow property, which sounds unintuitive, but holds for our graphs. The operators is used to indicate exceptional control flow out of the function, but in itself does not throw, the throwing is done by a runtime call. R=titzer@chromium.org TEST=unittests/CommonOperatorTest/CommonSharedOperatorTest.Properties Review URL: https://codereview.chromium.org/1046173002 Cr-Commit-Position: refs/heads/master@{#27541}
-
svenpanne authored
Currently this only sets branch hints, so we get unlikely code "out of the way", but in the long run the register allocator needs some love to treat the unlikely code as, well, unlikely. :-) Review URL: https://codereview.chromium.org/1048063002 Cr-Commit-Position: refs/heads/master@{#27540}
-
verwaest authored
BUG=chromium:471554 LOG=y R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1050493002 Cr-Commit-Position: refs/heads/master@{#27539}
-
dcarney authored
R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/1041163002 Cr-Commit-Position: refs/heads/master@{#27538}
-
mstarzinger authored
TEST=cctest/test-run-jsexceptions Review URL: https://codereview.chromium.org/989123003 Cr-Commit-Position: refs/heads/master@{#27537}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1040183004 Cr-Commit-Position: refs/heads/master@{#27536}
-
rmcilroy authored
The libdl library is already included on target builds of Android and needs to be added to the build command line with a particular order to avoid undefined references in other libraries. Fix this by only explicitly including it in host builds and relying on the implicit inclusion on target builds. Also remove the librt hack which is not longer necessary due to the AOSP build bot having been removed. BUG=chromium:469973 LOG=Y Review URL: https://codereview.chromium.org/1036133005 Cr-Commit-Position: refs/heads/master@{#27535}
-
akos.palfi authored
Port 8dad78cd Original commit message: This adds the basics necessary to support float32 operations in TurboFan. The actual functionality required to detect safe float32 operations will be added based on this later. Therefore this does not affect production code except for some cleanup/refactoring. In detail, this patchset contains the following features: - Add support for float32 operations to arm, arm64, ia32 and x64 backends. - Add float32 machine operators. - Add support for float32 constants to simplified lowering. - Handle float32 representation for phis in simplified lowering. In addition, contains the following (related) cleanups: - Fix/unify naming of backend instructions. - Use AVX comparisons when available. - Extend ArchOpcodeField to 9 bits (required for arm64). - Refactor some code duplication in instruction selectors. BUG= Review URL: https://codereview.chromium.org/1045203003 Cr-Commit-Position: refs/heads/master@{#27534}
-
mvstanton authored
Because simulators have a seperate JavaScript and C++ stack, and because they try to avoid calling the runtime StackCheck function on entry to every function, it can happen in recursive calls that the C++ stack overflows while the JavaScript stack is okay. The runtime StackCheck function would catch this, but as an optimization, generated code only looks at the JavaScript stack pointer to determine if it should make that runtime call. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1050433002 Cr-Commit-Position: refs/heads/master@{#27533}
-
v8-autoroll authored
Rolling v8/third_party/icu to 46be516de5c83aa0b7b3b75be669b48e7a803290 Rolling v8/tools/clang to 6aa9a498bf4c1567efe9b78da82678ed1e8e3298 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1046053003 Cr-Commit-Position: refs/heads/master@{#27532}
-
- 30 Mar, 2015 4 commits
-
-
balazs.kilvady authored
Port 8dad78cd Original commit message: This adds the basics necessary to support float32 operations in TurboFan. The actual functionality required to detect safe float32 operations will be added based on this later. Therefore this does not affect production code except for some cleanup/refactoring. In detail, this patchset contains the following features: - Add support for float32 operations to arm, arm64, ia32 and x64 backends. - Add float32 machine operators. - Add support for float32 constants to simplified lowering. - Handle float32 representation for phis in simplified lowering. In addition, contains the following (related) cleanups: - Fix/unify naming of backend instructions. - Use AVX comparisons when available. - Extend ArchOpcodeField to 9 bits (required for arm64). - Refactor some code duplication in instruction selectors. BUG=v8:3589 LOG=n Review URL: https://codereview.chromium.org/1046953004 Cr-Commit-Position: refs/heads/master@{#27531}
-
dusan.milosavljevic authored
TEST= BUG= Review URL: https://codereview.chromium.org/1046873004 Cr-Commit-Position: refs/heads/master@{#27530}
-
rmcilroy authored
The V8::IdleNotification will only return 'True' when the gc idle time handler thinks there is no more GC which can be done. However, the gc idle task handler can end up repeatedly making no progress (e.g., if it can't finalize a sweep) which causes idle tasks to be repeatedly scheduled in Chrome which do nothing but wake up Chrome. Fix this by returning Done if we can't make any progress within an Idle Round. BUG=chromium:470615 LOG=Y Review URL: https://codereview.chromium.org/1042483002 Cr-Commit-Position: refs/heads/master@{#27529}
-
ishell authored
BUG=chromium:470804 LOG=Y Review URL: https://codereview.chromium.org/1033273005 Cr-Commit-Position: refs/heads/master@{#27528}
-