1. 05 Jul, 2022 2 commits
    • Maya Lekova's avatar
      Reland "[fastcall] Support EnforceRange annotation" · 8559a04f
      Maya Lekova authored
      This is a reland of commit 84e078c6. It fixes an undefined behaviour and guards against NaNs in d8-test.cc.
      
      Original change's description:
      > [fastcall] Support EnforceRange annotation
      >
      > This CL implements checks in case EnforceRange is requested for a
      > given parameter by using TryTruncate* operators. It implements 2 such
      > truncations on x64 and arm64 - TryTruncateFloat64ToInt32 and
      > TryTruncateFloat64ToUint32.
      >
      > Bug: chromium:1052746
      > Change-Id: I32f34d9dc1265af568cc576663620a8f7f8245f6
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721618
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Commit-Queue: Maya Lekova <mslekova@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#81512}
      
      Bug: chromium:1052746, chromium:1341851, chromium:1341891
      Change-Id: I21e0e452c92cc93f8b06985a335f409855be0546
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743518Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#81529}
      8559a04f
    • Manos Koukoutos's avatar
      Revert "[fastcall] Support EnforceRange annotation" · d9b62c16
      Manos Koukoutos authored
      This reverts commit 84e078c6.
      
      Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/22000/overview
      
      Original change's description:
      > [fastcall] Support EnforceRange annotation
      >
      > This CL implements checks in case EnforceRange is requested for a
      > given parameter by using TryTruncate* operators. It implements 2 such
      > truncations on x64 and arm64 - TryTruncateFloat64ToInt32 and
      > TryTruncateFloat64ToUint32.
      >
      > Bug: chromium:1052746
      > Change-Id: I32f34d9dc1265af568cc576663620a8f7f8245f6
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721618
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Commit-Queue: Maya Lekova <mslekova@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#81512}
      
      Bug: chromium:1052746
      Change-Id: I2218681c7cb5d05dea6d8ac5347b19bc0070c1a6
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743514
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      Owners-Override: Manos Koukoutos <manoskouk@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#81513}
      d9b62c16
  2. 04 Jul, 2022 1 commit