- 30 Apr, 2019 1 commit
-
-
Ben L. Titzer authored
R=binji@chromium.org Change-Id: I936d906be90c0c6d3b84b5ad4e8cb574ab8cd970 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585851 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#61135}
-
- 11 Jan, 2018 1 commit
-
-
Ben Smith authored
It was included accidentally. It is not in the ES spec, nor is it provided by any other browser. BUG=chromium:793095 Change-Id: I2370a6d2b8d14def8dbd47ff4a1ffb4f5f65f097 Reviewed-on: https://chromium-review.googlesource.com/815757 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50491}
-
- 08 Apr, 2017 1 commit
-
-
binji authored
This revealed a bug in the TypedArray(typedArray) constructor when the arg is backed by a SharedArrayBuffer. Also install the species getter and add a test, since it's not tested in test262 presently. BUG=v8:5983,v8:5984 R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2798403004 Cr-Commit-Position: refs/heads/master@{#44500}
-
- 23 Mar, 2017 1 commit
-
-
binji authored
BUG=v8:5897 Review-Url: https://codereview.chromium.org/2741413006 Cr-Commit-Position: refs/heads/master@{#44075}
-
- 07 Jul, 2016 1 commit
-
-
franzih authored
Drive-by-fix: hydrogen code does not blindly return the byteLength offset, instead it executes what is defined in the byteLength getter. BUG= Review-Url: https://codereview.chromium.org/2123263002 Cr-Commit-Position: refs/heads/master@{#37595}
-
- 11 Mar, 2016 1 commit
-
-
adamk authored
ES2015 Object.prototype.toString semantics were enabled in version 4.9, which has been in stable Chrome for nearly two weeks at this point. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1784033002 Cr-Commit-Position: refs/heads/master@{#34732}
-
- 30 Dec, 2015 1 commit
-
-
littledan authored
Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of https://codereview.chromium.org/1554523002/ ) Reason for revert: Should be fixed again with this Blink change to add NeedsManualRebaseline Original issue's description: > Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) > > Reason for revert: > [Sheriff] Changes layout tests. Please fix upstream first if intended. > > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 > > Original issue's description: > > Use ES2015-style TypedArray prototype chain > > > > This patch switches TypedArrays to use the prototype chain described > > in the ES2015 specification, which adds a %TypedArray% superclass above > > all individual TypedArray types. Most methods are defined on the > > superclass rather than the subclasses. > > > > In order to prevent a performance regression, a few methods are > > marked as inline. Inlining might prevent code which was previously > > monomorphic from becoming polymorphic, and it was specifically > > applied in places where methods became more polymorphic than before. > > Tests with realistic workloads would be nice to do before this > > ships in stable. > > > > This patch does not bring TypedArrays up to full spec compliance. In > > particular, @@species is not yet supported. > > > > R=cbruni > > BUG=v8:4085 > > LOG=Y > > > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > > Cr-Commit-Position: refs/heads/master@{#33050} > > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4085 > > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c > Cr-Commit-Position: refs/heads/master@{#33053} TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org BUG=v8:4085 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1558663002 Cr-Commit-Position: refs/heads/master@{#33067}
-
- 29 Dec, 2015 1 commit
-
-
machenbach authored
Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first if intended. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 Original issue's description: > Use ES2015-style TypedArray prototype chain > > This patch switches TypedArrays to use the prototype chain described > in the ES2015 specification, which adds a %TypedArray% superclass above > all individual TypedArray types. Most methods are defined on the > superclass rather than the subclasses. > > In order to prevent a performance regression, a few methods are > marked as inline. Inlining might prevent code which was previously > monomorphic from becoming polymorphic, and it was specifically > applied in places where methods became more polymorphic than before. > Tests with realistic workloads would be nice to do before this > ships in stable. > > This patch does not bring TypedArrays up to full spec compliance. In > particular, @@species is not yet supported. > > R=cbruni > BUG=v8:4085 > LOG=Y > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > Cr-Commit-Position: refs/heads/master@{#33050} TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1554523002 Cr-Commit-Position: refs/heads/master@{#33053}
-
- 28 Dec, 2015 1 commit
-
-
littledan authored
This patch switches TypedArrays to use the prototype chain described in the ES2015 specification, which adds a %TypedArray% superclass above all individual TypedArray types. Most methods are defined on the superclass rather than the subclasses. In order to prevent a performance regression, a few methods are marked as inline. Inlining might prevent code which was previously monomorphic from becoming polymorphic, and it was specifically applied in places where methods became more polymorphic than before. Tests with realistic workloads would be nice to do before this ships in stable. This patch does not bring TypedArrays up to full spec compliance. In particular, @@species is not yet supported. R=cbruni BUG=v8:4085 LOG=Y Review URL: https://codereview.chromium.org/1541233002 Cr-Commit-Position: refs/heads/master@{#33050}
-
- 04 Dec, 2015 1 commit
-
-
machenbach authored
Revert of [es6] Correctify and unify ArrayBuffer and SharedArrayBuffer constructors. (patchset #2 id:20001 of https://codereview.chromium.org/1500543002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/1497763004/ Original issue's description: > [es6] Correctify and unify ArrayBuffer and SharedArrayBuffer constructors. > > The ArrayBuffer and SharedArrayBuffer constructors should raise an > exception when called with no arguments or undefined length. Also > unified the ArrayBuffer and SharedArrayBuffer implementations as C++ > builtins, and removed some (now) obsolete runtime entries. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3235ccbb7826ceec2188f6ebab98fc851b54f60e > Cr-Commit-Position: refs/heads/master@{#32590} TBR=yangguo@chromium.org,cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1501673002 Cr-Commit-Position: refs/heads/master@{#32606}
-
- 03 Dec, 2015 1 commit
-
-
bmeurer authored
The ArrayBuffer and SharedArrayBuffer constructors should raise an exception when called with no arguments or undefined length. Also unified the ArrayBuffer and SharedArrayBuffer implementations as C++ builtins, and removed some (now) obsolete runtime entries. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1500543002 Cr-Commit-Position: refs/heads/master@{#32590}
-
- 17 Jun, 2015 1 commit
-
-
machenbach authored
Revert of Add %TypedArray% to proto chain (patchset #6 id:100001 of https://codereview.chromium.org/1186733002/) Reason for revert: [Sheriff] Changes layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/429 See e.g.: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/429/layout-test-results/inspector/console/console-big-array-pretty-diff.html Please upload a blink side needsmanualrebaseline change first for these tests if the change is intended. Please also add a blink trybot on a reland of this CL. Original issue's description: > Add %TypedArray% to proto chain > > According to the ES6 spec, the main methods and getters shouldn't > be properties of the individual TypedArray objects and prototypes > but instead on %TypedArray% and %TypedArray%.prototype. This > difference is observable through introspection. This patch moves > some methods and getters to the proper place, with the exception > of %TypedArray%.prototype.subarray and harmony methods. These will > be moved in follow-on patches. > > BUG=v8:4085 > LOG=Y > R=adamk > > Committed: https://crrev.com/a10590158260737b256fac3254b4939f48f90095 > Cr-Commit-Position: refs/heads/master@{#29057} TBR=adamk@chromium.org,arv@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1192433003 Cr-Commit-Position: refs/heads/master@{#29070}
-
- 16 Jun, 2015 1 commit
-
-
littledan authored
According to the ES6 spec, the main methods and getters shouldn't be properties of the individual TypedArray objects and prototypes but instead on %TypedArray% and %TypedArray%.prototype. This difference is observable through introspection. This patch moves some methods and getters to the proper place, with the exception of %TypedArray%.prototype.subarray and harmony methods. These will be moved in follow-on patches. BUG=v8:4085 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1186733002 Cr-Commit-Position: refs/heads/master@{#29057}
-
- 04 Jun, 2015 1 commit
-
-
arv authored
Blink's DOM bindings are not yet ready. BUG=493137, 239915 LOG=N R=rossberg, adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1153263004 Cr-Commit-Position: refs/heads/master@{#28804}
-
- 22 May, 2015 1 commit
-
-
binji authored
This adds a new external type (v8::SharedArrayBuffer) that uses a JSArrayBuffer under the hood. It can be distinguished from an ArrayBuffer by the newly-added is_shared() bit. Currently there is no difference in functionality between a SharedArrayBuffer and an ArrayBuffer. However, a future CL will add the Atomics API, which is only available on an SharedArrayBuffer. All non-atomic accesses are identical to ArrayBuffer accesses. LOG=N BUG= Review URL: https://codereview.chromium.org/1136553006 Cr-Commit-Position: refs/heads/master@{#28594}
-
- 30 Mar, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org,dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/1038313004 Cr-Commit-Position: refs/heads/master@{#27518}
-
- 10 Mar, 2015 1 commit
-
-
dcarney authored
the implementation doesn't yet throw on strict mode assignment BUG= Review URL: https://codereview.chromium.org/992913002 Cr-Commit-Position: refs/heads/master@{#27121}
-
- 24 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
R=dslomov@chromium.org Review URL: https://codereview.chromium.org/664333003 Patch from Caitlin Potter <caitpotter88@gmail.com>. Cr-Commit-Position: refs/heads/master@{#24885} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24885 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Oct, 2014 2 commits
-
-
dslomov@chromium.org authored
Updates Object.prototype.toString() to use algorithm described in harmony drafts. Currently, the behaviour is essentially the same as ES262's version, however this changes when internal structures such as Promise make use of symbolToStringTag (as they are supposed to, see v8:3241), and changes further once Symbol.toStringTag is exposed publicly. BUG=v8:3241, v8:3502 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/546803003 Patch from Caitlin Potter <caitpotter88@gmail.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/670623003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Oct, 2014 3 commits
-
-
dslomov@chromium.org authored
R=verwaest@chromium.org, ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24691 Review URL: https://codereview.chromium.org/652303002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r24691 because win64 release build breaks. TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/659313002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=verwaest@chromium.org, ishell@chromium.org Review URL: https://codereview.chromium.org/652303002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24691 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
1. Fixed typo. lenght -> length. Arbitary -> Arbitrary. 2. TypedArray DataView property getters should throw TypeError when called on incompatible types. 3. Should not use integers as keys in the arbitrary-properties test. R=dslomov@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/652603002 Patch from Xueqiao Xu <xuq@google.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Mar, 2014 3 commits
-
-
dslomov@chromium.org authored
R=hpayer@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20330 Review URL: https://codereview.chromium.org/212603014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20338 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r20330 for breaking arm64 nosnap tests. TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/216993002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20336 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=hpayer@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/212603014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20330 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Oct, 2013 1 commit
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/25700010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
ES6 does not prescribe it, but both Blink and Firefox have it. Also does a small rename of parameter in test. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/19562002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
Further refinement to semantics that I have missed in previous change. Both Blink and Firefox are permissive with arguments to .set method. However, when first argument to "set" is a number, all implementations throw, so that users know that a.set(0,27) does not assign 27 to 0th element of a, not 0 to 27th element of a. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/19210002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/19086003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15655 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
ES6 spec tacitly allows them, and they are allowed in Firefox and in WebKit/Blink. R=bmeurer@chromium.org,rossberg@chromium.org Review URL: https://codereview.chromium.org/18769005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Jun, 2013 1 commit
-
-
dslomov@chromium.org authored
ES6 bug 695 (https://bugs.ecmascript.org/show_bug.cgi?id=695). This never worked in WebKit, so no compatibility issues. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/17904007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15346 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jun, 2013 1 commit
-
-
dslomov@chromium.org authored
Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative length arguments. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/17572009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jun, 2013 1 commit
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/17153011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 May, 2013 1 commit
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/14581005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 May, 2013 2 commits
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/14650014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/14740017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14537 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 May, 2013 2 commits
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/14857002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/14850011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14519 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-