- 27 Jul, 2015 1 commit
-
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1255883002 Cr-Commit-Position: refs/heads/master@{#29870}
-
- 23 Jul, 2015 2 commits
-
-
mvstanton authored
All of this is controlled by the CallDescriptor. It's simply the case that if you specify less registers than the function arity calls for, the rest are assumed to be on the stack. Bailout handlers accept these constant stack arguments too. BUG= Review URL: https://codereview.chromium.org/1250563004 Cr-Commit-Position: refs/heads/master@{#29813}
-
danno authored
Previous to this CL, ICs used a slightly different code idiom to get to C++ code from generated code than runtime intrinsics, using an IC_Utility class that in essence provided exactly the same functionality as Runtime::FunctionForId, but in its own quirky way. This CL unifies the two mechanisms, folding IC_Utility away by making all IC entry points in C++ code, e.g. IC miss handlers, full-fledged runtime intrinsics. This makes it possible to eliminate a bunch of ad-hoc declarations and adapters that the IC system had to needlessly re-invent. As a bonus and the original reason for this yak-shave: IC-related C++ runtime functions are now callable from TurboFan. Review URL: https://codereview.chromium.org/1248303002 Cr-Commit-Position: refs/heads/master@{#29811}
-
- 22 Jul, 2015 1 commit
-
-
mvstanton authored
It's just the same as StoreTransitionDescriptor. BUG= Review URL: https://codereview.chromium.org/1248973002 Cr-Commit-Position: refs/heads/master@{#29789}
-
- 13 Jul, 2015 1 commit
-
-
verwaest authored
BUG=v8:4296 LOG=n Review URL: https://codereview.chromium.org/1228063004 Cr-Commit-Position: refs/heads/master@{#29618}
-
- 30 Jun, 2015 1 commit
-
-
conradw authored
Revert "Revert relanded strong property access CL" Regression issues should be solved. Initial patchset is the original, subsequent patchsets are the fixing modifications. This reverts commit 4ac7be56. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1199983002 Cr-Commit-Position: refs/heads/master@{#29384}
-
- 25 Jun, 2015 1 commit
-
-
Michael Stanton authored
It's useful for the megamorphic keyed store case to not require a vector and slot as input. Analogous to the load case, we have a dummy one-ic-slot vector to aid. Since the only kind of MISS is for megamorphic cache stub failures, we don't need the real vector. The reason is that megamorphic cache stub failures don't result in any change to the type feedback vector state. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1210583002 Cr-Commit-Position: refs/heads/master@{#29280}
-
- 19 Jun, 2015 1 commit
-
-
conradw authored
Reason: Regressions in various benchmarks. Revert "Revert of Revert of [strong] Implement strong mode restrictions on property access (patchset #1 id:1 of https://codereview.chromium.org/1189153002/)" This reverts commit 41405c04. Revert "X87: Revert of Revert of [strong] Implement strong mode restrictions on property access." This reverts commit 48de5f4d. Revert "Fix overlapping KeyedLoadIC bitfield." This reverts commit 4e6c956a. Revert "MIPS64: Fix 'Revert of Revert of [strong] Implement strong mode restrictions on property access'." This reverts commit 74f97b0d. BUG= Review URL: https://codereview.chromium.org/1199493002 Cr-Commit-Position: refs/heads/master@{#29166}
-
- 18 Jun, 2015 3 commits
-
-
conradw authored
Revert of Revert of [strong] Implement strong mode restrictions on property access (patchset #1 id:1 of https://codereview.chromium.org/1189153002/) Reason for revert: Issue was ultimately caused/fixed by https://codereview.chromium.org/1194673002/ Original issue's description: > Revert of [strong] Implement strong mode restrictions on property access (patchset #23 id:460001 of https://codereview.chromium.org/1168093002/) > > Reason for revert: > Speculative revert, maybe breaks GC-stress > > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/808 > > Original issue's description: > > [strong] Implement strong mode restrictions on property access > > > > Implements the strong mode proposal's restrictions on property access. > > > > To be fully explored in a followup: proxies, interceptors, access checks, load from super > > > > BUG=v8:3956 > > LOG=N > > > > Committed: https://crrev.com/85dbfb9a389e7b21bd2a63862202ee97fc5d7982 > > Cr-Commit-Position: refs/heads/master@{#29109} > > TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3956 > > Committed: https://crrev.com/407657b706711fd5f8d417841e24b284886f3776 > Cr-Commit-Position: refs/heads/master@{#29115} TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1185343005 Cr-Commit-Position: refs/heads/master@{#29122}
-
conradw authored
Revert of [strong] Implement strong mode restrictions on property access (patchset #23 id:460001 of https://codereview.chromium.org/1168093002/) Reason for revert: Speculative revert, maybe breaks GC-stress http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/808 Original issue's description: > [strong] Implement strong mode restrictions on property access > > Implements the strong mode proposal's restrictions on property access. > > To be fully explored in a followup: proxies, interceptors, access checks, load from super > > BUG=v8:3956 > LOG=N > > Committed: https://crrev.com/85dbfb9a389e7b21bd2a63862202ee97fc5d7982 > Cr-Commit-Position: refs/heads/master@{#29109} TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Review URL: https://codereview.chromium.org/1189153002 Cr-Commit-Position: refs/heads/master@{#29115}
-
conradw authored
Implements the strong mode proposal's restrictions on property access. To be fully explored in a followup: proxies, interceptors, access checks, load from super BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1168093002 Cr-Commit-Position: refs/heads/master@{#29109}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 28 May, 2015 1 commit
-
-
mvstanton authored
This finishes up work begun by CL (https://codereview.chromium.org/546683003/) some months ago. BUG= Review URL: https://codereview.chromium.org/1149053004 Cr-Commit-Position: refs/heads/master@{#28683}
-
- 20 May, 2015 1 commit
-
-
mvstanton authored
Also removed ornamentation like "VectorRaw" from stub names. BUG= Review URL: https://codereview.chromium.org/1144063002 Cr-Commit-Position: refs/heads/master@{#28516}
-
- 15 May, 2015 1 commit
-
-
mvstanton authored
Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. BUG= Review URL: https://codereview.chromium.org/1129853002 Cr-Commit-Position: refs/heads/master@{#28422}
-
- 15 Apr, 2015 1 commit
-
-
jkummerow authored
The cells are stored on prototypes (in their map's PrototypeInfo). When a prototype object changes its map, then both its own validity cell and those of all "downstream" prototypes are invalidated; handlers for a given receiver embed the currently valid cell for that receiver's prototype during their compilation and check it on execution. Review URL: https://codereview.chromium.org/908213002 Cr-Commit-Position: refs/heads/master@{#27845}
-
- 18 Mar, 2015 2 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1019563002 Cr-Commit-Position: refs/heads/master@{#27280}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1015983003 Cr-Commit-Position: refs/heads/master@{#27274}
-
- 26 Feb, 2015 4 commits
-
-
machenbach authored
Revert of Also skip when the target is the global object (patchset #1 id:1 of https://codereview.chromium.org/961723002/) Reason for revert: Breaks unscopables and fix attempt needed to be reverted too. Original issue's description: > Also skip when the target is the global object > > BUG= > > Committed: https://crrev.com/cc918d30b9d586ce974b71232473f2ae3c5e7847 > Cr-Commit-Position: refs/heads/master@{#26887} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/960363002 Cr-Commit-Position: refs/heads/master@{#26900}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/961723002 Cr-Commit-Position: refs/heads/master@{#26887}
-
verwaest authored
Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). BUG= Review URL: https://codereview.chromium.org/961693002 Cr-Commit-Position: refs/heads/master@{#26886}
-
verwaest authored
Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. Proxies up the chain are guaranteed to provide access if we had access to the receiver, since otherwise we wouldn't have been able to compile the stub in the first place. If the security check would change, the window navigates, changing the map of the JSGlobalProxy. BUG= Review URL: https://codereview.chromium.org/958843002 Cr-Commit-Position: refs/heads/master@{#26875}
-
- 19 Feb, 2015 1 commit
-
-
ulan authored
BUG=chromium:454619 LOG=NO Review URL: https://codereview.chromium.org/926293004 Cr-Commit-Position: refs/heads/master@{#26748}
-
- 17 Feb, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/935603002 Cr-Commit-Position: refs/heads/master@{#26696}
-
- 04 Feb, 2015 1 commit
-
-
marja authored
This enables adding more language modes in the future. For maximum flexibility, LanguageMode is a bitmask, so we're not restricted to use a sequence of language modes which are progressively stricter, but we can express the language mode as combination of features. For now, LanguageMode can only be "sloppy" or "strict", and there are STATIC_ASSERTS in places which need to change when more modes are added. LanguageMode is a bit like the old LanguageMode when "extended" mode was still around (see https://codereview.chromium.org/8417035 and https://codereview.chromium.org/181543002 ) except that it's transmitted through all the layers (there's no StrictModeFlag). BUG= Review URL: https://codereview.chromium.org/894683003 Cr-Commit-Position: refs/heads/master@{#26419}
-
- 02 Feb, 2015 2 commits
-
-
mvstanton authored
When --vector-ics is true, we still tail-call to the hand-written megamorphic KeyedLoadIC (formerly "generic"). Now that this code uses the megamorphic cache, it needs to deal properly with the vector and slot registers. Achieve this with a sentinel vectors/slot combo. R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/892173002 Cr-Commit-Position: refs/heads/master@{#26381}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/815143002 Cr-Commit-Position: refs/heads/master@{#26379}
-
- 30 Jan, 2015 4 commits
-
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/893573003 Cr-Commit-Position: refs/heads/master@{#26363}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/881783003 Cr-Commit-Position: refs/heads/master@{#26360}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/877243004 Cr-Commit-Position: refs/heads/master@{#26358}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/878263002 Cr-Commit-Position: refs/heads/master@{#26345}
-
- 29 Jan, 2015 4 commits
-
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/873723005 Cr-Commit-Position: refs/heads/master@{#26331}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/883253002 Cr-Commit-Position: refs/heads/master@{#26326}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/880333003 Cr-Commit-Position: refs/heads/master@{#26320}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/877343003 Cr-Commit-Position: refs/heads/master@{#26317}
-
- 28 Jan, 2015 2 commits
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/886503002 Cr-Commit-Position: refs/heads/master@{#26310}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/879213003 Cr-Commit-Position: refs/heads/master@{#26306}
-
- 26 Jan, 2015 1 commit
-
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/872723003 Cr-Commit-Position: refs/heads/master@{#26275}
-
- 16 Jan, 2015 2 commits
-
-
jkummerow authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/852313002 Cr-Commit-Position: refs/heads/master@{#26111}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/836093007 Cr-Commit-Position: refs/heads/master@{#26097}
-