- 07 May, 2015 10 commits
-
-
yangguo authored
Revert of Revert of Wrap runtime.js in a function. (patchset #1 id:1 of https://codereview.chromium.org/1123353004/) Reason for revert: Failing test has been fixed. Original issue's description: > Revert of Wrap runtime.js in a function. (patchset #2 id:20001 of https://codereview.chromium.org/1126213002/) > > Reason for revert: > [Sheriff] Breaks nosnap: > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2872 > > Original issue's description: > > Wrap runtime.js in a function. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 > > Cr-Commit-Position: refs/heads/master@{#28275} > > TBR=jkummerow@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/62bd294f909ff448d0f876a3d745966a24cdc3f7 > Cr-Commit-Position: refs/heads/master@{#28277} TBR=jkummerow@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1131843002 Cr-Commit-Position: refs/heads/master@{#28287}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1132493002 Cr-Commit-Position: refs/heads/master@{#28286}
-
machenbach authored
Revert of Remove Scope::scope_uses_this_ flag (patchset #1 id:1 of https://codereview.chromium.org/1129823002/) Reason for revert: The reason for reverting is: [Sheriff] Need to fix compilation after this revert: https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d38411 Original issue's description: > Remove Scope::scope_uses_this_ flag > > Use of the "this" variable is now tracked using scopes, like any other variable. > > R=arv@chromium.org > LOG=N > BUG= > > Committed: https://crrev.com/afba55965118d9ba57e53c729f52be2340e626e0 > Cr-Commit-Position: refs/heads/master@{#28268} TBR=arv@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1131713004 Cr-Commit-Position: refs/heads/master@{#28285}
-
machenbach authored
Revert of Remove Scope::scope_uses_arguments_ flag (patchset #1 id:1 of https://codereview.chromium.org/1124233002/) Reason for revert: [Sheriff] Need to fix compilation after this revert: https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d38411 Original issue's description: > Remove Scope::scope_uses_arguments_ flag > > Use of arguments is tracked as a variable, like any other variable. > > R=arv@chromium.org > LOG=N > BUG= > > Committed: https://crrev.com/d4ea33f480243fb5b7d2cca6edddcaa3e9478e29 > Cr-Commit-Position: refs/heads/master@{#28271} TBR=arv@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1134453002 Cr-Commit-Position: refs/heads/master@{#28284}
-
machenbach authored
Revert of Resolve references to "this" the same way as normal variables (patchset #2 id:20001 of https://codereview.chromium.org/1130733003/) Reason for revert: [Sheriff] Breaks jetstream benchmark with errors like this: >>> Running suite: JetStream/bigfib.cpp >>> Stdout (#1): undefined:93: ReferenceError: this is not defined this['Module'] = Module; ^ ReferenceError: this is not defined at eval (eval at __run (runner.js:13:3), <anonymous>:93:3) at eval (native) at __run (runner.js:13:3) at Object.runSimpleBenchmark (runner.js:44:31) at runner.js:97:13 Original issue's description: > Resolve references to "this" the same way as normal variables > > Make the parser handle references to "this" as unresolved variables, so the > same logic as for the rest of function parameters is used for the receiver. > Minor additions to the code generation handle copying the receiver to the > context, along with the rest of the function parameters. > > Based on work by Adrian Perez de Castro <aperez@igalia.com>. > > BUG=v8:2700 > LOG=N > > Committed: https://crrev.com/06a792b7cc2db33ffce7244c044a9c05afbb6116 > Cr-Commit-Position: refs/heads/master@{#28263} TBR=rossberg@chromium.org,arv@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2700 Review URL: https://codereview.chromium.org/1129723003 Cr-Commit-Position: refs/heads/master@{#28283}
-
yangguo authored
NOTRY=true TBR=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1130123002 Cr-Commit-Position: refs/heads/master@{#28282}
-
jochen authored
Allows for getting rid of the special casing for float64 and is probably faster. BUG=v8:3996 R=verwaest@chromium.org,dslomov@chromium.org,plind44@gmail.com LOG=n Review URL: https://codereview.chromium.org/1128433006 Cr-Commit-Position: refs/heads/master@{#28281}
-
ben authored
On systems that have CLOCK_REALTIME_COARSE with good enough resolution, we can avoid making a system call to get the current time; it's serviced from the vDSO. BUG= LOG=N Review URL: https://codereview.chromium.org/1125003002 Cr-Commit-Position: refs/heads/master@{#28280}
-
chunyang.dai authored
port 7798548a (r28260) original commit message: typeof was implemented as a runtime function. Calling it in optimized code with a non-constant input becomes burdensome. BUG= Review URL: https://codereview.chromium.org/1124263005 Cr-Commit-Position: refs/heads/master@{#28279}
-
chunyang.dai authored
port 06a792b7 (r28263). original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com> BUG= Review URL: https://codereview.chromium.org/1124393002 Cr-Commit-Position: refs/heads/master@{#28278}
-
- 06 May, 2015 30 commits
-
-
machenbach authored
Revert of Wrap runtime.js in a function. (patchset #2 id:20001 of https://codereview.chromium.org/1126213002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/2872 Original issue's description: > Wrap runtime.js in a function. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/65c56d49b2d671ac9e379de726bff3eb03a508c1 > Cr-Commit-Position: refs/heads/master@{#28275} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1123353004 Cr-Commit-Position: refs/heads/master@{#28277}
-
scottmg authored
R=jochen@chromium.org BUG=chromium:485155 LOG=y Review URL: https://codereview.chromium.org/1124293002 Cr-Commit-Position: refs/heads/master@{#28276}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1126213002 Cr-Commit-Position: refs/heads/master@{#28275}
-
hpayer authored
BUG=chromium:436911 LOG=n Review URL: https://codereview.chromium.org/1130833002 Cr-Commit-Position: refs/heads/master@{#28274}
-
mbrandy authored
Port 7798548a Original commit message: typeof was implemented as a runtime function. Calling it in optimized code with a non-constant input becomes burdensome. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1124243002 Cr-Commit-Position: refs/heads/master@{#28273}
-
mbrandy authored
Port 18619d35 Original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>. R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1129803003 Cr-Commit-Position: refs/heads/master@{#28272}
-
wingo authored
Use of arguments is tracked as a variable, like any other variable. R=arv@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1124233002 Cr-Commit-Position: refs/heads/master@{#28271}
-
caitpotter88 authored
BUG=v8:4007 LOG=N R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/548833002 Cr-Commit-Position: refs/heads/master@{#28270}
-
mbrandy authored
Port cf53fed9 Original commit message: ArgumentsAdaptorStub for derived constructor (the one that needs new.target) works in this way: - If the constructor is invoked via the Construct stub, we know that actual arguments always include new.target. ``arguments`` object however should not include a new.target, therefore we remove it. We achieve this by decrementing the argument count. - If the constructor is invoked as a call, we do not care for a correct ``arguments`` array since the constructor will immediately throw on entrance. The bug is that the call could actually pass 0 actual arguments, but I decrement unconditionally :(. The fix is to detect this case and avoid decrementing. ``arguments`` is bogus, but it is ok as constructor throws. Long-term we should just remove mucking about with arguments for new.target and just get it from the stack. R=dslomov@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1125223002 Cr-Commit-Position: refs/heads/master@{#28269}
-
wingo authored
Use of the "this" variable is now tracked using scopes, like any other variable. R=arv@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1129823002 Cr-Commit-Position: refs/heads/master@{#28268}
-
hpayer authored
BUG=chromium:436911 LOG=n Review URL: https://codereview.chromium.org/1128923002 Cr-Commit-Position: refs/heads/master@{#28267}
-
conradw authored
https://codereview.chromium.org/1125783002 did not handle all cases for some architectures. These cases are now covered, and tests have been extended to check them. BUG=v8:4073 LOG=N Review URL: https://codereview.chromium.org/1128143002 Cr-Commit-Position: refs/heads/master@{#28266}
-
hpayer authored
Revert of New insertion write barrier. (patchset #3 id:200001 of https://codereview.chromium.org/1073953006/) Reason for revert: Various performance regressions. Original issue's description: > New insertion write barrier. > > BUG= > > Committed: https://crrev.com/6e9e2c08292b553602c74b16b8ccff4e4ccac003 > Cr-Commit-Position: refs/heads/master@{#28199} TBR=ulan@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1131583002 Cr-Commit-Position: refs/heads/master@{#28265}
-
mvstanton authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1116943002 Cr-Commit-Position: refs/heads/master@{#28264}
-
wingo authored
Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>. BUG=v8:2700 LOG=N Review URL: https://codereview.chromium.org/1130733003 Cr-Commit-Position: refs/heads/master@{#28263}
-
hpayer authored
BUG=chromium:436911 Review URL: https://codereview.chromium.org/1127993002 Cr-Commit-Position: refs/heads/master@{#28262}
-
ben authored
I know the bug has been closed but this seems like a simple addition that may be useful in other ways as well. BUG=v8:2180 LOG=N Review URL: https://codereview.chromium.org/1128553002 Cr-Commit-Position: refs/heads/master@{#28261}
-
mvstanton authored
typeof was implemented as a runtime function. Calling it in optimized code with a non-constant input becomes burdensome. BUG= Review URL: https://codereview.chromium.org/1114563003 Cr-Commit-Position: refs/heads/master@{#28260}
-
bmeurer authored
This revives the Terminate operator and removes the weird Always operator. As a first step we let the ControlReducer connect non terminating loops via Terminate. The next step will be to change the graph builder to insert Terminate nodes into every loop. Review URL: https://codereview.chromium.org/1123213002 Cr-Commit-Position: refs/heads/master@{#28259}
-
jochen authored
Make sure all lists are either regularly cleared or trimmed R=hpayer@chromium.org BUG=none LOG=n Review URL: https://codereview.chromium.org/1123213003 Cr-Commit-Position: refs/heads/master@{#28258}
-
titzer authored
R=hpayer@chromium.org, erikcorry@chromium.org BUG= Review URL: https://codereview.chromium.org/1105693002 Cr-Commit-Position: refs/heads/master@{#28257}
-
rossberg authored
R=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1130723002 Cr-Commit-Position: refs/heads/master@{#28256}
-
verwaest authored
Review URL: https://codereview.chromium.org/1116003005 Cr-Commit-Position: refs/heads/master@{#28255}
-
ben authored
Fix the following build error: ../deps/v8/src/compiler/graph-visualizer.h:23:1: error: 'FILE' does not name a type See https://github.com/iojs/io.js/issues/1637 for background. BUG=v8:4079 LOG=N Review URL: https://codereview.chromium.org/1128053002 Cr-Commit-Position: refs/heads/master@{#28254}
-
conradw authored
The Hydrogen representation for binops was never changed to care about the language mode. We thought this was ok, but it turns out we need to keep track of it to make sure inlining doesn't mess with the "strongness" of binops. Also added more rigorous inlining testing. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1123043002 Cr-Commit-Position: refs/heads/master@{#28253}
-
vogelheim authored
long and trivial functions, so that they can be eagerly compiled after all. This essentially allows the parser to renege on its earlier decision to lazy-parse, if additional information suggests it was a bad decision. BUG=chromium:470930 LOG=Y Review URL: https://codereview.chromium.org/1102523003 Cr-Commit-Position: refs/heads/master@{#28252}
-
bmeurer authored
An AdvancedReducer is basically a regular Reducer with an editor that can perform graph editing operations beyond changing or replacing the node that is currently being reduced. The GraphReducer is the default implementation of the AdvancedReducer::Editor interface. The ControlReducerImpl is now just an AdvancedReducer, which temporarily requires a Finish method in the reducer to implement the dead node trimming until we move that to the GraphReducer (which in turn requires that all loops are connected to End). Review URL: https://codereview.chromium.org/1122423003 Cr-Commit-Position: refs/heads/master@{#28251}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1118273004 Cr-Commit-Position: refs/heads/master@{#28250}
-
machenbach authored
TBR=yangguo@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1125123002 Cr-Commit-Position: refs/heads/master@{#28249}
-
yangguo authored
NOTRY=true TBR=machenbach@chromium.org BUG=4078 LOG=N Review URL: https://codereview.chromium.org/1123183003 Cr-Commit-Position: refs/heads/master@{#28248}
-