- 17 Aug, 2018 11 commits
-
-
jgruber authored
Bug: v8:6666 Change-Id: I9a9c6779138f7ee601a5061401ef0c777ba2b7ca Reviewed-on: https://chromium-review.googlesource.com/1179678 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55189}
-
Sigurd Schneider authored
This reduced the number of targets depending on assembler.h from ~900 to ~350. Bug: v8:8054 Change-Id: I74ae2ce7a4b27791d0ee25542ee0b2175bedf5f7 Reviewed-on: https://chromium-review.googlesource.com/1174534 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55188}
-
jgruber authored
Now that we pass in assembler options during builtin setup, we can be more precise in assembler configuration. Isolate-independent generation is only requested for isolate-independent builtins. And pc-relative jumps additionally need a valid code range. Bug: v8:6666 Change-Id: I64dfb414549a2f1e87610244c48d9405e63a1b12 Reviewed-on: https://chromium-review.googlesource.com/1177707Reviewed-by:
-
Marja Hölttä authored
This way the snapshot will contain only old space objects. BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib19642795b1e8c7cbeda5162be86909c1a777767 Reviewed-on: https://chromium-review.googlesource.com/1177384Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55186}
-
Ulan Degenbaev authored
This moves write-barrier for writes into code to heap-write-barrier.h and adds four new functions: - WriteBarrierForCode(host, rinfo, object) - combined generational and marking write barrier. - WriteBarrierForCode(host) - combined write barrier that rescans all pointers in the host (former RecordWritesIntoCode). - GenerationalWriteBarrierForCode. - MarkingWriteBarrierForCode. Bug: v8:8054,v8:7490 Change-Id: Ib1e07cfa1d5998fca2fa44e2ad08c52305f1373f Reviewed-on: https://chromium-review.googlesource.com/1174436Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Dan Elphick authored
When printing the number and size of the instance types in each snapshot, break out each line into the number for each AllocationSpace. (This removes the specific RO_SPACE path that just broke out its stats). Change-Id: I9d5bcecc4f0e8e1ec5c83409f54164f9bf83c5be Reviewed-on: https://chromium-review.googlesource.com/1175826Reviewed-by:
-
Ben L. Titzer authored
JSArrays and JSArrayBuffers are very different animals. As such, split the js-array.h header into two parts. R=ulan@chromium.org,mstarzinger@chromium.org Bug: v8:5402 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I82f987ecea3e2e1ceaf8f8962a2b88165558c57e Reviewed-on: https://chromium-review.googlesource.com/1177760Reviewed-by:
-
Hai Dang authored
Change-Id: Ib53ebb8372bd952f038edc06166e7d1c8b05abc2 Reviewed-on: https://chromium-review.googlesource.com/1174549 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I268e8673ca5c8f6737cae8190d78caf325e864bd Reviewed-on: https://chromium-review.googlesource.com/1177604Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55181}
-
Andrey Lushnikov authored
R=dgozman Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5fd64b95772ed061c0a432431a6e5273e5d44790 Reviewed-on: https://chromium-review.googlesource.com/1149321 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#55180}
-
Kanghua Yu authored
This CL refactors the CodeAssembler::Branch(condition, true_body, false_body) which was introduced by https://crrev.com/c/1175488, and this reduces snapshot by 864 bytes. Change-Id: Ifde7d6f39bd7f265e71fef5bdcc6e69d8ab5be85 Reviewed-on: https://chromium-review.googlesource.com/1175488Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Kanghua Yu <kanghua.yu@intel.com> Cr-Commit-Position: refs/heads/master@{#55179}
-
- 16 Aug, 2018 29 commits
-
-
Brian Stell authored
Bug: v8:7955, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2dbba859472059e684ec2c631b7e96d1289f39f0 Reviewed-on: https://chromium-review.googlesource.com/1173165Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Brian Stell <bstell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55178}
-
Frank Tang authored
Previously, FormatDate implemented two functions: (a) "DateTime Format Functions" as in ecma402/#sec-datetime-format-functions (b) "FormatDateTime( dateTimeFormat, x )" as in ecma402/#sec-formatdatetime This patch split FormatDate into two separate functions exactly as they are specified. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iae47f4d992f1767968e5a6df7d1a45a95bc33192 Reviewed-on: https://chromium-review.googlesource.com/1178886 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I1834893f05229834289bc368b00dc314e7de1b65 Reviewed-on: https://chromium-review.googlesource.com/1177746Reviewed-by:
-
Deepti Gandluri authored
Change-Id: I24893d2db441282df8ac3267b0daf8f163e0edb5 Reviewed-on: https://chromium-review.googlesource.com/1177198Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55175}
-
Deepti Gandluri authored
Change-Id: I55d15fd15cc714732139e4bf12bd75f21f922048 Reviewed-on: https://chromium-review.googlesource.com/1174013Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55174}
-
Leszek Swirski authored
This reverts commit 5d69010e. Reason for revert: New test fails on ARM GC stress bot - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20GC%20Stress/8054 Original change's description: > [asmjs] Properly validate asm.js heap sizes > > Enforce both engine limitations and spec (http://asmjs.org/spec/latest/) > limitations on the size of asm.js heaps. > > R=clemensh@chromium.org > CC=mstarzinger@chromium.org > > Bug: chromium:873600 > Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd > Reviewed-on: https://chromium-review.googlesource.com/1174411 > Commit-Queue: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55163} TBR=mstarzinger@chromium.org,titzer@chromium.org,clemensh@chromium.org Change-Id: I95ca5306a495bfc0f78d7a29f5d6269fc9c0bdfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:873600 Reviewed-on: https://chromium-review.googlesource.com/1178141Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55173}
-
Toon Verwaest authored
Change-Id: I62ddddf64d4de79765469e883295e246a18d7f84 Reviewed-on: https://chromium-review.googlesource.com/1177749Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I18512b508127c48ab0a1dc5a6a221d0f491bb5fe Reviewed-on: https://chromium-review.googlesource.com/1175917 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I3c04e3cedfa220d58eb1307977b99869485c7f4d Reviewed-on: https://chromium-review.googlesource.com/1177744Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I36dda6606aecb9e8e2e9604c49e62ec70e3aee29 Reviewed-on: https://chromium-review.googlesource.com/1174447 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Georg Neis authored
Don't compute the ToNumber conversion of long strings as it is expensive. Bug: v8:7790 Change-Id: Ief104f9229f7f633e31d26c98ed24b08a161525b Reviewed-on: https://chromium-review.googlesource.com/1177719Reviewed-by:
-
Jakob Kummerow authored
This reverts commit 957854dd. Reason for revert: breaks fuzzing builds => blocks rolling, crbug.com/874440 Original change's description: > Reland "[cleanup] Reland: Remove deprecated functions" > > This reverts commit 717b9385. > > Reason for revert: Cast build is now fixed > > Original change's description: > > Revert "[cleanup] Reland: Remove deprecated functions" > > > > This reverts commit c8376b00. > > > > Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 > > > > Original change's description: > > > [cleanup] Reland: Remove deprecated functions > > > > > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > > > with no changes since the break in chromium for ChromeOS is now fixed. > > > > > > Removes all V8_DEPRECATED functions that weren't recently marked as well > > > any V8_DEPRECATE_SOON function that relied on using using the address of > > > an object to get hold of the Isolate. > > > > > > Bug: v8:7786 > > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > > > Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 > > > Reviewed-on: https://chromium-review.googlesource.com/1172350 > > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > > Commit-Queue: Dan Elphick <delphick@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#55119} > > > > TBR=yangguo@chromium.org,delphick@chromium.org > > > > Change-Id: Id1308a694092acfc90a3e7183d66c002feb63999 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: v8:7786 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > > Reviewed-on: https://chromium-review.googlesource.com/1174751 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55127} > > TBR=yangguo@chromium.org,leszeks@chromium.org,delphick@chromium.org > > Change-Id: Id65dae1abdad6f854afec9eb59ed2bddd9246f79 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7786 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > Reviewed-on: https://chromium-review.googlesource.com/1175721 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55136} TBR=yangguo@chromium.org,leszeks@chromium.org,delphick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7786 Change-Id: I5dc792a3a1c986b8609487ca6ad1e485a8940521 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1177661Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#55167}
-
Ivica Bogosavljevic authored
Fix 0027c834 FLAG_runtime_stats was declared as Int but it was accessed as pointer. On 64-bit architectures pointer access needs to be eight byte aligned. This created unaligned memory access on 64-bit architectures for those architectures that do not support unaligned memory access. TEST=mjsunit/wasm/table,cctest/test-accessors/AccessorIC Change-Id: I569b69583de98b4c5fb7266f23f927bbd006966d Reviewed-on: https://chromium-review.googlesource.com/1177601 Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55166}
-
Ben L. Titzer authored
R=ahaas@chromium.org Bug: chromium:751825, chromium:773631 Change-Id: I87f6e9859b6adfe46adde7bf08fd16978035aa1f Reviewed-on: https://chromium-review.googlesource.com/1177702Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55165}
-
Georg Neis authored
Forcing it seems unnecessary and hinders concurrent compilation. Also turn a related condition into a CHECK. Bug: v8:7790 Change-Id: Ie7d7e47e6bc2743d742cfe07e65436c1b8b994f3 Reviewed-on: https://chromium-review.googlesource.com/1177705Reviewed-by:
-
Ben L. Titzer authored
Enforce both engine limitations and spec (http://asmjs.org/spec/latest/) limitations on the size of asm.js heaps. R=clemensh@chromium.org CC=mstarzinger@chromium.org Bug: chromium:873600 Change-Id: I104c23bbd0a9a7c494f97f8f9e83ac5a37496dfd Reviewed-on: https://chromium-review.googlesource.com/1174411 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
John Barboza authored
Bug: v8:8062 Change-Id: I5a5c39c0b5cffdcb15444caa670919be6fc3d007 Reviewed-on: https://chromium-review.googlesource.com/1171199 Commit-Queue: John Barboza <jbarboza@ca.ibm.com> Reviewed-by:
-
Andreas Haas authored
{AsyncCompileJob::FinishCompile} assumes that a context is set on the isolate when it is called. This was not the case when it was called at the end of streaming compilation. R=mstarzinger@chromium.org Bug: chromium:874525 Change-Id: Ia31cd9eb40598918262ff14606796027a6c80bc0 Reviewed-on: https://chromium-review.googlesource.com/1177392 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Bret Sepulveda authored
Change-Id: I76264a2f912eaac0ca913004fe9ec1f57d03ecb9 Reviewed-on: https://chromium-review.googlesource.com/1177390Reviewed-by:
-
Mathias Bynens authored
The proposal is currently at Stage 3 of the TC39 process. Repository: https://github.com/tc39/proposal-global Bug: v8:5537 Change-Id: I36c39fdab049497f50685c6672655b67ec4d8ce9 Reviewed-on: https://chromium-review.googlesource.com/1174113 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Georg Neis authored
We really want to catch such errors. (std::optional throws an exception in some of these cases.) Change-Id: I7f8c3aff38aed1b3cbe52bcfb92062268fd3b201 Reviewed-on: https://chromium-review.googlesource.com/1177387Reviewed-by:
-
Toon Verwaest authored
Change-Id: Ic70a83335c60ba2f1f656398fc6b19db7af99348 Reviewed-on: https://chromium-review.googlesource.com/1175915 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Peter Marshall authored
This is a reland of 898f880a Original change's description: > [cpu-profiler] Turn on detailed line info for optimized code > > Cautiously turn on this flag by default to check the impact on > performance bots. Could show minor regressions in old space and/or > code_and_metadata memory buckets. > > Bug: v8:7983 > Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd > Reviewed-on: https://chromium-review.googlesource.com/1162234 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54908} Bug: v8:7983 Change-Id: Iff53bc19c92f26f386948bd4a58e8dcf0493cf0d Reviewed-on: https://chromium-review.googlesource.com/1177481Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:616879 Change-Id: I283e7ae6b867b03f11aed2facc275fe4767ab26c Reviewed-on: https://chromium-review.googlesource.com/1177388 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55155}
-
Hai Dang authored
Direct call to CloneFastJSArray is used to improve performance in that case. Tests are also added. Bug: v8:7980 Change-Id: Ifca34f3e182b776cd9862da8bf529fc13f6be9ed Reviewed-on: https://chromium-review.googlesource.com/1172782Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7424 Change-Id: Ic43f81b51c651fa826ec4d13a7eb508a27489f97 Reviewed-on: https://chromium-review.googlesource.com/1160305Reviewed-by:
-
Sigurd Schneider authored
It looks like we are not putting doubles into the constant pool on arm any time soon, so lets remove this feature. A follow-up CL will remove the 64bit support from the constant pool. Bug: v8:8054 Change-Id: I87865a9c252c8967b5ac71b4db5d8c3b93a0e705 Reviewed-on: https://chromium-review.googlesource.com/1174531Reviewed-by:
-
Sigurd Schneider authored
This reverts commit cd285951. Reason for revert: No size improvements, but 5% regression on octane/NavierStrokes: https://chromeperf.appspot.com/report?sid=ebcd213df609b4ff31b0b25b5c8aab9d0738ff46f623161bdcdbb6f594112761&start_rev=579365&end_rev=582538 Original change's description: > [arm] Use constant pool for off-heap targets > > This CL puts off-heap targets (i.e. code addresses for embedded builtins) > in the constant pool on ARM. > > We are landing this CL to evaluate impact on benchmarks and code size, > and expect to revert it once we have gathered that data. > > Bug: v8:6666 > > Change-Id: If4935a6fb162cd1ffb34489c6fa9630f10ca2c9f > Reviewed-on: https://chromium-review.googlesource.com/1154924 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54914} TBR=sigurds@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6666, chromium:872176 Change-Id: Icd0019c7f0c890d0eb09ddc2a74745c6b68db263 Reviewed-on: https://chromium-review.googlesource.com/1172482 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Shiyu Zhang authored
Merge rip-relative loading and call/jump into one instruction for OFF_HEAP_TARGET call/jump. For example, REX.W movq r10,[rip+#disp] call r10 turns into: call [rip+#disp] Change-Id: I17e115d054b4b352bdaf8eba2e6ac4054bbedaca Reviewed-on: https://chromium-review.googlesource.com/1172152 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
-
