- 13 Jan, 2021 26 commits
-
-
Bill Budge authored
- Changes GetOffsetToReturns to take into account return slot padding and argument padding. - Changes GetStackParameterDelta to use GetOffsetToReturns for the SP delta calculation. - Removes GetFirstUnusedStackSlot. Change-Id: I13df72e86750c62798bae262f0560cf1d7f981db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593306 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#72078}
-
Clemens Backes authored
This CL prepares the WasmModuleBuilder for memory64 and adds a first mjsunit test which executes a few memory loads and stores, some of them trapping. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: Ia77c32ff0ee774665cd4bd0997c3609f6f17b80f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2589974 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72077}
-
Camillo Bruni authored
Drive-by-fix: Sort forward declarations in v8.h Bug: v8:11263 Change-Id: I2d1b5324e0cddd54a1bec440e1aebcebef393a6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581958 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72076}
-
bcoe authored
Implement coverage tracking for optional chains. Bug: v8:10060 Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Gus Caplan <snek@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benjamin Coe <bencoe@google.com> Cr-Commit-Position: refs/heads/master@{#72075}
-
Zhi An Ng authored
Implement these 4 instructions for arm64 and arm Liftoff: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u Drive-by cleanup of the test case to make it clearer that we are checking against an unsigned result. Bug: v8:10972 Change-Id: I509a8df8a6f2109417ad5aaaa0324ced50bdc84a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626713Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72074}
-
Zhi An Ng authored
Ext mul's codegen assumes that all inputs are in registers, but the instruction-selector wasn't the correct constraints. The codegen for ext mul is slightly complicated so we chose to restrict the inputs to be registers rather than changing codegen. Bug: chromium:1165966,v8:11262 Change-Id: I5d4eb56d17a4d0a2927b089dbf74362c7e7ff4fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626711Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72073}
-
Zhi An Ng authored
Bug: v8:10971 Change-Id: I5650458501f548f8120bcc15fbeb9cd220e3e137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621861 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: Iec2fdaf3f180e6e59e40a558bf85a41cd96826ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2626464Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72071}
-
Milad Fa authored
Port 8c52f66f Original Commit Message: Implement these 4 instructions for x64 Liftoff: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u We move the codegen for the *high* instructions into macro-assembler to allow sharing of the optimized code sequence between TurboFan and Liftoff. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I790860cbb0f9854c31959684712cde42254bde2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625878Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72070}
-
Milad Fa authored
Port 6f521386 Original Commit Message: Create a macro-assembler helper function to enable code sharing between Liftoff and TurboFan. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I3e72ad3a2d7dfdd9737a5acd2416741c1d486306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625880Reviewed-by:
-
Liviu Rau authored
Bug: chromium:1165806 Change-Id: Id637bb8ca2736a7a1430b3115ac48629ca1e8a36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2627309 Commit-Queue: Liviu Rau <liviurau@chromium.org> Auto-Submit: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72068}
-
Zhi An Ng authored
Create a macro-assembler helper function to enable code sharing between Liftoff and TurboFan. Bug: v8:10971 Change-Id: I8d8132f4cf3386b28cdf5350fde2e076428d68c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621860 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
When merging a bundle with itself, we should consider the merge a success even though we do not merge anything. The result is used to determine whether the backward spilling heuristic might introduce a stack to stack move. For this purpose, it only matters whether the phi and its input end up in the same bundle. R=sigurds@chromium.org Bug: chromium:1158088 Change-Id: Icdcfe81d58bce5916b87a34a46c9611f5978bf27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625876Reviewed-by:
-
Nico Hartmann authored
This reverts commit 164cf80b. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/14532/overview Original change's description: > [regexp] Hard-crash on invalid offsets in AdvanceCurrentPosition > > Drive-by: Range checks in `Emit(byte, twenty_four_bits)` to ensure the > given packed bits actually fit into 24 bits. > > Bug: chromium:1166138 > Change-Id: I2e711e6466bb48d7b9897f68dfe621d12bd92508 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625877 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72064} TBR=jgruber@chromium.org,leszeks@chromium.org,pthier@chromium.org Change-Id: Ibe72ecda03518e444442a0440ecdae7669bfc4c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1166138 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625883Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72065}
-
Jakob Gruber authored
Drive-by: Range checks in `Emit(byte, twenty_four_bits)` to ensure the given packed bits actually fit into 24 bits. Bug: chromium:1166138 Change-Id: I2e711e6466bb48d7b9897f68dfe621d12bd92508 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625877 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
This skips sending the data urls along with Runtime.CallFrame, and Runtime.ExceptionDetails. Also-by: bmeurer@chromium.org Bug: chromium:1132260 Change-Id: I45136bc0d3217caf8fbd93946b021f56f64f04b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621077 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72063}
-
Mythri A authored
This is a reland of 8aa6b15f with a fix for TSAN failures. Original change's description: > Disable bytecode flushing once we toggle coverage mode. > > Changing coverage mode generated different bytecode in some cases. > Hence it is not safe to flush bytecode once we toggle coverage mode. > > Bug: chromium:1147917 > Change-Id: I9e640aeaec664d3d4a4aaedf809c568e9ad924fc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615020 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71985} Bug: chromium:1147917 Change-Id: Ibd8c4feb8615ba7b92fe547c55d455958c94c526 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624612 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72062}
-
Benedikt Meurer authored
This moves the logic for the debug name heuristic, which derives names for imported and exported entities from the relevant tables, into wasm-debug.{cc,h} and stores these maps on the DebugInfoImpl rather than on the WasmModule. Drive-by-fix: Also use the import table based heuristic for function names, just like we use it for everything else. Bug: chromium:1164305 Change-Id: I8a21e0880c680079f63e6607b5b62c788049b9e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625870 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: -
Leszek Swirski authored
MSVC's STL in debug mode rebinds the allocator passed to vectors to allocate helper structures, so we need StrongRootBlockAllocator to have proper rebind support rather than assuming it always rebinds to Address. Bug: v8:11241 Change-Id: I15688e43fe2c71ec4ff0c287a03e36ca57427417 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622915 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Implement these 4 instructions for ia32 Liftoff: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u We move the codegen for the *high* instructions into macro-assembler to allow sharing of the optimized code sequence between TurboFan and Liftoff. Bug: v8:10972 Change-Id: Ib5c6cbf6d4a39ef298298b75516f5221cb8ec249 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621863 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Create a macro-assembler helper function to enable code sharing between Liftoff and TurboFan. Bug: v8:10971 Change-Id: I10228b502d959dbde670c38c44992fa7133dab7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621859Reviewed-by:
-
Zhi An Ng authored
Move the current code sequence in TurboFan to a macro-assembler helper function to allow Liftoff to reuse it. Bug: v8:10997 Change-Id: I08a9d5b6d1f7898bf7e9239f54d69867e00b30eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2620906 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/eb94f1c..9b27757 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d599553..787a10d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d1a3011..3889691 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/82b992a..8149a96 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2246bee..b12d1c8 Rolling v8/tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 Rolling v8/tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 Rolling v8/tools/luci-go: git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e..git_revision:16e6d735358b0166f06fd2e4daa0da4cff9918e9 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id7c5629638d61e81b9868d7c905d88668a528b5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625753Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72056}
-
Zhi An Ng authored
Implement these 4 instructions for x64 Liftoff: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u We move the codegen for the *high* instructions into macro-assembler to allow sharing of the optimized code sequence between TurboFan and Liftoff. Bug: v8:10972 Change-Id: I900b24f96ee55784220656cb2664283b03c32110 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621862 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Move the current code sequence in TurboFan to a macro-assembler helper function to allow Liftoff to reuse it. Bug: v8:10997 Change-Id: I6205350897a4afc7ca9d0f84fd514be24508aef0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2620905Reviewed-by:
-
Seth Brenith authored
To improve incremental builds. Bug: v8:7793 Change-Id: I6990a97e058d22d34acd1f609167cd30ca7518ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596789Reviewed-by:
-
- 12 Jan, 2021 14 commits
-
-
Milad Fa authored
Change-Id: Ife7fb1c08acd864f59b1f45877e7e75fd81748a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625488Reviewed-by:
-
Milad Fa authored
Also fix the simulator to avoid overrating dst register during VectorPack. Bug: v8:10971 Change-Id: I137e3cf4f73ddfc12c50099d519668858f95ecf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625487Reviewed-by:
-
Milad Fa authored
Bug: v8:10971 Change-Id: Idaa75b5c4d63695dbb8eed2be076f067ff5df9ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2623817Reviewed-by:
-
Bill Budge authored
- Modify InstructionSelectors to track both padding and multiple slot values to correctly adjust stack pointers when pushing arguments. Pass stack offset as an immediate operand. - Modify CodeGenerators to handle alignment padding. Bug: v8:9198 Change-Id: I1c132284e07b5f5e73ce570a641f17decdfba504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596027Reviewed-by:
-
Mike Stanton authored
Add nicohartmann@ as an owner. Change-Id: I7c24b1ab575db857a15cff709f44c87c74106d80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593332Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#72048}
-
Milad Fa authored
Port d6c4c884 R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I99c91b49c1fda7e50fee7d9a204e9ade3e336220 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2623808Reviewed-by:
-
Milad Fa authored
Port acbdaa4c Original Commit Message: Also remove some ifdefs since it is implemented on all architectures. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I2ec501c15dda5a0aa970b8b7d18a995e60f71b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624747Reviewed-by:
-
Clemens Backes authored
bulk-memory shipped in V8 v7.5, hence the feature flag can be removed now. This saves some binary size and a few dynamic checks for the flag. R=ahaas@chromium.org Bug: v8:11074 Change-Id: Ia73622637939f2192940fdd6909520786ed27286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622913Reviewed-by:
-
Camillo Bruni authored
Drive-by-fix: - fix load spinner z-index Change-Id: I4a8f9b768ec858da4d91780ae0998a685f4438bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624609Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72044}
-
Camillo Bruni authored
Bug: v8:10667 Change-Id: Ie11b21f6610ad5e5be81e12191207ac85680a1ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622213 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This adds the following internal properties to `WasmInstanceObject` values in DevTools: - `[[Module]]` pointing to the `WasmModuleObject`, allowing the developer to find the module to an instance no matter where in DevTools front-end the instance is inspected. - `[[Functions]]`, `[[Globals]]`, `[[Memories]]`, and `[[Tables]]` are shown (when they aren't empty), allowing developers to inspect the entities within an instance no matter where in DevTools front-end it's inspected. This also updates the _Module_ scope for Wasm frames to show the entity containers (`functions`, `globals`, `memories` and `tables`) in addition to the `instance` and `module` to make it easier accessible (fewer clicks to get there), but also to align it better with the _Add property path to Watch_ and _Copy property path_ features (since exactly the same names are exposed via Debug Evaluate on Wasm frames). ``` > Stack > Locals v Module > module > instance > functions > globals > memories > tables ``` Drive-by-fix: Move GetWasmModuleObjectInternalProperties() logic into debug-wasm-support.cc Screenshot: https://imgur.com/ksEHG2I.png Doc: http://bit.ly/devtools-wasm-entities Fixed: chromium:1165294 Bug: chromium:1071432, chromium:1164241, chromium:1165304 Change-Id: Ia88fb2705287c79988ff2b432e4a33ac34e098f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622912Reviewed-by:
Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72042}
-
Milad Fa authored
`0x12345678` will be written to memory in the same order on BE machines however, as Wasm is LE enforced, a memory load will force a byte reverse operation on BE machines which changes the value. To fix the problem, we write the reversed value to memory. Change-Id: I0d562768d5cef823cb918ed1b57a2a41e404ffc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622927 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Leszek Swirski authored
The dead target check in TransitionArrayNeedsCompaction, confirming that Smi (uninitialized) targets imply that no other target is dead, has to additionally support Smi entries. Bug: v8:11305 Change-Id: I6f3fa9e7420b1bd0a64a25dae670f439e3f41162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622914 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Make sure gcmole detects issue in DisallowGarbageCollection scopes. DisallowGarbageCollection is widely used in the codebase to document code that doesn't allocate. However, this has the rather unexpected side-effect that gcmole is not run when such a scope is active. This CL changes the default behavior of gcmole to run even with DisallowGarbageCollection scopes present. This will give us the best results of both worlds, dynamic checks by the fuzzer, and static analysis by gcmole. To allow crazy local raw pointer operations there is a new DisableGCMole scope that explicitly disables gcmole. Change-Id: I0a78fb3b4ceaad35be9bcf7293d917a41f90c91f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615419Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72039}
-
