- 19 Oct, 2016 8 commits
-
-
ahaas authored
Using uint32 to store the the number of control outputs allows WebAssembly switches to have more than 2^16 case. BUG=v8:5531 TEST=mjsunit/regress/wasm/regression-5531 R=titzer@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2425983002 Cr-Commit-Position: refs/heads/master@{#40420}
-
bmeurer authored
When the input to Number.parseInt is a HeapNumber in Signed32 range, we can just return the (truncated) input value (i.e. we need to map -0 to 0 due to the ToString conversion). R=jarin@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2432923002 Cr-Commit-Position: refs/heads/master@{#40419}
-
bmeurer authored
The inlined version of Number.parseInt did a ToInt32 truncation, which is not what the EcmaScript specification says. R=jarin@chromium.org BUG=v8:5538 Review-Url: https://chromiumcodereview.appspot.com/2432143002 Cr-Commit-Position: refs/heads/master@{#40418}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eb8eb7a..e54cf97 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapul/+log/9a96d45..ae987bf TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2432033002 Cr-Commit-Position: refs/heads/master@{#40417}
-
zhengxing.li authored
port 308788b3 (r40397) original commit message: Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). BUG= Review-Url: https://chromiumcodereview.appspot.com/2429623005 Cr-Commit-Position: refs/heads/master@{#40416}
-
kozyatinskiy authored
.. to make windows bot happy. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428213002 Cr-Commit-Position: refs/heads/master@{#40415}
-
kozyatinskiy authored
console should be non enumerable. BUG=chromium:656826 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428473003 Cr-Commit-Position: refs/heads/master@{#40414}
-
kozyatinskiy authored
* introduced v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState); * migrated inspector to new API; * added cctest for new API; * added inspector test for setPauseOnExceptionState. BUG=chromium:652939,v8:5510 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2396193002 Cr-Commit-Position: refs/heads/master@{#40413}
-
- 18 Oct, 2016 32 commits
-
-
bjaideep authored
Port 308788b3 Original commit message: Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2425243003 Cr-Commit-Position: refs/heads/master@{#40412}
-
gdeepti authored
BUG= Review-Url: https://codereview.chromium.org/2410763002 Cr-Commit-Position: refs/heads/master@{#40411}
-
jochen authored
R=jgruber@chromium.org,machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2421303002 Cr-Commit-Position: refs/heads/master@{#40410}
-
bmeurer authored
http://crrev.com/2424403002 contained a typo comparing the input map against the undefined constant rather than the HeapNumber map, which tanks the case where Number.parseInt is used instead of Math.floor. TBR=epertoso@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2425703007 Cr-Commit-Position: refs/heads/master@{#40409}
-
jpp authored
Comma expressions need to special-handle function calls. When validating the rhs of a Comma, the validatior needs to ensure that it returns AsmType::Float() if the function being called is fround(). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5528 Review-Url: https://chromiumcodereview.appspot.com/2426473007 Cr-Commit-Position: refs/heads/master@{#40408}
-
mythria authored
Add support to collect feedback about oddballs in Add, Mul, Div and Modulus stubs. Turbofan uses NumberOrOddball feedback to reduce the number of deoptimizations. BUG=v8:4280, v8:5400 LOG=N Review-Url: https://codereview.chromium.org/2406263002 Cr-Commit-Position: refs/heads/master@{#40407}
-
jwolfe authored
BUG=v8:5388 Review-Url: https://codereview.chromium.org/2422383002 Cr-Commit-Position: refs/heads/master@{#40406}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2425553003 Cr-Commit-Position: refs/heads/master@{#40405}
-
kozyatinskiy authored
debug-interface.h contains part of v8-debug.h that is used by src/inspector. BUG=v8:5510 R=dgozman@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2423713003 Cr-Commit-Position: refs/heads/master@{#40404}
-
titzer authored
R=ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2429833002 Cr-Commit-Position: refs/heads/master@{#40403}
-
epertoso authored
BranchIf and helpers were introduced when exporting the schedule from the RawMachineAssembler was not ensuring that the CFG was well-form. These methods, that were used to introduce blocks to ensure edge-split form, are now unnecessary. BUG= Review-Url: https://codereview.chromium.org/2426923002 Cr-Commit-Position: refs/heads/master@{#40402}
-
bmeurer authored
These intrinsics are unused now, and so we can drop all the code in fullcodegen and Crankshaft that deals with those. TurboFan and Ignition never tried to optimize those. R=mstarzinger@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2427673004 Cr-Commit-Position: refs/heads/master@{#40401}
-
ahaas authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2413343002 Cr-Commit-Position: refs/heads/master@{#40400}
-
bmeurer authored
R=epertoso@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2424403002 Cr-Commit-Position: refs/heads/master@{#40399}
-
ivica.bogosavljevic authored
MIPS64: Fix Word32Compare turbofan operator implementation when comparing signed with unsigned operand MIPS64 doesn't support Word32 compare instructions. Instead it relies that the values in registers are correctly sign-extended and uses Word64 comparison instead. This behavior is correct in most cases, but doesn't work when comparing signed with unsigned operands. The solution proposed here tries to match a comparison of signed with unsigned operand, and perform Word32Compare simulation only in those cases. Unfortunately, the solution is not complete because it might skip cases where Word32 compare simulation is needed, so basically it is a hack. BUG= TEST=mjsunit/compiler/uint32 Review-Url: https://codereview.chromium.org/2391393003 Cr-Commit-Position: refs/heads/master@{#40398}
-
bmeurer authored
Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). R=mvstanton@chromium.org, mythria@chromium.org BUG=v8:2206,v8:4280,v8:5267 Review-Url: https://codereview.chromium.org/2426693002 Cr-Commit-Position: refs/heads/master@{#40397}
-
mythria authored
When inlining JSCallConstruct in turbofan, receiver is initialized to model the behaviour of constructor. When an implicit receiver is not required the receiver value should be set to the hole value instead of undefined value. When initializing the receiver via super calls, we check that the receiver is the hole value. BUG=chromium:653407 Review-Url: https://codereview.chromium.org/2424123002 Cr-Commit-Position: refs/heads/master@{#40396}
-
yangguo authored
TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2426913002 Cr-Commit-Position: refs/heads/master@{#40395}
-
machenbach authored
Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Review-Url: https://codereview.chromium.org/2425913002 Cr-Original-Commit-Position: refs/heads/master@{#40382} Cr-Commit-Position: refs/heads/master@{#40394}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2428493003 Cr-Commit-Position: refs/heads/master@{#40393}
-
clemensh authored
This ensures that the stack traces show up correctly in DevTools. I will later extend it for source view. R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG=chromium:613110 Review-Url: https://codereview.chromium.org/2420093002 Cr-Commit-Position: refs/heads/master@{#40392}
-
yangguo authored
Unknown external references must trigger assertion failure. Review-Url: https://codereview.chromium.org/2428463002 Cr-Commit-Position: refs/heads/master@{#40391}
-
zhengxing.li authored
The CL #40373 (https://codereview.chromium.org/2405253006 ) caused a Gcc compilation error. The error message was: ../src/code-stub-assembler.cc: In member function ‘v8::internal::compiler::Node* v8::internal::CodeStubAssembler::CreateArrayIterator(v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::IterationKind)’: ../src/code-stub-assembler.cc:7909:7: error: ‘kBaseMapIndex’ may be used uninitialized in this function [-Werror=maybe-uninitialized] int kBaseMapIndex; ^ cc1plus: all warnings being treated as errors make[1]: *** [/home/zxli/work/google-v8/v8/out/x87.release/obj.target/v8_base/src/code-stub-assembler.o] Error 1 This CL fixed this issue by initalizing kBaseMapIndex to 0. BUG= Review-Url: https://codereview.chromium.org/2423343002 Cr-Commit-Position: refs/heads/master@{#40390}
-
zhengxing.li authored
port 77419488 (r40377) original commit message: This slot is completely unused and always undefined anyways, so there's no need to maintain the slot during object construction. BUG= Review-Url: https://codereview.chromium.org/2425183002 Cr-Commit-Position: refs/heads/master@{#40389}
-
zhengxing.li authored
port 3f6e0a4e (r40354) original commit message: RIP, handwritten KeyedLoadICStub, handwritten KeyedLoadIC_Megamorphic, and hydrogenized KeyedLoadGeneric! BUG= Review-Url: https://codereview.chromium.org/2430613003 Cr-Commit-Position: refs/heads/master@{#40388}
-
clemensh authored
... instead of getting it from the FunctionMirror. For WASM frames (including asm.js -> WASM), the function is either unresolved or does not contain the script. The added test case failed before this CL. R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG=v8:4203, chromium:656622 Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615 Review-Url: https://codereview.chromium.org/2415073003 Cr-Original-Commit-Position: refs/heads/master@{#40348} Cr-Commit-Position: refs/heads/master@{#40387}
-
zhengxing.li authored
port 87ae05c7 (r40341) original commit message: Utilize all opportunities to turn leas into adds. BUG= Review-Url: https://codereview.chromium.org/2429763002 Cr-Commit-Position: refs/heads/master@{#40386}
-
machenbach authored
Revert of [build] Switch off warning on gcc bots. (patchset #2 id:20001 of https://codereview.chromium.org/2425913002/ ) Reason for revert: Seems to be the wrong flag: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4709 Original issue's description: > [build] Switch off warning on gcc bots. > > Switch off maybe-uninitialized warning as it gives often > false positives with optimizations in gcc. > > NOTRY=true > TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org > > Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c > Cr-Commit-Position: refs/heads/master@{#40382} TBR=bmeurer@chromium.org,zhengxing.li@intel.com,caitp@igalia.com,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2422103006 Cr-Commit-Position: refs/heads/master@{#40385}
-
bmeurer authored
The inlined version of Array.prototype.push returned the value that was pushed instead of the new "length" property value. R=jarin@chromium.org BUG=chromium:656037 Review-Url: https://codereview.chromium.org/2425903002 Cr-Commit-Position: refs/heads/master@{#40384}
-
verwaest authored
BUG=v8:5501 Review-Url: https://codereview.chromium.org/2424013002 Cr-Commit-Position: refs/heads/master@{#40383}
-
machenbach authored
Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Review-Url: https://codereview.chromium.org/2425913002 Cr-Commit-Position: refs/heads/master@{#40382}
-
jgruber authored
This CL adds two new fast-paths for RegExp.prototype.replace in the case that the regexp itself is an unmodified JSRegExp instance and the replace argument is callable. Such cases call directly into runtime. This could be improved even further by turning the relevant runtime functions into inline TurboFan. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2415663007 Cr-Commit-Position: refs/heads/master@{#40381}
-