- 08 Feb, 2018 16 commits
-
-
Franziska Hinkelmann authored
Implement empty desctructor because of the forward declarations. Change-Id: I56af92d7ded44b6fcd3582d1e3a10e9bb5cb1296 Reviewed-on: https://chromium-review.googlesource.com/905671Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#51180}
-
Clemens Hammacher authored
For local variables of type i64 and also for i64 constants, it makes sense to store the constant value in the {VarState} instead of loading the value into a register immediately. This also helps with some instructions like i64 bitshifts, but also general patterns like incrementing an i64 local variable by a fixed number. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Ibed15228bbc53632dd3e60d7862ff2fbcb9832ca Reviewed-on: https://chromium-review.googlesource.com/904443 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Dan Elphick authored
The new macro takes a void(Label* ok, Label* not_ok), which should generate statements that branch to one of the labels. If the not_ok Label is reached, it will abort just like CSA_ASSERT. Also replaces an instance of #ifdef DEBUG ... #endif with this pattern in builtins-regexp-gen.cc Change-Id: Ie7ec87e041c040c03f9c528dccc8e709e50ed9b9 Reviewed-on: https://chromium-review.googlesource.com/906933Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#51178}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Bug: chromium:772804 Change-Id: I1f72b9710b25edf7d95fa5404bf22bd543fed66b Reviewed-on: https://chromium-review.googlesource.com/908459Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51177}
-
sreten.kovacevic authored
Added registers and conditions for this architecture. Implemented some of the instructions, mainly for wasm context operations. Bug: v8:6600 Change-Id: I5f3e32eb4d284172b21434456395256872da3b46 Reviewed-on: https://chromium-review.googlesource.com/906609 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51176}
-
Clemens Hammacher authored
Because of missing parentheses, the computation of the "half index" was wrong, and always produced 0 or 1. Also, for non-pairs, we were still passing kHighWord for the RegPairHalf. R=ahaas@chromium.org Bug: v8:7422, v8:6600 Change-Id: If056aa8005d4b44e667b7d76b9be49ec0191d0eb Reviewed-on: https://chromium-review.googlesource.com/908554Reviewed-by:
-
Yang Guo authored
R=jarin@chromium.org Bug: v8:178 Change-Id: I4b77e96072d5b8b70df21477bba8cdbf573d184c Reviewed-on: https://chromium-review.googlesource.com/908289Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51174}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Bug: chromium:772804 Change-Id: I738d67bd504180de70359f4aabec3ef8f54cee16 Reviewed-on: https://chromium-review.googlesource.com/907557 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51173}
-
Dan Elphick authored
Bug: chromium:810320 Change-Id: I5e07d27e4895539b49707c56197fc8413281af06 Reviewed-on: https://chromium-review.googlesource.com/907891Reviewed-by:
-
Kim-Anh Tran authored
Lazy compilation on native heap is currently lacking debug trace info and checks that are available for the GC heap. This commit adds lacking checks and debug outputs for the native heap. R=clemensh@google.com Change-Id: Iec2592bd421fdcbbd4461b13a7851926e791d297 Reviewed-on: https://chromium-review.googlesource.com/904531Reviewed-by:
-
Taketoshi Aono authored
Original CL is https://chromium-review.googlesource.com/c/v8/v8/+/810504 Reverted issue is https://bugs.chromium.org/p/chromium/issues/detail?id=804159 Fix Object.entries descriptor array value index. This reverts commit e5ecb248. Bug: v8:6804, chromium:804159 Change-Id: I73a5a5f670c5b36e0c5cc7984d5979ecec43d969 Reviewed-on: https://chromium-review.googlesource.com/892684 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true Bug: chromium:616017 Change-Id: I48a29bc96e2c7ae54f4b5bbb6790db1d8bfccab4 Reviewed-on: https://chromium-review.googlesource.com/908288Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:5267 Change-Id: I7fb48f6e2c7a3f3dd64e799492d94f68efea9a7f Reviewed-on: https://chromium-review.googlesource.com/905646Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#51168}
-
Michael Achenbach authored
This enables compiling V8 stand-alone for mips (big endian) on an ia32 host with gn args: custom_toolchain="//:mips-bundled" v8_use_snapshot=false v8_enable_i18n_support=false icu_use_data_file=false is_debug=false target_cpu="mips" Bug: chromium:632390 Change-Id: I0b59126d742a2979dd0fcbcdd3a574008a09479a Reviewed-on: https://chromium-review.googlesource.com/904990Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7e86dc4..3ba6ca6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1d86294..b4a4bed Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2a49b96..357315f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4616ff3d23772623d26d69ed3d5228db8a3e677c Reviewed-on: https://chromium-review.googlesource.com/908069 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51166}
-
Deepti Gandluri authored
Change-Id: I1fe7ba0a942c6da2d1c85c2391762cb434098cf1 Reviewed-on: https://chromium-review.googlesource.com/907346Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51165}
-
- 07 Feb, 2018 24 commits
-
-
Caitlin Potter authored
This change has been useful when inspecting on_reject callbacks in Isolate::InternalPromiseHasUserDefinedRejectHandler, it's probably going to be helpful for other things too. BUG= R=adamk@chromium.org, littledan@chromium.org Change-Id: I7c5bac87a3b8bd3ce19d71cf73397a93109976ba Reviewed-on: https://chromium-review.googlesource.com/907641Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#51164}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:616879 Change-Id: I2cc9f55d1d244fa448d928574a8033e36af13028 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/907572Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51163}
-
Deepti Gandluri authored
Currently the disassembler tests continue on unimplemented instructions, fix to abort instead as most bugs in the disassemblers will appear as unimplemented instructions. - Localize testing disassembler method to abort on unimplemented - Fix failing x64 disassembler tests Change-Id: I703cca9709c528327ec381d05a78cf3314ea4fa9 Reviewed-on: https://chromium-review.googlesource.com/907489Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:793324 Change-Id: I0d898a6c9bf04b5b6e7bbb706ab62a34317cf393 Reviewed-on: https://chromium-review.googlesource.com/907550Reviewed-by:
-
Junliang Yan authored
wasm code manager is known to have issue on reloc tagging and also constant pool. Ignore until fix go in. Change-Id: I4d7ddafba3cf8bc81c73a7b156cba39985bce48d Reviewed-on: https://chromium-review.googlesource.com/906950Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: I126279d9290958baffc4df4a03642e89c2e60fed Reviewed-on: https://chromium-review.googlesource.com/906730 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
- Revert "[builtins] Save one word in contexts for Promise.all." This reverts commit 7632da06. - Revert "[builtins] Also use the Promise#then protector for Promise#finally()." This reverts commit d4f072ce. - Revert "[builtins] Don't mess with entered context for MicrotaskCallbacks." This reverts commit 6703dacd. - Revert "[debugger] Properly deal with settled promises in catch prediction." This reverts commit 40dd0658. - Revert "[builtins] Widen the fast-path for Promise builtins." This reverts commit db0556b7. - Revert "[builtins] Unify PerformPromiseThen and optimize it with TurboFan." This reverts commit a582199c. - Revert "[builtins] Remove obsolete PromiseBuiltinsAssembler::AppendPromiseCallback." This reverts commit 6bf88852. - Revert "[builtins] Turn NewPromiseCapability into a proper builtin." This reverts commit 313b490d. - Revert "[builtins] Inline InternalPromiseThen into it's only caller" This reverts commit f7bd6a2f. - Revert "[builtins] Implement Promise#catch by really calling into Promise#then." This reverts commit b23b098f. - Revert "[promise] Remove incorrect fast path" This reverts commit 0f6eafe8. - Revert "[builtins] Squeeze JSPromise::result and JSPromise::reactions into a single field." This reverts commit 8a677a28. - Revert "[builtins] Refactor promises to reduce GC overhead." This reverts commit 8e7737cb. Tbr: hpayer@chromium.org Bug: chromium:800651, chromium:808911, v8:5691, v8:7253 Change-Id: I8c8ea5ed32ed62f6cd8b0d027a3707ddd891e5f1 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/906991 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51158}
-
Karl Schimpf authored
Adds the remaining saturating float to int conversion opcodes. Bug: v8:7226 Change-Id: If84e564a7816eb4aedbc336f5c2e614da22bb10a Reviewed-on: https://chromium-review.googlesource.com/905472 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: Ic697e7863fb5ef870979ea82b4e6de3efb5cfbd2 Reviewed-on: https://chromium-review.googlesource.com/906773 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Adam Klein authored
This patch attempts to reduce the special handling of destructuring assignments in arrow function parameters by "adopting" them from wherever they were initially parsed into the arrow function's FunctionState/Scope. This avoids incorrectly re-setting the Scope of such assignments multiple times for arrow functions that are nested inside other arrow params themselves. It also generally seems better, in that we now only rewrite destructuring assignments for a single function at a time. Bug: chromium:807096 Change-Id: I6bef5613f99e3e8c130fc0aa2ee5d6fcf2efd34b Reviewed-on: https://chromium-review.googlesource.com/900168Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Caitlin Potter <caitp@igalia.com> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#51155}
-
Sathya Gunasekaran authored
Declare the private field variable in the preparser as well, to be consistent with the parser. Bug: v8:5386 Change-Id: I961ddf14e47b99701e2463cab0f4d4de140e1e3a Reviewed-on: https://chromium-review.googlesource.com/905843Reviewed-by:
-
Leszek Swirski authored
When suspending, rather than saving all registers up to a certain index, only save the ones that are live according to the liveness analysis. Others are saved as optimized out constants, and are skipped during the GenaratorStore lowering. Symmetrically, only restore live registers when resuming. Change-Id: Icc2df905b0fe2fe5c372097bd67d5316edcd1b54 Reviewed-on: https://chromium-review.googlesource.com/905662 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Yang Guo authored
We reuse most of the infrastructure to set break points, with minor differences when we encounter functions where we can only break on entry: - PrepareFunctionForBreakPoints simply deopts all functions. - Break point objects have the canonical source position 0. - Break point is set/checked/cleared via bit on the DebugInfo. - Debug::Break do not continue stepping since stepping is implemented via regular break points and therefore do not interfere with break on entry. I promise to add more tests. Bug: v8:178 Change-Id: Ifc8231995c771286db0b848b811e1c3ad3b12494 Reviewed-on: https://chromium-review.googlesource.com/906245 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Port https://chromium-review.googlesource.com/c/v8/v8/+/888700 to MIPS Change-Id: I16cd2de41c790dea307efa7c78125dec1c4304a4 Reviewed-on: https://chromium-review.googlesource.com/906768Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#51151}
-
Peter Marshall authored
Cleanup CL that removes unnecessary builtins that were just wrapping the throwing of errors. Use the ThrowTypeError and ThrowRangeError helpers more consistently from CSA. Change-Id: I2d0c3647340c88c457b27e16c0a81567869b7ec7 Reviewed-on: https://chromium-review.googlesource.com/906769 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#51150}
-
Clemens Hammacher authored
If the interpreter has an upper limit of instructions to execute, treat grow_memory like 1000 other instructions in order to account for the huge execution time of grow_memory. R=ahaas@chromium.org Bug: chromium:807383 Change-Id: Id513a41257734a3041bef45bbc00c461fdec6787 Reviewed-on: https://chromium-review.googlesource.com/905605Reviewed-by:
-
Junliang Yan authored
Port 7c14a408 Original Commit Message: It turns out that .incbin can be problematic for build systems, in that the included binary file is not detected as a build-time dependency. The alternative is .byte inclusion, which we test here. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie42da993ae61964eb3f02f328333ec140902d929 Reviewed-on: https://chromium-review.googlesource.com/906688Reviewed-by:
-
jgruber authored
The .byte directive will be used instead of .incbin since the latter comes with complications involving build-time dependency detection. Drive-by-edits: Move macro definitions closer to their use-sites. TBR=rmcilroy@chromium.org Cq-Include-Trybots: luci.v8.try:v8_win64_msvc_compile_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Bug: v8:6666 Change-Id: Ibda0b3577688248dbf627cb69965d28309193859 Reviewed-on: https://chromium-review.googlesource.com/906488 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mike Stanton authored
We need a deopt point for the case when we fail to find an initial element from which to begin the reduction step. Bug: v8:7384 Change-Id: I5e476ddc433be690577677b018639c4c0c70809b Reviewed-on: https://chromium-review.googlesource.com/906508Reviewed-by:
-
Choongwoo Han authored
There are functions that were called by TypedArraySpeciesCreate that is deleted now. This CL removes Create, HasJSTypedArrayPrototype, DefaultConstructor in JSTypedArray, which is not used anymore. Change-Id: Ib4785cc52a8f18f2a3dfc3f27e39a23260cb2a4f Reviewed-on: https://chromium-review.googlesource.com/905712Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#51145}
-
Peter Marshall authored
We don't need these wrappers - we can just use ThrowTypeError from CSA instead. There were also a bunch of unused runtime functions which we can just delete. This CL has no behavior changes. Change-Id: I5efefd726aff4cca8e8feba6cd05fe8ff5663931 Reviewed-on: https://chromium-review.googlesource.com/906470Reviewed-by:
-
Sergiy Byelozyorov authored
This makes it easier to restart an aborted merge. R=machenbach@chromium.org TEST=ran tools/release/script_test.py locally Bug: v8:7410 Change-Id: I26b1b09e0000c9c689ad80be32ced9e35634bcec Reviewed-on: https://chromium-review.googlesource.com/905665 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Predrag Rudic authored
Port 0761b55d Original Commit Message: "Extend the code-generator tests to cover AssembleMove and AssembleSwap with Simd128 registers and stack slots, for targets that support them. For this to work however, we need support for passing Simd128 stack parameters in TurboFan which this patch implements for Arm and x86. PPC and S390 both do not support the Simd128 representation and it appears MIPS and MIPS64's implementation of AssembleMove and AssembleSwap do not support it either. As per the design of the tests, the set of values to perform moves on are represented in a FixedArray of Smis (for kTagged) and HeapNumbers (for kFloat32 and kFloat64). They are converted to raw values for the moves to be performed on, to be then converted back into a FixedArray. For the kSimd128 representation, we represent values as a FixedArray of 4 Smis, each representing a lane. They are converted to a raw Simd128 vector using the `I32x4ReplaceLane` and `I32x4ExtractLane` operations. Finally, these tests need Simd128 variables mixed with the CodeStubAssembler which is not a use-case officially supported. And as a result, the `RecordWrite` stub does not guarantee to preserve Simd128 registers. To get around this, we have to be careful to skip write barriers when dealing with Simd128 parameters inside the "teardown" function, and we've had to move all allocations to the "setup" function. Thanks to this, we are able to catch bugs such as this one https://bugs.chromium.org/p/v8/issues/detail?id=6843." Change-Id: If867dedf4a2c72cb75c58effda93e3eec432fd67 Reviewed-on: https://chromium-review.googlesource.com/906469Reviewed-by:
-
Choongwoo Han authored
- Remove %TypedArray%.of in js/typedarray.js - Implement %TypedArray%.of in builtins/builtins-typedarray-gen.cc - This CL makes TA.of 1.5x faster Bug: v8:5929 Change-Id: Ie165114a0ab9b4ec9ed70840c4c6a42d1eeed101 Reviewed-on: https://chromium-review.googlesource.com/897227 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
