- 22 Jul, 2020 3 commits
-
-
Nico Hartmann authored
Add synchronized accessors for ScriptContextTable on NativeContext. Add corresponding cctest. Bug: v8:7790 Change-Id: If390f3d4a72441a8b4323e9413d7627cd15514c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299372 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68981}
-
Santiago Aboy Solanes authored
If we insert a second SIMPLE_PROPERTY_ARRAY we move from kWeakRef encoding to kFullTransitionArray encoding. As always, we are searching in the meantime in a background thread. Bug: v8:7790 Change-Id: I5e3d85657dda4c199e50b9c35e7f617f1821a8f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243218Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68980}
-
Nico Hartmann authored
This CL makes the ScriptContextTable concurrently accessible from the background thread (in particular ScriptContextTable::get_context). A cctest is added to check synchronization with tsan. Bug: v8:7790 Change-Id: I2e2dc8c6a7cfa369787959c4d5ed5f357f4720fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260567Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
- 21 Jul, 2020 27 commits
-
-
Ng Zhi An authored
The load splat, load extend, load zero macros are essentially the same, consolidate them into a single macro. Change-Id: Ic812043b37524deb3a9e6ddc223bb95ae77e1d4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304715 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68978}
-
Milad Farazmand authored
Change-Id: I818534bc2fedd127689bf82f2cdd3a4f2f8c31e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310574Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68977}
-
Frank Tang authored
Per change in https://github.com/tc39/ecma402/pull/459/ Bug: v8:10732 Change-Id: I2ef21e8b450cbf9c61f987c61f3ba7d6959db81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309149Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68976}
-
Ng Zhi An authored
v128.const (kExprS128) is the only constant expression supported (similar to the other value types). Bug: v8:10731 Change-Id: I9b11b47a851903dfd79d3590eff67b615057f81c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308389 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1107901 Change-Id: Ieacea3dd60e80143a0cbeebf4ab5f91d3888e1a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310351 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68974}
-
Ng Zhi An authored
Prototype in TurboFan x64 and interpreter, bailout in Liftoff. Suggested in https://github.com/WebAssembly/simd/pull/237. Bug: v8:10713 Change-Id: I5346c351fb2ec5240b74013e62aef07c46d5d9b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2300924Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... behind --trace-zone-type-stats flag. Per-object-type statistics requires the following GN args: v8_enable_precise_zone_stats = true use_rtti = true When precise zone stats is enabled, the used zone memory value is calculated more precisely, in particular it takes into account the state of the active segment. By default, the used memory in the active segment is not taken into account because of performance overhead. Bug: v8:10572 Change-Id: I938d9e264cfe6a8b63a89db87d187d8e2be63c8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2281006 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68972}
-
Arnaud Robin authored
On desktop systems, we use a very basic tiering strategy: Everything is initially compiled with Liftoff, and once that is done, the module can start being used. Concurrently to the execution, we re-compile all code with TurboFan, and hot-swap each function once TurboFan finishes. We should start using a more dynamic strategy where each function is tiered-up when judged necessary. This change will then tier-up each liftoff function once it has been called 5 times. I then added a counter in the native module, that is updated directly from Liftoff code, and a runtime call is then made when the counter reaches the goal. R=clemensb@chromium.org CC=thibaudm@chromium.org Bug: v8:10728 Change-Id: I8dc2b02fdff8d97781bb1cf496886594b3d7f644 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306803 Commit-Queue: Arnaud Robin <arobin@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Lippautz authored
V8 already depends on cppgc_base which means that unittests does not need to depend on cppgc_for_testing any longer. Move the cppgc_for_testing dependency to the stand-alone cppgc_unittests binary Bug: v8:10674 Change-Id: I07bfe30901eb1683d2e0ee0189f73b5244884f27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310249 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#68970}
-
Georg Neis authored
This reverts commit f44900d2. Reason for revert: caused performance regressions on Nexus 7!? https://bugs.chromium.org/p/chromium/issues/detail?id=1105420 Original change's description: > [turbofan] Prettify a condition > > Change-Id: I3800486f18a3693c9e2d3ace0a6f8ee626efc84e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289780 > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Auto-Submit: Georg Neis <neis@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68756} TBR=neis@chromium.org,nicohartmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1105420 Change-Id: Icc97c7c2fff79bb4860a9c36f6d2d3f531e524b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310250 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When a reservation of exactly 4GB is requested on a 32-bit platform, we can simply pretend that we tried and failed. Fixed: chromium:1107234 Change-Id: I9a3f4dbd31064aff620337aa291768fe47174fb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308346 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68968}
-
Tamer Tas authored
R=rmcilroy@chromium.org,machenbach@chromium.org,jkummerow@chromium.org Bug: chromium:1099623 Change-Id: I7f79549a5de171dd2d85c86b3c4114f8aa2250b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308344 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Drive-by: Improve comment, use << operator where possible Change-Id: I5d2bff57a3f19a0fbb746136a897bf50e1173775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308337Reviewed-by:
-
Clemens Backes authored
Move wrapper compilation to the jobs API. Moving function compilation is much more complex and will be done in a follow-up CL. R=ahaas@chromium.org CC=krivoy@chromium.org Bug: chromium:1101340 Change-Id: I0749e52a88264b725bba28252a6c76ae3338bb0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301933Reviewed-by:
-
Jakob Gruber authored
With work on NCI proceeding, it makes sense to test multiple pipeline configurations. The nci variant (passes --turbo-nci) now spawns dedicated NCI compilation jobs and inserts generated code into the code cache. The nci_as_highest_tier variant (passes --turbo-nci-as-highest-tier) simply replaces TF with NCI code (no extra jobs, no extra caching). This mode stresses NCI generated code more than the nci variant, in which NCI code only runs on cache hits. Bug: v8:8888 Change-Id: I4c2a43cce5271a6c288e7aba195dcc9daed6af9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299361 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68964}
-
Victor Gomes authored
This regression is due to miscalculating the mapped_count in escape-analysis-reducer. Since NewArguemntsElements contains the entire arguments count instead of the rest argument size, we need to subtract (or add in the case of the reversed arguments stack) the formal parameter count to the index. Change-Id: I865018573fc3b0f0d20f7286653b7f6803cbe665 Bug: chromium:1106667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304576 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Clemens Backes authored
Most code comments use lowercase. This CL fixes the few that used uppercase, for consistency. R=thibaudm@chromium.org Change-Id: Ib02c8202f049a968662c91ade2252df24326a943 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308336Reviewed-by:
-
Manos Koukoutos authored
They have been replaced with {array,struct}.new_with_rtt. Also, rework tests that used those instructions. Bug: v8:7748 Change-Id: I2aaccb1958bf2b8d6cad4969abc612216856393d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307318 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Clemens Backes authored
For debugging code, disable opcode merging. Otherwise, the effect of the first merged opcode would not be observable when stepping. R=thibaudm@chromium.org Bug: v8:10350 Change-Id: Id656c9dee8f9676bf3d7881f3782e5ead76b5e71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306802 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Adds new histogram V8.TimeToSafepoint to measure the time needed to reach a global safepoint/stop-the-world. Bug: v8:10315 Change-Id: I77701b26dfd47e04d64c4ecba3c47530ff8b9485 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308390Reviewed-by:
-
Leszek Swirski authored
Split the capacity calculation logic and the allocation logic for StringTable resizing (both shrinking and enlarging). This allows us to: a) Precalculate the new size, without potentially first shrinking then resizing again, b) Make the final size calculation more explicit, b) In the future, maybe allow the allocation to happen outside a lock, and the rehashing to be inside it, for a concurrent string table. Change-Id: Ie41773520f2b20d9d244c151a153ed784f17283e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307218 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
We currently still merge opcodes (i.e. i32 comparisons plus a br_if). This CL adds a test for this, which checks for the current behaviour. A follow-up CL will fix this and update the expected output accordingly. R=thibaudm@chromium.org Bug: v8:10350 Change-Id: I846aa931a3ec1a27043f04e830503d5732ae473e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307232Reviewed-by:
-
Manos Koukoutos authored
Also remove traces of array.new_sub Bug: v8:7748 Change-Id: I96a922a16406960a80af0788e9cad5aa5692000a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307237 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:10592 Change-Id: Ifebe773371b3e6019c386087519ba433b436557b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304584 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Original design doc: https://docs.google.com/document/d/1dthXsVHMc1Sd_oYf9a-KZSFOd_a8dUgnt4REAG8YIXA Design changes: https://docs.google.com/document/d/1aeEGDm1XSqoJkQQKz9F75WqnuAa2caktxGy_O_KpO9Y Reland: - rewrote timing dependent tests to be more robust - removed 1 flaky test - disabled tests for DelayedTasksPlatform Original: https://chromium-review.googlesource.com/c/v8/v8/+/2202981 TBR=ishell@chromium.org, ulan@chromium.org Bug: v8:10239 Change-Id: I2a042e419462f4c9f54ec549bfe16ec6684560b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307211 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68954}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9862443..e2b8e15 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/eb3987e..9e12121 Rolling v8/buildtools/linux64: git_revision:d585128cdaf3e6ff7bfd58641965e60c12618eb1..git_revision:3028c6a426a4aaf6da91c4ebafe716ae370225fe Rolling v8/third_party/aemu-linux-x64: bMBorsHPd-GA42g-lfkvaE5HhiZVCcqkoLNKDzb8ElUC..53Ps2Qo0mizBNjRI9qS90a_RTYhxglcY6H9yccc0ckcC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4ed789b..a30bbb6 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/642be1d..9949ab7 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie61a4ce3b8e53a3ece32fc7781fd8dbdf3ca57b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309290Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68953}
-
Frank Tang authored
Bug: v8:10733 Change-Id: I417c19b13ecc3de1e7a33ed31e4eb0129eabe7e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309113Reviewed-by:
-
- 20 Jul, 2020 10 commits
-
-
Ng Zhi An authored
I was looking around and couldn't find any tests for select with v128 params. Adding it for completion. Change-Id: I9e3770e37eaddb23fc99649579b175536c1df844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308093Reviewed-by:
-
Milad Farazmand authored
Change-Id: I3f7adb9c430abfaf9a0a9aae88150850f7214034 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307179Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68950}
-
Etienne Pierre-Doray authored
This reverts commit d1aee56d. Reason for revert: Trace event is causing telemetry regressions (crbug.com/1094957). I got a few days of traces and didn't really find what I was looking for, so I'll find another way to investigate. Original change's description: > [Jank]: Add uri trace events > > To investigate jank found in UMA sampling profiler. > > Bug: chromium:1081433 > Change-Id: I457731380505af5a4d7a0c30d01b4049ffd2b436 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242037 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68326} TBR=leszeks@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1081433, chromium:1094957 Change-Id: I6c9573e9a77a54255c5fadc3cec14d437fd62b45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2279135 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Also changing the wording of comment under s390 instruction-selector to match PPC. Change-Id: I8fa77cbf51872792acd0e89915cb11d4759d51f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305850Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68948}
-
Michael Achenbach authored
Some fuzzers replaced strigify and then caused uncaught errors from harness methods using prettyPrinted. Bug: chromium:1102897 Change-Id: I7ae6a90040ba0aa5ec1efa4a8b73e053ec75dd79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304814 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68947}
-
Andreas Haas authored
jkummerow made many changes to wasm-compiler.cc and co, and is more than qualified to be an owner. R=clemensb@chromium.org Change-Id: I05cb1b7c73627d4c3fe59f154c1267c7cd44a2d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307314Reviewed-by:
-
Manos Koukoutos authored
Bug: chromium:1103839 Change-Id: Id70b4632fb15cb16c16cb94ad0f7676e5293769d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307311Reviewed-by:
-
Manos Koukoutos authored
Bug: chromium:1104053 Change-Id: Iacfeeb80ab981f20dc2fc40cf8435514876fcf28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307233Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:10596 Change-Id: I435b0b979394698263b530bc5188bbec63960738 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299376 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Dominik Inführ authored
AllocationCounter just stores all allocation observers for now. Bug: v8:10315 Change-Id: I4ff4208877dd9454c9eef5e5d2e2349b7f00065f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306793 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
