- 25 Jan, 2016 19 commits
-
-
sigurds authored
* Add caching to handling of dangling loads * Add two unittests for load elimination on escaped objects BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1619103004 Cr-Commit-Position: refs/heads/master@{#33498}
-
ishell authored
BUG=chromium:580506 LOG=N Review URL: https://codereview.chromium.org/1631673002 Cr-Commit-Position: refs/heads/master@{#33497}
-
mbrandy authored
Fix additional cases where the AIX compiler reports that a variable may be used uninitialized. R=danno@chromium.org, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1628483003 Cr-Commit-Position: refs/heads/master@{#33496}
-
mstarzinger authored
This fixes corner cases where the start offsets of exception handler regions within the handler table fall together. This assumption was based on full-codegen code and no longer holds with the interpreter. The tables however are still well nested and code has been added to verify that in debug mode. R=rmcilroy@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1633573002 Cr-Commit-Position: refs/heads/master@{#33495}
-
mstarzinger authored
The current support for try-catch in the interpreter can handle most of the cases appearing in our test suite. Also the flag in question did not detect try-finally constructs. This removes the flag and instead extends the test expectations. R=rmcilroy@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1631593003 Cr-Commit-Position: refs/heads/master@{#33494}
-
akos.palfi authored
BUG= Review URL: https://codereview.chromium.org/1632643002 Cr-Commit-Position: refs/heads/master@{#33493}
-
jochen authored
If it's Smi::FromInt(0), the NULL check would trigger. Instead, use the handle-zap value to mean "not set". BUG=v8:3647,chromium:580651 R=vogelheim@chromium.org LOG=y Review URL: https://codereview.chromium.org/1628173002 Cr-Commit-Position: refs/heads/master@{#33492}
-
sigurds authored
This CL reduces the memory overhead of escape analysis by introducing a "copy on demand" strategy for virtual states and virtual objects. BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1606613002 Cr-Commit-Position: refs/heads/master@{#33491}
-
mlippautz authored
- Completely rely on the concurrent sweeping state for SweepingCompleted() - Rename the state accordingly. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1614953002 Cr-Commit-Position: refs/heads/master@{#33490}
-
rmcilroy authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1627943003 Cr-Commit-Position: refs/heads/master@{#33489}
-
yangguo authored
See https://github.com/tc39/ecma262/issues/128 R=erik.corry@gmail.com, littledan@chromium.org BUG=v8:2952 LOG=N Review URL: https://codereview.chromium.org/1608693003 Cr-Commit-Position: refs/heads/master@{#33488}
-
bmeurer authored
Cleanup %ForInPrepare runtime entry, and unify common logic with %ForInEnumerate (renamed from %GetPropertyNamesFast). Also introduce a TupleType to properly type JSForInPrepare and its projections w/o special hacks in the Typer. And fix %ForInNext and JSForInNext to be consistent with fullcodegen again (after the proxy refactorings last quarter). R=jarin@chromium.org BUG=v8:3650 LOG=n Review URL: https://codereview.chromium.org/1631583002 Cr-Commit-Position: refs/heads/master@{#33487}
-
titzer authored
This CL implements loop assignment analysis, a pass over a loop's body to record local variables that are assigned. This pre-pass is similar to that done on the JavaScript AST for the same reason: avoid introducing too many phis at loop headers when building a graph. R=bradnelson@chromium.org,ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1617723003 Cr-Commit-Position: refs/heads/master@{#33486}
-
titzer authored
R=mstarzinger@chromium.org,rossberg@chromium.org,bmeurer@chromium.org,hpayer@chromium.org,jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1600873002 Cr-Commit-Position: refs/heads/master@{#33485}
-
littledan authored
A recent ES2015 semantics web compatibility fix changed a WebKit test from a syntax error to a known failure without a syntax error. This confused the fuzzer infrastructure. This patch updates the test expectations to the expected output, based on what the new semantics provide. R=machenbach,adamk BUG=v8:4693 LOG=N Review URL: https://codereview.chromium.org/1628013003 Cr-Commit-Position: refs/heads/master@{#33484}
-
zhengxing.li authored
port a0878333(r33460) original commit message: We already had hand-written optimized code for %_ToName in fullcodegen, but the optimizing compilers always went to the runtime for %_ToName, which is pretty bad for many of our builtins. So this CL moves the existing native code to a ToNameStub (similar to the existing ToStringStub), and uses the ToNameStub consistently in all compilers to actually implement %_ToName. BUG= Review URL: https://codereview.chromium.org/1622793006 Cr-Commit-Position: refs/heads/master@{#33483}
-
zhengxing.li authored
port ca51c204(r33463) original commit message: This fixes the broken return address when the exception handler within interpreted bytecode is being entered via stack unwinding. The address in question will never actually be taken, but our stack walker uses this address to determine whether a frame is interpreted. BUG= Review URL: https://codereview.chromium.org/1632453002 Cr-Commit-Position: refs/heads/master@{#33482}
-
mtrofin authored
moves, we move those to the node, and remove them from the predecessors ("merge" them to the common node). If only some of the moves are common, we don't do anything. This is what this change addresses. The bug linked below should be addressed by this change. The only difference in codegen before/after the change that introduced the bug was un-merged moves. BUG=chromium:549262 LOG=N Review URL: https://codereview.chromium.org/1527203002 Cr-Commit-Position: refs/heads/master@{#33481}
-
bmeurer authored
Now TurboFan always uses the newly introduced %ForInPrepare, no matter whether baseline is the interpreter or fullcodegen. For fullcodegen, we introduce a new PrepareId bailout point for this purpose. Drive-by-fix: Avoid the NoObservableSideEffectsScope in Crankshaft and use the PrepareId bailout point instead. R=jarin@chromium.org BUG=v8:3650 LOG=n Review URL: https://codereview.chromium.org/1630523002 Cr-Commit-Position: refs/heads/master@{#33480}
-
- 23 Jan, 2016 3 commits
-
-
v8-autoroll authored
Rolling v8/buildtools to 222bd42ce39d1bd8f08fe089b066f49c469e1cdf Rolling v8/tools/clang to 3ed46b50b0b4e8c829ea6492bbe357b2b7b8e64a TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1623773002 Cr-Commit-Position: refs/heads/master@{#33479}
-
adamk authored
The web appears to depend on being able to redeclare functions-in-blocks in sloppy mode (examples seen so far tend to redeclare identical functions, most likely accidentally). This patch opens a minimal hole: two same-named function declarations in the same scope are allowed, only in sloppy mode. BUG=v8:4693, chromium:579395 LOG=y Review URL: https://codereview.chromium.org/1622723003 Cr-Commit-Position: refs/heads/master@{#33478}
-
rmcilroy authored
Change the interpreter to always store the current context in the frame's context slot instead of the function context. This makes it possible to restore the correct context during deopt. BUG=v8:4678,v8:4280 LOG=N Review URL: https://codereview.chromium.org/1604923002 Cr-Commit-Position: refs/heads/master@{#33477}
-
- 22 Jan, 2016 18 commits
-
-
mbrandy authored
Port a0878333 Original commit message: We already had hand-written optimized code for %_ToName in fullcodegen, but the optimizing compilers always went to the runtime for %_ToName, which is pretty bad for many of our builtins. So this CL moves the existing native code to a ToNameStub (similar to the existing ToStringStub), and uses the ToNameStub consistently in all compilers to actually implement %_ToName. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1620313004 Cr-Commit-Position: refs/heads/master@{#33476}
-
mbrandy authored
This change allows the PPC simulator to execute on PPC hardware where, due to calling conventions, we must distinguish between Object* and ObjectPair return values. We find this useful as another available option for debugging certain problems. While not strictly necessary for Intel platforms, we hope that this is less offensive now that BUILTIN_CALL_TRIPLE has been added. BUG= R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com Review URL: https://codereview.chromium.org/1604653006 Cr-Commit-Position: refs/heads/master@{#33475}
-
mstarzinger authored
These tests have been disabled while support for try-finally was work in progress. By now control flow is connected properly and the tests pass. R=oth@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1626503002 Cr-Commit-Position: refs/heads/master@{#33474}
-
ofrobots authored
Revert "Revert of [profiler] Implement POC Sampling Heap Profiler (patchset #12 id:220001 of https://codereview.chromium.org/1555553002/ )" This reverts commit 77df8659. BUG= Review URL: https://codereview.chromium.org/1618693004 Cr-Commit-Position: refs/heads/master@{#33473}
-
mstarzinger authored
This adds an explicit ReThrow bytecode to be used in the modelling of try-finally statements. An exception that is being re-thrown should not trigger message object creation or location computation and hence cannot use the existing Throw bytecode. R=rmcilroy@chromium.org TEST=cctest/test-interpreter/InterpreterTryFinally BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1621673002 Cr-Commit-Position: refs/heads/master@{#33472}
-
mbrandy authored
Port ca51c204 Original commit message: This fixes the broken return address when the exception handler within interpreted bytecode is being entered via stack unwinding. The address in question will never actually be taken, but our stack walker uses this address to determine whether a frame is interpreted. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com TEST=cctest/test-interpreter/InterpreterTryCatch BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1615093004 Cr-Commit-Position: refs/heads/master@{#33471}
-
rmcilroy authored
Adds support for ForOf to the interpreter. BUG=v8:4685 LOG=N Review URL: https://codereview.chromium.org/1618693005 Cr-Commit-Position: refs/heads/master@{#33470}
-
bmeurer authored
In case the receiver map has an enum cache, %ForInPrepare returns the length of the actual enum cache, which might include properties that are further down the transition tree tho. R=jarin@chromium.org BUG=v8:3650 LOG=n Review URL: https://codereview.chromium.org/1619353002 Cr-Commit-Position: refs/heads/master@{#33469}
-
sigurds authored
R=jarin@chromium.org BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1608073003 Cr-Commit-Position: refs/heads/master@{#33468}
-
cbruni authored
Is it frozen water? Is it a train? No, but it's both (relatively) fast and (relatively) cool, it's ICE, the IC-Explorer. Upload an IC trace and you can easily* drill-down on where most IC changes happen. It even comes with a colored title and runs in your favourite browser without dependencies (yeah, I'm looking at you JQuery!) *according to a user study with a random 1-person group. R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/1618213003 Cr-Commit-Position: refs/heads/master@{#33467}
-
mstarzinger authored
TBR=rmcilroy@chromium.org TEST=cctest/test-bytecode-generator NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1612373004 Cr-Commit-Position: refs/heads/master@{#33466}
-
mstarzinger authored
This models function local control flow through try-finally constructs using a token dispatch mechanism. All paths through the finally block are assigned a token, at the end of the finally block a switch construct dispatches according to this token. R=oth@chromium.org,rmcilroy@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1613443002 Cr-Commit-Position: refs/heads/master@{#33465}
-
rmcilroy authored
Break and continue operations need to pop the context chain to the correct context before jumping to the target. BUG=v8:4280,v8:4678 LOG=N Review URL: https://codereview.chromium.org/1618693002 Cr-Commit-Position: refs/heads/master@{#33464}
-
mstarzinger authored
This fixes the broken return address when the exception handler within interpreted bytecode is being entered via stack unwinding. The address in question will never actually be taken, but our stack walker uses this address to determine whether a frame is interpreted. R=rmcilroy@chromium.org TEST=cctest/test-interpreter/InterpreterTryCatch BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1615063002 Cr-Commit-Position: refs/heads/master@{#33463}
-
jarin authored
In d8, run with --runtime-call-stats and it will output the stats when d8 finishes. In Chrome, run the following: (only on trusted code, this punches *massive* security hole into Chrome) chrome --js-flags="--runtime-call-stats --allow-natives-syntax" To get the stats in the console, just run console.log(%GetAndResetRuntimeCallStats()); To output stats every second: setInterval(function() { console.log(%GetAndResetRuntimeCallStats()); }, 1000) Review URL: https://codereview.chromium.org/1615943002 Cr-Commit-Position: refs/heads/master@{#33462}
-
ishell authored
When accessor getter callback is called the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according to ES6 there's no difference between strict and non-strict property loads. For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true if the property is set in strict context. Interceptors follow same idea: for getter, enumerator and query callbacks the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true in strict context. This CL also cleans up the CallApiGetterStub and removes bogus asserts from [arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers containing duplicates. BUG=v8:4267 LOG=Y Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f Cr-Commit-Position: refs/heads/master@{#33438} Review URL: https://codereview.chromium.org/1587073003 Cr-Commit-Position: refs/heads/master@{#33461}
-
bmeurer authored
We already had hand-written optimized code for %_ToName in fullcodegen, but the optimizing compilers always went to the runtime for %_ToName, which is pretty bad for many of our builtins. So this CL moves the existing native code to a ToNameStub (similar to the existing ToStringStub), and uses the ToNameStub consistently in all compilers to actually implement %_ToName. Review URL: https://codereview.chromium.org/1622493002 Cr-Commit-Position: refs/heads/master@{#33460}
-
cbruni authored
Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1612413003/ ) Reason for revert: let me quickly revert the revert, wut? Goal: my CL should not be in the tree! Original issue's description: > Reland of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #1 id:1 of https://codereview.chromium.org/1619803003/ ) > > Reason for revert: > the deopt issues have been taken care of by benedikt > > Original issue's description: > > Revert of [runtime] Do not use the enum-cache for non-prototype objects. (patchset #10 id:180001 of https://codereview.chromium.org/1608523002/ ) > > > > Reason for revert: > > tanks for-in significantly > > > > Original issue's description: > > > [runtime] Do not use the enum-cache for keys retrieval. > > > > > > Currently we fail to properly handle shadowed properties. If the > > > receiver defines a non-enumerable property that reappears on the > > > prototype as enumerable it incorrectly shows up in [[Enumerate]]. > > > By extending the KeyAccumulator to track non-enumerable properties > > > we can now properly filter them out when seeing them further up in > > > the prototype-chain. > > > > > > BUG=v8:705 > > > LOG=y > > > > > > Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7 > > > Cr-Commit-Position: refs/heads/master@{#33405} > > > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=v8:705 > > LOG=n > > > > Committed: https://crrev.com/6e0573c6fff1c3041bab106d1197ab1b64aa9a6a > > Cr-Commit-Position: refs/heads/master@{#33443} > > TBR=jkummerow@chromium.org,bmeurer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:705 > > Committed: https://crrev.com/5569e270eda517b5ea74e3a7676b3230cbe2f7a9 > Cr-Commit-Position: refs/heads/master@{#33458} TBR=jkummerow@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:705 Review URL: https://codereview.chromium.org/1614313003 Cr-Commit-Position: refs/heads/master@{#33459}
-