- 20 Jun, 2018 39 commits
-
-
Brian Stell authored
Change-Id: I741d53f3e132a4770fa738b7e902c1f24eafd594 Reviewed-on: https://chromium-review.googlesource.com/1107237 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53895}
-
Igor Sheludko authored
This is a preliminary step for adding support for additional flags and return types. Bug: v8:7754, v8:6600 Change-Id: I1f65ec41f22b61a9471eb7105033007744563e91 Reviewed-on: https://chromium-review.googlesource.com/1107917 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53894}
-
Predrag Rudic authored
Port of 733b7c82 Original description: > [wasm] Introduce jump table > > This introduces the concept of a jump table for WebAssembly, which is > used for every direct and indirect call to any WebAssembly function. > For lazy compilation, it will initially contain code to call the > WasmCompileLazy builtin, where it passes the function index to be > called. > For non-lazy-compilation, it will contain a jump to the actual code. > The jump table allows to easily redirect functions for lazy > compilation, tier-up, debugging and (in the future) code aging. After > this CL, we will not need to patch existing code any more for any of > these operations. > > R=mstarzinger@chromium.org, titzer@chromium.org > > Bug: v8:7758 > Change-Id: I45f9983c2b06ae81bf5ce9847f4542fb48844a4f > Reviewed-on: https://chromium-review.googlesource.com/1097075 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53805} Change-Id: Ifa7c2abe89a6dc5dbb03a547db2fab68e292f344 Reviewed-on: https://chromium-review.googlesource.com/1107630 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53893}
-
Simon Zünd authored
This CL fixes a bug where execution would continue on a fast-path even though a previous recursion step bailed to the slow path. This would allow possibly illegal loads that could leak to JS. Drive-by change: Instead of bailing to the slow-path on each recursion step, we now bail completely and start the slow-path afterwards. R=cbruni@chromium.org, jgruber@chromium.org Bug: chromium:854299, v8:7382 Change-Id: Ib2fd5d85dbd0c3894d7775c4f62e053c31b5e5d1 Reviewed-on: https://chromium-review.googlesource.com/1107702 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53892}
-
Alexey Kozyatinskiy authored
Extracted from https://chromium-review.googlesource.com/c/v8/v8/+/1105493/ R=yangguo@chromium.org Bug: v8:7862 Change-Id: I804a444a43047e3303b5f1b0140522b4f609f3ba Reviewed-on: https://chromium-review.googlesource.com/1107393 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53891}
-
Ben L. Titzer authored
This CL attempts to simplify the Assembler's dependency on the isolate, in particular on a global "serializer_enabled" mode contained therein. The "serializer_enabled" condition enabled and disabled a number of things in both the assemblers and macro assemblers. To make these dependencies explicit, the Assembler::IsolateData is refactored to be a proper Assembler::Options struct that controls specific assembler behaviors, with default settings easily computable from the isolate. This also helps make the contract for compiling WASM code more explicit (since WASM code needs to have reloc info recorded for external references) we can explicitly enable this recording without trying to "trick" the assembler using "serializer_enabled". R=jgruber@chromium.org CC=mstarzinger@chromium.org, herhut@chromium.org Change-Id: I7a8ba49df7b75b292d73ec2aa6e507c27a3d99c8 Reviewed-on: https://chromium-review.googlesource.com/1105982 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
When encountering a LoadStackPointer input to a comparison, generate a register LocationOperand that points to the stack pointer. This can avoid unnecessary spilling of the stack pointer. Since sp is a special register for arm64, we need to add a mechanism to print its name in RegisterConfiguration. This is a port of https://chromium-review.googlesource.com/1055568 that made the same change for arm. It also ports the tests added in https://chromium-review.googlesource.com/1099068 to arm and arm64. Bug: v8:7844 Change-Id: I5adc672ff877b9888ef755e8e60e4eabbc61061b Reviewed-on: https://chromium-review.googlesource.com/1107810Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#53889}
-
Peter Marshall authored
There is no point calling AllocationSpaceName manually every time. We could get rid of AllocationSpaceName entirely, except that the serializer calls it directly on ints that are casted to AllocationSpace objects first. Change-Id: I26b2181347dba960c8523d5dcecf8128208c59a2 Reviewed-on: https://chromium-review.googlesource.com/1107816Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53888}
-
Camillo Bruni authored
- Add parseString and parseVarArgs helper constants - Fix number formatting in parser-processor.js - Rename time to duration in parse-processor - Fix eval handling in parse-processor Bug: chromium:757467, chromium:850038 Change-Id: Ibce57b46d22e03ddaa5baa22f45d8df4c93af2cd Reviewed-on: https://chromium-review.googlesource.com/1102435Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53887}
-
jgruber authored
Some cctests force fresh creation of heap constants, even though the cctest binary itself is an embedded snapshot build (i.e.: a snapshot blob exists, and a binary-embedded blob exists). This breaks a few assumptions, for example that off-heap builtins have a single, canonical off-heap code range. Unfortunately this isn't that easy to fix. I see a few alternatives: 1. In builtins setup, if an embedded blob exists, regenerate the builtins for their metadata (things like the safepoint table offset), and then replace them by off-heap trampolines. 2. As above, but deserialize the trampolines from the snapshot blob. 3. As above, but pack required metadata into the embedded blob and create trampolines from there. 4. Act as if the embedded blob does not exist. Alternative 1 does not work because the generated code can be slightly different at at runtime vs. mksnapshot-time. Alternative 2 is out because we do not have access to the snapshot blob in TestIsolate setup. Alternative 3 is probably the preferred option but would be a more involved change. This CL takes path 4. It's not an optimal solution, but it can be replace by alternative 3 later. TBR=ulan@chromium.org Bug: v8:7718, v8:7751 Change-Id: I36c024cb0179615011c886ed3978bc95f0d197ac Reviewed-on: https://chromium-review.googlesource.com/1098924Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I6b109a596ba4bbeeab4189003b902f026ab79ac9 Reviewed-on: https://chromium-review.googlesource.com/1107809Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I82e329058d7904e638010e10b4f75aac5075e7d1 Reviewed-on: https://chromium-review.googlesource.com/1107062Reviewed-by:
-
Clemens Hammacher authored
The stack check builtin really has stub linkage, not wasm linkage. For the stack check, it technically does not make a difference currently since the stack check does not receive any arguments. R=mstarzinger@chromium.org Change-Id: Ia3e6ea192250dc3799c7a5166cf616f883c1f63f Reviewed-on: https://chromium-review.googlesource.com/1107709Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If9904fe8feb9b4e157d42d6e84f1aa263abcc8b7 Reviewed-on: https://chromium-review.googlesource.com/1106160 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53882}
-
Yang Guo authored
Unconditionally setting the JSFunction code to that of the SFI may skip initializing the feedback vector. R=leszeks@chromium.org Bug: v8:7857 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I65d4bf32493be4cade2eaf3d665d44f93e80f809 Reviewed-on: https://chromium-review.googlesource.com/1107618 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53881}
-
Leszek Swirski authored
Bug: v8:7786 Change-Id: I369eb0bf32d89603b6b944c2bb8fe402a16e429b Reviewed-on: https://chromium-review.googlesource.com/1104423 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I89339f2d9035d1882e8d29a9119f1bc2d68927e5 Reviewed-on: https://chromium-review.googlesource.com/1105759Reviewed-by:
-
Clemens Hammacher authored
This test was not adapted for the jump table yet. R=mstarzinger@chromium.org Bug: v8:7867 Change-Id: Ifd03899b0757972525dcc54f04949635d03fa493 Reviewed-on: https://chromium-review.googlesource.com/1107624 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: chromium:854213 Change-Id: I01fafbf63009f309758b07ba59013c72c7439a10 Reviewed-on: https://chromium-review.googlesource.com/1107707Reviewed-by:
-
Leszek Swirski authored
If the isolate is available via another object (including JSReceivers and Contexts), grab it through that rather than HeapObject::GetIsolate. As a drive-by, fix up places where this looked like it would work but didn't because of null or uninitialized objects. Bug: v8:7786 Change-Id: I3454840073d1455b3738e0ac34ccaa3c9a220896 Reviewed-on: https://chromium-review.googlesource.com/1104170Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: v8:7187 Change-Id: I9c64d637501f074464b1fe3637df50be447603ab Reviewed-on: https://chromium-review.googlesource.com/1098934 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53875}
-
Yang Guo authored
This reverts commit 9d406a02. Reason for revert: Layout Test failures: https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064/24236 Original change's description: > Reland "[array] Change QuickSort to TimSort for Array.p.sort" > > This is a reland of 6bb82368 > > Original change's description: > > [array] Change QuickSort to TimSort for Array.p.sort > > > > Bug: v8:7382 > > Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d > > Reviewed-on: https://chromium-review.googlesource.com/1100881 > > Commit-Queue: Simon Zünd <szuend@google.com> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53838} > > Bug: v8:7382 > Change-Id: I499d782feaeb36df154e00a11d3b03cd41442347 > Reviewed-on: https://chromium-review.googlesource.com/1107497 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Simon Zünd <szuend@google.com> > Cr-Commit-Position: refs/heads/master@{#53864} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: I877834301d98174b148e42dee42f598a62c544de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Reviewed-on: https://chromium-review.googlesource.com/1107757Reviewed-by:
-
Dan Elphick authored
Replace all implicit Handle<T>(T*) constructors in src/bootstrapper.cc with explicit ones that use a local variable or parameter. (All done using Leszek's awesome new tool!) Bug: v8:7786 Change-Id: Iec01fda502dd121bc1815d5dab73bd09bb3e5aa6 Reviewed-on: https://chromium-review.googlesource.com/1107697Reviewed-by:
-
Creddy authored
This is a reland of 380dba0a Original change's description: > [runtime][gc] Drop AllocationSite::weak_next field for sub-literals > > Use AllocationSite without Weaknext field for all the allocations in nested > literal except for Root. The nested field is sufficient to link all the > allocations in a nested literal. Only the Root is added to heap weak_alloc_list > for GC to traverse > > Change-Id: I946e63292c6d168197cd2a087f697c73cc431272 > Reviewed-on: https://chromium-review.googlesource.com/1101323 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53813} Change-Id: Ic451fb3600b87f8f69748b1659ff89a80c9322fa Reviewed-on: https://chromium-review.googlesource.com/1106257Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ic16e1da4ca50070ceff7f9a441250db2d20a868f Reviewed-on: https://chromium-review.googlesource.com/1104471 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Georg Neis authored
There's no need to assume anything when we don't reduce the node. R=bmeurer@chromium.org Change-Id: Ic39b6e634c662824a72affd91318ca024f3e1055 Reviewed-on: https://chromium-review.googlesource.com/1105832Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53870}
-
Leszek Swirski authored
Fix assumption that only top level code won't have outer scope infos. Bug: v8:7690 Change-Id: Ia6eec7b406632ad301e7db557597204c7ca66730 Reviewed-on: https://chromium-review.googlesource.com/1107622Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I6a6347d7394ddeacbb185a2e6e5187898bfca2dc Reviewed-on: https://chromium-review.googlesource.com/1106173Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#53868}
-
Théotime Grohens authored
This CL adds a constexpr int31 == operator that returns a constexpr bool value. It also fixes a bug that this introduces because branch generation for ternary operators incorrectly assumed that the condition value was bool, whereas it can also be constexpr bool now. Change-Id: Ie7d3497c9d1112c121b4a29561fe065b5bf01fb6 Reviewed-on: https://chromium-review.googlesource.com/1106343Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53867}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:854503 Change-Id: I07ae21bee95c2ef781824c6b98929ceb3786b1dd Reviewed-on: https://chromium-review.googlesource.com/1107559Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53866}
-
Georg Neis authored
This is in order to check if we can get rid of the cache. Bug: v8:7790 Change-Id: Id6625ffc440665b090f999564b006506f947ae45 Reviewed-on: https://chromium-review.googlesource.com/1107620Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53865}
-
Simon Zünd authored
This is a reland of 6bb82368 Original change's description: > [array] Change QuickSort to TimSort for Array.p.sort > > Bug: v8:7382 > Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d > Reviewed-on: https://chromium-review.googlesource.com/1100881 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53838} Bug: v8:7382 Change-Id: I499d782feaeb36df154e00a11d3b03cd41442347 Reviewed-on: https://chromium-review.googlesource.com/1107497Reviewed-by:
-
Georgia Kouveli authored
We can instead pass the deopt id in a register, where before we were passing the deopt entry address. This removes the need for the deopt tables altogether, saving 192kB. Change-Id: I479d4de1a0245de328720b6b03a1955c8c63f696 Reviewed-on: https://chromium-review.googlesource.com/1076472Reviewed-by:
-
Georg Neis authored
Also fix an oversight in my previous CL. R=jarin@chromium.org Bug: v8:7790 Change-Id: I61c783392b7b7b38ea28dc44dc1e932d15b55bc6 Reviewed-on: https://chromium-review.googlesource.com/1106170Reviewed-by:
-
Yang Guo authored
GCC 4.9 used on some Node.js CI machines complains when the control reaches the end of a non-void function and no return is encountered. R=bmeurer@google.com, ofrobots@google.com, yangguo@google.com Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5af0192cb187eccbf34dbb60ff3ac2e4774af803 Reviewed-on: https://chromium-review.googlesource.com/1105619Reviewed-by:
-
Clemens Hammacher authored
The reference to the {NativeModule} (stored in a {Managed}) should live on the {WasmModuleObject}, not on the individual {WasmCompiledModule} objects. R=titzer@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I21dfa088c9643d36d9fd5052a145e7e2af5e47f9 Reviewed-on: https://chromium-review.googlesource.com/1106380 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Achenbach authored
TBR=santa Bug: chromium:854503 Change-Id: I88ae0256b74cbc62df6ef81069d55eb894171a35 Reviewed-on: https://chromium-review.googlesource.com/1107064Reviewed-by:
-
Clemens Hammacher authored
The {ModuleEnv} already contains a pointer to the {WasmModule}, no need to pass it explicitly. R=titzer@chromium.org Change-Id: Icf0e8ea8b25c33dd5bcaeab2a4a746376e73813d Reviewed-on: https://chromium-review.googlesource.com/1105828 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
Our tests currently don't set {WasmModule::num_declared_functions} correctly. This CL fixes that. This enables the use of {WasmModule::num_declared_functions} instead of {NativeModule::num_functions_ - NativeModule::num_imported_functions_}. Drive-by: Fix {std::vector} reservation to reserve enough space for all functions during decoding. R=titzer@chromium.org Change-Id: I6d7783aed1c0de3275fc72787dec17c38ff8c73b Reviewed-on: https://chromium-review.googlesource.com/1106166 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
- 19 Jun, 2018 1 commit
-
-
Junliang Yan authored
Port 825c7481 R=tebbi@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: If067828166e44b99f48add7e929d6be8b585f34b Reviewed-on: https://chromium-review.googlesource.com/1106877Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53856}
-
