1. 13 Dec, 2021 1 commit
  2. 07 Jun, 2021 1 commit
    • Andreas Haas's avatar
      [wasm] Allow WebAssembly.Global.value.set to be called with undefined · ad938456
      Andreas Haas authored
      A spec test (wasm-js/global/value-get-set) requires
      WebAssembly.Global.value.set to throw an exception if it is called with
      0 arguments. The implementation in V8, however, just checked if the
      first parameter is `undefined`. This implementation indeed threw an
      exception if 0 arguments were provided, but it also threw an exception
      when `undefined` is provided as a parameter. This, however, violates
      the spec, because globals can be reset to `undefined`.
      
      With this CL we replace the checking for `undefined` by checking the
      length of the arguments that get provided.
      
      R=ecmziegler@chromium.org
      
      Bug: chromium:1211342
      Change-Id: Ic87a0b369dea3e49eddb8f71f2c29dc6a8f5f558
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940901Reviewed-by: 's avatarEmanuel Ziegler <ecmziegler@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74982}
      ad938456
  3. 01 Jun, 2021 1 commit
  4. 27 Apr, 2021 1 commit
  5. 15 Sep, 2020 1 commit
  6. 10 Jun, 2020 1 commit
  7. 09 Jun, 2020 1 commit
  8. 05 Jun, 2020 1 commit
  9. 03 Jun, 2020 2 commits
  10. 17 Feb, 2020 1 commit
  11. 08 Oct, 2019 2 commits
  12. 14 May, 2019 1 commit
  13. 08 May, 2019 1 commit
  14. 18 Mar, 2019 1 commit
  15. 30 Jan, 2019 1 commit
  16. 16 Jan, 2019 1 commit
  17. 15 Jan, 2019 2 commits
    • Andreas Haas's avatar
      [wasm][anyref] Implement re-export of mutable anyref globals · 51ad897d
      Andreas Haas authored
      R=mstarzinger@chromium.org
      
      Bug: v8:7581
      Change-Id: If469467663e632a1dba3bd55ace830e1b2f38f7e
      Reviewed-on: https://chromium-review.googlesource.com/c/1409427
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58824}
      51ad897d
    • Andreas Haas's avatar
      [wasm][anyref] Support importing mutable anyref globals · b3e6013e
      Andreas Haas authored
      With this CL we support importing mutable anyref globals. The CL
      contains the following changes:
      
      * We store a reference to the buffer of the imported global in
        `WasmInstance::imported_mutable_globals_buffer`. This FixedArray is
        already used to keep the ArrayBuffers of value-typed imported
        mutable globals alive but was not accessed otherwise.
      
      * We store the offset in the buffer of the imported global in
        `WasmInstance::imported_mutable_globals`. This `Address`-array is
        used for value-typed imported mutalbe globals to store direct
        pointers into the backing store of the ArrayBuffer of the imported
        global.
      
      * In wasm-compiler.cc we generate code to load these fields and then
        load or store globals.
      
      * in module-compiler.cc I removed the counter variable
        `next_imported_mutable_global_index`. The variable was only used for
        a DCHECK. I replaced the DCHECK with a slightly weaker DCHECK now.
      
      * Tests.
      
      R=mstarzinger@chromium.org
      
      Bug: v8:7581
      Change-Id: I11f0f4d8637c98eded5fb2eec44bc8ead8ed5c7b
      Reviewed-on: https://chromium-review.googlesource.com/c/1409169
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58822}
      b3e6013e
  18. 10 Jan, 2019 1 commit
  19. 08 Jan, 2019 2 commits
  20. 04 Jan, 2019 1 commit
  21. 18 Dec, 2018 1 commit
    • Andreas Haas's avatar
      [wasm][anyref] Implement anyref globals · 32562e91
      Andreas Haas authored
      This CL implements the global.get and global.set instruction for anyref
      globals. This includes:
      
      * Properly decode anyref globals.
      * Add a FixedArray to WasmInstanceObject to store anyref globals.
      * Initialize the FixedArray.
      * Generate code for global.get and global set.
      
      This CL does not allow to import globals yet.
      
      R=clemensh@chromium.org
      
      Bug: v8:7581
      Change-Id: I62617409271d9b6f2253a191681189865aa1f459
      Reviewed-on: https://chromium-review.googlesource.com/c/1380112Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58318}
      32562e91