- 04 Mar, 2015 1 commit
-
-
arv authored
Function name property is now standardized in ES6. It was a Mozilla proprietary extension before. With ES6, the property was made configurable, so that it can be used instead of another proprietary property, displayName. This is a revert of revert https://chromium.googlesource.com/v8/v8.git/+/c791d8411225aa95518c880defd9a5b1ea243afc. Last time this broke a Chrome browser test which has since been updated: https://chromium.googlesource.com/chromium/src/+/5f75a3be4c9334aba627d6c5eb884adf965e1d78 BUG=v8:3333 LOG=N R=mstarzinger@chromium.org,verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/977003004 Cr-Commit-Position: refs/heads/master@{#26996}
-
- 02 Mar, 2015 1 commit
-
-
arv authored
Revert of ES6: Make function name configurable (patchset #10 id:220001 of https://codereview.chromium.org/960343002/) Reason for revert: Breaks Chrome browser test that checks Object.name [16509:16509:0228/030150:INFO:CONSOLE(43)] "Uncaught Error: Clobbered Object.name getter", source: http://www.chromium.org:33611/assertions.js (43) http://build.chromium.org/p/client.v8/builders/Linux%20Tests%20%28dbg%29%281%29/builds/2328/steps/browser_tests/logs/stdio Original issue's description: > ES6: Make function name configurable > > This is partially based on r21609 but that CL was incomplete. > > Function name is still non writable so one has to use defineProperty > to change the actual value. > > BUG=v8:3333 > LOG=N > R=adamk, mstarzinger@chromium.org > > Committed: https://crrev.com/f7790f7670c8d859455a98fcb90ff1b66af1eca7 > Cr-Commit-Position: refs/heads/master@{#26924} TBR=adamk@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3333 Review URL: https://codereview.chromium.org/969683002 Cr-Commit-Position: refs/heads/master@{#26933}
-
- 27 Feb, 2015 1 commit
-
-
arv authored
This is partially based on r21609 but that CL was incomplete. Function name is still non writable so one has to use defineProperty to change the actual value. BUG=v8:3333 LOG=N R=adamk, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/960343002 Cr-Commit-Position: refs/heads/master@{#26924}
-
- 03 Jun, 2014 1 commit
-
-
mvstanton@chromium.org authored
This reverts commit r21609 due to browser test failures. TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/313583002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21632 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:3333 LOG=N Review URL: https://codereview.chromium.org/303463006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=danno@google.com, danno@chromium.org Review URL: https://codereview.chromium.org/297163009 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:3333 LOG=N Review URL: https://codereview.chromium.org/296413003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Feb, 2014 2 commits
-
-
rossberg@chromium.org authored
Plenty of test failures on test262, Mozilla, Webkit. Will have to investigate. TBR=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/139983003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
ES6 makes the Function object properties "length" and "name" configurable; switch the implementation over to follow that. Doing so exposed a problem in the handling of non-writable, but configurable properties backed by foreign callback accessors internally. As an optimization, if such an accessor property is re-defined with a new value, its setter was passed the new value directly, keeping the property as an accessor property. However, this is not correct should the property be non-writable, as its setter will then simply ignore the updated value. Adjust the enabling logic for this optimization accordingly, along with adding a test. LOG=N R=rossberg@chromium.org, rossberg BUG=v8:3045 Review URL: https://codereview.chromium.org/116083006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Dec, 2013 1 commit
-
-
rossberg@chromium.org authored
Set [[Writable]] to false for the "name" property of strict functions as well, mirroring what non-strict functions have it as. LOG=N R=rossberg@chromium.org TEST=mjsunit/regress/regress-270142 BUG=270142 Review URL: https://codereview.chromium.org/99203006 Patch from Sigbjorn Finne <sigbjornf@opera.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18387 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Aug, 2013 1 commit
-
-
jkummerow@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/22611009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16353 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Feb, 2013 1 commit
-
-
verwaest@chromium.org authored
BUG=chromium:173974 Review URL: https://chromiumcodereview.appspot.com/12178017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13586 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jan, 2013 1 commit
-
-
verwaest@chromium.org authored
This is necessary for monomorphic stubs that rely on instance types, such as ArrayLength, StringLength and FunctionPrototype. BUG=chromium:172345 Review URL: https://chromiumcodereview.appspot.com/12082023 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Jan, 2013 1 commit
-
-
yangguo@chromium.org authored
R=svenpanne@chromium.org BUG=170856 Review URL: https://chromiumcodereview.appspot.com/11896060 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Oct, 2008 1 commit
-
-
sgjesse@chromium.org authored
report the exception when they happen in the try block and not as previously when re-thrown after execution of the finally block. There is no longer any message generated by re-throw. Added test cases for various combinations of try/catch/finally with throw in different places. Added a regression directory to the messages tests which is processed by the test runner. Added regression tests for the specific bugs fixed. Runs all the test suites. BUG=73 BUG=75 Review URL: http://codereview.chromium.org/8050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2008 1 commit
-
-
christian.plesner.hansen authored
In the shell sample don't print the result of executing a script, only evaluating expressions. Fixed issue when building samples on Windows using a shared V8 library. Added visibility option on Linux build which makes the generated library 18% smaller. Changed build system to accept multiple build modes in one build and generate seperate objects, libraries and executables for each mode. Removed deferred negation optimization (a * -b => -(a * b)) since this visibly changes operand conversion order. Improved parsing performance by introducing stack guard in preparsing. Without a stack guard preparsing always bails out with stack overflow. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2008 1 commit
-
-
christian.plesner.hansen authored
git-svn-id: http://v8.googlecode.com/svn/trunk@2 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-