- 13 Apr, 2016 16 commits
-
-
machenbach authored
Revert of [Atomics] code stubs for atomic operations (patchset #28 id:530001 of https://codereview.chromium.org/1617503003/ ) Reason for revert: [Sheriff] Roll was reverted. Please fix unused methods, see: https://codereview.chromium.org/1884913002/ https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/5585/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > [Atomics] code stubs for atomic operations > > * New atomic code stubs for x64, ia32, arm, arm64 > * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue > to macro-assembler-ia32 (API based on x64 macro assembler) > * Remove runtime implementation of Atomics.load, the code stub should always be > called instead > * Add new test to mjsunit atomics test; check that Smi values of different > sizes are supported when possible, else fall back to HeapNumbers > > These changes were needed to add another codestub: > * Bump kStubMajorKeyBits from 7 to 8 > * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 > > BUG=v8:4614 > LOG=y > > Committed: https://crrev.com/10b5febe11b318cfef130abae343183ac862e60d > Cr-Commit-Position: refs/heads/master@{#35427} TBR=jarin@chromium.org,bmeurer@chromium.org,rodolph.perfetta@gmail.com,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4614 Review URL: https://codereview.chromium.org/1884883003 Cr-Commit-Position: refs/heads/master@{#35443}
-
machenbach authored
TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1885863003 Cr-Commit-Position: refs/heads/master@{#35442}
-
machenbach authored
Fix after https://codereview.chromium.org/1887583002/ TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1881163003 Cr-Commit-Position: refs/heads/master@{#35441}
-
mvstanton authored
Visit the Optimized Code Map on first call rather than closure creation. This is useful for escape analysis, and helps upcoming changes to type feedback gathering. Adding notry due to crashed builders: NOTRY=true BUG= Committed: https://crrev.com/9336f4cc6d25d39a128176679a70dbd13a6d946e Cr-Commit-Position: refs/heads/master@{#35395} Review URL: https://codereview.chromium.org/1670143002 Cr-Commit-Position: refs/heads/master@{#35440}
-
neis authored
Annotate generator functions and loops therein with the number of contained yields. This information will eventually be used by the bytecode generator. R=bmeurer@chromium.org BUG=v8:4907 LOG=n Review URL: https://codereview.chromium.org/1877403003 Cr-Commit-Position: refs/heads/master@{#35439}
-
ssanfilippo authored
A new script, bytecode_dispatches_report.py reads the table produced when FLAG_trace_ignition_dispatches is enabled and produces either a report of top source-destination pairs, or a heatmap that can be viewed interactively and saved to file. BUG=v8:4899 LOG=N Review URL: https://codereview.chromium.org/1869423002 Cr-Commit-Position: refs/heads/master@{#35438}
-
machenbach authored
Check if a previous run left an inconsistent state behind. The check is right before trying to push a new state as then all information is available, like commit message and tag name. This is still only a band-aid. If gnumbd is down for a longer period, an unprocessed commit won't be found, but the push attempt will still fail. Review URL: https://codereview.chromium.org/1887583002 Cr-Commit-Position: refs/heads/master@{#35437}
-
ishell authored
... to avoid potential stack overflow when updating happens near the stack limit. BUG=chromium:599440 LOG=Y Review URL: https://codereview.chromium.org/1884653002 Cr-Commit-Position: refs/heads/master@{#35436}
-
clemensh authored
This is very similar to the existing rule for a GTAGS file, and reuses parts of it (the gtags.files file). R=ahaas@chromium.org, mstarzinger@chromium.org, titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/1873253002 Cr-Commit-Position: refs/heads/master@{#35435}
-
mlippautz authored
R=hpayer@chromium.org BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1886493003 Cr-Commit-Position: refs/heads/master@{#35434}
-
epertoso authored
Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition make use of them in the respective bytecode handlers. Review URL: https://codereview.chromium.org/1881003002 Cr-Commit-Position: refs/heads/master@{#35433}
-
mlippautz authored
- Additionally allow to commit late lists to an already started sweeper BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1871423002 Cr-Commit-Position: refs/heads/master@{#35432}
-
richard_chamberlain authored
This patch replaces the unused 'take_snapshot' parameter on FatalProcessOutOfMemory() with a 'is_heap_oom' parameter. The parameter is set to true on error paths where the JS heap is out of memory, as distinct from a malloc() failure i.e. process out of memory. The message output to stderr or passed to embedding applications via FatalErrorCallback is 'Javascript heap out of memory' rather than 'process out of memory'. BUG= R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com Review URL: https://codereview.chromium.org/1873443002 Cr-Commit-Position: refs/heads/master@{#35431}
-
neis authored
Instead of looking at the top JavaScriptFrame, take the needed information as arguments. This is in preparation of the new generators implementation. R=adamk@chromium.org, bmeurer@chromium.org BUG=v8:4907 LOG=n Review URL: https://codereview.chromium.org/1883443003 Cr-Commit-Position: refs/heads/master@{#35430}
-
bmeurer authored
The StringAddStub can automatically convert arbitrary inputs according to the semantics for the addition operator, if one side is already a string. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1881413002 Cr-Commit-Position: refs/heads/master@{#35429}
-
v8-autoroll authored
Rolling v8/buildtools to de013cf87971d0ab40596f2275a633432c908052 Rolling v8/tools/clang to 05a5cb33164e3c656a3375a1614ab350ca799215 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1883703003 Cr-Commit-Position: refs/heads/master@{#35428}
-
- 12 Apr, 2016 24 commits
-
-
binji authored
* New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 BUG=v8:4614 LOG=y Review URL: https://codereview.chromium.org/1617503003 Cr-Commit-Position: refs/heads/master@{#35427}
-
jyan authored
port 52148c41 Original Commit Message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com, mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1884573003 Cr-Commit-Position: refs/heads/master@{#35426}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1883533006 Cr-Commit-Position: refs/heads/master@{#35425}
-
mbrandy authored
Port eb5fe0df Original commit message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1878233002 Cr-Commit-Position: refs/heads/master@{#35424}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1872203005 Cr-Commit-Position: refs/heads/master@{#35423}
-
jyan authored
Port 79ff6507 R=verwaest@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1877353002 Cr-Commit-Position: refs/heads/master@{#35422}
-
mythria authored
When %OptimizeOSR is used with ignition flag, the runtime function tries to compile for OSR on interpreted functions. This cl modifies Runtime_OptimizeOsr function to return false for interpreted frames. BUG=v8:4280,chromium:599002 LOG=N Review URL: https://codereview.chromium.org/1880073002 Cr-Commit-Position: refs/heads/master@{#35421}
-
marija.antic authored
Fix for drotr and drotr32 instructions in MIPS64 simulator. BUG= Review URL: https://codereview.chromium.org/1880953002 Cr-Commit-Position: refs/heads/master@{#35420}
-
mstarzinger authored
This uses the common predicate SharedFunctionInfo::IsApiFunction to determine flushability. Just a minor cleanup, no change in semantics. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1878183002 Cr-Commit-Position: refs/heads/master@{#35419}
-
bmeurer authored
Previously TurboFan always went to the runtime to allocate in old space, which is pretty slow compare to a stub call. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1877323002 Cr-Commit-Position: refs/heads/master@{#35418}
-
jyan authored
port 2e329666 Original Commit Message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=bmeurer@chromium.org, neis@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1882553003 Cr-Commit-Position: refs/heads/master@{#35417}
-
mbrandy authored
Port 2e329666 Original commit message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1874323002 Cr-Commit-Position: refs/heads/master@{#35416}
-
thakis authored
Makes browser_tests --gtest_filter=CrSettingsBrowserTest.CrSettingsTest complete in a little over 8 seconds instead of timing out after 45s on my box. Without this patch, the test is much slower in gn builds than in gyp builds. v8/ part, goes with https://codereview.chromium.org/1880693003 BUG=chromium:586511 LOG=n Review URL: https://codereview.chromium.org/1882453002 Cr-Commit-Position: refs/heads/master@{#35415}
-
mlippautz authored
R=ulan@chromium.org BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1882033002 Cr-Commit-Position: refs/heads/master@{#35414}
-
ulan authored
This ensures that GC tracer scope is nested in a trace event. BUG= Review URL: https://codereview.chromium.org/1881993002 Cr-Commit-Position: refs/heads/master@{#35413}
-
hlopko authored
When the embedder sets the heap tracer, V8, during marking, will collect all reachable wrappers, and then ask embedder to trace its heap. The embedder is expected to call PersistentBase::RegisterExternalReference with all wrappers reachable from the given ones. This fixed point iteration happens in MarkCompact::ProcessEphemeralMarking. For more efficient object visiting during marking, we need a special JS_API_OBJECT_TYPE (in tandem with already existing JS_SPECIAL_API_OBJECT_TYPE) and corresponding visitor (JSApiObjectVisitor). BUG=chromium:468240 LOG=no Review URL: https://codereview.chromium.org/1844413002 Cr-Commit-Position: refs/heads/master@{#35412}
-
bmeurer authored
Make these builtins fast by default w/o relying on the %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal with well in TurboFan (and ignition). CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel R=epertoso@chromium.org Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb Cr-Commit-Position: refs/heads/master@{#35350} Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c Cr-Commit-Position: refs/heads/master@{#35402} Review URL: https://codereview.chromium.org/1868963002 Cr-Commit-Position: refs/heads/master@{#35411}
-
machenbach authored
Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. (patchset #3 id:40001 of https://codereview.chromium.org/1868963002/ ) Reason for revert: Please rebaseline: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5992 Original issue's description: > [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. > > Make these builtins fast by default w/o relying on the > %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal > with well in TurboFan (and ignition). > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg > R=epertoso@chromium.org > > Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb > Cr-Commit-Position: refs/heads/master@{#35350} > > Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c > Cr-Commit-Position: refs/heads/master@{#35402} TBR=epertoso@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877263002 Cr-Commit-Position: refs/heads/master@{#35410}
-
jochen authored
This is a convenience API that an embedder can use to do final checks on the return value. Note that this creates a new handle and thus defeats the performance optimization done for ReturnValue - an embedder should only use this in non-performance critical code paths. BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1875263003 Cr-Commit-Position: refs/heads/master@{#35409}
-
machenbach authored
BUG=535160 TBR=sergiyb@chromium.org, kjellander@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1884473002 Cr-Commit-Position: refs/heads/master@{#35408}
-
gdeepti authored
Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 Cr-Commit-Position: refs/heads/master@{#35182} Committed: https://crrev.com/297932a302ce0b73c3618ef9e4eba9d9d241f2b3 Cr-Commit-Position: refs/heads/master@{#35400} Review URL: https://codereview.chromium.org/1759383003 Cr-Commit-Position: refs/heads/master@{#35407}
-
oth authored
Fixes updating golden files following instanceof change. BUG=v8:4280 LOG=N R=rmcilroy@chromium.org,ssanfilippo@chromium.org Review URL: https://codereview.chromium.org/1858593002 Cr-Commit-Position: refs/heads/master@{#35406}
-
mbrandy authored
Port 79ff6507 R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1874983004 Cr-Commit-Position: refs/heads/master@{#35405}
-
hablich authored
Revert of Visit the Optimized Code Map on first call rather than closure creation. (patchset #7 id:120001 of https://codereview.chromium.org/1670143002/ ) Reason for revert: Blocks roll. See https://codereview.chromium.org/1877003002/ for detailed messages. You should be able to repro this with Linux ASAN. Original issue's description: > Visit the Optimized Code Map on first call rather than closure creation. > > This is useful for escape analysis, and helps upcoming changes to > type feedback gathering. > > BUG= > > Committed: https://crrev.com/9336f4cc6d25d39a128176679a70dbd13a6d946e > Cr-Commit-Position: refs/heads/master@{#35395} TBR=mstarzinger@chromium.org,bmeurer@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1878063004 Cr-Commit-Position: refs/heads/master@{#35404}
-