- 17 Jun, 2019 8 commits
-
-
Toon Verwaest authored
Change-Id: Iacfa08afd809f5edba8e5e4e45ebe6e9c87b9814 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660625 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62204}
-
Andreas Haas authored
In the existing code, whenever unreachable control instructions needed values from the stack which were not available, values of type kWasmVar were put on the stack. When these values were type-checked the first time, the expected type was assigned to them for later validation. This behavior has several draw-backs: * In an unobservable way, this implementation does not match the requirements of the spec. With the anyref proposal, this difference becomes observable. * Type checking functions were not read-only anymore, because if unreachable code was validated, the stack got manipulated in these functions. With the refactoring, I pulled out the handling of unreachable code out of the type checking functions. These checking functions can be validation-only functions. For type checking unreachable code, I start by popping values of the expected types off the stack. Thereby all available values on the stack get type-checked. Afterwards, I push all values again on the stack with the expected type if needed. This allows to continue the expected type checking for later instructions. R=clemensh@chromium.org Bug: v8:7581 Change-Id: Ib98e70a44bf9780626d4aa8a3e5fe8c2f230b787 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645328Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62203}
-
Georg Schmid authored
This is a reland of a66e3e57 Original change's description: > [csa] Tweak CSA pipeline to eliminate more redundant checks > > - Lower LoadObjectField to LoadFromObject > - Mark LoadFromObject and StoreToObject as non-allocating > - Use optimizable BitcastTaggedSignedToWord in TaggedIsNotSmi check > > R=jarin@chromium.org, tebbi@chromium.org > > Change-Id: I42992d46597be795aee3702018f7efd93fcc6ebf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657926 > Commit-Queue: Georg Schmid <gsps@google.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62173} R=tebbi@chromium.org Change-Id: Id7ae13ba17a2083fd4109f34ce026030716ececb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660622 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62202}
-
Jakob Gruber authored
RegExp assertions (e.g.: '^', '$', '\b', ...) sequences have certain properties that this rewriter exploits: 1. They are zero-width and order-independent, thus one can remove all duplicate assertions. 2. If a subsequence is guaranteed to fail, the entire sequence fails. Any sequence always known to fail (e.g. containing both '\b' and '\B') can be rewritten to a single node that triggers failure. This CL generalizes the previous optimization for repeated assertions to be order-independent, i.e. assertions only have to be in the same sequence but not next to each other. Bug: v8:6515, v8:6126 Change-Id: I3f92f081ce8a55ad8c34c269a09a6686e3b008f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657925 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#62201}
-
Jakob Kummerow authored
Drive-by cleanup: alpha-sort entries in .gitignore NOTRY=true Change-Id: I14cd97d256a3bc370daad5f64e389d1efb7d50ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660613Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62200}
-
Yu Yin authored
Port 7b48dd55 https://crrev.com/c/1648155 Original Commit Message: This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. Change-Id: I1c8a5a18ac998b16d84556f08637b32d758f44da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1659992 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Yu Yin <xwafish@gmail.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#62199}
-
Jakob Gruber authored
Bug: v8:9359 Change-Id: I06a4ccc53abff25237a1113774a0b17bdf861c86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658157Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fc6c021..8ef7aaa Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9c81a61..6ae683b Rolling v8/buildtools/linux64: git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9..git_revision:8c7f49102234f4f4b9349dcb258554675475e596 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/a959e4f..523c0fd TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iec7e2e610ed51abd1fc79835737bc0f1baa80be6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1661694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62197}
-
- 16 Jun, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7498eac..fc6c021 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/000fc63..2e4b470 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f72f02b..96bccf1 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ic6497154440ff7d830ed17b542ed86b4f8d94e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1661855Reviewed-by:
-
- 15 Jun, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/be4d13b..7498eac Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/8756a42..9c81a61 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/ad46488..5938e05 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e502dbc..000fc63 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/539db7d..f72f02b TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I03cc05994c0671fc0a98a65dc0467e09ebe86135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1661335Reviewed-by:
-
Johannes Henkel authored
New revision: 83b1154a9661d22bba9a368d368214cc20880419 This updates the usages of the protocol types to the new definitions, using std::vector-based implementations of protocol::Array. Change-Id: Ibb095862fed7db23f1a0b4b5b726bddbe1e2585e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1654091 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#62194}
-
- 14 Jun, 2019 29 commits
-
-
Igor Sheludko authored
Bug: chromium:973045, v8:7611, v8:9114, v8:9183, v8:9343 Tbr: verwaest@chromium.org,tebbi@chromium.org Change-Id: I08b509368972956d1c7aedf53884d2590e4cfa27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660619 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: If482c6a14f389d54c6ca3891aa7b8475f7a1fce1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660617 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62192}
-
Mike Stanton authored
In the JSCallReducer, we need to serialize prototypes of receiver maps in order to verify that they are the promise prototype. Bug: v8:7790 Change-Id: Ie9817e531b7faaa3f11dae61a120b46ef5c49847 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660487Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#62191}
-
Mythri A authored
Bug: v8:8394, v8:9183, v8:8803 Change-Id: Icd52eaaae28f605b14c0e63d3aca18541e3c8f6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660616 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62190}
-
Mythri A authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: I88c0268b30d4b927f9856db7a3b054b74baf1923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660608 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... since decompression customization for MapWord is already handled by HeapObject::MapField. Bug: v8:9353, v8:9183 Change-Id: I009cdbbf8fc7e72029e1b9be54a0f0b73050e738 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660475 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#62188}
-
Milad Farazmand authored
Port 7b48dd55 Original Commit Message: This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie696468685517333515bf4b0b78fdd7d8c4e7763 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660628Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 7e7c1b10 Original change's description: > [cleanup] Add operator parameter accessor for S8x16Shuffle > > Bug: v8:7517, v8:9183 > Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 > Auto-Submit: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62177} TBR=tebbi@chromium.org Bug: v8:7517, v8:9183 Change-Id: Ia72d73416b2d6b8e7e2fba97cfce39e4ab387a08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660610 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62186}
-
Daniel Vogelheim authored
This extends the existing Isolate::SetAllowCodeGenerationFromStringsCallback mechanism, by adding SetModifyCodeGenerationFromStringCallback, which can also modify the eval argument (it could e.g. add escaping). Bug: chromium:940927 Change-Id: I2b72ec2e3b77a5a33f428a0db5cef3f9f8ed6ba2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593336Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#62185}
-
Igor Sheludko authored
It will allow us to use knowledge about the type of field during value decompression upon field read. Use the new class for HeapObject::MapField. Bug: v8:9353 Change-Id: I1368426ec2e25fcec3af8d5cccd7a78d80423e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658150 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=mythria@chromium.org Bug: v8:9183 Change-Id: I3913ce4bb69895994a0e397f0f96c83813668ea4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660480Reviewed-by:
-
Tobias Tebbi authored
This is a reland of 6eff6cc9 Original change's description: > [torque] introduce separate implicit parameters for JavaScript calling convention > > Implicit parameters for builtins with JavaScript linkage are now separate, using > the keyword "js-implicit". They have to be one of: > - context: Context > - receiver: Object (this in JS) > - target: JSFunction (arguments.callee in JS) > - newTarget: Object (new.target in JS) > > Bug: v8:9120 v8:7793 > > Change-Id: I916f60971bb53d5046b6006725d0ce39291ca55e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658159 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62174} TBR=tmrts@chromium.org Bug: v8:9120 v8:7793 Change-Id: Idb25d316d9d87e345ab74c2df583ff2648da012c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660483 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: If6a4f39991f222337f1c49bd0439e9669d89b030 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660486 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 7e7c1b10. Reason for revert: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8910673611629290864/+/steps/OptimizeForSize/0/logs/RunWasm_S16x4Reverse_simd_lowered/0 Original change's description: > [cleanup] Add operator parameter accessor for S8x16Shuffle > > Bug: v8:7517, v8:9183 > Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 > Auto-Submit: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62177} TBR=sigurds@chromium.org,tebbi@chromium.org Change-Id: Ic26376c9fe28e7e74cbdb1fa9ec2f7627d2adeee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7517, v8:9183 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660609Reviewed-by:
-
Yang Guo authored
This reverts commit a66e3e57. Reason for revert: Likely to have caused UBSAN issues: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/6671 Original change's description: > [csa] Tweak CSA pipeline to eliminate more redundant checks > > - Lower LoadObjectField to LoadFromObject > - Mark LoadFromObject and StoreToObject as non-allocating > - Use optimizable BitcastTaggedSignedToWord in TaggedIsNotSmi check > > R=jarin@chromium.org, tebbi@chromium.org > > Change-Id: I42992d46597be795aee3702018f7efd93fcc6ebf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657926 > Commit-Queue: Georg Schmid <gsps@google.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62173} TBR=jarin@chromium.org,tebbi@chromium.org,gsps@google.com Change-Id: I0a1c0515a8a61d32f77a392f1efc0751b6aae2a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660485Reviewed-by:
-
Ross McIlroy authored
Bug=v8:8801,v8:8394,v8:9183 Change-Id: I5bd3505938a49dab0299f1d1d022e8a31cc806c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660479 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7517, v8:9183 Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
See example v8_linux64_perf_try(_triggered) builds on this CL triggered using the following command lines: python tools/try_perf.py --linux64 --confidence-level 1 compile python tools/try_perf.py --linux64 --confidence-level 1 arewefastyet python tools/try_perf.py --linux64 --confidence-level 3 arewefastyet This also fixes running tools/run_perf.py --help and adds logging for the current confidence level, which allows users to monitor progress. Example runs: https://chrome-swarming.appspot.com/task?id=456e4d6e743cc510 (Compile) https://chrome-swarming.appspot.com/task?id=456e5145615aa510 (JetStream) https://chrome-swarming.appspot.com/task?id=456e53eeb9104410 (JSBench) https://chrome-swarming.appspot.com/task?id=456e541e0e13bc10 (AreWeFastYet) Finally, this adds support for fractional confidence levels. Example runs: https://chrome-swarming.appspot.com/task?id=456e5970e6f24410 (AreWeFastYet) https://chrome-swarming.appspot.com/task?id=456e5a8f3f407c10 (Compile) R=tmrts@chromium.org, machenbach@chromium.org Bug: chromium:880724 Change-Id: I725a83060c0bdd3ef08a7f0e4df843611c712d37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660471Reviewed-by:
-
Yang Guo authored
This reverts commit 6eff6cc9. Reason for revert: Presubmit failure. Original change's description: > [torque] introduce separate implicit parameters for JavaScript calling convention > > Implicit parameters for builtins with JavaScript linkage are now separate, using > the keyword "js-implicit". They have to be one of: > - context: Context > - receiver: Object (this in JS) > - target: JSFunction (arguments.callee in JS) > - newTarget: Object (new.target in JS) > > Bug: v8:9120 v8:7793 > > Change-Id: I916f60971bb53d5046b6006725d0ce39291ca55e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658159 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62174} TBR=sigurds@chromium.org,tebbi@chromium.org,tmrts@chromium.org,szuend@chromium.org Change-Id: Ide206788745bd15677bd60fe32d2476321967069 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9120 v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660482Reviewed-by:
-
Tobias Tebbi authored
Implicit parameters for builtins with JavaScript linkage are now separate, using the keyword "js-implicit". They have to be one of: - context: Context - receiver: Object (this in JS) - target: JSFunction (arguments.callee in JS) - newTarget: Object (new.target in JS) Bug: v8:9120 v8:7793 Change-Id: I916f60971bb53d5046b6006725d0ce39291ca55e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658159Reviewed-by:
-
Georg Schmid authored
- Lower LoadObjectField to LoadFromObject - Mark LoadFromObject and StoreToObject as non-allocating - Use optimizable BitcastTaggedSignedToWord in TaggedIsNotSmi check R=jarin@chromium.org, tebbi@chromium.org Change-Id: I42992d46597be795aee3702018f7efd93fcc6ebf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657926 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
-
Ross McIlroy authored
Bug=v8:8801,v8:8394,v8:9183 Change-Id: I9d88d2aa2b261b0f8df83dd6075b68cbc626161f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660476 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Simon Zünd authored
The CL https://crrev.com/c/1646846 changed column numbers for Wasm frames in Error.stack traces. Instead of using the offset relative to the beginning of the function, the absolute offset inside the module is displayed as hex. This CL propagates that change to the StackTrace C++ API, so StackFrame::GetColumn() also returns the absolute offset. Note that the StackFrame API historically uses "0" to signal "no information", so the line and column numbers for Wasm frames are also adjusted to 1-based, even though they signify function index and absolute offset into the module. This CL does not touch Script::PositionInfo.column. That field still contains the offset relative to the function start. Bug: v8:8742 Change-Id: If4fd37fa681c7ebd0823ce0d95eccc1335c35272 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655300 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Dan Elphick authored
This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. Bug: v8:9338 Change-Id: I83f66af99fb27f131fc39ff426fdca4b1d674b70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648155 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=mythria@chromium.org Bug: v8:9183 Change-Id: Ia534816b460eaf005a0017afeb2d55ccb3402a37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660473Reviewed-by:
-
Andreas Haas authored
R=mythria@chromium.org Bug: v8:9183 Change-Id: Id7c29452ef6d643b59eb3252df188bf288e2de23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660469Reviewed-by:
-
Jakob Kummerow authored
Func::type() was broken for functions created with Func::make(). Change-Id: I2867bcf00d9e5c1488165a804598c9ca8081ff25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655648 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62167}
-
Andreas Haas authored
I removed the following entries: .d8_history - afaict, this does not exist anymore. If it exists, it would be in the out/ directory and thereby ignored anyways. /hydrogen.cfg - hydrogen is no more. /obj - this is now also in the out/ directory. d8_g - I think this does not exist anymore, or would be in the out/ directory. shell - If it still exists, it would be in the out/ directory. shell_g - same here. NOTRY=true R=jkummerow@chromium.org Bug: v8:9183 Change-Id: Iadb8d2533bfdda1190ec3a31a9ca9c199e087fd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660468Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
When iterating over the holdings inside the cleanup callback, we could potentially unregister the weakref which is next or prev on the key list causing these checks to be incorrect. Bug: v8:9360, v8:8179 Change-Id: I53ea12346eb4882b16a82677b64ba2c756d23a1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658161Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62165}
-
