- 18 Aug, 2022 24 commits
-
-
Anton Bikineev authored
Pointer compression regresses binary size on Fuchsia by about 300K. However, the change improves Oilpan memory by 15-20% (2-4% of PMF), which is beneficial for memory-impoverished platforms. Bug: chromium:1325007 Fuchsia-Binary-Size: See commit description. Change-Id: Ie16fd992e45e29e264549a960e9755ec58da1691 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829313Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82572}
-
Deepti Gandluri authored
Reference instruction lowerings are in the corresponding issue: https://github.com/WebAssembly/relaxed-simd/issues/40 Lowers directly to Pmulhrsw in the macro assembler as we use DefineSameAsFirst in place of the Movdqa on non-AVX hardware Bug: v8:12609, v8:12284 Change-Id: I6de45a2d8895637f895d3b0cc68f5dd1f67f77aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3837853Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#82571}
-
Frank Tang authored
Fix BalanceDuration to pass relativeTo to BalancePossiblyInfiniteDurationResult and then pass to NanosecondsToDays. The bug is introduced in https://chromium-review.googlesource.com/c/v8/v8/+/3781117 The spec text in 4-a of BalancePossiblyInfiniteDuration is "a. Let result be ? NanosecondsToDays(nanoseconds, relativeTo)." but the code wrote "a. Let result be ? NanosecondsToDays(nanoseconds, *undefined*)." Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-balancepossiblyinfiniteduration Bug: v8:11544 Change-Id: I3ea9a3b71521cdcc210e9db370d6e849fcde56ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834431 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#82570}
-
Frank Tang authored
Spec text: https://tc39.es/proposal-temporal/#sec-temporal-parsetemporaldurationstring Bug: v8:11544 Change-Id: I2d54759c07529f95c7a27c334ee5d3fa6760b2e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835292Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82569}
-
Shu-yu Guo authored
AcqRel barriers are currently unused and will be used by the shared value barrier in a future CL. Bug: v8:12547 Change-Id: I8ae40b9e17f007441125dfa5d0a04f46565785fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827319Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82568}
-
Milad Fa authored
mksnapshot is currently failing as FlagValues are not aligned to kMinimumOSPageSize. Change-Id: Ib6e88a3bd72af874022647ff9708024902f21a50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3838773Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82567}
-
Danylo Boiko authored
Bug: v8:7327 Change-Id: I7312ec4fb23bbf1c67fdf110de221105279bfa4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3837859Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Cr-Commit-Position: refs/heads/main@{#82566}
-
Samuel Groß authored
This is a reland of commit 6ec7be21 The issues that caused the CL to be reverted appear to be unrelated to this change as they still occurred after the revert. Original change's description: > [sandbox] Sandboxify WasmExportedFunctionData::sig > > This CL changes the WasmExportedFunctionData class to store a direct > ExternalPointer to the wasm::FunctionSig instead of referencing it > through a Foreign. This in turn makes it possible to use a unique > pointer tag for that external pointer when the sandbox is enabled. > > Drive-by: move WasmInternalFunction::call_target external pointer to the > end of the object, in line with other external pointer fields. > > Bug: v8:10391, v8:12949 > Change-Id: Ic3ff622a075c9eaa2f8d8835803437466290c928 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829086 > Commit-Queue: Samuel Groß <saelo@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82523} Bug: v8:10391, v8:12949 Change-Id: I108810ce86b95289dfb6d6377535813deac79a9f Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3838109Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#82565}
-
Michael Lippautz authored
Bug: v8:13141 Change-Id: I05e905a40a572c7f85f60629b2303cd73ae06a70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3838731 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82564}
-
Feng Yu authored
Bug: v8:12781 Change-Id: I1bf06cd74b82e98f44e00f8d6e9049d1b92c86cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827121Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82563}
-
Michael Lippautz authored
Provides a v8::base::Malloc::AllocateAtLeast() method that is also UBSan-safe and use it in the GC's worklist. Depends on https://crrev.com/c/3834601 Bug: v8:13193 Change-Id: I1bd182e613fb3c6a5a6b90bf56f12bd210d5ef8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3833818 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#82562}
-
Camillo authored
- Force RecordError in case of a TerminationException - Remove Module::RecordErrorUsingPendingException - Use more raw objects and instance methods if possible Bug: v8:12379 Change-Id: Ia7e73715c3cdfe59d3fa324be3ce4213e454ff26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829087Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82561}
-
Camillo authored
Add outlined StackLimitCheck::HandleInterrupt helper for the uncommon path. Change-Id: Ib13dc84ac632f3455d5933748428f9550a23d435 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829088Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82560}
-
Michael Lippautz authored
Traced nodes were allocated black, even outside of GCs. Nodes would always survive one GC, while the objects pointed to could die. This CL removes black allocation and relies on proper write barriers (that are anyways in place) to mark the nodes and their objects. This also means that marked nodes should always point to live objects which is now verified in the atomic pause. Bug: v8:13141 Change-Id: Ie5cdc92d8fe5f57865d02b71d3fae9425ae532fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820070 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82559}
-
Matthias Liedtke authored
Also fix eqref/i31ref fromJS() handling to accept unwrapped Smis. This does not convert HeapNumbers to Smis if they fit. Bug: v8:7748 Change-Id: Ida70a826f9541b7f3fbe9eecbb2b4fe362b5ef70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829477 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82558}
-
Samuel Groß authored
The previous code incorrectly rounded down the number of entries to free to kBlockSize (expressed in KB) instead of kEntriesPerBlock (expressed in # of entries) to compute the start of the evacuation area. Further, depending on the block sized used, the previous heuristics does not necessarily guarantee that at least one full block would be evacuated. This CL fixes both of these issues. Bug: v8:10391 Change-Id: I5ddecd5d582bcf89e1c52df431f006889685320a Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3837860Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#82557}
-
Tobias Tebbi authored
Bug: chromium:1353360 Change-Id: Id39bfb72ba0ffc6e547b907bb82599fb4a0529a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834255 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82556}
-
Jose Dapena Paz authored
In existing implementation, of MethodLoad event, the method name passed to ETW is coming from CodeEventLogger::CodeCreateEvent, and includes the source file or URL, column and line numbers, method name and a marker for the kind of code generation. This is partially redundant, as the reference to source ID will point to the already generated SourceLoad event, with the file information. Also, Windows Performance Analyzer will already pick line and column number for the stack representation. So, for those cases, we just need to send to ETW the script method name. Even better, this changeset uses the DebugNameCStr logic to retrieve the inferred name in case there is no name available. Bug: v8:12987 Change-Id: If09c1fedc9da158a3c72932655e2e6b09e818d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763862Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/main@{#82555}
-
V8 Autoroll authored
Change-Id: Ia8c534ccbec53fc2d59b6d357697513bfec3a015 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3837856Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#82554}
-
JianxiaoLuIntel authored
`mksnapshot --trace_turbo` will crash because builtins have no bytecode. Bug: v8:7327 Change-Id: I61740b9ce934e85d158518787a2c7dc76c57e8d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834641Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#82553}
-
Dominik Inführ authored
Introducing IncrementalMarking::AdvanceForTesting as last bottleneck for driving incremental marking in addition to AdvanceFromTask and AdvanceOnAllocation. Now that we have those 3 bottlenecks, Step() and AdvanceWithDeadline() can become private methods in IncrementalMarking. We also don't need the StepResult return value in Step() anymore, which allows us to remove CombineStepResult. Bug: v8:12775 Change-Id: I702714439ef7ea4b9abf2156387503d4d00a7a48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823131Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82552}
-
Matthias Liedtke authored
This is a reland of commit ee89a269 Original change's description: > [wasm-gc] Add extern.externalize > > This adds `extern.externalize(ref null any): ref null extern` to wasm > which packs wasm objects into JS objects if the js-interop flag is not set. > This is the counterpart to extern.internalize introduced in > 50ec8a11. > > Bug: v8:7748 > Change-Id: I67b8fe6d70b9f526ff6c43b0a4d7861c7ff5dad0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3825879 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82492} Bug: v8:7748 Change-Id: Ie13cfd6464006dcadc2a53f2dbf77f76ab185504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829940Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82551}
-
Peter Kasting authored
This fixes a compile error in C++20. Bug: chromium:1284275 Change-Id: If7f634f56bea94d594bd7a1e660b902dbebbab1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835291Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#82550}
-
Dominik Inführ authored
Maglev write barrier needs to use different page flag mask to also call into the slow path of the barrier for old-to-shared pointers. Bug: v8:11708 Change-Id: I9ff5ead0517e9682672452f9868b16fa0dd94be2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834256Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82549}
-
- 17 Aug, 2022 16 commits
-
-
Frank Tang authored
1. Add if/throw based on IsValidEpochNanoseconds() in DisambiguatePossibleInstants, ParseTemporalInstant, GetIANATimeZoneEpochValueAsArrayOfInstantForUTC, GetIANATimeZoneEpochValueAsArrayOfInstant, JSTemporalTimeZone::GetPossibleInstantsFor, and InterpretISODateTimeOffset( 2. Add assert IsValidEpochNanoseconds in GetISOPartsFromEpoch 3. Fix ISODateTimeWithinLimits These changes are syncing of the following PRs: https://github.com/tc39/proposal-temporal/pull/2277 https://github.com/tc39/proposal-temporal/pull/2084 https://github.com/tc39/proposal-temporal/pull/2312 https://github.com/tc39/proposal-temporal/pull/2273 https://github.com/tc39/proposal-temporal/pull/2117 Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-disambiguatepossibleinstants https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalinstant https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getpossibleinstantsfor https://tc39.es/proposal-temporal/#sec-temporal-interpretisodatetimeoffset https://tc39.es/proposal-temporal/#sec-temporal-getisopartsfromepoch https://tc39.es/proposal-temporal/#sec-temporal-isodatetimewithinlimits Bug: v8:11544 Change-Id: I38244d039f33e294b698d470b587b1b44b72fa09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3831150Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82548}
-
Frank Tang authored
Pass OrdinaryObjectCreate(*null*) to DifferenceISODateTime in NanosecondsToDays and to DifferenceZonedDateTime in AddDuration https://github.com/tc39/proposal-temporal/pull/2295 Bug: v8:11544 Change-Id: Ied1860b755b1cebd0fbcbc4bd574cd525f108378 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835263Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82547}
-
Frank Tang authored
Move calendar validation out of ParseTemporalCalendarString Spec PR https://github.com/tc39/proposal-temporal/pull/1954 Bug: v8:11544 Change-Id: I4dbfcba1a9f5940d5692547b7ea212ebe45ca341 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835265Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82546}
-
Frank Tang authored
See issues in https://github.com/tc39/test262/issues/3553 and https://github.com/tc39/proposal-temporal/issues/2165 Bug: v8:11544 Change-Id: Iefe6353e95178e1241a7f29c80b24baad2a8428d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835266 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#82545}
-
Frank Tang authored
Pass undefined for option in calendar monthDayFromFields and yearMonthFromFields https://github.com/tc39/proposal-temporal/issues/1685 Bug: v8:11544 Change-Id: I3fd37e176bd83dc0b01d92a3c323d2933291c49b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835262Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82544}
-
Milad Fa authored
Port 805df68f Original Commit Message: Baseline write barrier needs to use different page flag mask to also call into the slow path of the barrier for old-to-shared pointers. R=dinfuehr@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I00c179ac04b74b1196951ae4d8c868d312d5a856 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834633 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82543}
-
Jakob Kummerow authored
When a string is in a local or on the value stack at a breakpoint, DevTools should be able to show its value. Bug: v8:12868 Change-Id: I79014d74c8ef7b212469382bdedca85568b3bcc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834038 Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82542}
-
Shu-yu Guo authored
This reverts commit e50472d6. Reason for revert: compilation-hints-decoder breakage https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20ASAN/45708/overview Original change's description: > [wasm] Refactor compilation tier computations > > The way we initialized the "compilation progress" was pretty convoluted, > with multiple levels of functions being called for initializing every > single slot. > > This CL refactors this to compute one default value for the whole > module, and only modifies those slots that need special handling (e.g. > because of compilation hints, or lazy/eager compilation after > deserialization). > > We also rename "liftoff_functions" to "eager_functions" in the > deserialization path; the idea is that those functions should get > eagerly compiled because we expect them to be needed during execution. > Usually they would be Liftoff-compiled, but it's more consistent to use > the existing logic to choose the baseline tier. In the default > configuration, this will still use Liftoff, but if Liftoff is disabled > we will use TurboFan instead. > > R=jkummerow@chromium.org, ahaas@chromium.org > > Bug: v8:12425 > Change-Id: Ie58840b19efd0b1e98f1b02d5f1d4369410ed8e1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829606 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82521} Bug: v8:12425 Change-Id: I45cef01ea40c50c3b86fbceca9b482a9bded535e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835290 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82541}
-
Dominik Inführ authored
This is a reland of commit 9cca4e60 This CL disables the mjsunit tests as well in single generation mode. Original change's description: > [heap] Handle old-to-new slot promotion to shared heap > > The GC might promote an in-place internalizable string from new space > directly into the shared heap. This means that the GC might need to > create OLD_TO_SHARED slots when updating OLD_TO_NEW slots. > > This CL implements this both for minor and full GCs. > > Bug: v8:11708 > Change-Id: I6102b9024d1dd5dd602d654b006ea5897ab5baa6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804604 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82298} Bug: v8:11708 Change-Id: I9e96fe7c3f263d4088536d3a15af6d00fa82625e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3828099Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82540}
-
Peter Kasting authored
This fixes C++20 compile errors due to math between disparate enum types being deprecated (e.g. ENUM_A_VAL | ENUM_B_VAL). Bug: chromium:1284275 Change-Id: I7fc83888bb9c8156909cbc3ea1b30ef94d4a2c1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3830986 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82539}
-
Dominik Inführ authored
Baseline write barrier needs to use different page flag mask to also call into the slow path of the barrier for old-to-shared pointers. Bug: v8:11708 Change-Id: I955f30376f3de912b418298cdcf1e38dd2adda2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834254 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82538}
-
Victor Gomes authored
That entails that V8 built with bazel does not support snapshot compression. NOTE: Snapshot compression has always been supported, but it has never been enabled. We do not even have a flag for it. Change-Id: I4b67db618be2c62e6a6f34e71eb0dac2ec26fa36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834031Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82537}
-
Darius M authored
The "length" field of strings should never be mutated once it has been initialized. This means that the checks done by StringRef::length were never really useful. This CL thus removes them. Bug: chromium:1352386 Change-Id: I49f681daad119553eb0d4f1c2315bff5138197d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829541 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#82536}
-
Nico Hartmann authored
This reverts commit 6ec7be21. Reason for revert: Speculative revert for https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64/47984/overview Original change's description: > [sandbox] Sandboxify WasmExportedFunctionData::sig > > This CL changes the WasmExportedFunctionData class to store a direct > ExternalPointer to the wasm::FunctionSig instead of referencing it > through a Foreign. This in turn makes it possible to use a unique > pointer tag for that external pointer when the sandbox is enabled. > > Drive-by: move WasmInternalFunction::call_target external pointer to the > end of the object, in line with other external pointer fields. > > Bug: v8:10391, v8:12949 > Change-Id: Ic3ff622a075c9eaa2f8d8835803437466290c928 > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829086 > Commit-Queue: Samuel Groß <saelo@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82523} Bug: v8:10391, v8:12949 Change-Id: I18a7c9603e30d7cd78fd599e59596015260a5818 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834259 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82535}
-
Junliang Yan authored
Port 00746406 Original Commit Message: ... which affect how builtin calls are generated. This CL replaces the following boolean options - builtin_calls_as_table_load, - inline_offheap_trampolines, - short_builtin_calls, - use_pc_relative_calls_and_jumps, with an enum BuiltinCallJumpMode and a boolean option use_pc_relative_calls_and_jumps_for_mksnapshot. BUG= LOG=N Change-Id: I9ad83d27fc5b295ca4827e9608d4be10f7b10551 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3831638 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82534}
-
Jakob Linke authored
.. at which time, the standard ML frame is not yet set up. Instead, an INTERNAL frame with a few fixed tagged stack slots is created in preparation for the runtime call in GenerateTailCallToReturnedCode. Bug: v8:7700 Fixed: v8:13192 Change-Id: Icd7adbc25aa6a5446a43a0fb3ee70c65ee33cc5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835683 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82533}
-