- 20 Dec, 2018 1 commit
-
-
Rafael Cintron authored
Coalesce all of the individual contributors from Microsoft in AUTHORS file into *@microsoft.com. Change-Id: Ic0e7e01e8055b426c86fee2a5af2174f071c872a Reviewed-on: https://chromium-review.googlesource.com/c/1385504Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#58382}
-
- 19 Dec, 2018 38 commits
-
-
Adam Klein authored
It's been enabled for several releases now. R=gsathya@chromium.org Change-Id: Ib1806a1373821ee542dae2fd80f639b56bd99ed9 Reviewed-on: https://chromium-review.googlesource.com/c/1384796Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58381}
-
Sathya Gunasekaran authored
Since we have FindEntry, this is redudant. This patch also * Makes the tests for FindEntry stricter by testing the value * Makes the OrderedNameDictionary::Add and SmallOrderedNameDictionary::Add consistent by using GetHash and using a DCHECK for the FindEntry call Bug: v8:6443, v8:7569 Change-Id: I4859cd6735ec385c19acad6ce5cecaeac45173dd Reviewed-on: https://chromium-review.googlesource.com/c/1382828 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58380}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: Iaa995c8fbb9f309dadac4e308d727f628fdb8b3c Reviewed-on: https://chromium-review.googlesource.com/c/1384314Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58379}
-
Sathya Gunasekaran authored
Bug: v8:6443, v8:7569 Change-Id: I1bcd3458c2d548d36bf2961a2faf41919c433a91 Reviewed-on: https://chromium-review.googlesource.com/c/1382829 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58378}
-
Bruce Dawson authored
Recent versions of the Windows Universal CRT changed the behavior of fmod for when the first parameter is negative. In particular, a result of negative zero became positive zero. This is rarely critical but it causes test failures and may effect some JS test suites or web pages. The fix is to modify Modulo to check for a result of 0 when the first parameter is negative and change the result to -0. That fixes four of the five test failures and the fifth one is fixed by comparing the results against Modulo instead of std::fmod. Bug: chromium:915045 Change-Id: Ia4490ec98361a37006d6c338acd33f959fa3ccea Reviewed-on: https://chromium-review.googlesource.com/c/1383091 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58377}
-
Toon Verwaest authored
Later we want to automatically declare the parameters while parsing, which moves the declaration before body parsing anyway. This is just a step in that direction, making sure that it works. Change-Id: I0645269aa26643de138848c599cfe5d1ad4bf32c Reviewed-on: https://chromium-review.googlesource.com/c/1384319Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58376}
-
Toon Verwaest authored
Now we just check for each variable declared in the parameter scope whether it occurs as a lexical variable in the body scope. This way the preparser will also identify them. Bug: v8:2728, v8:5064 Change-Id: I9fd96590fa431de0656c85295fd31af9b36f2e32 Reviewed-on: https://chromium-review.googlesource.com/c/1384225Reviewed-by:
-
Mythri authored
Bug: v8:8394 Change-Id: I698b769369abd8ab1e6384f5e64d4111b4d6486d Reviewed-on: https://chromium-review.googlesource.com/c/1384317Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#58374}
-
Igor Sheludko authored
Tbr: machenbach@chromium.org Bug: v8:8562 Change-Id: If2242c6271d400e7c4c031e10871b06438c2636d Reviewed-on: https://chromium-review.googlesource.com/c/1384088 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Now a descriptor array tracks the number of descriptors that were already marked. The marking visitor of a map only marks the subset of the descriptors that it needs and that are not already marked. If a descriptor array is shared between M maps and has N descriptos, then the number of marking operations is reduced from O(M*N) to O(N). This patch also adds a marking barrier for descriptors. The marked descriptor counter in a descriptor array is not cleared after mark-compact GC. Instead, it embeds two bits from the global mark-compact epoch counter and is considered 0 if the bits do not match the current value of the global epoch counter. Bug: v8:8486 Change-Id: I2a7822a6833f3143e1d351e5e4819c2ef2c07fb0 Reviewed-on: https://chromium-review.googlesource.com/c/1382746 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#58372}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: Iebb60551a461304539d943a080ce107eecf6fdbf Reviewed-on: https://chromium-review.googlesource.com/c/1384264Reviewed-by:
-
Sigurd Schneider authored
This CL improves load times by up to 6x. This is achieved by not setting event handlers per-line, but setting one event handler on the container. Unfortunately, load times are dominated by the graph view, which needs to be addressed in another CL. Bug: v8:7327 Notry: true Change-Id: Ie9a999f4150617fd763b770fcacca6096f457880 Reviewed-on: https://chromium-review.googlesource.com/c/1384312Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58370}
-
Sathya Gunasekaran authored
OrderedNameDictionarHandler is the external API to interface with the OrderedNameDictionary variants. This abstracts away the need for the user to know that there are two different backing stores. Bug: v8:6443, v8:7569 Change-Id: Ief4f0904823988e629a01060b018b4cb0291542d Reviewed-on: https://chromium-review.googlesource.com/c/1381758 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Reachability is already being tracked in the function body decoder. This CL adds a DCHECK that the reachability tracked in the SsaEnv matches the reachability tracked in the function body decoder. Most of our methods will only be called for reachable code anyway. For exceptions, we still track reachability explicitly for now in the wasm graph builder, this can be refactored in the future by improving reachability tracking for catch blocks in the function body decoder. If this DCHECK survives fuzzing for a few days, we can remove code that handles unreachable code in graph-building-interface.cc. R=herhut@chromium.org Bug: v8:8423, v8:8611 Change-Id: I0fb375c99497352aad396816566883fe234ca0ac Reviewed-on: https://chromium-review.googlesource.com/c/1384089Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58368}
-
Dan Elphick authored
The TODOs are wrong for now since even without full codegen, it's still possible for it to be compiled, so this just removes them Bug: v8:8562 Change-Id: Ia9f2539e22364b31c0b45b0408dfe434f212c72a Reviewed-on: https://chromium-review.googlesource.com/c/1384311Reviewed-by:
-
Clemens Hammacher authored
No need for empty header files and empty implementation files (which will be compiled even though they are empty). R=ishell@chromium.org Bug: v8:8562 Change-Id: Icd54b0cab7dba991d11c26262deb2b034f67869e Reviewed-on: https://chromium-review.googlesource.com/c/1384305Reviewed-by:
-
Clemens Hammacher authored
The platform-specific simulators are only included on the respective hardware, so no need to guard against other platforms. Also, unify where the USE_SIMULATOR macro is evaluated. Make it cover the whole implementation file. Also, make sure to include the respective header file first, as suggested by the style guide, and fix up includes in general. R=ishell@chromium.org Bug: v8:8562, v8:7490 Change-Id: Ifc6a87030364eab1e6a6fcbda008607ccd1c1f2f Reviewed-on: https://chromium-review.googlesource.com/c/1384090Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I0dab49a03b74abc68600885f4951c5cb727a3d73 Reviewed-on: https://chromium-review.googlesource.com/c/1366736Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58364}
-
Mythri authored
Don't allocate feedback vectors and feedback metadata in lite mode. Also updates to skip tests that require feedback vectors. This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/1384087 after skipping the failing tests. Bug: v8:8394 Change-Id: I7766533b85a144e62996ceed8d542cdc534feeb5 Reviewed-on: https://chromium-review.googlesource.com/c/1384307Reviewed-by:
-
Sergiy Belozorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ee3e8b..9945d79 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/7d88270..5cce74c Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/6fecaa5..e958d6e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/368ebf1..203676d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7fa4fbc..c6a8d11 TBR=machenbach@chromium.org Change-Id: I55cd001dd1dd6d4c37dd2bd0c59ea3cb8ad8ad00 Reviewed-on: https://chromium-review.googlesource.com/c/1384308Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58362}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I37361ded733d21a5814a2a23a4155d7e8b562446 Reviewed-on: https://chromium-review.googlesource.com/c/1384092Reviewed-by:
-
Igor Sheludko authored
Also added != 0 for readability in checks like: if (FIELD_SIZE(kFooOffset) != 0) {...} Bug: v8:8477, v8:8562 Change-Id: Ibc305103475e6ec029e89e7ad095ec0a1fa30189 Reviewed-on: https://chromium-review.googlesource.com/c/1382743 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58360}
-
Clemens Hammacher authored
Many callers of {DoReturn} either already call {EndControl}, or pop the control afterwards, hence we do not need to {EndControl}. Hence only call {EndControl} when really needed. R=herhut@chromium.org Bug: v8:8423 Change-Id: Ie4e7b2dd6918cc0f9619a72d624014222f58a251 Reviewed-on: https://chromium-review.googlesource.com/c/1384085Reviewed-by: -
Sigurd Schneider authored
This addresses most of the regression in of Kraken's json-stringify-tinderbox-orig with 31bit Smis: Many object properties become heap numbers, and printing an integer which is represented as a double is slower than printing the integer directly. Change-Id: I9a14c4da61721b6c3f22e88145acc6a61ed4a419 Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1382741Reviewed-by:
-
Toon Verwaest authored
We don't eagerly throw for assignments to calls; see v8:4480. They are simply turned into assignments to Property instead. We need to record a declaration error, however. Otherwise we'll end up with a Property in a declaration context. To reduce the scope of the lazy throwing, in this fix I record a pattern error instead, making calls as assignment target in a destructuring assignment context throw eagerly. Bug: chromium:916288 Change-Id: If94a46b5d2b65c3549c641e0e19135c6c8af7a9a Reviewed-on: https://chromium-review.googlesource.com/c/1384084Reviewed-by:
-
Igor Sheludko authored
These load operations will decompress values if pointer compression is enabled. Bug: v8:7703 Change-Id: I4c5cef39a735f3b03e36d27c0e5e7c21653bbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1382742 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 62e86b88. Reason for revert: Fails on arm sim lite debug: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite%20-%20debug/1075 Original change's description: > Do not allocate feedback vectors and feedback metadata in lite mode > > Don't allocate feedback vectors and feedback metadata in lite mode. > Also updates to skip tests that require feedback vectors. > > Bug: v8:8394 > Change-Id: I22c64a32c44bb8f25fb09003d6e9fc5a04e84f8a > Reviewed-on: https://chromium-review.googlesource.com/c/1378173 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58351} TBR=rmcilroy@chromium.org,yangguo@chromium.org,mlippautz@chromium.org,mythria@chromium.org Change-Id: I88fd37ea4e21aa2cc81eceb87ddb35c23224beae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8394 Reviewed-on: https://chromium-review.googlesource.com/c/1384087Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I68ede2cda0441cd9a032318462fe3a085480a1dd Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1380111Reviewed-by:
-
Toon Verwaest authored
- Directly declares the special catch variable from the parser-base. - Tracks Scope on PreParserBlock and finds conflicting lexical declarations by simply walking the VariableMap of the block inserted for the pattern; or the catch variable in case of identifier. - This also enables throwing errors for duplicate let in the preparser. We may have to back that out if it breaks something. Bug: v8:2728, v8:7828 Change-Id: Id2eea62062533eb99cd6670c42a4b1da87139008 Reviewed-on: https://chromium-review.googlesource.com/c/1382095Reviewed-by:
-
Igor Sheludko authored
and fix platform builtins. This CL also introduces MacroAssembler::xxx_tagged() operations which operate on potentially compressed tagged values without doing decompression. This CL also drive-by fixes compilation failures when pointer compression is enabled. Bug: v8:7703 Change-Id: Id417f2a78907e8911aaa79ef404f5bcc87d9a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/1382740Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Mythri authored
Don't allocate feedback vectors and feedback metadata in lite mode. Also updates to skip tests that require feedback vectors. Bug: v8:8394 Change-Id: I22c64a32c44bb8f25fb09003d6e9fc5a04e84f8a Reviewed-on: https://chromium-review.googlesource.com/c/1378173 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Moving the declaration of operator<< from objects-printer.cc to heap-object.h makes sure that it is visible. Change-Id: I316db9c03a464974129b8e9c776423bb80066cdd Reviewed-on: https://chromium-review.googlesource.com/c/1382737Reviewed-by:
-
Sigurd Schneider authored
This refactoring reduces the LoC after preprocessor expansion by 370,322 gen ( 21 files): 71,503 to 1,631,168 ( 23x) src ( 624 files): 367,639 to 53,231,764 ( 145x) test ( 392 files): 490,770 to 37,450,839 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,183,681 to 102,836,194 ( 87x) gen ( 21 files): 71,503 to 1,613,222 ( 23x) src ( 624 files): 367,634 to 52,964,046 ( 144x) test ( 392 files): 490,771 to 37,366,181 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,183,677 to 102,465,872 ( 87x) Bug: v8:8562 Change-Id: Ib4e771c37471a2ff19c5538e62c038943cc74eaf Reviewed-on: https://chromium-review.googlesource.com/c/1382469Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
tzik authored
This CL moves variables that control MicrotaskQueue to MtQ itself. Namely, * is_running_microtasks_ and microtask_completed_callbacks_ from v8::internal::Isolate * microtasks_depth_, microtasks_suppressions_ and debug_microtask_depth_ from v8::internal::HandleScopeImplementer. As the current implementation has these variables one per-Isolate rather than per-MicrotaskQueue, this is needed to have multiple MicrotaskQueues for an Isolate. Bug: v8:8124 Change-Id: Id63075cbfb59cf5b7f45a4184affb206400150da Reviewed-on: https://chromium-review.googlesource.com/c/1358029 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the third change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported globals into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. This CL does minimal changes to the processing of globals itself. That code looks quite complex at the moment. Therefore I want to do the refactoring of that code in separate CLs, so that each CL is smaller and more understandable. R=clemensh@chromium.org Bug: v8:8562 Change-Id: Ie553a2c9031cef07f0b9925144c79248084e428d Reviewed-on: https://chromium-review.googlesource.com/c/1382732 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the third change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported memory into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. * Add one `return false;` after reporting a LinkError. - I think it should have been this way all along. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I34d68d7bc1013c2743a68778dfc22a2d8e1d46af Reviewed-on: https://chromium-review.googlesource.com/c/1382731 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Yang Guo authored
Bug: v8:8558 Change-Id: Ib179947fb1b00f32a574ae3084e3107cc264a851 Reviewed-on: https://chromium-review.googlesource.com/c/1369951 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
tzik authored
On MIPS and MIPS64, UseScratchRegisterScope has only one register for the scratch register [1,2], and TurboAssembler::CallCFunctionHelper runs out of it as fast_c_call_caller_fp_address uses the register. That causes code generation failures. As a workaround, this CL reduces the number of nested UseScratchRegisterScope where the code generation is failing. [1]: https://chromium.googlesource.com/v8/v8.git/+/dde25872f58951bb0148cf43d6a504ab2f280485/src/mips/assembler-mips.cc#310 [2]: https://chromium.googlesource.com/v8/v8.git/+/dde25872f58951bb0148cf43d6a504ab2f280485/src/mips64/assembler-mips64.cc#287 Change-Id: I0813c656cafdb09ccd6f53d51f3620385e00022f Reviewed-on: https://chromium-review.googlesource.com/c/1379590Reviewed-by:
-
- 18 Dec, 2018 1 commit
-
-
Toon Verwaest authored
Now just accumulate right before we might validate a property and once we're done, so we're guaranteed to catch all PatternErrors. Bug: v8:8607 Change-Id: Ibc5bc7773756f4827868ca01d0f9fb0c5545e59b Reviewed-on: https://chromium-review.googlesource.com/c/1382749 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
