- 22 Aug, 2018 6 commits
-
-
Peter Marshall authored
We would return the wrong chunk for the first element past the chunk boundary, e.g. if the first chunk was size=8, then Find(8) would return an address in the first block rather than the second one. Bug: v8:8077 Change-Id: I90281f853dd7ca68dc065ed773d0ae9787f00988 Reviewed-on: https://chromium-review.googlesource.com/1183483 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55294}
-
Jaroslav Sevcik authored
Change-Id: I319496294fe5b560ac6189c178fa047879093729 Reviewed-on: https://chromium-review.googlesource.com/1184701Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55293}
-
Bogdan Lazarescu authored
This is useful even if there are other uses of the arithmetic result, because it moves dependencies further back. Change-Id: I6136a657b547198cb4ec92f38b89ddf5df334124 Reviewed-on: https://chromium-review.googlesource.com/1179662Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Bogdan Lazarescu <bogdan.lazarescu@arm.com> Cr-Commit-Position: refs/heads/master@{#55292}
-
Andreas Haas authored
R=titzer@chromium.org Change-Id: I6c817fa82333ca12d2d8f9f8704eac157f3caa9f Reviewed-on: https://chromium-review.googlesource.com/1184705Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55291}
-
Maya Lekova authored
This reverts commit e987606a. Reason for revert: Speculatively reverting due to possible failure: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Android%20Builder/8641 Original change's description: > inspector: do not convert and store String16 for script source > > We need script source for: > - calculating hash to report as part of scriptParsed event, > - reporting it as response on getScriptSource request, > - searching inside as response on searchInContent request, > - breakpoints hints. > > In all cases there is no need to store source on inspector side. > > R=alph@chromium.org > > Bug: chromium:873865,v8:7731 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ice24ddc72cfff36fb9a2dff2d7c4543defe3f668 > Reviewed-on: https://chromium-review.googlesource.com/1182603 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55286} TBR=alph@chromium.org,kozyatinskiy@chromium.org Change-Id: I38d744dc811a5b747c1fcf27d88bdf770acf5c18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:873865, v8:7731 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1184742Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55290}
-
Tobias Tebbi authored
This reverts commit cdaaa311. Reason for revert: chromium:876445 chromium:876453 chromium:876443 Original change's description: > [builtins] Reland Array.prototype.splice() Torque implementation. > > Before, splice was implemented with a C++ fast path and a > comprehensive JavaScript version. > > This impl. is entirely in Torque with a fastpath for SMI, > DOUBLE and OBJECT arrays, and a comprehensive slow path. > The same level of "sparse" array support as given by the > array.js implementation is included. > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ia7334a30b401988309e9909cfa0069da0bb6fb9f > Reviewed-on: https://chromium-review.googlesource.com/1169466 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55263} TBR=mvstanton@chromium.org,jgruber@chromium.org,tebbi@chromium.org Change-Id: I5b750a98e671b7284474ffcabc6b4d37a9d1219e No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1184741Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55289}
-
- 21 Aug, 2018 34 commits
-
-
Adam Klein authored
Also update comments that'd gotten unnecessarily verbose over ten years of language development. Bug: v8:8015 Change-Id: I6688ce22e4aa92f66f937159d890b9922f109d43 Reviewed-on: https://chromium-review.googlesource.com/1180357Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55288}
-
Hannes Payer authored
Bug: chromium:874437,chromium:852420 Change-Id: I4f484a6bb7072804dbcaacab77d25ba7a3fe338f Reviewed-on: https://chromium-review.googlesource.com/1183188Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55287}
-
Alexey Kozyatinskiy authored
We need script source for: - calculating hash to report as part of scriptParsed event, - reporting it as response on getScriptSource request, - searching inside as response on searchInContent request, - breakpoints hints. In all cases there is no need to store source on inspector side. R=alph@chromium.org Bug: chromium:873865,v8:7731 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ice24ddc72cfff36fb9a2dff2d7c4543defe3f668 Reviewed-on: https://chromium-review.googlesource.com/1182603 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#55286}
-
Michael Lippautz authored
This call can be used by embedder to request a GC for testing reasons. The GC also takes the current embedder stack state as an argument that is forwarded to the embedder when entering the atomic pause. This way embedders can request garbage collections for testing and set how the embedder should treat the stack. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id10604565b4457dd0fca402afeb5f8e592fa0bae Reviewed-on: https://chromium-review.googlesource.com/1183431 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=mstarzinger@chromium.org Change-Id: Iacdff28dd1383d77d7708de4ee22d9f2a77d872a Reviewed-on: https://chromium-review.googlesource.com/1183440 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55284}
-
Benedikt Meurer authored
Refactor the ArrayIteratorPrototypeNext CSA builtin to handle the JSArray element access in a dedicated helper macro, very similar to how it's done for JSTypedArray's. Also add support for dictionary elements to this helper macro using the existing dictionary access logic in the CodeStubAssembler. This improves the readability of the builtin significantly and the performance of iterating arrays with dictionary elements goes up by a factor of ~3.5x. Bug: v8:8015, v8:8070 Change-Id: Ibfee760ea1e4bc0fffb42b232fb1d097b706bd1f Reviewed-on: https://chromium-review.googlesource.com/1183305Reviewed-by:
-
Florian Sattler authored
This pull in noexcept changes in inspector_protocol Bug: v8:7999 Change-Id: I6db9ad419d6c1a11fee4379004435e76bbedcead Reviewed-on: https://chromium-review.googlesource.com/1182804Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55282}
-
Bret Sepulveda authored
This patch splits the log file into a vector of std::strings when logging is stopped, so verifying that lines are present can be done in terms of std library functions. Verifications are now done by simple substring matching instead of via a prefix or suffix, in preparation for a new test that needs to match the middle of a line. This patch also deletes some dead/debugging code. Change-Id: I5c6b75b0807c41312d35208deda26546dc0f7216 Reviewed-on: https://chromium-review.googlesource.com/1183187Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#55281}
-
Alexey Kozyatinskiy authored
Inspector tries to provide sourceURL and sourceMappingURL for scripts with parser errors. Without this CL we convert source of each script to inspector string and search for magic comment there. Some web sites use pattern when they get some data from network and constantly try to parse this data as JSON, in this case we do a lot of useless work. So we can parse magic comments on V8 side only for compilation errors (excluding parse JSON errors), to do it we can reuse scanner by running it on each potential comment. R=alph@chromium.org,verwaest@chromium.org,yangguo@chromium.org Bug: chromium:873865,v8:7731 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I77c270fd0e95cd7b2c9ee4b7f72ef344bc1fa104 Reviewed-on: https://chromium-review.googlesource.com/1182446Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: Ic3df370e2859bf77572b34a314ad8ed17b75b942 Reviewed-on: https://chromium-review.googlesource.com/1183485 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55279}
-
Igor Sheludko authored
... by properly exporting respective functions from the binary. Change-Id: I6f9b63f65a886e430c1b0e431ebf62e589f4d455 Reviewed-on: https://chromium-review.googlesource.com/1183493Reviewed-by:
-
Benedikt Meurer authored
This removes a couple of intrinsics/runtime functions/macros that are no longer needed at all (or not in TurboFan for performance reasons). Bug: v8:8015 Change-Id: I08ae8de7cc63019eb30d3b71dd1c824d6392076a Reviewed-on: https://chromium-review.googlesource.com/1183481Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55277}
-
Michael Starzinger authored
R=ahaas@chromium.org Change-Id: I92d6e7fc41c9cbb3792a66c9ea8996efe1c8d87d Reviewed-on: https://chromium-review.googlesource.com/1183434Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55276}
-
Florian Sattler authored
Bug: v8:7926 Change-Id: I237428af129fd19dbca39c1e243252774e26902c Reviewed-on: https://chromium-review.googlesource.com/1182805Reviewed-by:
-
Ivica Bogosavljevic authored
TEST=wasm-spec-tests/tests/exports,wasm-spec-tests/tests/data Change-Id: I5c1001b00f2a7eab41e6e143afa19803969c0fe4 Reviewed-on: https://chromium-review.googlesource.com/1181022Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55274}
-
Benedikt Meurer authored
This adds new CSA helpers ThrowIfArrayBufferIsDetached() and ThrowIfArrayBufferViewBufferIsDetached() which check whether ArrayBuffers or ArrayBufferViews have been detached. This improves readability of the code that has to deal with typed arrays. Bug: v8:8015 Change-Id: Iafab86c418bd0e12bb7d7ec803151a1f6b786400 Reviewed-on: https://chromium-review.googlesource.com/1183422 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I50f729eac8d8b0c25a1f83f2b1f86800f21a8a8b Reviewed-on: https://chromium-review.googlesource.com/1183301 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org Change-Id: If459225345f8a94eb566334e15331f7741c952d4 Reviewed-on: https://chromium-review.googlesource.com/1183103 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Ross McIlroy authored
BUG=v8:8040 Change-Id: I004f5748bafeff60885fd85f1b1a6ea44af06340 Reviewed-on: https://chromium-review.googlesource.com/1183196Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55270}
-
Igor Sheludko authored
This is prerequisite for V8 heap pointer compression. Bug: v8:7703 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2cdf02bd4cd535beb78a5db5b7cbdf67433a6d16 Reviewed-on: https://chromium-review.googlesource.com/1181136 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I692ce8dbe3169cfb912647c31a9e8121dc5eff5d Reviewed-on: https://chromium-review.googlesource.com/1183306 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Dan Elphick authored
UNREACHABLE and CHECK call V8_Fatal directly so treat them like V8_Dcheck, but also ensure that the frame is moved up to the DCHECK frame even if it calls V8_Fatal. Change-Id: Iad5f2e3ea95182bed473d6b2d843a0c1e111911d Reviewed-on: https://chromium-review.googlesource.com/1183303Reviewed-by:
-
Georg Neis authored
This reverts commit acf09252. Reason for revert: Undesired side effects. Original change's description: > [turbofan] Force creation of initial maps upfront. > > When encountering a JSFunction, generate its initial map (if > appropriate). This ensures that we can depend on the initial > map during optimization. > > We are not sure about the performance impact of this change, it > might cause regressions. > > R=jarin@chromium.org, mslekova@chromium.org > > Bug: v8:7790, chromium:875175 > Change-Id: I4bbf62e30730f55a53d9bb7eee62c87d820616fb > Reviewed-on: https://chromium-review.googlesource.com/1180970 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55253} TBR=jarin@chromium.org,neis@chromium.org,mslekova@chromium.org Change-Id: I322f504d068f752b218680f633b8719864ca4950 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790, chromium:875175 Reviewed-on: https://chromium-review.googlesource.com/1183341Reviewed-by:
-
jgruber authored
This populates the isolate-independent builtin whitelist with initial builtins that do not access any isolate-dependent data and thus don't need the root register at all. Unlike most other platforms, we can't use a scratch register in the off-heap trampoline since there's no free register available. The trampolines on ia32 are thus implemented as pc-relative jumps (thankfully we can address the entire address space). Drive-by: Made Code::IsIsolateIndependent consistent with FinalizeEmbeddedCodeTargets. Code targets are only allowed on some platforms. Bug: v8:6666 Change-Id: I0bf02eecba8a099afa7b7c892188cd377cbda840 Reviewed-on: https://chromium-review.googlesource.com/1183224Reviewed-by:
-
jgruber authored
When enabled, this will print all builtins that could, in theory, be marked as isolate-independent (because their reloc info only contains viable entries), but are not. This is only intended for use while implementing embedded builtins on ia32 and can be removed afterwards. Bug: v8:6666 Change-Id: I2cb54c851391480824f15f6e5ddb7919e179da4a Reviewed-on: https://chromium-review.googlesource.com/1183222Reviewed-by:
-
Tobias Tebbi authored
Before, splice was implemented with a C++ fast path and a comprehensive JavaScript version. This impl. is entirely in Torque with a fastpath for SMI, DOUBLE and OBJECT arrays, and a comprehensive slow path. The same level of "sparse" array support as given by the array.js implementation is included. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia7334a30b401988309e9909cfa0069da0bb6fb9f Reviewed-on: https://chromium-review.googlesource.com/1169466Reviewed-by:
-
Andreas Haas authored
R=titzer@chromium.org Bug: chromium:868844 Change-Id: Ib96416dc6ae36e024e90187944f2e9ca92e8b83b Reviewed-on: https://chromium-review.googlesource.com/1183200Reviewed-by:
-
Benedikt Meurer authored
Instead of changing the [[IteratedObject]] field to undefined to mark an array iterator as exhausted, store the appropriate maximum value into the [[ArrayIteratorNextIndex]] field such that the iterator will never produce any values again. Without this change the map check and the "length" access on the [[IteratedObject]] cannot be eliminated inside the loop, since the object can either be the array or undefined. Even with this change it's still not possible immediately due to missing aliasing information in the LoadElimination, but it paves the way for follow up improvements. Eventually the goal is to have `for..of` as fast as a traditional `for` loop even for really tight loops. This CL also hardens the implementation of the ArrayIterator by using proper CASTs and CSA_ASSERTs. The readability of the CSA builtin was improved by utilizing proper helper functions. Bug: v8:7510, v8:7514, v8:8070 Change-Id: Ib46604fadad1a0f80e77fe71a1f47b0ca31ab841 Reviewed-on: https://chromium-review.googlesource.com/1181902 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Ross McIlroy authored
BUG=v8:8040 Change-Id: I705f9afebfa770a8415fa268dd13ba00e90808d4 Reviewed-on: https://chromium-review.googlesource.com/1181429 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55260}
-
Sigurd Schneider authored
This reverts commit cabcfb3a. Reason for revert: Breaks a layout test "fast/js/date-proto-generic-invocation.html" as can be seen in https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25626 Original change's description: > [Intl] Move ToDateTimeOptions/ToLocaleDateTime to C++ > > Bug: v8:7961 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ic414a51a64040f253da1d7ccf03c558ea70ad2bf > Reviewed-on: https://chromium-review.googlesource.com/1155271 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55199} TBR=kadams@nvidia.com,jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7961 Change-Id: I39203fb281b9a54236b12a69c1f8389bcb5d411f Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1183165Reviewed-by:
-
Toon Verwaest authored
This reverts the following 3 CLs: Revert "[scanner] Templatize scan functions by encoding" Revert "[asm] Remove invalid static cast of character stream" Revert "[scanner] Prepare CharacterStreams for specializing scanner and parser by character type" The original idea behind this work was to avoid copying, converting and buffering characters to be scanned by specializing the scanner functions. The additional benefit was for scanner functions to have a bigger window over the input. Even though we can get a pretty nice speedup from having a larger window, in practice this rarely helps. The cost is a larger binary. Since we can't eagerly convert utf8 to utf16 due to memory overhead, we'd also need to have a specialized version of the scanner just for utf8. That's pretty complex, and likely won't be better than simply bulk converting and buffering utf8 as utf16. Change-Id: Ic3564683932a0097e3f9f51cd88f62c6ac879dcb Reviewed-on: https://chromium-review.googlesource.com/1183190Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#55258}
-
Hai Dang authored
Bug: v8:7973 Change-Id: I44ad457c3a103c36bd7b928cc64a056c1a1afc46 Reviewed-on: https://chromium-review.googlesource.com/1183102Reviewed-by:
-
Michael Lippautz authored
Avoid accessing |byte_length| during processing buffers. The length might be a HeapNumber that has already been processed (e.g. moved) in the current garbage collection cycle. Bug: v8:8076 Change-Id: I6d79631e300845a29f15a9f60933ee41ffc95300 Reviewed-on: https://chromium-review.googlesource.com/1183193Reviewed-by:
-
Jakob Gruber authored
This reverts commit ad5b7365. Reason for revert: https://crbug.com/875678 Original change's description: > [x64] Apply rip-relative call/jump for OFF_HEAP_TARGET > > Merge rip-relative loading and call/jump into one instruction for > OFF_HEAP_TARGET call/jump. For example, > > REX.W movq r10,[rip+#disp] > call r10 > > turns into: > > call [rip+#disp] > > Change-Id: I17e115d054b4b352bdaf8eba2e6ac4054bbedaca > Reviewed-on: https://chromium-review.googlesource.com/1172152 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55150} TBR=sigurds@chromium.org,jgruber@chromium.org,shiyu.zhang@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:875678 Change-Id: I5a9dd6e29cc53566d681864f7e275a70ccdcb0cb Reviewed-on: https://chromium-review.googlesource.com/1183164 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
