- 25 Jun, 2015 34 commits
-
-
binji authored
The issue is that Worker.prototype.terminate was deleting the C++ Worker object, and then Worker.prototype.getMessage was trying to read messages from the queue. The simplest solution is to keep workers in a zombie state when they have been terminated. They won't be reaped until Shell::CleanupWorkers is called. I've also fixed some threading issues with Workers: * Workers can be created by another Worker, so the Shell::workers_ variable must be protected by a mutex. * An individual Worker can typically only be accessed by the isolate that created it, but the main thread can always terminate it, so the Worker::state_ must be accessed in a thread-safe way. BUG=chromium:504136 R=jochen@chromium.org LOG=n Review URL: https://codereview.chromium.org/1208733002 Cr-Commit-Position: refs/heads/master@{#29306}
-
balazs.kilvady authored
Port d783b763 Original commit message: ARM64's `fmin` and `fmax` instructions don't have the same behaviour as TurboFan's Float(32|64)(Min|Max) functions. BUG=4206 LOG=N Review URL: https://codereview.chromium.org/1204903004 Cr-Commit-Position: refs/heads/master@{#29305}
-
mbrandy authored
Port a58ba8d8 Original commit message: This introduces some initial building blocks for calling out to C/C++ functions directly from TurboFan generated code objects. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1206343002 Cr-Commit-Position: refs/heads/master@{#29304}
-
mbrandy authored
Port c1a4f747 Original commit message: The idea is that TurboFan can use this information for more intelligent inlining. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1208093002 Cr-Commit-Position: refs/heads/master@{#29303}
-
mbrandy authored
Port 9e7af9ef Original commit message: It's useful for the megamorphic keyed store case to not require a vector and slot as input. Analogous to the load case, we have a dummy one-ic-slot vector to aid. Since the only kind of MISS is for megamorphic cache stub failures, we don't need the real vector. The reason is that megamorphic cache stub failures don't result in any change to the type feedback vector state. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1212493002 Cr-Commit-Position: refs/heads/master@{#29302}
-
mbrandy authored
R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1210083002 Cr-Commit-Position: refs/heads/master@{#29301}
-
mbrandy authored
R=wingo@igalia.com, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1209703002 Cr-Commit-Position: refs/heads/master@{#29300}
-
wingo authored
BUG=v8:4213 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/1210003003 Cr-Commit-Position: refs/heads/master@{#29299}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1211833002 Cr-Commit-Position: refs/heads/master@{#29298}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1209983002 Cr-Commit-Position: refs/heads/master@{#29297}
-
yangguo authored
Now that we keep tabs on shared function infos from a script, we can speed up finding shared function infos for debugging. However, in case we have to compile a function that cannot be lazily compiled without context, we fall back to the slow heap iteration. R=mstarzinger@chromium.org BUG=v8:4132,v8:4052 LOG=N Review URL: https://codereview.chromium.org/1206573004 Cr-Commit-Position: refs/heads/master@{#29296}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1205913002 Cr-Commit-Position: refs/heads/master@{#29295}
-
vogelheim authored
This is a follow-on to https://code.google.com/p/v8/source/detail?r=22431 This will remove the compatibility logic, so that the API as described in r22431 is the only API. I'll let this CL will sit around for a while to give embedders a chance to update their code. R=yangguo@chromium.org, ulan@chromium.org BUG=chromium:399580 LOG=Y Review URL: https://codereview.chromium.org/392263002 Cr-Commit-Position: refs/heads/master@{#29294}
-
wingo authored
Originally applied in https://codereview.chromium.org/1202963005 BUG=v8:4214 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel LOG=N R=arv@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1208873002 Cr-Commit-Position: refs/heads/master@{#29293}
-
arv authored
The stack layout was different for different ports. BUG=v8:3887 LOG=N R=dslomov@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1203103003 Cr-Commit-Position: refs/heads/master@{#29292}
-
yangguo authored
BUG=v8:4132 LOG=N Review URL: https://codereview.chromium.org/1211803002 Cr-Commit-Position: refs/heads/master@{#29291}
-
erikcorry authored
Previous code review https://codereview.chromium.org/1182783009/ R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1204123003 Cr-Commit-Position: refs/heads/master@{#29290}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1207613005 Cr-Commit-Position: refs/heads/master@{#29289}
-
bmeurer authored
Also remove the weird work-around for this missing optimization in CHECK_DATE in macros.py. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1205353002 Cr-Commit-Position: refs/heads/master@{#29288}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1194023004 Cr-Commit-Position: refs/heads/master@{#29287}
-
yangguo authored
Currently DebugInfo objects can be created independently from whether the debugger is active. When tearing down the isolate, we would go through DebugInfo objects and iterate through break locations, causing this assertion to fail. R=ulan@chromium.org BUG=v8:4241 LOG=N Review URL: https://codereview.chromium.org/1210813002 Cr-Commit-Position: refs/heads/master@{#29286}
-
yangguo authored
Revert of Reland "Keep a canonical list of shared function infos." (patchset #3 id:40001 of https://codereview.chromium.org/1211453002/) Reason for revert: proxies test failing https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/903/steps/Mjsunit/logs/proxies Original issue's description: > Reland "Keep a canonical list of shared function infos." > > This reverts commit 3164aa74. > > Committed: https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 > Cr-Commit-Position: refs/heads/master@{#29282} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1206263002 Cr-Commit-Position: refs/heads/master@{#29285}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1206803003 Cr-Commit-Position: refs/heads/master@{#29284}
-
Benedikt Meurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1208003002. Cr-Commit-Position: refs/heads/master@{#29283}
-
yangguo authored
This reverts commit 3164aa74. Review URL: https://codereview.chromium.org/1211453002 Cr-Commit-Position: refs/heads/master@{#29282}
-
Michael Stanton authored
The idea is that TurboFan can use this information for more intelligent inlining. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1201193003 Cr-Commit-Position: refs/heads/master@{#29281}
-
Michael Stanton authored
It's useful for the megamorphic keyed store case to not require a vector and slot as input. Analogous to the load case, we have a dummy one-ic-slot vector to aid. Since the only kind of MISS is for megamorphic cache stub failures, we don't need the real vector. The reason is that megamorphic cache stub failures don't result in any change to the type feedback vector state. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1210583002 Cr-Commit-Position: refs/heads/master@{#29280}
-
Benedikt Meurer authored
This introduces some initial building blocks for calling out to C/C++ functions directly from TurboFan generated code objects. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1205023002. Cr-Commit-Position: refs/heads/master@{#29279}
-
Michael Starzinger authored
This is one step torwards extracting an OptimizedCodeMap out from the SharedFunctionInfo in order to have a more flexible implementation. R=bmeurer@chromium.org, jarin@chromium.org Review URL: https://codereview.chromium.org/1205783003. Cr-Commit-Position: refs/heads/master@{#29278}
-
bmeurer authored
This partially reverts https://codereview.chromium.org/1162563002 because we might actually be able to optimize certain combinations now due to dead code elimination. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1202263006 Cr-Commit-Position: refs/heads/master@{#29277}
-
bbudge authored
I missed some functions that need to change. LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1199413009 Cr-Commit-Position: refs/heads/master@{#29276}
-
mstarzinger authored
This is one step torwards extracting an OptimizedCodeMap out from the SharedFunctionInfo in order to have a more flexible implementation. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1210523002 Cr-Commit-Position: refs/heads/master@{#29275}
-
v8-autoroll authored
Rolling v8/third_party/icu to c3f79166089e5360c09e3053fce50e6e296c3204 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1206173002 Cr-Commit-Position: refs/heads/master@{#29274}
-
arv authored
BUG=v8:4227 LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1200373003 Cr-Commit-Position: refs/heads/master@{#29273}
-
- 24 Jun, 2015 6 commits
-
-
arv authored
We need to do the ToName before the ToObject. BUG=v8:4229 LOG=N R=adamk Review URL: https://codereview.chromium.org/1211663002 Cr-Commit-Position: refs/heads/master@{#29272}
-
arv authored
The escaping of back ticks in template strings was incorrect BUG=v8:4240 LOG=N TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/1209713003 Cr-Commit-Position: refs/heads/master@{#29271}
-
arv authored
If the replacer array contains a number wrapper we should use the toString result and not valueOf. BUG=v8:4228 LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1207013002 Cr-Commit-Position: refs/heads/master@{#29270}
-
dstence authored
R=mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1202383005 Cr-Commit-Position: refs/heads/master@{#29269}
-
arv authored
The i18n.js code was calling a lot of methods, which might have been removed or replaced by user code. Make sure we use the original functions. BUG=v8:4220 LOG=N R=adamk, littledan CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1199813004 Cr-Commit-Position: refs/heads/master@{#29268}
-
machenbach authored
Revert of Fix receiver when calling eval() bound by with scope (patchset #3 id:40001 of https://codereview.chromium.org/1202963005/) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream blink first. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/574 Please consider extra blink trybots on a reland. Original issue's description: > Fix receiver when calling eval() bound by with scope > > Thanks to André Bargull for the report. > > BUG=v8:4214 > LOG=N > R=arv@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/3c5f0db3a1768ade68108bf003676ce378d1cbdc > Cr-Commit-Position: refs/heads/master@{#29259} TBR=arv@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4214 Review URL: https://codereview.chromium.org/1201273004 Cr-Commit-Position: refs/heads/master@{#29267}
-