- 28 Jul, 2016 16 commits
-
-
Alexander.Gilday2 authored
perf-turbo.py merges a perf data file and a turbofan trace file into a single json object which can then be piped to a file and uploaded to turbolizer to display the profiling data in the disassembly. With the changes, turbolizer now shows the event counts for instruction in percentage form and with heatmap-stype colouring. Multiple different events can be recorded at once with a new drop-down menu to select which event to view the counts of. The documentation has been updated with instructions. Using the script is optional and turbolizer retains previous functionality if a trace without profiling data is uploaded. BUG=None Review-Url: https://codereview.chromium.org/2174803002 Cr-Commit-Position: refs/heads/master@{#38124}
-
dcheng authored
This reduces the size of GetStrongGcSubrootName() from 77 KB to 10KB. BUG=5240 Review-Url: https://codereview.chromium.org/2189633003 Cr-Commit-Position: refs/heads/master@{#38123}
-
zhengxing.li authored
X87: Reland of [interpreter] Add explicit OSR polling bytecode. (patchset #1 id:1 of https://codereview.chromium.org/2184553003/ ). port e1ad114e (r38056) original commit message: Reason for revert: Fix has been landed. Original issue's description: > Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6 id:100001 of https://codereview.chromium.org/2172233002/ ) > > Reason for revert: > Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ? > > E.g.: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607 > > Original issue's description: > > [interpreter] Add explicit OSR polling bytecode. > > > > This adds an explicit {OsrPoll} bytecode into every loop header which > > triggers on-stack replacement when armed. Note that each such bytecode > > stores the static loop depths as an operand, and hence can be armed for > > specific loop depths. > > > > This also adds builtin code that triggers OSR compilation and switches > > execution over to optimized code in case compilation succeeds. In case > > compilation fails, the bytecode dispatch just continues unhindered. > > > > R=rmcilroy@chromium.org > > TEST=mjsunit/ignition/osr-from-bytecode > > BUG=v8:4764 > > > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458 > > Cr-Commit-Position: refs/heads/master@{#38043} > > TBR=rmcilroy@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4764 > > Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc > Cr-Commit-Position: refs/heads/master@{#38044} BUG= Review-Url: https://codereview.chromium.org/2190903002 Cr-Commit-Position: refs/heads/master@{#38122}
-
jochen authored
Use it like this: Program received signal SIGTRAP, Trace/breakpoint trap. [Switching to Thread 0x7f50d02c4700 (LWP 8152)] base::debug::(anonymous namespace)::DebugBreak () at ../../base/debug/debugger_posix.cc:230 230 } (gdb) bt at ../../base/debug/debugger_posix.cc:230 ... args_object=0x7f50d02bfe00, isolate=0x2f001c9e2020) at ../../v8/src/builtins/builtins-api.cc:123 ... (gdb) jss (gdb) bt isolate=0x2f001c9e2020, is_construct=false, target=..., receiver=..., argc=1, args=0x7f50d02c0518, new_target=...) at ../../v8/src/execution.cc:111 isolate=0x2f001c9e2020, callable=..., receiver=..., argc=1, argv=0x7f50d02c0518) at ../../v8/src/execution.cc:168 ... R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2186013002 Cr-Commit-Position: refs/heads/master@{#38121}
-
machenbach authored
BUG=chromium:580337 TBR=yangguo@chromium.org, jochen@chromium.org, pfeldman@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2192563003 Cr-Commit-Position: refs/heads/master@{#38120}
-
zhengxing.li authored
port ba092fb0 (r37971) original commit message: So far we don't have a useful way to inline Math.max or Math.min in TurboFan optimized code. This adds new operators NumberMax and NumberMin and changes the Float64Max/Float64Min operators to have JavaScript semantics instead of the C++ semantics that it had previously. This also removes support for recognizing the tenary case in the CommonOperatorReducer, since that doesn't seem to have any positive impact (and actually doesn't show up in regular JavaScript, where people use Math.max/Math.min instead). BUG= Drive-by-fix: Also nuke the unused Float32Max/Float32Min operators. Review-Url: https://codereview.chromium.org/2187463005 Cr-Commit-Position: refs/heads/master@{#38119}
-
bmeurer authored
If the input to a CheckString is already a String, then the check is redundant. R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2190833002 Cr-Commit-Position: refs/heads/master@{#38118}
-
machenbach authored
This is required for all executables. BUG=chromium:580337 TBR=yangguo@chromium.org, jochen@chromium.org, pfeldman@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2183313007 Cr-Commit-Position: refs/heads/master@{#38117}
-
neis authored
R=adamk@chromium.org BUG=v8:5237 Review-Url: https://codereview.chromium.org/2188753002 Cr-Commit-Position: refs/heads/master@{#38116}
-
mstarzinger authored
R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2190623002 Cr-Commit-Position: refs/heads/master@{#38115}
-
jochen authored
R=marja@chromium.org BUG=v8:5215 Review-Url: https://codereview.chromium.org/2191443003 Cr-Commit-Position: refs/heads/master@{#38114}
-
machenbach authored
The isolate_driver automatically adds referenced shared libraries. They don't need to be listed explicitly. The hard-coded location blocks the GN transition as the library location is different in GYP and GN. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2190543003 Cr-Commit-Position: refs/heads/master@{#38113}
-
marja authored
BUG= Review-Url: https://codereview.chromium.org/2182493006 Cr-Commit-Position: refs/heads/master@{#38112}
-
yangguo authored
This adds the build target inspector_protocol_parser_test, which depends on several more inspector protocol related targets. The resulting gtest executable runs, but has failures that have to be fixed. GN build configuration will follow. A copy of v8-inspector/js_protocol.json has been included to be able to use it before the actual migration. BUG=chromium:580337 Review-Url: https://codereview.chromium.org/2184733002 Cr-Commit-Position: refs/heads/master@{#38111}
-
ddchen authored
This patch updates internal data structures used by V8 to support multiple indirect function tables (WebAssembly/design#682). But, since this feature is post-MVP, the functionality is not directly exposed and parsing/generation of WebAssembly is left unchanged. Nevertheless, it is being used in an experiment to implement fine-grained control flow integrity based on C/C++ types. BUG= Review-Url: https://codereview.chromium.org/2174123002 Cr-Commit-Position: refs/heads/master@{#38110}
-
v8-autoroll authored
Rolling v8/build to 0a8d7715646009e2d0935f72462c481be22c6de4 Rolling v8/tools/mb to 1d3f4544cadd78d89c8c71c37ef5474ac2b1e297 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2191643003 Cr-Commit-Position: refs/heads/master@{#38109}
-
- 27 Jul, 2016 24 commits
-
-
machenbach authored
Revert of MIPS: Fix mksnapshot on big-endian. (patchset #3 id:40001 of https://codereview.chromium.org/2172653002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/2189443003/ Doesn't work with the last chromium gyp bot. Original issue's description: > MIPS: Fix mksnapshot on big-endian. > > Paritally revert standalone.gypi changes in a451bd1a and introduce a new separate variable for the mkpeephole. > > On big-endian MIPS, qemu is used to build the snapshot, > because there's no simulator support for big-endian MIPS. > > BUG= > > Committed: https://crrev.com/928d2395c3fdf836cf9961cde96e6b274a6b1e20 > Cr-Commit-Position: refs/heads/master@{#38103} TBR=oth@chromium.org,machenbach@google.com,akos.palfi@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2182633010 Cr-Commit-Position: refs/heads/master@{#38108}
-
mstarzinger authored
This removes the ability to directly access the {FunctionType} stored within a {CallInterfaceDescriptor}. The field is in the process of being deprecated and should no longer be accessed. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2191533002 Cr-Commit-Position: refs/heads/master@{#38107}
-
bmeurer authored
Introduce an appropriate StringCharCodeAt simplified operator and use that to optimize the String.prototype.charCodeAt/.charAt builtins. R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2180373005 Cr-Commit-Position: refs/heads/master@{#38106}
-
qyearsley authored
This is intended to be submitted just after http://crrev.com/2174553002, which renames these builders. BUG=590036 NOTRY=true Review-Url: https://codereview.chromium.org/2181133002 Cr-Commit-Position: refs/heads/master@{#38105}
-
fmeawad authored
V8 has had a trace event macro interface for while, but without a tracing controller a standalone V8 would be unable to collect traces. This CL introduces a complete Tracing Controller system for V8. It is fully function except that it does not yet store trace event args. This CL has a few components, The tracing controller itself, contributed by the author of this CL The Trace config (including the parser), contributed by lpy@ The Trace Object, Trace Writer, and Trace Buffer are all contributed by rksang@ BUG=v8:4561 LOG=N The original CL was failing the V8 Arm Builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2456 and the V8 Mips Builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/2506 The failure is due to undefined behavior of CHECK_EQ of 2 const char* Fix in patch #1 Committed: https://crrev.com/3d598452679ce208ad9b2f48e0fb3fae352ce375 Cr-Commit-Position: refs/heads/master@{#38073} patch from issue 2137013006 at patchset 200001 (http://crrev.com/2137013006#ps200001) Review-Url: https://codereview.chromium.org/2183923004 Cr-Commit-Position: refs/heads/master@{#38104}
-
akos.palfi authored
Paritally revert standalone.gypi changes in a451bd1a and introduce a new separate variable for the mkpeephole. On big-endian MIPS, qemu is used to build the snapshot, because there's no simulator support for big-endian MIPS. BUG= Review-Url: https://codereview.chromium.org/2172653002 Cr-Commit-Position: refs/heads/master@{#38103}
-
Miran.Karic authored
Default icu data file for all architectures was set to icudtl.dat, for big endian this should be icudtb.dat. This will fix intl tests for big endian once v8 rolls to a newer version of icu that supports big endian. BUG= TEST=intl/* Review-Url: https://codereview.chromium.org/2182043002 Cr-Commit-Position: refs/heads/master@{#38102}
-
klaasb authored
Remove TODO to perform same optimization as AstGraphBuilder. When visiting for effect in a postfix count operation, don't keep the intermediate result of ToNumber. BUG=v4:4280 LOG=n Review-Url: https://codereview.chromium.org/2187823002 Cr-Commit-Position: refs/heads/master@{#38101}
-
oth authored
BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/2187713004 Cr-Commit-Position: refs/heads/master@{#38100}
-
jacob.bramley authored
All supported ARM targets support unaligned accesses for integer accesses. This patch removes the remnants of support for older targets. BUG=v8:5077 Review-Url: https://codereview.chromium.org/2184823002 Cr-Commit-Position: refs/heads/master@{#38099}
-
mlippautz authored
- Overhead for HashTable was not accounted in bytes - Name table in typefeedback metadata changed BUG=chromium:631094 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2190563002 Cr-Commit-Position: refs/heads/master@{#38098}
-
danno authored
Review-Url: https://codereview.chromium.org/2187463003 Cr-Commit-Position: refs/heads/master@{#38097}
-
klaasb authored
https://codereview.chromium.org/2176143002 removed parsing of a golden file header option but did not remove the option. BUG= LOG=n Review-Url: https://codereview.chromium.org/2189583002 Cr-Commit-Position: refs/heads/master@{#38096}
-
danno authored
BUG=608675 Review-Url: https://codereview.chromium.org/2184073002 Cr-Commit-Position: refs/heads/master@{#38095}
-
mlippautz authored
Objects that reside below the age mark could be on pages that have been moved within new space. In this case mementos survived which can actually point to already-collected allocation sites. BUG=chromium:631050,chromium:581412 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2179033005 Cr-Commit-Position: refs/heads/master@{#38094}
-
ishell authored
Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one. BUG=v8:5236 Review-Url: https://codereview.chromium.org/2184063002 Cr-Commit-Position: refs/heads/master@{#38093}
-
hablich authored
Revert of [gn] Don't use PIE for host executables (patchset #2 id:20001 of https://codereview.chromium.org/2179303003/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/2182043004/ Original issue's description: > [gn] Don't use PIE for host executables > > Using PIE switches on ASLR. With mksnapshot, this can lead > to non-deterministic snapshots. > > BUG=v8:5233 > > Committed: https://crrev.com/4ca39b53245619d94a80a93939613774e68e4649 > Cr-Commit-Position: refs/heads/master@{#38084} TBR=jochen@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5233 Review-Url: https://codereview.chromium.org/2187613003 Cr-Commit-Position: refs/heads/master@{#38092}
-
epertoso authored
This leads to a better handling of the Smi case when we introduce a checked truncation from a number or oddbal to a 32 bit word, which we were previously doing by concatenating a Smi to float64 conversion with a float64 to word32 truncation. BUG= Review-Url: https://codereview.chromium.org/2191503002 Cr-Commit-Position: refs/heads/master@{#38091}
-
balazs.kilvady authored
Port 52f2ceb0 Original commit message: On MIPS different signaling NaN values must be used for hardware and simulator targets, even at snapshot generation when always simulator is used. This introduces SilenceNaN operator, which makes sure that we only store quiet NaNs into holey arrays. We omit the NaN silencing code at instruction selection time if the input is an operation that cannot possibly produce signalling NaNs. BUG= TEST=mjsunit/compiler/regress-store-holey-double-array Review-Url: https://codereview.chromium.org/2188433002 Cr-Commit-Position: refs/heads/master@{#38090}
-
machenbach authored
This prepares for https://codereview.chromium.org/2188693002/ With the current configuration, sanitizers wouldn't be used at all. The clang configuration is automatically derived in GN. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2184683004 Cr-Commit-Position: refs/heads/master@{#38089}
-
bmeurer authored
Also run the BranchElimination (plus CommonOperatorReducer and the DeadCodeElimination) during the load elimination phase, so we can elminate some Phi nodes early on that would otherwise confuse the truncation analysis and/or representation selection, i.e. if there's a branch that is never taken, that would yield undefined, we'd have to choose tagged representation for the Phi, even if the always taken branch yields an integer. R=epertoso@chromium.org BUG=v8:4930,v8:5141 Review-Url: https://codereview.chromium.org/2190543002 Cr-Commit-Position: refs/heads/master@{#38088}
-
yangguo authored
R=marja@chromium.org BUG=chromium:621361 Review-Url: https://codereview.chromium.org/2185913003 Cr-Commit-Position: refs/heads/master@{#38087}
-
epertoso authored
This required the introduction of the CheckedNumberOrOddballAsWord32 use info, and a change in the RepresentationChanger to handle it. BUG= Review-Url: https://codereview.chromium.org/2184513003 Cr-Commit-Position: refs/heads/master@{#38086}
-
mstarzinger authored
R=mythria@chromium.org TEST=mjsunit/regress/regress-2618 BUG=v8:4764 Review-Url: https://codereview.chromium.org/2183463003 Cr-Commit-Position: refs/heads/master@{#38085}
-