- 29 Aug, 2016 8 commits
-
-
bmeurer authored
Drop the typing rules for the machine operators and replace them with UNREACHABLE. These typing rules were never correct and there's also no need to have those rules at all. Drive-by-fix: Remove the extremely annoying test-simplified-lowering.cc file, which is not very useful, but consumes a large amount of time to keep it compiling and passing. Instead we should introduce appropriate tests for the SimplifiedLowering that also test something meaningful w/o just cementing the implementation. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2292463002 Cr-Commit-Position: refs/heads/master@{#38970}
-
neis authored
This will be used for scope infos in a follow-up CL. R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2277273002 Cr-Commit-Position: refs/heads/master@{#38969}
-
bmeurer authored
These JavaScript operators were special hacks to ensure that we always operate on Smis for the magic for-in index variable, but this never really worked in the OSR case, because the OsrValue for the index variable didn't have the proper information (that we have for the JSForInPrepare in the non-OSR case). Now that we have loop induction variable analysis and binary operation hints, we can just use JSLessThan and JSAdd instead with appropriate Smi hints, which handle the OSR case by inserting Smi checks (that are always true). Thanks to OSR deconstruction and loop peeling these Smi checks will be hoisted so they don't hurt the OSR case too much. Drive-by-change: Rename the ForInDone bytecode to ForInContinue, since we have to lower it to JSLessThan to get the loop induction variable goodness. R=epertoso@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2289613002 Cr-Commit-Position: refs/heads/master@{#38968}
-
heimbuef authored
Used a BitField to for Variable fields instead of relying on the compiler, saving some memory probably. This reduces sizeof(Variable) from 64 to 40 on x64 BUG=v8:5209 Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190 Review-Url: https://codereview.chromium.org/2257493002 Cr-Original-Commit-Position: refs/heads/master@{#38891} Cr-Commit-Position: refs/heads/master@{#38967}
-
bmeurer authored
R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2291433003 Cr-Commit-Position: refs/heads/master@{#38966}
-
bmeurer authored
Typing these operators should never happen and doesn't make any sense at all. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2286253002 Cr-Commit-Position: refs/heads/master@{#38965}
-
bmeurer authored
For asm.js we now have a dedicated AsmTyper, that uses it's own type system (which is tailored towards asm.js), and so we don't need the special asm.js types anymore in the TypeCache. This also moves the TypeCache into the src/compiler directory, because it doesn't make sense to use outside anyways. TBR=ahaas@chromium.org R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2289573002 Cr-Commit-Position: refs/heads/master@{#38964}
-
bmeurer authored
There's no need to preserve the exact callee for lazy bailouts from JSCallFunction in the AstGraphBuilder, as fullcodegen code will never look at that value after the callee returns. So we just push optimized_out instead. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2285183002 Cr-Commit-Position: refs/heads/master@{#38963}
-
- 28 Aug, 2016 3 commits
-
-
hablich authored
Reland of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2286163002/ ) Reason for revert: Roll was unstuck before the revert landed => reland Original issue's description: > Revert of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2264283007/ ) > > Reason for revert: > Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241 > > Original issue's description: > > Fix compiler warnings on "make android_arm" > > > > Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 > > Cr-Commit-Position: refs/heads/master@{#38937} > > TBR=bmeurer@chromium.org,jkummerow@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/d992c1f52f116930239ed90cc033442047e789b4 > Cr-Commit-Position: refs/heads/master@{#38961} TBR=bmeurer@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2285113002 Cr-Commit-Position: refs/heads/master@{#38962}
-
hablich authored
Revert of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2264283007/ ) Reason for revert: Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241 Original issue's description: > Fix compiler warnings on "make android_arm" > > Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 > Cr-Commit-Position: refs/heads/master@{#38937} TBR=bmeurer@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2286163002 Cr-Commit-Position: refs/heads/master@{#38961}
-
mlippautz authored
Revert of "[heap] Switch to 500k pages" (patchset #1 id:1 of https://codereview.chromium.org/2278653003/ ) Reason for revert: Tanks pretty much alle metrics across the board. Probably LO space limit too low but needs investigation. Original issue's description: > [heap] Switch to 500k pages > > Decrease regular heap object size to 400k. In a follow up, we can now get rid of > the new space border page while keeping the 1M minimum new space size. > > This reverts commit 1617043c. > > BUG=chromium:636331 > > Committed: https://crrev.com/2101e691caeef656eb91f1c98620b3955d337c83 > Cr-Commit-Position: refs/heads/master@{#38916} TBR=ulan@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:636331 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2289493002 Cr-Commit-Position: refs/heads/master@{#38960}
-
- 27 Aug, 2016 2 commits
-
-
verwaest authored
BUG=v8:5209 Review-Url: https://codereview.chromium.org/2281393002 Cr-Commit-Position: refs/heads/master@{#38959}
-
verwaest authored
Revert of Always deserialize scope infos for parsing (patchset #3 id:40001 of https://codereview.chromium.org/2280933002/ ) Reason for revert: Significantly tanks parsing. We probably should just keep on doing what we're doing: partially deserialize while resolving variables. If we do scope-info backed resolution after regular resolution based on remaining free variables, we can probably reduce the time-frame of that part. We soon after anyway need to sync with the main thread. Original issue's description: > Always deserialize scope infos for parsing > > When looking up variables in the ScopeInfo, we did a linear scan of the > ScopeInfo. Since that's unacceptably slow, a context slot cache was added > that would speed up repeated lookups of the same variable. > > Instead, just always fully convert the ScopeInfo into scopes, so they can > lookup variables without scanning the ScopeInfo. > > This also allows for removing the now unused ContextSlotCache. > > R=adamk@chromium.org,verwaest@chromium.org,marja@chromium.org > BUG=v8:5315 > > Committed: https://crrev.com/81f824cad18e4dc873a8838943217eb9c9f0c1f0 > Cr-Commit-Position: refs/heads/master@{#38953} TBR=adamk@chromium.org,marja@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5315 Review-Url: https://codereview.chromium.org/2287783003 Cr-Commit-Position: refs/heads/master@{#38958}
-
- 26 Aug, 2016 27 commits
-
-
littledan authored
As part of the work to implement catch prediction for async functions, the resulting Promise that is the output of the function needs to be available earlier for a couple reasons: - To be able to do %DebugPushPromise/%DebugPopPromise over the body of the async function - To be able to pass the resulting promise into AsyncFunctionAwait in order to set up the dependency chains This patch creates the Promise earlier and pushes it onto the debug stack; a later patch will set up the dependency chain. Although the debug stack is set up, it's not anticipated that this will change the catch prediction helpfully yet, as everything will still likely be predicted as 'caught' for now, as before. R=caitp@igalia.com,yangguo@chromium.org CC=neis@chromium.org,gsathya@chromium.org BUG=v8:5167 Review-Url: https://codereview.chromium.org/2233923003 Cr-Commit-Position: refs/heads/master@{#38957}
-
adamk authored
R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2282043002 Cr-Commit-Position: refs/heads/master@{#38956}
-
lpy authored
By removing the copy flag, we reduce the amount of strings to be copied each time. BUG=v8:5089 LOG=N Review-Url: https://codereview.chromium.org/2233993002 Cr-Commit-Position: refs/heads/master@{#38955}
-
bjaideep authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2283773003 Cr-Commit-Position: refs/heads/master@{#38954}
-
jochen authored
When looking up variables in the ScopeInfo, we did a linear scan of the ScopeInfo. Since that's unacceptably slow, a context slot cache was added that would speed up repeated lookups of the same variable. Instead, just always fully convert the ScopeInfo into scopes, so they can lookup variables without scanning the ScopeInfo. This also allows for removing the now unused ContextSlotCache. R=adamk@chromium.org,verwaest@chromium.org,marja@chromium.org BUG=v8:5315 Review-Url: https://codereview.chromium.org/2280933002 Cr-Commit-Position: refs/heads/master@{#38953}
-
jyan authored
callback_entrypoint_address call could return nullptr and therefore causes seg fault intermittently. R=jochen@chromium.org, lpy@chromium.org, yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2274573007 Cr-Commit-Position: refs/heads/master@{#38952}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2277513003 Cr-Commit-Position: refs/heads/master@{#38951}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2269053002 Cr-Commit-Position: refs/heads/master@{#38950}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2278523002 Cr-Commit-Position: refs/heads/master@{#38949}
-
jbroman authored
The embedder is expected to arrange for the array buffer contents to be transferred into a v8::ArrayBuffer in the receiving context (generally by assuming ownership of the externalized backing store). BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2275033003 Cr-Commit-Position: refs/heads/master@{#38948}
-
franzih authored
BUG=v8:5260 Review-Url: https://codereview.chromium.org/2263303003 Cr-Commit-Position: refs/heads/master@{#38947}
-
jochen authored
We should always only have exactly as many heap slots as context locals R=verwaest@chromium.org,marja@chromium.org BUG= Review-Url: https://codereview.chromium.org/2280883002 Cr-Commit-Position: refs/heads/master@{#38946}
-
mstarzinger authored
The accumulator is always part of the translation for every interpreted frame. The assumption is that all frames are in {TOS_REGISTER} state. This however is not supported for non-topmost frames and we need to avoid pushing the accumulator onto the machine stack. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2271153003 Cr-Commit-Position: refs/heads/master@{#38945}
-
Miran.Karic authored
These DCHECKs were causing several test failures or r6. They should not be here because only NEG.PS format was removed in r6, NEG.S and NEG.D instructions remain. BUG= Review-Url: https://codereview.chromium.org/2276563006 Cr-Commit-Position: refs/heads/master@{#38944}
-
Miran.Karic authored
Floating point negate instructions are still present in release 6, only one format of neg is removed, NEG.PS. Others formats can be used and in r6 they also change the sign of NaN-like operands as well. This makes r6 generated code simpler for Neg_d and Neg_s macroassembler functions. BUG= Review-Url: https://codereview.chromium.org/2285703002 Cr-Commit-Position: refs/heads/master@{#38943}
-
mlippautz authored
BUG=chromium:641267 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2283713002 Cr-Commit-Position: refs/heads/master@{#38942}
-
ivica.bogosavljevic authored
on architectures that do not support missaligned memory access BUG=unittests/AstDecoderTest.Float64Const, unittests/AstDecoderTest.Float32Const Review-Url: https://codereview.chromium.org/2275323002 Cr-Commit-Position: refs/heads/master@{#38941}
-
mlippautz authored
New space evaucation in MC supports, similar to scavenges, fall back allocation in old space. For new space evacuation we support stick and non-sticky modes for fallback. The sticky mode essentially removes the capability to allocate in new space while the non-sticky mode only falls back for a single allocation. We use the non-sticky mode for allocations that are too large for a LAB but should still go in new space. When such an allocation fails in new space, we allocate in old space in non-sticky mode as we would still like to reuse the remainder memory in new space. However, in such a case we fail to properly report the space allocated in resulting in a missed recorded slot. BUG=chromium:641270 R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2280943002 Cr-Commit-Position: refs/heads/master@{#38940}
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2286593003 Cr-Commit-Position: refs/heads/master@{#38939}
-
ahaas authored
These tests became obsolete. They tested a requirement that has been removed from the WebAssembly specification. R=titzer@chromium.org, Balazs.Kilvady@imgtec.com Review-Url: https://codereview.chromium.org/2284593002 Cr-Commit-Position: refs/heads/master@{#38938}
-
jkummerow authored
Review-Url: https://codereview.chromium.org/2264283007 Cr-Commit-Position: refs/heads/master@{#38937}
-
ahaas authored
This CL fixes the first bug I found with the new fuzzing. The problem is that the number of locals is unbounded. This CL bounds the number of locals of one type with 8000000, an arbitrary number. R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2271803004 Cr-Commit-Position: refs/heads/master@{#38936}
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2281863002 Cr-Commit-Position: refs/heads/master@{#38935}
-
nikolaos authored
A minor change in the logic of expression classifiers that eliminates the use for MergeNonPatterns. R=adamk@chromium.org, littledan@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2275313002 Cr-Commit-Position: refs/heads/master@{#38934}
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. Many of these files we need to rebuild are cctests which pull in more includes than they need. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2278103002 Cr-Commit-Position: refs/heads/master@{#38933}
-
bmeurer authored
Using the dedicated simplified operator we are able to eliminate redundant neuterung checks as long as there is no call in the effect chain. This yields a nice speed up for the Octane Mandreel benchmark (and TypedArray-heavy workloads in general). R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2279213002 Cr-Commit-Position: refs/heads/master@{#38932}
-
neis authored
R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2275943005 Cr-Commit-Position: refs/heads/master@{#38931}
-