- 03 Mar, 2022 8 commits
-
-
jameslahm authored
- add CopyDataPropertiesWithExcludedProperties intrinsic - add CopyDataPropertiesWithExcludedProperties_Baseline intrinsic Bug: v8:11614 Change-Id: Ie6a3db4c9edda40ecf84b8d1107e70fd7ff0d5fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3470349Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79342}
-
jameslahm authored
Isolate::isolate_key_ and Isolate::per_isolate_thread_data_key_ are created in Isolate::InitializeOncePerProcess() and should be deleted in Isolate::DisposeOncePerProcess(). Bug: v8:11914 Change-Id: Ic3000d21f86a9d419373ef7c777c21661f544fee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3490712Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#79341}
-
Jakob Gruber authored
Now that only ppc lacks support, state that explicitly s.t. it's clear which platforms are still missing. Bug: v8:11420 Change-Id: I22a91270aaa389fc27ce5c7a3f8e8b9c44f01eb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497544 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79340}
-
Leszek Swirski authored
LiveNodeInfo was stored in a Node->LiveNodeInfo map, which was never copied or merged alongside control flow. Lookups in this map were a bit part of register allocation time, and it was mostly duplicating data that was already in the ValueNode. So, instead of a separate LiveNodeInfo, store the current register allocation state directly on the ValueNode. This involves a bit of clobbering of state (in particular, we have to clobber the next_use id), but that doesn't matter since regalloc is a forward pass and with this change, it's less memory and zero map lookups. Measuring on a (very large) function, this reduces compile time from 300ms to 200ms. Bug: v8:7700 Change-Id: I02620f1a795bd308d1de03d694c102cb5ea3ff50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500617Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79339}
-
Nico Hartmann authored
Bug: v8:12619 Change-Id: I3b9f82a21c9454ff37036e8abcf73862e38f1fc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494243Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#79338}
-
haoyuintel authored
The movq instruction with 8 immediate bytes is used for moving negative Smi to register previously. This CL reduce the immediate bytes by using mov imm32 with sign extension. To move a Smi of -1 to register, the disassembly before the commit is as: 48b8feffffffffffffff REX.W movq rax, 0xfffffffffffffffe The disassembly after the commit is as: 48c7c0feffffff REX.W movq rax, 0xfffffffe Change-Id: Ib54a4fbe66f59f86b9f13a72431ceb38470f1017 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500205Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Haoyu Zhang <haoyu.zhang@intel.com> Cr-Commit-Position: refs/heads/main@{#79337}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/aabb6b9..e6ef2e3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/893aa03..113dd1b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d62cc7b..1ec1fe1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a255e40..b65bfd5 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I8d3607b351e49ccf49c172bf03fcf5793e8cbdfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3499565 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79336}
-
Shu-yu Guo authored
This reverts commit 7d4c264e. Reason for revert: Blocking chromium roll, failures in ASAN unittests: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_asan_rel_ng/1104768/test-results Original change's description: > Reland "heap: Force incremental marking in C++ only workloads" > > This is a reland of commit 4fde3328 > > Most recent fix made Oilpan aware of --single-threaded-gc which > is necessary as GCs are more eagerly scheduled in tests. > > Original change's description: > > heap: Force incremental marking in C++ only workloads > > > > ... when above a certain minimum threshold. This is to guard against > > memory running away in scenarios where the JS heap is empty and > > there's only high throughput C++ allocations that don't allow for a > > memory reducer GC to kick in. > > > > This logic should be revisited after Oilpan's young generation > > collector is implemented which may allow switching to a more efficient > > shrinking strategy for initial heap setup. > > > > Bug: chromium:1029379, chromium:1300028, chromium:1300492 > > Change-Id: I93924fc2fe77d6226c29358d3afb1cc9d6fbf3b1 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484319 > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#79255} > > Bug: chromium:1029379, chromium:1300028, chromium:1300492 > Change-Id: Ia0c443248b951240cce6dbe1f68581ff1061a7d9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500301 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79327} Bug: chromium:1029379, chromium:1300028, chromium:1300492 Change-Id: I3fd0a5d4ded7d3ce7cd74a50a11b3a0367477d06 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500656 Auto-Submit: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79335}
-
- 02 Mar, 2022 11 commits
-
-
Michael Lippautz authored
- Add a comment on the macro that registers a prefinalizer. - Refactor the API to avoid exposing internal types needlessly. Change-Id: Ia88e786304616848556263410a8f5398c5374533 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497766Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79334}
-
Camillo Bruni authored
GetConstructorName might allocate and thus triggers gcmole warnings. This is a temporary workaround until the called function is cleanly fixed. Bug: v8:12674 Change-Id: I43bd190d887abcd79116e8c328ceedfb0c9fad79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497769 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#79333}
-
Jakob Gruber authored
.. to distinguish between Maglev and Turbofan targets. Also move one tracing function to tiering-manager. We may want to move all --trace-opt code into one place in the future (it's currently split between here and compiler.cc). Bug: v8:7700 Change-Id: I9756460124b14fc3213296d083071f338421966a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500612 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79332}
-
Seth Brenith authored
Currently, a streamed script which specifies 'use strict' is stored in the isolate script cache with a key indicating that it is strict mode. However, the keys should be based on the context executing the script, not the content of the script, so that the next lookup can find the entry without having to parse the script first. Bug: v8:12668 Change-Id: Iaa76c00c431ad54a86ffd18b61cb4f67dc457b03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3498220Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79331}
-
Omer Katz authored
spaces. Change-Id: I454c719519452f1c33a7a8b0b6393ed61c8f819d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497742 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79330}
-
Camillo Bruni authored
Profiler: - Track profiler tick durations - Various speedups due to low-level hacking Improve code-panel: - Better register highlighting - Added address navigation and highlighting - Removed obsolete inline source-view Improve script-panel: - Keep current source position focused when showing related entries - Better tool-tip with buttons to focus on grouped entries per source postion - Focus by default on other views when showing related entries Improve timeline-panel: - Initialise event handlers late to avoid errors - Lazy initialise chunks to avoid errors when zooming-in and trying to create tooltips at the same time Change-Id: I3f3c0fd51985aaa490d62f786ab52a4be1eed292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492521Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79329}
-
Jakob Gruber authored
When --maglev is set, tier up to Maglev from unoptimized tiers based on --interrupt-budget-for-maglev, initially set to 40KB (which should very roughly by 1/10th of the time until the TF tierup decision is made). On the first interrupt, a non-concurrent optimization to Maglev is requested, which the next call to the marked function will perform. - There is no support for tiering from Maglev to TF yet. - Maglev's language support is minimal and tests are not expected to pass with --maglev. - Disable --maglev by default for now. Drive-by: fixes related to Maglev flag definitions. Bug: v8:7700 Change-Id: I121bb3f4f3830fdd20e1d4a12d3e04f08a99be38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500302Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79328}
-
Michael Lippautz authored
This is a reland of commit 4fde3328 Most recent fix made Oilpan aware of --single-threaded-gc which is necessary as GCs are more eagerly scheduled in tests. Original change's description: > heap: Force incremental marking in C++ only workloads > > ... when above a certain minimum threshold. This is to guard against > memory running away in scenarios where the JS heap is empty and > there's only high throughput C++ allocations that don't allow for a > memory reducer GC to kick in. > > This logic should be revisited after Oilpan's young generation > collector is implemented which may allow switching to a more efficient > shrinking strategy for initial heap setup. > > Bug: chromium:1029379, chromium:1300028, chromium:1300492 > Change-Id: I93924fc2fe77d6226c29358d3afb1cc9d6fbf3b1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484319 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79255} Bug: chromium:1029379, chromium:1300028, chromium:1300492 Change-Id: Ia0c443248b951240cce6dbe1f68581ff1061a7d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500301Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79327}
-
Jakob Gruber authored
OptimizationDecision holds the optimization {reason, code kind, concurrency mode}. We centralize it to avoid having to recalculate in Optimize when we already know everything in ShouldOptimize. Bug: v8:7700 Change-Id: Ifcd902e86f844ce045bcefd4ae72ac17b42acb3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500300 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79326}
-
Jakob Gruber authored
.. by moving them all to TieringManager. Bug: v8:7700 Change-Id: I03eb2d1607b06ece84a1ca98ebc723788dbc0cde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500220 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79325}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/27d089d..aabb6b9 Rolling v8/buildtools/linux64: git_revision:e3f114f46537152cfbdb553015518d1db1b812fd..git_revision:d7c2209cebcfe37f46dba7be4e1a7000ffc342fb Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/2ea265b..d1c7f92 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2cfdaa8..d62cc7b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2bad9f0..a255e40 Rolling v8/tools/luci-go: git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8..git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70 Rolling v8/tools/luci-go: git_revision:582e828c5a8aaf5cdd0ad1d5465fb9092b71eab8..git_revision:a1616e207f0d9c24beefe848ee899b7a73efcb70 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ief20092d545bbd6f48d8dda10164832cb180810d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3499125 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79324}
-
- 01 Mar, 2022 15 commits
-
-
Nico Hartmann authored
Bug: chromium:1208805 Change-Id: Ia211d74f8de1dd031d5bda9885ec567e2d56b4cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897089 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#79323}
-
Manos Koukoutos authored
According to the latest changes in wasm-gc, externref will be renamed to anyref, and will be assigned as the top of the reference type hierarchy. Since in the current wasm type system funcref is not a subtype of anyref, subtyping is now dependent on whether wasm-gc is enabled. Bug: v8:7748 Change-Id: I0c0ae3dd5523e624d4490ca33d1fba4c2ae59393 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3468345Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79322}
-
Michael Lippautz authored
Before this CL Oilpan would schedule concurrent marking and sweeping even in the presence of --single-threaded-gc. This e.g. flakily breaks Blink tests that do not set up a thread-pool in certain configurations where they pass --single-threaded (implying --single-threaded-gc). Bug: chromium:1300492 Change-Id: I64f0c6a20f9c29d689a62e63cc5a8d024962ff2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497760Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79321}
-
Leszek Swirski authored
InitialValue needs to have a spill slot (e.g. for deopts) but shouldn't emit an actual spill (since they're already on stack). Drive-by, fix printing of Checkpoint and CheckMaps parameters. Bug: v8:7700 Change-Id: I3c1acfce6638b1ad604f7c7a1938694814c326ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497371 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79320}
-
Leszek Swirski authored
GetFreeRegisters is supposed to find some number of free registers that the current node can use as safe temporaries, but they shouldn't be considered "allocated", as they will be free as soon as the node's code completes. Now we no longer decrement free_register_count_ in GetFreeRegisters, to avoid leaking registers allocated for temporaries. Bug: v8:7700 Change-Id: I485607fedec79fbeca4675781923b7ad3a6bfc6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497381Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79319}
-
Jakob Gruber authored
- Add the Isolate as an explicit param (we already have it at all callsites) - Pass an explicit CodeKind param to MarkForOptimization in preparation for Maglev. - Split EnsureFeedbackVector into that, plus CreateAndAttachFeedbackVector for when we know it has to be created. Bug: v8:7700 Change-Id: Ie9022deccd31d472d6df3d442b25583af5569ab0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497383 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79318}
-
Pierre Langlois authored
When running with the simulator, Assembler::debug() can record an inline comment to be printed when the simulator encounters it. We need to make sure pools are not emitted while the comment is recorded in the code stream. However the BlockPoolsScope was missing its margin argument to tell it how much code we're going to generate, and could forget to emit pools when it should have, causing crashes later on when a branch cannot jump over the code comment. Bug: v8:12637 Change-Id: I39e50f176d87c781c865b81fb9aca57d69c8c019 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494544Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/main@{#79317}
-
Michael Lippautz authored
Single generation doesn't have a young generation, so we cannot check whether it's inline allocation is enabled. Bug: v8:12615 Change-Id: I145e7c3ff225dc0099136289c9aef4ddd28b3578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3487993 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79316}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I117f0ed7df60eff145b0ecd509ffa7debc137038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494239Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79315}
-
Jakob Gruber authored
gcc builds seem to have troubles with this: error: call to non-constexpr function Remove the UNREACHABLE() calls for now but keep a TODO to potentially re-enable them again once we've figured this out. Bug: v8:7700,v8:12667 Change-Id: I9628a1326c1c4200b90aad25cd2eabfeb06608fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494237 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79314}
-
Igor Sheludko authored
1) add relaxed version of Code::main_cage_base accessors and use them from in those cases where they can be called from backround thread, 2) pass the main cage base value to IsCode() predicate to avoid accessing non-acomic Heap pointer value in page headers from background compilation thread. Drive-by cleanup: use MarkingVerifier::cage_base() instead of Code::main_cage_base(). Bug: v8:11880, v8:12611 Change-Id: I9fd28c1a3babb862d08fec09f6cfc369beaad231 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494238Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#79313}
-
Lu Yahan authored
Change-Id: I55fa83f403464522ee8cebb8dd79e9aecdcc23a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492398 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79312}
-
Benedikt Meurer authored
Don't expose the line end table logic to V8DebuggerScript, but instead use the existing Script::GetPositionInfo() logic to resolve end line and column numbers for scripts. This also avoids having to copy (the potentially huge) line ends tables to std::vector's twice per script. Bug: chromium:1162229 Change-Id: I03365d42c320d462360bacc444f7fa97904a9748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494240 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79311}
-
jameslahm authored
LiftoffAssembler::RecordSpillsInSafepoint use Safepoint will be mistaken for v8::internal::Safepoint, which cause build failure on riscv64, change it to use SafepointTableBuilder::Safepoint Bug: v8:12665 Change-Id: I597ea04b0c8b466c2f5a322d22ed989d00bedc5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492397Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79310}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/19909af..27d089d Rolling v8/buildtools/linux64: git_revision:0725d7827575b239594fbc8fd5192873a1d62f44..git_revision:e3f114f46537152cfbdb553015518d1db1b812fd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/666eff9..2cfdaa8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6b28c1d..2bad9f0 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/5e0b0d0..7c9c220 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5de4327..aa5ea60 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/55aa202..3a67a50 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I51ce67dd1f61d7585c1e107ea24ae80b16a23b07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3496123 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79309}
-
- 28 Feb, 2022 6 commits
-
-
Nikolaos Papaspyrou authored
The following histograms have been deprecated, as they are superseded by V8.GC.Cycle.*.Young or not needed anymore (next to each, the corresponding isolate counter): - V8.GCScavenger (gc_scavenger) - V8.GCScavengerBackground (gc_scavenger_background) - V8.GCScavengeReason (scavenge_reason) - V8.GCScavengerForeground (gc_scavenger_foreground) - V8.GCBackgroundScavenger (background_scavenger) - V8.GCMarkCompactor (gc_mark_compactor) This CL removes the corresponding instrumentation in the code and the isolate counters. Bug: chromium:1154636 Bug: chromium:1299555 Change-Id: I62d28ff60ef47a058fe148c7855af8e2c1cc0aed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3487548Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#79308}
-
Milad Fa authored
Change-Id: I0938fa9cf52334cbf84a0b38b8e80b88431dff0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494439Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79307}
-
Milad Fa authored
inspector tests are not yet enabled as a few issues need to be solved related to endianness and IBM lane numbering. Change-Id: I3c5c87af45037033d4a112cb7e1da8b7923ce0f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3489244Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79306}
-
Jakob Gruber authored
Maglev is currently enabled only on x64; BUILD.gn knows about this through v8_enable_maglev, but v8_check_header_includes doesn't. It thus tries to compile maglev files on platforms that don't have maglev support yet. Add an explicit maglev exclude rule until we support other platforms. Bug: v8:7700 Change-Id: Iac991741c7d630dc4ed9f9fbf6df7656853cc743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494536 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79305}
-
Benedikt Meurer authored
This was originally introduced to address http://crbug.com/794941, to make the disassembly generation for WebAssembly modules lazy. Nowadays we no longer generate a text representation for the Wasm disassembly in V8, and this method always returns `false`. Bug: chromium:794941, chromium:1162229 Change-Id: I8b67e451a3657bf732615585577525aeea2b2f55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494236 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#79304}
-
Stephan Hartmann authored
Bug: chromium:957519 Change-Id: I33377e652f31e5dc54b8941a6b49ea8c76690597 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492522Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Stephan Hartmann <stha09@googlemail.com> Cr-Commit-Position: refs/heads/main@{#79303}
-