- 13 Aug, 2020 16 commits
-
-
Leszek Swirski authored
Rather than an Object array, use a Tagged_t array to store the elements of the off-heap string table. This matches the old on-heap string table's behaviour, and recovers memory regressions from that work. To be able to do this, this also introduces a new slot type, OffHeapObjectSlot. This is because CompressedObjectSlot assumes that the slot is on-heap, and that it can mask the slot location to recover the isolate root. OffHeapObjectSlot doesn't define an operator*, and instead provides a `load(const Isolate*)` method. The other slots also gain this method so that they can use it in slot-templated functions. Also, the RootVisitor gains an OffHeapObjectSlot overload, which is UNREACHABLE by default and only needs to be defined by visitors that can access the string table. As a drive-by, fix some non-atomic accesses to the off-heap string table, also using the new slot. Bug: chromium:1109553 Bug: chromium:1115116 Bug: chromium:1115559 Bug: chromium:1115683 Change-Id: I819ed7bf820e9ef98ad5d5f9d0d592efbb6f5aa6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352489 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#69381}
-
Santiago Aboy Solanes authored
Cleanups: * Additional offset was always 0 so it can be removed * Reordered arguements to take advantage of the implicit arguments Bug: v8:9708, v8:6949 Change-Id: I2168b80013958ab5b017280422fbfc9c7a137dcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349304Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69380}
-
Dominik Inführ authored
Locks the allocation mutex if SupportsConcurrentAllocation() returns true. Unifies code/condition from multiple usages. Bug: v8:10315 Change-Id: I684d12284e862df5d68986841e04ff25527422eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352775 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Updating external memory counters from Isolate::AdjustAmountOfExternalAllocatedMemory races with concurrent allocation. Bug: v8:10315 Change-Id: I42c8cad41280d3e14eb6745cb268ff6cdd958c75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352776 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Zeynep Cankara authored
This CL adds the functionality to filter IC Panel via double clicking on the event type on Timeline Panel. Bug: v8:10644 Change-Id: I47cdf87652a8f6fc25a5c1a5b0270d97ed9068b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352773 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69377}
-
Kim-Anh Tran authored
This extends the skip list feature from step over to step into. On a step into we can pass a skipList, which contains locations that we do not want to stop at. Bug: chromium:1105765 Change-Id: I70a4ded3f6a7eada14f54ae9c2f994c155c7305b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2345224Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#69376}
-
Zeynep Cankara authored
This CL adds the functionality to filter log events falling into the time range specified by the user via mouse events on timeline tracks. The log event selections on panels updated based on the selected time range. Bug: v8:10644 Change-Id: Iaf53896fd5c43cefea6d4c40bab5fcb136494b5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351670 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Clemens Backes authored
Bring the return value of {InterpretWasmModule} in sync with {CallWasmFunctionForTesting}, because the fuzzers now compare the two. R=ahaas@chromium.org Bug: chromium:1115431 Change-Id: I0abf79c4418a4e6cc7365a78148e5e71cf32231b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351678 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#69374}
-
Clemens Backes authored
While waiting for baseline compilation to finish (i.e. in the synchronous compilation API), do also contribute to compilation. This restores the performance from before switching to the jobs API, because all threads will now be used for synchronous compilation. Drive-by: Remove unused {CompilationStateImpl::background_compile_token} method. R=ahaas@chromium.org Bug: chromium:1101340, chromium:1113234 Change-Id: I61eddb813eb2779cdd41f11c8d840d63132d4360 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351671Reviewed-by: -
Manos Koukoutos authored
Changes: - Move some helper functions into WasmGraphBuilder. - Introduce call_mode and null_check as additional arguments to WasmGraphBuilderInterface::DoCall/DoReturnCall. - Introduce ValueType::is_strict_reference_type. - Improve usage of ValueType API. Bug: v8:9495 Change-Id: Id3fb9f0d7a4770475ac895b03b38bfa7f2fec252 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343083 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69372}
-
Dominik Inführ authored
Fixes race between concurrent allocation and incrementing max_old_generation_size_ in InvokeNearHeapLimitCallback(). Bug: v8:10315 Change-Id: If3586fd6164e784e66b0815d0200a27798127649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352771Reviewed-by:
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: Id7d5600e07cd0dfbce409925acf6047e019f501c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352769Reviewed-by:
-
Clemens Backes authored
TurboFan generates significantly less code than Liftoff for this test, and depending on timing it can happen that we need to generate thousands of functions, which takes some time and occasionally runs into timeouts. Thus disable tier-up for this test, such that we stick with the much longer Liftoff code, and reach the four separate code spaces quicker. R=ahaas@chromium.org Change-Id: I8e9a0cb466c1bdfef29aceeb5dd31aa96d05b70b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352490Reviewed-by:
-
Clemens Backes authored
Instead of hard-coding the logic for empty modules, just re-use the {TriggerCallbacks} method. This will also ensure that the {finished_events_} set will be populated correctly, such that callbacks added later will still receive the events. R=ahaas@chromium.org Bug: chromium:1101340 Change-Id: I6641f23dc0459d0b6591bb03cc8c1b99dcaa90ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351669Reviewed-by: -
Zeynep Cankara authored
This CL integrates a navigation controller to zoom in and out of timeline events and navigate in map panel using key events. Bug: v8:10644 Change-Id: I80496c086b0342b009bbbc3d45282b95cbe82e0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351659 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Santiago Aboy Solanes authored
Since it will be patched in later in the cases where it will be used, there is no need to have it as a parameter. Bug: v8:7790 Change-Id: I93b27f3baf8c3841a60f5ac5ed09993d1caf19bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351667Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69366}
-
- 12 Aug, 2020 17 commits
-
-
Bill Budge authored
This reverts commit 1b35c0fa. Reason for revert: Seems to reliably break a numerics test: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31516 Original change's description: > Improve NumberToString when cache miss and Smi > > Cache miss was handled in runtime before. This change add fast path for > Smi in this case. > > Perf show 30% improvement for the following example. > Before 67 ms > After 42 ms > > const start = new Date(); > const MAX = 1000000; > for (var i = 0; i < MAX; i++) { > i.toString(); > } > const end = new Date(); > console.log("Time :"+ (end-start)); > > Change-Id: I162e9c35f58551ca6a5a0efe79fb7c7b482a8594 > Bug: v8:10477 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332866 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69362} TBR=jgruber@chromium.org,leszeks@chromium.org,duongn@microsoft.com Change-Id: I80f6bdb0464c0034e6c4a16478848618cef7e046 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351389Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69365}
-
Milad Farazmand authored
Change-Id: Ic0e82d752046349d9f21f0001b84b23d73065fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2353032Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69364}
-
Frank Tang authored
Fix containing() w/ n point to surrogate tail. Bug: v8:6891 Change-Id: I4d7e4083ba409eecaefaf2ec5c67b7226bd7c97c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2348208 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Z Nguyen-Huu authored
Cache miss was handled in runtime before. This change add fast path for Smi in this case. Perf show 30% improvement for the following example. Before 67 ms After 42 ms const start = new Date(); const MAX = 1000000; for (var i = 0; i < MAX; i++) { i.toString(); } const end = new Date(); console.log("Time :"+ (end-start)); Change-Id: I162e9c35f58551ca6a5a0efe79fb7c7b482a8594 Bug: v8:10477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332866 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: -
Zeynep Cankara authored
This CL changes the panel layout by implementing a grid format. The new layout displays Map and IC panel side by side and making it easier to control the position of panels. Bug: v8:10644 Change-Id: Ic9b48459dd67741c1c39ed2c350ee7c552f1cc92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343081 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69361}
-
Santiago Aboy Solanes authored
The (now unique)PersistentHandles container follows this path: 1) PersistentHandles created via PersistentHandlesScope inside of CompilationHandleScope 2) Owned by OptimizedCompilationInfo 3) Owned by JSHeapBroker 4) Owned by the broker's LocalHeap 5) Back to the broker for a brief moment (after tearing down the LocalHeap as part of exiting LocalHeapScope) 6) Back to OptimizedCompilationInfo when exiting the LocalHeapScope. There is a special case in GenerateCodeForTesting where the JSHeapBroker will not be retired in that same method. In this case, we need to re-attach the PersistentHandles container to the JSHeapBroker. The identity map of the persistent & canonical handles also gets passed around like the persistent handles. The only difference is that is created in the CanonicalHandleScope (i.e step 1) is different). Bug: v8:7790 Change-Id: I2da77a7e08f3fd360a46b606c5fbda08c0af27df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332811 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#69360}
-
Thibaud Michaud authored
Remove extra source positions added by Liftoff to help with OSR. Compute the return address based on the call source position instead. R=clemensb@chromium.org Bug: v8:10337 Change-Id: Ifc14e924825b670ebaed920bb19d0fa09eca1b23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351666Reviewed-by:
-
Zeynep Cankara authored
This CL maximises the space use in between panels and fixes asymmetries in the Web app to make the UI panel views more compact and increase accessibility of the web app for different screen size. Bug: v8:10644 Change-Id: I07bf6317db2cf3fa59204120276f0f885e356e6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351660Reviewed-by:
-
Sathya Gunasekaran authored
FeedbackSlotIterator abstracts over the different IC states and provides an unified interface to iterate over the map and handlers in the IC. Bug: v8:10582 Change-Id: I67861bfbd33d82e8b1ad06156fbf6fd72775321c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349295 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Move external memory counters out of IsolateData back into Heap. The class ExternalMemoryAccounting now stores all counters and is responsible for updates. This change will allow turning counters into atomic variables. Bug: v8:10315 Change-Id: I2abeda298d3cfcc630fd04ca78a3d6d703e3b419 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346647Reviewed-by:
-
Thibaud Michaud authored
DebugInfo::RemoveBreakpoint was never called. Call it in WasmScript::ClearBreakPoint to remove the breakpoint from the list and recompile the function. R=clemensb@chromium.org Bug: v8:10147 Change-Id: I0d11bdab102eeacc2a5f9ae9b4a20e8c900b26f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351665Reviewed-by:
-
Dominik Inführ authored
The only user was ArrayBufferTracker which got removed already. Bug: v8:10064 Change-Id: I97f8ed0727abec01b3b65ba965026f61fb9acb85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346406 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Since the StringTable can only contain old strings, skip iterating it when SkipRoot::kOldGeneration is set. Bug: chromium:1115132, chromium:1115100 Change-Id: I6d065a0ea7f3142c5d474eb0919e801e13976f6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351664 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Backes authored
A minor fix to the {InterpretAndExecuteModule} function: We instantiate the module twice. If the first instantiation worked, then also the second instantiation must succeed. Plus minor drive-by cleanup. R=ahaas@chromium.org Bug: chromium:1113681 Change-Id: Ib897cb1907152cdd9b0ed2b513a6c8217a3f400c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349288 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Dominik Inführ authored
ArrayBufferTracker was superseded by ArrayBufferList and ArrayBufferSweeper. Now that ArrayBufferSweeper is used in production, we can remove the unused ArrayBufferTracker mechanism. Bug: v8:10064 Change-Id: I479169c76b6c5c634672024f77e689bb64a36504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339105Reviewed-by:
-
Santiago Aboy Solanes authored
Also remove the unused StoreFixedDoubleArrayHoleSmi Bug: v8:9708, v8:6949 Change-Id: I07b6e83520a6ac667a4bd08d90510931141719a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349303Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69350}
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:6949 Change-Id: I3fa0b3d76fb6343eb986321e40cee673b6c30670 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349302Reviewed-by:
-
- 11 Aug, 2020 7 commits
-
-
Sathya Gunasekaran authored
Bug: v8:10582, v8:9684 Change-Id: I4b53b161f9154212568856206ff011e61975e431 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247652 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Bill Budge authored
This reverts commit f4548e75. Reason for revert: Breaks some gap resolver tests: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim/24204 Original change's description: > [regalloc] Place spill instructions optimally > > Design doc: > https://docs.google.com/document/d/1n9ADWnDI-sw0OvdSmrthf61prmDqbDmQq-NSrQw2MVI/edit?usp=sharing > > Most of this change follows directly what is discussed in the design > document. A few other things are also changed: > > - PopulateReferenceMapsPhase is moved after ResolveControlFlowPhase so > that it can make use of the decision regarding whether a value is > spilled at its definition or later. > - SpillSlotLocator is removed. It was already somewhat confusing, > because the responsibility for marking blocks as needing frames was > split: in some cases they were marked by SpillSlotLocator, and in > other cases they were marked by CommitSpillsInDeferredBlocks. With > this change, that split responsibility would become yet more > confusing if we kept SpillSlotLocator for the values that are spilled > at their definition, so I propose a simpler rule that whatever code > adds the spill move also marks the block. > - A few class definitions (LiveRangeBound, FindResult, > LiveRangeBoundArray, and LiveRangeFinder) are moved without > modification from register-allocator.cc to register-allocator.h so > that we can refer to them from another cc file. > > Bug: v8:10606 > Change-Id: I374a3219a5de477a53bc48117e230287eae89e72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285390 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69345} TBR=rmcilroy@chromium.org,seth.brenith@microsoft.com,thibaudm@chromium.org Change-Id: Ie57109a009ee7ee541a6ff6f89901d1ac99027d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2350440Reviewed-by:
-
Ng Zhi An authored
This is a reland of 57242a05 no-sse4.1 builds were failing due to missing simd-scalar-lowering for s128.const, this reland adds that implementation. Original change's description: > [wasm-simd][arm] Use vmov to move all ones to register > > vceq(dst, dst, dst) does not seem to always set the register to all > ones. The right way should be be to use vmov (immediate) anyway. This > was not supported in the assembler yet, so we need changes to the > assembler, diassembler, and simulator. > > There is an unfortunate fork in logic in the simulator, due to the way > the switches are set up, vmov (imm) logic is duplicated across two > different cases, because the switch looks at the top bit of the > immediate. Refactoring this will be a bigger change that is irrelevant > for this bug, so I'm putting that off for now. Instead we extract the > core of vmov (imm) into helpers and call it in the two cases. > > Bug: chromium:1112124 > Change-Id: I283dbcd86cb0572e5ee720835f897b51fae96701 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2337503 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69315} Bug: chromium:1112124 Change-Id: Id450e5cea41f7a569e49be8386a7788ca8f00658 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346937Reviewed-by:
-
Seth Brenith authored
Design doc: https://docs.google.com/document/d/1n9ADWnDI-sw0OvdSmrthf61prmDqbDmQq-NSrQw2MVI/edit?usp=sharing Most of this change follows directly what is discussed in the design document. A few other things are also changed: - PopulateReferenceMapsPhase is moved after ResolveControlFlowPhase so that it can make use of the decision regarding whether a value is spilled at its definition or later. - SpillSlotLocator is removed. It was already somewhat confusing, because the responsibility for marking blocks as needing frames was split: in some cases they were marked by SpillSlotLocator, and in other cases they were marked by CommitSpillsInDeferredBlocks. With this change, that split responsibility would become yet more confusing if we kept SpillSlotLocator for the values that are spilled at their definition, so I propose a simpler rule that whatever code adds the spill move also marks the block. - A few class definitions (LiveRangeBound, FindResult, LiveRangeBoundArray, and LiveRangeFinder) are moved without modification from register-allocator.cc to register-allocator.h so that we can refer to them from another cc file. Bug: v8:10606 Change-Id: I374a3219a5de477a53bc48117e230287eae89e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285390 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#69345}
-
Seth Brenith authored
I noticed a pattern that has been copied around to various places and thought a helper function might be appropriate. Change-Id: I8944ac5166c649f15c09f587308406cab317b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2346766Reviewed-by:
-
Milad Farazmand authored
Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468Reviewed-by:
-
Santiago Aboy Solanes authored
Also remove ParameterMode Bug: v8:9708, v8:6949 Change-Id: Iaf51004472a4aef0acf29d01497b1047247dc83d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349301Reviewed-by:
-
