- 26 Nov, 2020 21 commits
-
-
Junliang Yan authored
Change-Id: I79fc56578878f326725272d67a9936b04b22a02f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562119Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#71438}
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I58a49461723d8444fca8c2a3b0f3e75367604c76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562257Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#71437}
-
Mythri A authored
1. Don't optimize small functions early when tiering up from ignition to Turboprop. 2. When tiering up from Turboprop to Turbofan scale the ticks so we optimize small functions at roughly same time as default. 3. Adjust for the fact that profiler ticks are updated before performing the ShouldOptimize check when tiering up from TP -> TF. Bug: v8:9684 Change-Id: I6b68eed70abb9a86f9b99eac9c0b9a1fe6346027 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560725 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#71436}
-
Leszek Swirski authored
Make the IsEqualTo equality type parameter a template parameter, and add an option to skip the length check for cases where the length is known (e.g. in string table key comparisons). Change-Id: I893ac880ec1e830a50ba6d8f58f375ed96d6e14e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562247 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71435}
-
Camillo Bruni authored
- Add ToolTip helper that tracks scrolling target elements - Auto hide if the target scrolls out of view - ToolTip position depends on target position - Add basic tooltips for maps in the transition view, entries in timeline tracks and the source panel Drive-by-fix: - Move events.mjs to view/ folder - Add basic toString methods on various log entries - Add requestAnimationFrame update support for V8CustomElement Bug: v8:10644 Change-Id: I1059733cd094a986b715547b3d5747eefbc54bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551103 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71434}
-
Junliang Yan authored
Because actual condition code used by s390/ppc does not distinguish between signed and unsigned, we need to use a generic enum class for liftoff which needs to deal with signed/unsigned case differently. Change-Id: Ia870dc30788037996dc1c65de0117eac7d941697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560603 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Michael Achenbach authored
This passes the --simulate-errors flag for differential fuzzing with a probability of 0.01%. No-Try: true Bug: chromium:1152412 Change-Id: I3146c0ea5706be8b5ec13ee8740e1d185e008075 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562248Reviewed-by:
-
Thibaud Michaud authored
Use the overload of NativeModule::PublishCode that accepts a vector of codes to only lock/unlock once per batch. R=ahaas@chromium.org Bug: v8:11164 Change-Id: I6428d3d9cec8526bdfef223d7ba03b35bad9e1eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562251Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#71431}
-
Michael Achenbach authored
This adds a d8 flag --simulate-errors, which on shutdown will cause certain errors. This enables testing the reliability of sanitizers. This will cause a fatal error, a dcheck (if available) or a violation that can be detected with one of the following sanitizers: ASAN, UBSAN, MSAN, CFI. The same flag used in differential fuzzing will cause an error subsumed with the error state "fake_difference". Bug: chromium:1152412 Change-Id: I4b36c6fe716797004d634263617d22ca67b05600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554999 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: Idad2d6464ed29c8aa6d7d0665b84525c0f954df8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562245Reviewed-by:
-
Clemens Backes authored
This specific case was not implemented or tested before. Implementing it actually simplifies some of the existing logic, since StepOut can now reuse the generic logic in debug.cc for all cases (Wasm->Wasm, Wasm->JS, JS->Wasm). Drive-by: 1) Fix typo ("skip" -> "step"). 2) Move the check for Liftoff code from debug.cc to wasm-debug.cc, where it fits better. 3) Remove a TODO which is done already. R=thibaudm@chromium.org, szuend@chromium.org Bug: chromium:1145176 Change-Id: I415ca1d8bacef5b21bf1dafd9e16417ec2d12c7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560719 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#71428}
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I64d0d2a4f07add4adef78136b303881a900474a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560198Reviewed-by:
-
Vicky Kontoura authored
This CL re-enables use of the generic js-to-wasm wrapper for asm.js modules. Bug: v8:10982 Change-Id: I0aa6cd9387bfd7b3fc3cab18f09c7f78ec24fbb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562238Reviewed-by:
-
Santiago Aboy Solanes authored
Scopes in V8 are used to guarantee one or more properties during its lifetimes. If a scope is not named e.g MyClassScope(args) instead of MyClassScope scope(args) it will get created and automatically destroyed and therefore, being useless as a scope. This CL would produce a compiling warning when that happens to ward off this developer error. Follow-up to ccrev.com/2552415 in which it was introduced and implemented for Guard classes. Change-Id: Ifa0fb89cc3d9bdcdee0fd8150a2618af5ef45cbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555001 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#71425}
-
Eric Seckler authored
To unblock linux-perfetto-rel builds. The events were added in https://chromium-review.googlesource.com/c/v8/v8/+/2540548 and https://chromium-review.googlesource.com/c/v8/v8/+/2540552. Change-Id: I48ac0f8612fd95fa555457e68b6e4394862937fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560304 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#71424}
-
Leszek Swirski authored
Fix the python call to sys.executable, and sort imports Change-Id: I948291e0835c79445108f215e55885fdb2c01052 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560592 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71423}
-
Jakob Kummerow authored
Fixed: chromium:1151890 Change-Id: I26f5c76494a9ff3f5a141f381e1c9a543e368571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561618 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71422}
-
Omer Katz authored
Both sample are essentially the same up to string constants since cppgc's default platform started using libplatform. The only diff between the sample is whether we call v8::V8::IntializePlatform or cppgc::InitializeProcess. Drive-by: replace CPPGC_BUILD_IN_V8 with CPPGC_IS_STANDALONE which is more descriptive. Bug: chromium:1056170 Change-Id: I8fdeb59c3345af77f1bccd8b93255ab39b4d3181 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557516 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: -
Omer Katz authored
Bug: chromium:1056170 Change-Id: I3779ed504235e3aa3fbecb5f14dd2d43d9907c07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560201Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71420}
-
Liu Yu authored
Port: 3836aeb0 Change-Id: I2d852f3dbbb74ebd7ee176cdd398cf3e6b207772 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561422 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71419}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/29207aa..33f080d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8820ab8..b9a5e83 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0a241223c26cdfb3ebe26d2588c150cfb95ef7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560687Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71418}
-
- 25 Nov, 2020 19 commits
-
-
Shu-yu Guo authored
Bug: v8:10961 Change-Id: I3bd51fa1eaa448e08a99395f30c0322f23677fcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2559138Reviewed-by:
-
Milad Fa authored
Change-Id: I3bb6a6822dea5ce6aa3e12f3137861a2f93bbb68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560604Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71416}
-
Dominik Inführ authored
Scopes aren't used anymore. Change-Id: Id233974e3b9760560deb85d822218efe9ab9f896 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560199 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: I6146f5e566884b1d24ecb9ee6f154ad581ef2b66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560722 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
This reverts commit 873e5aa3. Reason for revert: Flaky cctest/test-incremental-marking/IncrementalMarkingUsingTasks Original change's description: > Reland "Reland "[Heap]: Convert Sweep to Job"" > > This is a reland of b16c7e5b > > Issue: ShouldYield is called multiple time. > Fix: ConcurrentSweepSpace returns false if not done (yielding), to avoid > calling it again. > > Issue: failing test-streaming-compilation > Safe to reland after > https://chromium-review.googlesource.com/c/v8/v8/+/2507379 > > Original change's description: > > Reland "[Heap]: Convert Sweep to Job" > > > > This is a reland of 795c0b1c > > Reason for revert: > > TSAN failures https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33884 > > Safe to reland as-is with fix to EagerUnmappingInCollectAllAvailableGarbage > > https://chromium-review.googlesource.com/c/v8/v8/+/2502809 > > > > Original change's description: > > > [Heap]: Convert Sweep to Job > > > > > > max concurrency is inferred from queue size for OLD_SPACE & MAP_SPACE. > > > Extra Sweeper::TearDown() in MarkCompactCollector::TearDown() is needed > > > to cancel job. > > > > > > Change-Id: Iafba7d7d24e8f6e5c5a1d5c0348dea731f0ac224 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2480783 > > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#70767} > > > > Change-Id: Id9a5baceed4664f53da39597af56a2067e4f3c6f > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502808 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70845} > > Change-Id: I32de9faebdbd2f7f6d7f9a9525871fc691fb3f2c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507378 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71347} TBR=ulan@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Issue: ShouldYield is called multiple time. Issue: failing test-streaming-compilation Change-Id: Ic82221d118d7a1f6ea98021e03f4d4b95368b01c Bug: v8:11198 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561198Reviewed-by:
-
Clemens Backes authored
Function tables have been removed from the scope object in https://crrev.com/c/2507696, hence the code for printing them is dead now. R=bmeurer@chromium.org Change-Id: Ib36fb314ae54468239737f100a6594d8d2031218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557982Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71412}
-
Clemens Backes authored
After preparing Liftoff, TurboFan, and the interpreter for this change, we now store the memory offset as uint64_t. {LoadLane} and {StoreLane} were added after the TurboFan refactoring, so those two are adapted similar to the other memory operations. TBR=manoskouk@chromium.org Bug: v8:10949 Cq-Include-Trybots: luci.v8.try:v8_win64_msvc_rel_ng Change-Id: I8f3084c21a7d99f72df1bc18c2b507c4e84570cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560720 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Vasili Skurydzin authored
Change-Id: I63446404789a33b97db2bacee2faf3a04e137ed5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558973Reviewed-by:
Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Leszek Swirski authored
This reverts commit cf9a28b6. Reason for revert: TSAN failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/34374? Original change's description: > [wasm] Reduce job priority once baseline compilation finishes > > This Cl changes the priority of baseline compilation from kUserVisible > to kUserBlocking. Once baseline compilation finishes, the priority is > reduced to kUserVisible. The reason for using kUserBlocking is that > thereby TurboFan compilation cannot block Liftoff compilation anymore. > Additionally, kUserBlocking is quite appropriate, as the initial > compilation does block a whole section of a web app from execution. > > R=clemensb@chromium.org > > Bug: v8:11088 > Change-Id: Ifde42d20f36d4c0a5122b0008311ccdffbb60e48 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519559 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71404} TBR=ahaas@chromium.org,clemensb@chromium.org Change-Id: I9a975c4c43189015491b08d3a98de991d8167daf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11088 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560200Reviewed-by:
-
Vasili Skurydzin authored
platform Change-Id: I644970a5dfe3794d2b9c90719b3a1b2b87c2f5e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558971Reviewed-by:
-
Michael Lippautz authored
Refactor write barriers and split calls, as e.g. DijkstraWriteBarrier also contained logic for recording slots (cards) for the young generation. The new API exposes the following: - GetWriteBarrierType(): Retrieving the type of barrier that must be emitted; - DijkstraWriteBarrier(), DijkstraWriteBarrierRange(): Dijkstra-style write barriers; - SteeleWriteBarrier(): Steele-style write barrier; - GenerationalBarrier(): Barrier for recording slots when using multiple generations; Compilers running with -O3 optimize the DijkstraWriteBarrierPolicy down to the same instructions as before the split. Change-Id: If68839cc6357b2f568986c9ce8ca753b1e96a70a Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557514 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Andreas Haas authored
In the generic wrapper we popped the wrong number of parameters off the stack. We always popped the number of parameters needed by the generic wrapper, according to the signature. The correct number though is max(parameters provide, parameters needed). R=victorgomes@chromium.org, thibaudm@chromium.org CC=vkont@google.com Bug: v8:10982 Change-Id: If9b8d4dbe093eb6df08ddf9f3594d5c60b9be33f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558317 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71406}
-
Mythri A authored
With concurrent inlining, the inlining phase happens on the background thread and the data needed for the inlining phase is serialized on the main thread. The serialization phase tries to gather data about functions called which is sometimes more expensive than inlining phase itself. So it's better not to use concurrent inlining for TurboFan compilations when tiering up from Turboprop to TurboFan. Turboprop compilations don't inline and hence it is OK to continue using concurrent inlining for Turboprop compilations. Bug: v8:9684 Change-Id: Ib529905213fa7f0df84ee52218adc27f7c219f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557504 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Andreas Haas authored
This Cl changes the priority of baseline compilation from kUserVisible to kUserBlocking. Once baseline compilation finishes, the priority is reduced to kUserVisible. The reason for using kUserBlocking is that thereby TurboFan compilation cannot block Liftoff compilation anymore. Additionally, kUserBlocking is quite appropriate, as the initial compilation does block a whole section of a web app from execution. R=clemensb@chromium.org Bug: v8:11088 Change-Id: Ifde42d20f36d4c0a5122b0008311ccdffbb60e48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519559 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The gn variable ios_use_goma_rbe is ignored since the CL https://crrev.com/c/2555117 landed, so stop overriding it on the bots (it is now always enabled which is what the bots want). Bug: none Change-Id: Iaa085dd1fd0559a41372744ed4c4491c4b5d9908 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558218Reviewed-by:
-
Hannes Payer authored
Change-Id: If01a247f2bae3c90708f9f8355325fa5b7113913 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560196Reviewed-by:
-
Eric Seckler authored
The dependency on v8_tracing supplies include paths & dependencies on the tracing library when built with v8_use_perfetto. This is an attempt to fix the linux-perfetto-rel builder [1], which is currently erroring: FAILED: obj/v8/cppgc_base/sweeper.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) In file included from ../../v8/src/heap/cppgc/sweeper.cc:24: In file included from ../../v8/src/heap/cppgc/stats-collector.h:17: In file included from ../../v8/src/heap/cppgc/trace-event.h:9: In file included from ../../v8/src/tracing/trace-event.h:12: gen/third_party/perfetto/protos/perfetto/trace/track_event/debug_annotation.pbzero.h:9:10: fatal error: 'perfetto/protozero/message.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [1] https://ci.chromium.org/p/chromium/builders/ci/linux-perfetto-rel Bug: chromium:1056170 Change-Id: Id5a382d472139f7abe5ead67ec6eed2f8395e6b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560257 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
The logic to detect if a 'br' instruction is a branch or a return was duplicated in function-body-decoder-impl.h and in both interfaces. Apart from code duplication, this structure also made it hard to implement planned compiler improvements. This CL removes this duplication by upgrading BrOrRet (that already existed in both Liftoff and Turbofan interfaces) to an interface function and using it for unconditional branches. Change-Id: Ia04952cce621335268fc40ef9544a99b61dc7da3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557515 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a minor refactoring before fixing actual issues. 1) The update of the {per_isolate_data_} is moved into {FloodWithBreakpoints}, which is already taking the mutex. 2) The {PrepareStep} method takes a {WasmFrame*} directly instead of its ID. In most cases, this prevents the creation of an additional stack frame iterator. R=thibaudm@chromium.org Bug: chromium:1145176 Change-Id: I1a6cd15550bbb4ef78ba522427bed1c23185569e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558318Reviewed-by:
-
