- 18 Nov, 2020 27 commits
-
-
Milad Fa authored
Change-Id: I2f6e76d93309f44f90a24c2ce93f324b44a8fc6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544921Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71271}
-
Maya Lekova authored
This is a temporary workaround until the root cause is fixed. Bug: v8:11178 TBR=jgruber@chromium.org Change-Id: I04ffaa83b88bca3d0db8079c1e798986e6bfcb62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547294Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#71270}
-
Camillo Bruni authored
- introduce view specific helper.mjs module - clean up some imports Bug: v8:10644 Change-Id: I0497c1a962c90f61f2beca667aca4a3f53a11e59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545705Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71269}
-
Jakob Kummerow authored
Mac-arm64 devices always have support for it. Found by thakis@chromium.org Change-Id: Id2dd9d53b66715efe8b4f7f0019d1ba06289c359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547281Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71268}
-
Frank Tang authored
Bug: v8:9613, v8:10447 Change-Id: Iff43b298c6edaa9b258038ae15406d5df209e8b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543266 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71267}
-
Frank Emrich authored
AddToDictionaryTemplate in literal-objects.cc was missing several cases when handling the overwriting between properties with statically known and dynamically computed names. This led to wrong enumeration orders in class prototypes created from class templates. Bug: v8:11158 Change-Id: I7381b4680ec533bd307a6c32d75c8a66394869df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536464 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71266}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/0e7319c0..36d2d2d34 Bug: v8:7834 Change-Id: If35f50920cddaad0dd8e12029d153c1e2f478aeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545572Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#71265}
-
Jakob Gruber authored
Megamorphic load builtins are a performance optimization when current feedback is megamorphic. We can't make this assumption for shared NCI code though, since feedback in other native contexts may *not* be megamorphic, and we'd thus miss out on necessary feedback collection. Bug: v8:8888 Change-Id: I2adc5ef9a6b021b35cf26f975c79228d556bf94f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546694 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#71264}
-
Jakob Gruber authored
... to --turbo-dynamic-map-checks. With the upcoming use in NCI code, this feature is no longer used exclusively by Turboprop. Bug: v8:8888 Change-Id: I61e01db086fd2e8566d2e2a09574be74b6e5a7bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546693 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:11166 Change-Id: I39d2b7e926d9954c25dec149a741c24d6a0e7353 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545707 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Andreas Haas authored
There is a flag in the WebAssembly trap handler that is set whenever WebAssembly code is entered, and that is reset when WebAssembly code is left. In runtime functions we have DCHECKs in place that check the value of this flag. This flag is only needed when trap handlers are enabled though. When trap handlers are disabled, the flag is not enabled and disabled consistently. DCHECKs should therefore only check the flag value when trap handlers are actually enabled. R=manoskouk@chromium.org CC=vkont@google.com Bug: v8:10982 Change-Id: I3325f6057ff8d9c39d029ef04c55792162d927f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545708Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71261}
-
Andreas Haas authored
This CL implements the spec change done in https://github.com/WebAssembly/reference-types/pull/116. R=manoskouk@chromium.org Bug: v8:10994 Change-Id: Ic2b4e0a52af225b5640447fe051a9c36e6d41be2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534818 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This has similar performance as the thread_id check. It removes the need to get the isolate for this check though, so it's a net positive. Bug: v8:7790 Change-Id: I329bb9d5fe695fb9ef4990ba3593703b1eedca0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546690Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71259}
-
Patrick Thier authored
Some tests explicitly set the --always-opt flag, but they are not ignored when the testrunner is invoked with variant="jitless" or variant="nooptimization". This CL implies --opt from --always-opt and excludes --always-opt when the testrunner is invoked with jitless or nooptimization variants. Change-Id: I49ebc3907666c462aa09a294a39a504a0c90de96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544548Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#71258}
-
Dominik Inführ authored
AssembleCode used CcTest::i_isolate() to load the isolate, however this might not be the isolate that should be used. Therefore take the isolate as an explicit argument. Note that this changes behavior of ExecuteMemoryAccess in test-sync-primitives-arm.cc. I think this test inadvertently created the assembly code in the isolate of another thread, while it didn't use the isolate it sets the handle scope up for. This change is required for relanding https://crrev.com/c/2543399. Bug: v8:10315 Change-Id: I754f4b45cec93727309fa73723011afe976f3689 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546682Reviewed-by:
-
Santiago Aboy Solanes authored
Pointer compression is not supported in arm32 and we will not encounter those MachineRepresentations. Bug: v8:7703 Change-Id: I72c94d57b27710bdca54d649755a91e869b4947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546686 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This CL fixes a spot (pointed out by Mythri) in which it was possible to start running unoptimized bytecode even if cached NCI code was present. Previously, the CompileLazy builtin would skip the runtime and start running bytecode immediately if the SharedFunctionInfo was already compiled; any NCI code was ignored. This CL changes the CompileLazy builtin to additionally check the SFI::may_have_cached_code bit. If set, call into the (new) function Runtime::kTryInstallNCICode to try and install NCI code. Bug: v8:8888 Change-Id: Icbee9f0780f9b65e9339f1a958f5b28abe42c810 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546680Reviewed-by:
-
Maya Lekova authored
This CL introduces a new fast_api_call_target field on the isolate, which is set by Turbofan before making the fast call. It then uses the field when creating a stack sample and stores it in the existing external_callback_entry used for regular API callbacks. The CL also adds a cctest with simple usage scenario and introduces a minor refactoring in test-api.cc. Design doc: https://docs.google.com/document/d/1r32qlPzGz0P7nieisJ5h2qfSnWOs40Cigt0LXPipejE/edit Bug: chromium:1052746 Change-Id: I2dab1bc395ccab0c14088f7c354fb52b08df8d32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488683 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#71254}
-
Leszek Swirski authored
This removes the dependency on Lua for running gcmole, and Python's expressiveness lets us clean up the code a bit, including getting rid of global variables, embedding the multiprocessing (removing the need for a separate `parallel.py`), and using difflib for printing the test expectation diff. Bug: v8:11169, v8:8590, chromium:1097212 Change-Id: If0ab5ea6f764864855d73cd0ba63cb37c1823955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543927 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Remove more deprecated APIs after upgrading uses in chrome. Bug: v8:11165, v8:10641, v8:8124, chromium:1096017 Change-Id: If0379806d73c2dbc877f09603b15a5a68dc75d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543926Reviewed-by:
-
Nico Hartmann authored
NOTRY=true TBR=szuend@chromium.org Bug: v8:11176 Change-Id: If10560a5c36e22ef0cd9f3c7344b4dc30d3bcf02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546687Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#71251}
-
Georg Neis authored
Bug: v8:10927 Change-Id: I37d3b591ceedeec0239fcec66d41bcf26f8503bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546683 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: Ifd47a3256ec23d2c62ff7bbaf4de226fdfd3f68d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546123Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71249}
-
Jakob Gruber authored
To be unskipped once root cause is fixed. Bug: v8:11166 Change-Id: I03c3ac9a7e715fce7683d230965bd92a410c8f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546681 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c854b81..a3c2a5d Rolling v8/third_party/aemu-linux-x64: FwzgY9X10eGIOA-l6ukRroKmBYo1As7yOiPDRfc6PxAC..ZJSAA8Pwi2mDf7nU7eRK7e3lmUHyrNUgCmzdRwsMbnMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f92a763..80f68fb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d4e6fb6..868f530 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c72342c..1b039cb TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic47da443ac8cd3b2ce6a83e3d80a54df8df7db8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546167Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71247}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I71fabf7628ec13440585c24381f5ba89e4df03d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543168Reviewed-by:
-
Zhi An Ng authored
These are prototype instructions, and were missing validation checks for lane immediates. Bug: chromium:1149040 Change-Id: I22537061e26980a1aa0b3944839ab947e5351d9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543164Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71245}
-
- 17 Nov, 2020 13 commits
-
-
Frank Tang authored
This is a reland of 915f729a Original change's description: > Add regression tests for 4 calendar bugs > > These bugs was fixed by ICU68 > > Bug: v8:10526, v8:10527, v8:10528, v8:10529 > Change-Id: I8d0dcb52d849f742e0a29314ac8a148370f60a1a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527086 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71062} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Bug: v8:10526 Bug: v8:10527 Bug: v8:10528 Bug: v8:10529 Change-Id: I8857fb8c104bb4bede8fe816574bfd46ccbcd082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71244}
-
Milad Fa authored
Change-Id: Ic5d52b3a7be345cfc4f104f83f23a4deb5972e4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545622Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71243}
-
Santiago Aboy Solanes authored
In https://crrev.com/c/v8/v8/+/2536465 we added acquiring the lock in WriteToFlat. Then, acquiring in TryStringToDouble not only is not necessary but also has undefined behaviour. This was causing timeouts and meant the tests were disabled in https://crrev.com/c/v8/v8/+/2543398. Bug: v8:7790, v8:11171 Change-Id: Iaab4e5079bac96786e536a2e4b766e93ea17e2c4 Fixes: v8:11171 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544544Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71242}
-
Dominik Inführ authored
Guard for extremely large and small values passed to Isolate::AdjustAmountOfExternalAllocatedMemory from the embedder. Bug: chromium:1147372 Change-Id: Ib1470bdf2dd16cbc6e61dd1bca97fa5a66f04c77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543925 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
Use the recently added -mmark-bti-property Clang flag to add GNU_PROPERTY_AARCH64_FEATURE_1_BTI to the ELF GNU program properties. Bug: v8:10026 Change-Id: Id35a60c9f5a8b3019313d56a142ab8f481e095a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543934Reviewed-by:
-
Clemens Backes authored
It took me a while to figure out how to set up everything to run the fuzzer locally. These improved error messages would have helped to find errors earlier. R=machenbach@chromium.org Bug: chromium:1142437 Change-Id: I414de0a8448cd81fdbf999cc7c3c8cf9394354f6 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543397 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 800307f6. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release%20builder/1258 Original change's description: > [wasm][memory64] Prepare Liftoff for ptrsize offsets > > This CL prepares the LiftoffAssembler interface for uintptr_t offsets. > Many places can still only handle 32-bit values, but after this CL we can > start storing the offsets as uintptr_t in the memory access immediates. > Some TODOs are placed to extend code generation for 64-bit additions, if > memory64 is enabled. > All of this will be addressed in follow-up CLs. > > R=manoskouk@chromium.org > > Bug: v8:10949 > Change-Id: Id3b9b8aa555ab41f082ba012f4f8d80586c35b89 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529452 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71236} TBR=clemensb@chromium.org,manoskouk@chromium.org Change-Id: I6246d2f16bc44b328915c6a66e9933f516459038 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544546Reviewed-by:
-
Santiago Aboy Solanes authored
Make the three map's bitfields use release/acquire semantics. This ensures, for example, that when we set the number of own descriptors on the map we will do so with a release store. Also, start reading and writing said bitfields concurrently when concurrent inlining is enabled. Note the BIMODAL_ACCESSOR_WITH_FLAG_B macro which enables this. Bug: v8:7790 Change-Id: I16561d8e065c50ce272b085d9606b98e37922633 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536640Reviewed-by:
-
Clemens Backes authored
This CL prepares the LiftoffAssembler interface for uintptr_t offsets. Many places can still only handle 32-bit values, but after this CL we can start storing the offsets as uintptr_t in the memory access immediates. Some TODOs are placed to extend code generation for 64-bit additions, if memory64 is enabled. All of this will be addressed in follow-up CLs. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: Id3b9b8aa555ab41f082ba012f4f8d80586c35b89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529452 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Nico Hartmann authored
TBR=solanes@chromium.org Bug: v8:11171 Change-Id: I8639f9becbb9fa8faa0a1823d58a83bf706d0fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543398Reviewed-by:
-
Milad Fa authored
Change-Id: Ie09b35d2e2cd28996bb7ebaa54175c14a4f5cea8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543162Reviewed-by:
-
Manos Koukoutos authored
Changes: - Fix read_value_type description. - Make sure read_value_type always emits an error for an invalid type. Remove checks for errors at call sites. - (Drive-by) Fix validation flags in DecodeLocals. Change-Id: I82bd8a61f0e26f39506fc6e4ab4be331dfe24ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526390 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71233}
-
Vicky Kontoura authored
This CL increases the budget for the tiering strategy of the js-to-wasm wrappers from 6 (which was initially picked at random, as the feature was experimental) to 1000 calls (which is picked based on benchmarking). The high-level rationale behind such a choice can be summarized in the following: - The generic wrapper is not that much slower than the specific wrappers, so it can handle up to some thousands of calls quite well. - After that, the generic wrapper starts lacking compared to the specific wrappers, even if compiling a specific wrapper means blocking the main thread. - Real-life applications do call exported functions thousands of times, so this is not an unrealistic choice. Bug: v8:10982 Change-Id: I143dd11e535101fd24810f63ed8b987cd03c4326 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539913 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
-
