- 16 Mar, 2021 14 commits
-
-
Ross McIlroy authored
Release-official builds strip error messages from CHECK messages. This can make it difficult to distinguish a CHECK crash location in crash reports. As such, instead of using V8_FatalNoContext, import the IMMEDIATE_CRASH macro from chromium and use that instead, which should cause a crash directly in the instruction stream so that the top stackframe on the crash report directly identifies the CHECK location that failed. More details here: https://docs.google.com/document/d/1tyMwzxUNH8BctM_urSQIYdcbwmzP4kTnwEjnFamBpKY Change-Id: I5b8175f19571834f790060d641db08d0b9c2c17b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756223Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73430}
-
Pierre Langlois authored
We try and match literal load instructions in order to print a relocation info comment. However, we could be doing it while we're decoding a constant pool. This would cause a DCHECK to fire on Arm64 with full pointers. Change-Id: I82a523dc5c033f86f41467db75e43419ab87d5ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756532Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#73429}
-
Frank Emrich authored
Change-Id: Iec90b4821f41838eb4c2bae26035af4e30082ef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762140Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73428}
-
Manos Koukoutos authored
The register allocator sometimes fails if a parameter node appears twice. This seems to be an issue in the register allocator rather than a global assumption of Turbofan. This CL ensures duplication does not happen in wasm code until the issue is resolved. Changes: - Cache parameter nodes in wasm-compiler. - Use Dead() over Parameter() as placeholder in lowering stages. Change-Id: I7afb5de45dd169819309fea3d3c1a7cfe68af62c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756529 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73427}
-
Michael Lippautz authored
Poisoning unmarked objects serves two purposes: - Prohibits finalizer from accessing other unmarked objects; - Unpoisioning also clears potential poisoning of the embedder which is necessary as the sweeper and compactor modify the payload of objects; Bug: chromium:1056170 Change-Id: I4346a0ab736603b3d6170b41b0e7255db1452897 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762137Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73426}
-
Toon Verwaest authored
Using RW to update code perturbs SMC snooping on some CPUs. This reland fixes Apple Silicon and jitless by forcing the flag off. Change-Id: Ie2cc2e4fac333cad24a129e59cbcb6b13590d6d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759515 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73425}
-
Sara Tang authored
While testing the perf for v8-etw, I noticed that the runtime flag didn't completely guard from event emission. This change fixes that. Bug: v8:11043 Change-Id: Iee919e6030214e18173c93e4426d6437aed08235 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757894Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73424}
-
Jakob Kummerow authored
This updates tools/bash-completion.sh to consider flags defined in src/wasm/wasm-feature-flags.h. No-Try: true Change-Id: I0556d237608c88a87d65f739c856f94e35e2123e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2761398 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73423}
-
Clemens Backes authored
This will make accidental includes much easier to see and fix. Without this, you might get compiler or linker errors instead. R=jkummerow@chromium.org Bug: v8:11238 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Change-Id: I235d779f9c1ed3af5d736f1554ded427935ddc9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756531 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73422}
-
Michael Achenbach authored
When the builder was moved to the main console it should have gotten a higher priority for tests as otherwise it's affected of bot shortage as in the bug below. No-Try: true Bug: v8:11566 Change-Id: Ide63f3659a8791e5ef4b48fc62504bc06bd09453 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762149 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73421}
-
Clemens Backes authored
This removes all wasm-related flags in no-wasm builds. We could have made them read-only, but fully removing them actually forces us to consider the no-wasm case at every use site, which often hints at further cleanups. R=jkummerow@chromium.org Bug: v8:11238 Change-Id: Ic140031a2732975b2a46116a58e26fe49f1f7c8c Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759518 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Liu Yu authored
Port: 3e689a7d Bug: v8:11453 Change-Id: I5671fe0505f0dfd924aa9b5242b3277ed03f2337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763632 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73419}
-
Clemens Backes authored
This removes the TYPE_WASM script type, and all fields on Script that are only needed for WebAssembly. R=jgruber@chromium.org Bug: v8:11238 Change-Id: I233bfd3dec9b389bc74d926670310fd175c0c6d8 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757690Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5f2e66e..5081eef Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6e87bdd..6d5a4e5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/159efca..593a6b5 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic44d5c48396e5e2bdfe7183434eb4defaf78d805 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762676Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73417}
-
- 15 Mar, 2021 26 commits
-
-
Shu-yu Guo authored
Note that top-level await is already on-by-default in blink. This flips the flag in V8 only for other embedders. Bug: v8:9344 Change-Id: Ic860b22316718b353a0493799fdf95200a71acc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2746843 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Ng Zhi An authored
palignr has a false dependency, so use punpckhbw. Plus optimize for AVX, which can have 1 less instruction. The logic for i16x8.extmul_high_u is slightly complicated (SSE case) to handle register aliasing. This allows us to have the most flexible register allocation, and be able to optimize the most Bug: v8:11468 Change-Id: I221b2d7a79009edb6c4060c136fc35ee7aff08fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757224Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73415}
-
Ng Zhi An authored
I want to extract the Canonicalize shuffle out of the arch-specific instruction selector, since all archs have to do that anyway. Adding these tests to make sure the matching still works. Bug: v8:11542 Change-Id: Ic7ce0e0a027ce858a30f79a0f9ef2495bcaab4c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750289Reviewed-by:
-
Ng Zhi An authored
S128Load and S128Store are not used, we create a node with Load/Store opcode and store the appropriate LoadType/StoreType indicating this is a 128-bit type. Bug: v8:11384 Change-Id: Ida4a36ab893637525cb827b659753ac90fcca743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2760539Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73413}
-
Milad Fa authored
Change-Id: I00ec1cd82160d7e987b7d66dfefd7297f665f05f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2760958 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73412}
-
Almothana Athamneh authored
Bug: v8:11454 Change-Id: I44ed59d5ca7d998ff1affd8acb30862b532a8b3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759519 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73411}
-
Clemens Backes authored
asm validation and translation to wasm is disabled in no-wasm builds, hence remove respective detection and marking of scopes and functions. R=verwaest@chromium.org Bug: v8:11238 Change-Id: I2ac8a84024fa37a0c5896a0f85ea4beea4d93137 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757689Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73410}
-
Thibaud Michaud authored
"FinishCall" is also unnecessary after a tail call, move it inside the condition too. R=clemensb@chromium.org Bug: chromium:1187484 Change-Id: I258dd736565546277deb33e52a4619d6aaa2fe25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759512Reviewed-by:
-
Milad Fa authored
Change-Id: I5608c6123433b1378d92c534e8f38dba68ac3d15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2760778Reviewed-by:
-
Clemens Backes authored
Add a module-wide cache to cache both TurboFan code and Liftoff debug code, such that we can quickly tier up or down a module without repeated recompilation. R=thibaudm@chromium.org Bug: v8:11556 Change-Id: Iec56e67b53e5a40c11ca24dae0728cb569a7c68f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757688 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73407}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ie50e5c85eaed04b4e90dd51261838f7f1a5f65a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743884 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is just adding an early exit, to avoid a big if-block spanning the whole method. Instead of doing this in the follow-up CL, which adds even more code to that block, I pulled it out for easier review. R=thibaudm@chromium.org Bug: v8:11556 Change-Id: Ie4f2e0635fe9875c90d32be8224f1b0709c82e00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757687Reviewed-by:
-
Junliang Yan authored
Port 3e689a7d Original Message: Only support empty exceptions for now. Unpacking i32s, and eventually arbitrary types, will be done in separate CLs. Bug: v8:11453 Change-Id: I4f019330bfb1753b424ef3a8c541054f5fa27e84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2760777Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73404}
-
Frank Emrich authored
This CL: a) Adds an unsigned 64 bit type to Torque, called uint64. b) Makes more operations on 64 bit integers from the raw machine assembler available in CSA and Torque. Change-Id: I147501d65882892e4628ec22088c0940df79a974 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742204 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73403}
-
Thibaud Michaud authored
Only support empty exceptions for now. Unpacking i32s, and eventually arbitrary types, will be done in separate CLs. R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ic3233e0bbdaad8b710cd836be9aef647d3131c9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739590 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Marja Hölttä authored
(Reland: removed the d8 changes, will land them separately.) The minimal implementation which does something useful. Initial machinery for serializing / deserializing objects and functions (only the very simple cases are supported). For more info, see https://docs.google.com/document/d/1Qierkg3b3klIwCQt-oZCHqhcc1_9DXNIErBwvdpD4wU/edit?usp=sharing Previous version: Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716288 TBR=leszeks@chromium.org,syg@chromium.org,hpayer@chromium.org Bug: v8:11525 Change-Id: Ia61ed7de36f371d931eff68156ab467723915704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759510Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Victor Costan authored
One of the x86 ISA extensions is confusingly named SSSE3 (*Supplemental* Streaming SIMD Extensions 3). SSSE3 supersedes SSE3, and is superseded by SSE4. This CL adds testing coverage for x86 CPUs that support SSE3 instructions, but do not support SSSE3 instructions. Chrome supports these CPUs, and they are used by a non-trivial amount of Chrome's users on Windows. Change-Id: I7b1f1e0167708ae285a71530a01b9b474cb08352 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757893 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#73400}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: Iecc78f14cd514cd650e00f1a4731fddba53e47a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752878 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Patrick Thier authored
If a Proxy is passed as argument to d8.test.verifySourcePositions, unwrap the target function. Bug: chromium:1186491 Change-Id: Iaacbf800f023121a07035a88745919df68f79217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748081Reviewed-by:
-
Seth Brenith authored
Torque generally supports marking things as unused by adding a single underscore to the front of identifiers. For locals, this feature works fine. For macros, it's only half-implemented: attempting to look up a macro that starts with _ fails (as it should), but the compiler also complains if the macro is unused. This change avoids emitting the latter error. Bug: v8:7793 Change-Id: Ib021c053004a180dd31993d3ad06cde463bafd5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757208 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 74960db4. Reason for revert: Segfaults on CFI: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/4999/overview Original change's description: > [wasm] Emit safepoint info for callee-saved registers in the deopt-index > > Encode safepoint info of callee-saved registers in the deopt index of > the normal safepoint. > > Change-Id: I93bd0d2330b7f592b767860743c04a65ddaa92f5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739977 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73395} Change-Id: Ic4803b06a64b615f2258c594b601b4e8fd4b7bff No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759513 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73396}
-
Andreas Haas authored
Encode safepoint info of callee-saved registers in the deopt index of the normal safepoint. Change-Id: I93bd0d2330b7f592b767860743c04a65ddaa92f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739977 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Cleanups around tracing bottlenecks and tests. Bug: chromium:1056170 Change-Id: I1f9ddd6d8727971db3bed5294f4ff3fdd20a9e34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757696 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Hong Zheng authored
Add a V8 API to update load start time for RAIL PERFORMANCE_LOAD mode Bug: v8:10947 Change-Id: If86a815f8974b47a6f4ba82c3661c21b73f39553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423403 Auto-Submit: Hong Zheng <hong.zheng@intel.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
This changes the behavior of SetBreakpointForScript to find more accurate break positions. Previously, setting a breakpoint would only consider the shared function info that contained the requested position for setting a breakpoint. More intuitively, a breakpoint should not necessarily be set in a function that contains the position, but in the closest breakable location that comes after the position we requested. To achieve this we: 1. find the shared function info of the inner most function that contains the requested_position. This function's end position is used to find other shared function infos in step 2. 2. search for all shared function infos that intersect with the range [requested_position, inner_most_function.break_position[. 3. From the shared function infos extracted in 2, find the one that has the closest breakable location to requested_position. Also-By: bmeurer@chromium.org Fixed: chromium:1137141 Change-Id: I4f4c6c3aac1ebea50cbcad9543b539ab1ded2b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742198 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73392}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/421f3e0..5f2e66e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/58bac68..6e87bdd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/bb890d6..159efca Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e645571..91db20b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I496ee15bb259471bc77e856d91dbb29ab70ae657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2758919Reviewed-by:
-
