- 26 Oct, 2018 31 commits
-
-
Ulan Degenbaev authored
The markbit check should be performed before using the map of the object. Change-Id: Ia19e48fd4660387d239e1e330368808727359c7f Reviewed-on: https://chromium-review.googlesource.com/c/1301496 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57040}
-
Jakob Gruber authored
Tbr: ishell@chromium.org Bug: v8:8238 Change-Id: I3fe3b821105d2ce58df717970085098f6336f937 Reviewed-on: https://chromium-review.googlesource.com/c/1301512Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57039}
-
Jakob Gruber authored
The assumption behind this optimization was invalid. Even if the string's prototype is unchanged, the symbol could exist somewhere further up the prototype chain. GetProperty has been sped up significantly so it might be fine to just skip this fast path. An alternative would be to use a protector cell. Bug: v8:8357 Change-Id: Ia577107a58157350eb15780c02aa63d77e600637 Reviewed-on: https://chromium-review.googlesource.com/c/1301498 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57038}
-
Igor Sheludko authored
and also move embedder fields from Isolate to IsolateData. The external memory counter fields are temporarily moved to IsolateData in order to avoid unexpected Node JS bot failures which happen if the fields are left in the Heap class. Bug: v8:8182 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I9d58f235c0ce40e110f595addd03b80b3617aa77 Reviewed-on: https://chromium-review.googlesource.com/c/1278793 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This changes the GC histograms from HistogramTimer to TimedHistogram. Bug: chromium:898613 Change-Id: Ie18c6dd3b958c3ce93f0f84faec0f306d699afa0 Reviewed-on: https://chromium-review.googlesource.com/c/1299241 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I80d62c2077ccf271e954d6bb9dda3e0d35d08a76 Reviewed-on: https://chromium-review.googlesource.com/c/1301510Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57035}
-
Georg Neis authored
This just adds calls to SerializePrototype right before we access the serialized prototype. Eventually we need to do this earlier. Bug: v8:7790, chromium:899115 Change-Id: I597e95f5f6df8aae608ee295fe9550e7c2a45e6d Reviewed-on: https://chromium-review.googlesource.com/c/1301475Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57034}
-
Sigurd Schneider authored
Flag -Wno-defaulted-function-deleted is not known to clang 4.0, which is currently the default on many systems, so filter the flag for now. R=mslekova@chromium.org Notry: true Change-Id: I9ee9cbbf97f411d409b8b4150897d7741abe24af Reviewed-on: https://chromium-review.googlesource.com/c/1301511 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Florian Sattler authored
BUG= v8:8372 Change-Id: Ic29847674a1e455a405c4599c01785ee7aefcedc Reviewed-on: https://chromium-review.googlesource.com/c/1301500 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57032}
-
Michael Achenbach authored
TBR=santa Change-Id: Iff32a0c25b083003a0dc6caa53ed5bb182f4de2d Reviewed-on: https://chromium-review.googlesource.com/c/1301508Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57031}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: I7f87b58242fa2e29166c11aacc235ef9c279b3e8 Reviewed-on: https://chromium-review.googlesource.com/c/1301478Reviewed-by:
-
Clemens Hammacher authored
Fix some JS smells as suggested in https://github.com/WebAssembly/spec/issues/897. R=ahaas@chromium.org Bug: v8:8238 Change-Id: Idc4f738da849f28477563df628dcae2805b1b47e Reviewed-on: https://chromium-review.googlesource.com/c/1301476Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57029}
-
Andreas Haas authored
This CL refactors the existing trap handler code for Linux to allow a cleaner extension to Windows. 1) The CL extracts platform-specific code into separate files, see https://docs.google.com/document/d/1HCgKIpdjy_CEodTLvZ5VuykDI6gGTHrTtau2j0zwm28. Specifically this means: * Move posix-specific API functions from v8.h to v8-wasm-trap-handler-posix.h. Deprecate the existing TryHandleSignal API function. * Move posix-specific function declarations from trap-handler-internal.h to handler-inside-posix.h * Move posix-specific function definitions from handler-shared.cc to handler-outside-posix.cc 2) The CL changes filenames from *-linux.* to *-posix.*. I expect that most of the implementation for MacOS will be the same as for Linux. Bug: v8:6743 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4bb7f199564a2f01042084d15a82311d11a93c7b Reviewed-on: https://chromium-review.googlesource.com/c/1280324 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57028}
-
Michael Lippautz authored
Fix: Guard with lock when accessing background counters. This reverts commit d5f3e225. CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_tsan_rel Change-Id: I4e00f41ce6a2fac86d4e90c70e57c7a333442a97 Reviewed-on: https://chromium-review.googlesource.com/c/1301503Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true Bug: chromium:898606 Change-Id: Ibbb11d3766c95a15c6262c741cd65d694de4489c Reviewed-on: https://chromium-review.googlesource.com/c/1301506 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Starzinger authored
The valid store types of a {Float64Array} heap view are specified to be "float?" and "double?". We correctly accepted both types but forgot to emit the appropriate conversion in the "float?" case. This just adds the missing conversion expression. R=clemensh@chromium.org TEST=mjsunit/regress/regress-crbug-898974 BUG=chromium:898974,v8:8347 Change-Id: I306b10e2088185b1522da29b1a113908ef9925f2 Reviewed-on: https://chromium-review.googlesource.com/c/1301499 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57025}
-
Michael Lippautz authored
GCs should only trigger only trigger when growing external memory but not when removing it. - The limit is already lowered when removing memory, so possible future allocations check against a lowered limit. - Memory pressure signals are already handled via an explicit V8 API. Bug: chromium:899035 Change-Id: I96da5862400e06edb8c9fa47357070b3b48560a1 Reviewed-on: https://chromium-review.googlesource.com/c/1301473Reviewed-by:
-
Benedikt Meurer authored
This adds support for Promise.all() to --async-stack-traces (also at zero cost, since we can derive the relevant information from the resolve element closure and context). In case of `Promise.all(a)` the stack trace even tells you which element of `a` is responsible, for example ```js async function fine() {} async function thrower() { await fine(); throw new Error(); } async function test() { await Promise.all([fine(), thrower()]); } ``` will generate the following stack trace ``` Error at thrower (something.js:1:9) at async Promise.all (index 1) at async test (something.js:3:3) ``` so it not only shows the async Promise.all() frames, but even tells the user exactly that the second element of `[fine(), thrower()]` is the relevant one. Bug: v8:7522 Change-Id: I279a845888e06053cf0e3c9338ab71caabaabf45 Reviewed-on: https://chromium-review.googlesource.com/c/1299248Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57023}
-
Peter Marshall authored
Currently, because the source float_64_array has an iterator, it hits the code in the "check_iterator" section of TypedArrayFrom which calls IterableToList. This builds a temporary PACKED_ELEMENTS array (and boxes all of the numeric values as HeapNumbers), then uses this as the source array. This patch checks if the source array is a TypedArray, and if the iterator is the built-in one (where we know the iterator's behaviour). If both are true then it bypasses the creation of this temporary array and uses the original TypedArray as the source. This allows it to take advantage of the existing fast code for copying one typed array to another. R=hablich@chromium.org, petermarshall@chromium.org Bug: chromium:884671 Change-Id: I19a944c9d6d5d07699c7dc3ad7196fc871200b62 Reviewed-on: https://chromium-review.googlesource.com/c/1297312Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57022}
-
Mike Stanton authored
We can use GcSafeFindCodeForInnerPointer() when handling a code added event. This method understands embedded builtins. Change-Id: I94757f96b7b4ad10cbf7cb5f715d3368cc86b798 Reviewed-on: https://chromium-review.googlesource.com/c/1297953Reviewed-by:
-
Peter Marshall authored
Bug: chromium:898469 Change-Id: I988a71ed92e1c466224235d32bc4e281dd4818cd Reviewed-on: https://chromium-review.googlesource.com/c/1301494Reviewed-by:
-
Peter Marshall authored
This test was incidentally fixed by https://chromium-review.googlesource.com/c/v8/v8/+/1280436. Calls to StartTickSample() and FinishTickSample() are not permitted by multiple producers. If the signal handler interrupts the main thread, both might receive the same pointer into the circular buffer and one will overwrite the data of the other. This means we cannot call it in tests, and have to use AddSample() instead. Bug: v8:8209 Change-Id: I6904204e88077f704f819b52cde0fdaab0f13462 Reviewed-on: https://chromium-review.googlesource.com/c/1299022Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57019}
-
Jakob Gruber authored
This CL restores consistency with other platforms. ebx is now the kRootRegister on ia32, and thus not an allocatable register any more. The PreserveRootIA32 register configuration can be removed since it is now identical to the Default configuration. Bug: v8:6666 Change-Id: If4e2b4c52aa8b5db40bcd3b4469004b29c0e3d99 Reviewed-on: https://chromium-review.googlesource.com/c/1299078 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57018}
-
Michael Achenbach authored
This skips big-object-literal on bots with dchecks (setting DEBUG) and with stress mode in general. NOTRY=true Bug: v8:8328 Change-Id: I53480d1ee942d2c83e46c8804bd8920a5e36cad2 Reviewed-on: https://chromium-review.googlesource.com/c/1301495Reviewed-by:
-
Dan Elphick authored
When creating a Code object, if it has valid builtin_index then create its RelocInfo in RO_SPACE. For embedded builds this moves about 48 bytes into RO_SPACE, but it's considerably more for nosnap builds. Bug: v8:7464 Change-Id: I598cb960c0068ef4be8d72ae8f5c8d74c0195aca Reviewed-on: https://chromium-review.googlesource.com/c/1299073Reviewed-by:
-
Dan Elphick authored
Move fixing up Filler objects after deserialization from the StartupDeserializer to the ReadOnlyDeserializer since that's what deserializes the Filler maps. Since only RO_SPACE can contain such objects, skip iterating over all the spaces and just fix them up directly in RO_SPACE. To this end, the PagedSpace code is moved to ReadOnlySpace and the Heap fix up method is removed. Change-Id: I7a01f1ef298e6d5e74d3173620fb7764c3b598f2 Reviewed-on: https://chromium-review.googlesource.com/c/1299013Reviewed-by:
-
Toon Verwaest authored
Bug: chromium:898936 Change-Id: I2c8d8212fa97436e32628d4030d36ce457346c1f Reviewed-on: https://chromium-review.googlesource.com/c/1300133Reviewed-by:
-
Toon Verwaest authored
Checking impl()->IsAsync(identifier) is insufficient since it could be parenthesized. By checking the token in addition to IsIdentifier guarantees that we've only seen the single token ASYNC. Bug: chromium:898812 Change-Id: Id94dd607381050b4bd8cd6d8672a5d11256db7da Reviewed-on: https://chromium-review.googlesource.com/c/1300134Reviewed-by:
-
Florian Sattler authored
NOTRY=true Change-Id: Ia081262a6daf3b819ec919443de5b3ae2483a5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1301373 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57012}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5a371bc..df2e6ae Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/b0e7838..c90bc96 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ed6fe0f..687f318 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7e0d61113455231c6fb40e229329b61c3de9b28c Reviewed-on: https://chromium-review.googlesource.com/c/1300856Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57011}
-
Jakob Kummerow authored
This CL applies the equivalent of the Object -> ObjectPtr transformation to MaybeObject and HeapObjectReference. We need no renaming in this case because we can just migrate them both in one go. Bug: v8:3770 Change-Id: Ie1259c3e8c556eff00f8bcf534d7270ca9fe00e1 Reviewed-on: https://chromium-review.googlesource.com/c/1298386 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57010}
-
- 25 Oct, 2018 9 commits
-
-
Junliang Yan authored
Port e893eb14 Original Commit Message: This adds support for having reference type values (i.e. anyref) stored in an exception. It is the natural combination of the reference type proposal and the exception handling proposal. Note that this also introduces support for having write barriers in generated WasmCode, as this is the first time we are storing references within generated code. Such write barriers will be needed for other uses of reference types (e.g. mutable global) regardless. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:8341 LOG=N Change-Id: I6837a31791654ebe4171f6ecb563939beb3a66dd Reviewed-on: https://chromium-review.googlesource.com/c/1299899Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57009}
-
Michael Lippautz authored
Change-Id: I87d17d087f47eb60efbd2ddaf04d5d574c73164c Reviewed-on: https://chromium-review.googlesource.com/c/1299245Reviewed-by:
-
Michael Achenbach authored
This reverts commit 9cde8808. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/3086 Original change's description: > [Compile] Ensure we don't access the native context during bytecode finalization. > > Resets the isolate's context to nullptr in debug builds during bytecode finalization > to ensure that we don't rely on the native context during context independent > unoptimized compilation. > > BUG=chromium:898076, v8:8041 > > Change-Id: Ifaa5006a7a3d31d7fbd535ebb63f8889c75526c4 > Reviewed-on: https://chromium-review.googlesource.com/c/1297961 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56979} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,leszeks@chromium.org Change-Id: I363bc9db3f4b89e46ecdaf41c101f7fc1145a325 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:898076, v8:8041 Reviewed-on: https://chromium-review.googlesource.com/c/1299247Reviewed-by:
-
Michael Achenbach authored
This reverts commit e05913ff. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23203 Original change's description: > [heap] Add marking summary counter > > Change-Id: I41e5c4a99331ddc844cd1fe86f63406a28eebdbf > Reviewed-on: https://chromium-review.googlesource.com/c/1299243 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57005} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I0acfee50159527f496f752015b19e56eaf1c1600 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1299246Reviewed-by:
-
Michael Lippautz authored
Change-Id: I41e5c4a99331ddc844cd1fe86f63406a28eebdbf Reviewed-on: https://chromium-review.googlesource.com/c/1299243Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I6b08006397a70c2a9c35807a39c6d7e1ebf185e0 Reviewed-on: https://chromium-review.googlesource.com/c/1299025 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Lei Zhang authored
In a DCHECK inside SetPayload(), MSVC gives a C4806 warning. Use the right types to avoid this. Also add pointer-with-payload.h to BUILD.gn. Change-Id: I10a415250e7d2f06dab7a10bff48eef5890bb723 Reviewed-on: https://chromium-review.googlesource.com/c/1297991 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: Ia231f3eef158643c9ebe29f0854b37610f962acb Reviewed-on: https://chromium-review.googlesource.com/c/1299242 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
A node short-cutting optimization was not updating uses correctly. This fix makes sure that there are no other users of the node, thus making the use update unnecessary. This fix might have negative performance implications. Change-Id: Ie9bd23caf4434eb2137e111dc5e7c143fd97521c Reviewed-on: https://chromium-review.googlesource.com/c/1299019 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
