1. 16 Oct, 2017 1 commit
  2. 13 Oct, 2017 1 commit
  3. 29 Aug, 2017 1 commit
  4. 28 Aug, 2017 1 commit
  5. 21 Aug, 2017 1 commit
  6. 09 May, 2017 1 commit
  7. 04 May, 2017 1 commit
  8. 29 Apr, 2017 1 commit
    • Daniel Ehrenberg's avatar
      Revert "[intl] Switch to using declared accessors" · 0ca84d06
      Daniel Ehrenberg authored
      This reverts commit 4968b2c4.
      
      Reason for revert: Speculative revert for severe perf regression
      https://bugs.chromium.org/p/chromium/issues/detail?id=716468#c3
      
      Original change's description:
      > [intl] Switch to using declared accessors
      > 
      > This patch cleans up the Intl code by switching to using declared
      > accessors, rather than embedder fields, for holding references to
      > ICU objects. Additionally:
      > - Rename classes to be more similar to how other classes are named
      > - Make some unreachable paths into check-fails, rather than throwing
      >   JS exceptions
      > - Move some macros from objects-inl.h into object-macros.h, to allow
      >   the implementation here to not touch objects.h
      > - Some setup logic is moved from runtime-i18n.cc to i18n.cc.
      > 
      > This patch leaves type tags as they are; a future patch should move
      > from a special Intl type tagging system to object types as other system
      > objects use. Future patches should also move more logic to i18n.cc
      > 
      > BUG=v8:5402,v8:5751,v8:6057
      > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      > 
      > Change-Id: Ia9cbb25cf8f52662e3deb15e64179d792c10842c
      > Reviewed-on: https://chromium-review.googlesource.com/479651
      > Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
      > Reviewed-by: Adam Klein <adamk@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#44804}
      
      TBR=adamk@chromium.org,marja@chromium.org,mstarzinger@chromium.org,littledan@chromium.org,jwolfe@igalia.com
      # Not skipping CQ checks because original CL landed > 1 day ago.
      BUG=v8:5402,v8:5751,v8:6057
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      Change-Id: I7a45d7def1f1de0f21e3efb7de9b31f6bcfea46d
      Reviewed-on: https://chromium-review.googlesource.com/490328Reviewed-by: 's avatarDaniel Ehrenberg <littledan@chromium.org>
      Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#44992}
      0ca84d06
  9. 24 Apr, 2017 2 commits
  10. 11 Apr, 2017 4 commits
  11. 22 Mar, 2017 1 commit
  12. 17 Mar, 2017 1 commit
    • titzer's avatar
      [rename] Rename internal field to embedder field. · 72e53936
      titzer authored
      This CL renames all occurrences of "internal field" to "embedder field"
      to prevent confusion. As it turns out, these fields are not internal to
      V8, but are actually embedder provided fields that should not be mucked
      with by the internal implementation of V8.
      
      Note that WASM does use these fields, and it should not.
      
      BUG=v8:6058
      
      Review-Url: https://codereview.chromium.org/2741683004
      Cr-Commit-Position: refs/heads/master@{#43900}
      72e53936
  13. 09 Mar, 2017 1 commit
    • jshin's avatar
      Prepare for ICU's switch to char16_t · fd5b3e75
      jshin authored
      ICU's UChar was uint16_t (non-Win) or wchar_t (Windows). It's switching
      to char16_t in both C/C++ API. It needs some changes. Fortunately,
      v8 needs only a couple of changes because v8 has been using
      reinterpret_cast in many places calling ICU API.
      
      This change was confirmed to work fine with ICU-59-to-be.
      
      BUG=v8:6062
      TEST=trybot
      
      Review-Url: https://codereview.chromium.org/2738503008
      Cr-Commit-Position: refs/heads/master@{#43707}
      fd5b3e75
  14. 12 Jan, 2017 1 commit
    • littledan's avatar
      [intl] Remove indirection in Intl objects · db13ed1d
      littledan authored
      With the new initialization semantics, the V8 ECMA 402 (Intl)
      implementation does not need to indirect through a symbol to
      get at the underlying object. This patch removes that indirection,
      simplifying the implementation.
      
      R=yangguo@chromium.org
      BUG=v8:5751
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      Review-Url: https://codereview.chromium.org/2601833002
      Cr-Commit-Position: refs/heads/master@{#42281}
      db13ed1d
  15. 09 Jan, 2017 2 commits
    • littledan's avatar
      [intl] Remove redundant type checking system · 788c96a9
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      This reland includes a fixed type check for
      Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      method which is not bound. All future methods will follow this
      pattern.
      
      The second reland ensures that a newly inserted test is only run
      if Intl is present.
      
      BUG=v8:5751,chromium:677055, v8:4962
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      TBR=yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2623683002
      Cr-Commit-Position: refs/heads/master@{#42152}
      788c96a9
    • marja's avatar
      include fixing: api.h shouldn't include objects-inl.h · 9c7b8726
      marja authored
      Downside: this adds all kinds of weird includes in the .cc files.
      
      (See design doc linked in the bug.)
      
      BUG=v8:5402
      
      Review-Url: https://codereview.chromium.org/2622503002
      Cr-Commit-Position: refs/heads/master@{#42140}
      9c7b8726
  16. 07 Jan, 2017 2 commits
    • machenbach's avatar
      Revert of [intl] Remove redundant type checking system (patchset #4 id:60001... · b1e4f79e
      machenbach authored
      Revert of [intl] Remove redundant type checking system (patchset #4 id:60001 of https://codereview.chromium.org/2600913002/ )
      
      Reason for revert:
      Breaks noi18n.
      
      Original issue's description:
      > [intl] Remove redundant type checking system
      >
      > Previously, the Intl implementation tracked types two ways:
      >  - In the intl_initialized_marker_symbol
      >  - In various named properties of the intl_impl_object_symbol value
      >
      > As far as I can tell, these will never disagree with each other,
      > modulo bugs in Intl itself. This patch removes the second type
      > checking system.
      >
      > This reland includes a fixed type check for
      > Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      > method which is not bound. All future methods will follow this
      > pattern.
      >
      > BUG=v8:5751,chromium:677055, v8:4962
      > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      >
      > Review-Url: https://codereview.chromium.org/2600913002
      > Cr-Commit-Position: refs/heads/master@{#42118}
      > Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25
      
      TBR=yangguo@chromium.org,adamk@chromium.org,littledan@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5751,chromium:677055, v8:4962
      
      Review-Url: https://codereview.chromium.org/2617323002
      Cr-Commit-Position: refs/heads/master@{#42119}
      b1e4f79e
    • littledan's avatar
      [intl] Remove redundant type checking system · aa8a2d27
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      This reland includes a fixed type check for
      Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      method which is not bound. All future methods will follow this
      pattern.
      
      BUG=v8:5751,chromium:677055, v8:4962
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      Review-Url: https://codereview.chromium.org/2600913002
      Cr-Commit-Position: refs/heads/master@{#42118}
      aa8a2d27
  17. 27 Dec, 2016 1 commit
  18. 23 Dec, 2016 1 commit
    • littledan's avatar
      [intl] Remove redundant type checking system · 0d5561b6
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      BUG=v8:5751
      
      Review-Url: https://codereview.chromium.org/2591203002
      Cr-Commit-Position: refs/heads/master@{#41941}
      0d5561b6
  19. 06 Sep, 2016 1 commit
  20. 17 Aug, 2016 1 commit
  21. 06 May, 2016 1 commit
  22. 08 Mar, 2016 1 commit
  23. 07 Jan, 2016 1 commit
  24. 08 Dec, 2015 1 commit
  25. 11 Aug, 2015 1 commit
    • mstarzinger's avatar
      Remove several grab-bag includes from the v8.h header. · 58109a2c
      mstarzinger authored
      This is the first step of turning the v8.h file into a normal header
      instead of an include-the-world header. The new rule is that no other
      header files are allowed to include v8.h, which is enforced by DEPS.
      
      Also the number of includes inside the v8.h file has been drastically
      reduced. Basically the last missing piece is the inclusion of the big
      objects-inl.h file.
      
      This in turn makes many headers follow the IWYU principle.
      
      R=bmeurer@chromium.org,hpayer@chromium.org,titzer@chromium.org
      
      Review URL: https://codereview.chromium.org/1282503003
      
      Cr-Commit-Position: refs/heads/master@{#30102}
      58109a2c
  26. 17 Jul, 2015 1 commit
    • hichris123's avatar
      Make NumberFormat use the ICU currency data, fix bug in NumberFormat · ddb5c2d9
      hichris123 authored
      NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency.
      
      This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point.
      
      BUG=435465,473104,304722
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1231613006
      
      Cr-Commit-Position: refs/heads/master@{#29734}
      ddb5c2d9
  27. 06 Jul, 2015 1 commit
  28. 01 Jun, 2015 1 commit
  29. 02 Mar, 2015 1 commit
  30. 18 Dec, 2014 1 commit
  31. 06 Oct, 2014 2 commits
  32. 03 Oct, 2014 1 commit
  33. 10 Sep, 2014 1 commit