1. 11 Mar, 2016 1 commit
  2. 30 Dec, 2015 1 commit
    • littledan's avatar
      Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of... · e549c7a3
      littledan authored
      Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of https://codereview.chromium.org/1554523002/ )
      
      Reason for revert:
      Should be fixed again with this Blink change to add NeedsManualRebaseline
      
      Original issue's description:
      > Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ )
      >
      > Reason for revert:
      > [Sheriff] Changes layout tests. Please fix upstream first if intended.
      >
      > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689
      >
      > Original issue's description:
      > > Use ES2015-style TypedArray prototype chain
      > >
      > > This patch switches TypedArrays to use the prototype chain described
      > > in the ES2015 specification, which adds a %TypedArray% superclass above
      > > all individual TypedArray types. Most methods are defined on the
      > > superclass rather than the subclasses.
      > >
      > > In order to prevent a performance regression, a few methods are
      > > marked as inline. Inlining might prevent code which was previously
      > > monomorphic from becoming polymorphic, and it was specifically
      > > applied in places where methods became more polymorphic than before.
      > > Tests with realistic workloads would be nice to do before this
      > > ships in stable.
      > >
      > > This patch does not bring TypedArrays up to full spec compliance. In
      > > particular, @@species is not yet supported.
      > >
      > > R=cbruni
      > > BUG=v8:4085
      > > LOG=Y
      > >
      > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7
      > > Cr-Commit-Position: refs/heads/master@{#33050}
      >
      > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=v8:4085
      >
      > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c
      > Cr-Commit-Position: refs/heads/master@{#33053}
      
      TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org
      BUG=v8:4085
      LOG=Y
      
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
      
      Review URL: https://codereview.chromium.org/1558663002
      
      Cr-Commit-Position: refs/heads/master@{#33067}
      e549c7a3
  3. 29 Dec, 2015 1 commit
    • machenbach's avatar
      Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of... · 28b55ffd
      machenbach authored
      Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ )
      
      Reason for revert:
      [Sheriff] Changes layout tests. Please fix upstream first if intended.
      
      https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689
      
      Original issue's description:
      > Use ES2015-style TypedArray prototype chain
      >
      > This patch switches TypedArrays to use the prototype chain described
      > in the ES2015 specification, which adds a %TypedArray% superclass above
      > all individual TypedArray types. Most methods are defined on the
      > superclass rather than the subclasses.
      >
      > In order to prevent a performance regression, a few methods are
      > marked as inline. Inlining might prevent code which was previously
      > monomorphic from becoming polymorphic, and it was specifically
      > applied in places where methods became more polymorphic than before.
      > Tests with realistic workloads would be nice to do before this
      > ships in stable.
      >
      > This patch does not bring TypedArrays up to full spec compliance. In
      > particular, @@species is not yet supported.
      >
      > R=cbruni
      > BUG=v8:4085
      > LOG=Y
      >
      > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7
      > Cr-Commit-Position: refs/heads/master@{#33050}
      
      TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4085
      
      Review URL: https://codereview.chromium.org/1554523002
      
      Cr-Commit-Position: refs/heads/master@{#33053}
      28b55ffd
  4. 28 Dec, 2015 1 commit
    • littledan's avatar
      Use ES2015-style TypedArray prototype chain · 07c91dcc
      littledan authored
      This patch switches TypedArrays to use the prototype chain described
      in the ES2015 specification, which adds a %TypedArray% superclass above
      all individual TypedArray types. Most methods are defined on the
      superclass rather than the subclasses.
      
      In order to prevent a performance regression, a few methods are
      marked as inline. Inlining might prevent code which was previously
      monomorphic from becoming polymorphic, and it was specifically
      applied in places where methods became more polymorphic than before.
      Tests with realistic workloads would be nice to do before this
      ships in stable.
      
      This patch does not bring TypedArrays up to full spec compliance. In
      particular, @@species is not yet supported.
      
      R=cbruni
      BUG=v8:4085
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1541233002
      
      Cr-Commit-Position: refs/heads/master@{#33050}
      07c91dcc
  5. 17 Jun, 2015 1 commit
  6. 16 Jun, 2015 1 commit
    • littledan's avatar
      Add %TypedArray% to proto chain · a1059015
      littledan authored
      According to the ES6 spec, the main methods and getters shouldn't
      be properties of the individual TypedArray objects and prototypes
      but instead on %TypedArray% and %TypedArray%.prototype. This
      difference is observable through introspection. This patch moves
      some methods and getters to the proper place, with the exception
      of %TypedArray%.prototype.subarray and harmony methods. These will
      be moved in follow-on patches.
      
      BUG=v8:4085
      LOG=Y
      R=adamk
      
      Review URL: https://codereview.chromium.org/1186733002
      
      Cr-Commit-Position: refs/heads/master@{#29057}
      a1059015
  7. 04 Jun, 2015 1 commit
    • arv's avatar
      Unship harmony tostring · 07c1f277
      arv authored
      Blink's DOM bindings are not yet ready.
      
      BUG=493137, 239915
      LOG=N
      R=rossberg, adamk
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
      
      Review URL: https://codereview.chromium.org/1153263004
      
      Cr-Commit-Position: refs/heads/master@{#28804}
      07c1f277
  8. 24 Apr, 2015 1 commit
  9. 23 Apr, 2015 2 commits