- 30 May, 2022 35 commits
-
-
Junliang Yan authored
Change-Id: I3bf465381df92dc2ec3181f1082463a2d7903854 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677332Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80828}
-
Clark DuVall authored
Bug: chromium:1328448 Change-Id: If0c3d02070071b5bb25df5bca51cf8c4cfc424d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673420Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#80827}
-
Pan, Tao authored
If the optimized code is deoptimized and the deoptimized exit offset is inside of the optimized OSR code related loop, the optimized OSR code is also out of date, remove the optimized OSR code, it will avoid hit the optimized OSR code and soon later deoptimization of the optimized OSR code. This CL will reduce deoptimization. E.g. Deoptimization of JetStream2 case navier-stokes function addFields is reduced from twice to once. Change-Id: I5bbf3039e916c3736b5b967d1f36b6ea90cfd40b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648219Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Tao Pan <tao.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#80826}
-
Seth Brenith authored
This is a reland of commit c8848cf4 This change was reverted due to a problem in a preceding change. This relanded version differs in its implementations of the CompilationCacheScript member functions Lookup, Put, and Age, because the intent is to not change any behavior. Original change's description: > CompilationSubCache has some complexity regarding generations of tables > which is only used by one subclass, CompilationCacheRegExp. This change > adjusts the class hierarchy so that classes only contain the necessary > member functions. > > Bug: v8:12808 > Change-Id: I4f4cf15bbf9b80c2de0c18aea82a0c238804759d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629603 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#80506} Bug: v8:12808 Change-Id: Ib0621b7de8da86a89752c66907f6a56adff9075d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665936Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80825}
-
Jakob Kummerow authored
The previous implementation would simply crash when command-line parameters to the bigint_shell weren't valid integers (where integers were expected). Change-Id: Ia9987ab241ae9cac8dad4517766bfdd0b8cc98b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677295 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80824}
-
Andy Wingo authored
Bug: v8:12868 Change-Id: Ied5e985db139517ec34446bcb8b16041e5d79af7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663092 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80823}
-
Milad Fa authored
This CL fixed the following compilation error: ``` error: inline declaration of 'Union(...)' follows declaration with attribute 'noinline' ``` Change-Id: I9672ca89d245e5f018f7dada57e30be1fc170115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673194Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80822}
-
Manos Koukoutos authored
See crrev.com/c/v8/v8/+/3660248 for context on typed wasm nodes. Bug: chromium:1329939 Change-Id: I58ce7790e75fa1e228ae5ea6a84216889099a203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676852 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80821}
-
Milad Fa authored
Port 3ac47847 R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I06a988b81c4fb711784fee5a700a51858ee5fbbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673193Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80820}
-
Camillo Bruni authored
Allow fast branches in the case the accumulator's live range doesn't extend beyond the branch test. Previously we were more restrictive and only allowed fast branches the test itself didn't use the accumulator register. Bug: v8:7700 Change-Id: Iec98028b3ddb04eeb51e98436a0bdc48f22920ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663744Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80819}
-
Dominik Inführ authored
NativeContexts are always allocated in old space and thus cannot die or move during minor GCs. Bug: v8:11708 Change-Id: I01ec7775aa1186d91ca620c464f570f24ac9f215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666617Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80818}
-
Clemens Backes authored
The number of fields gets huge, and we get a lot of repetitive code. Use a macro to simplify things. R=jkummerow@chromium.org Bug: v8:12425 Change-Id: I5282d03724fb7fe966ac9b281398adabfd339dcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667505 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80817}
-
Thibaud Michaud authored
design doc: https://docs.google.com/document/d/1h4nxeEkMrVBd3QUmLBFGCqbq9BPUPFfkU6L0-IdvJdE/edit?usp=sharing Bug: v8:5210, chromium:1269989, chromium:1313647 Change-Id: I31cc6c0756b3754b61c02f7c5ddde6b5016abcd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3613322Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80816}
-
Leszek Swirski authored
Bug: v8:12920 Change-Id: Iec1f4a2effc45299e30ecf8a586c535dbb22ee20 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676860 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80815}
-
Dominik Inführ authored
Get some test coverage before restarting the map space compaction finch again. This should test whether slots in invalidated objects are now properly ignored when the invalidated object is dead. Bug: v8:12578 Change-Id: I5b6f30b97c2db895183216ae5d5dbd4e5fa9d0c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676855Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80814}
-
Thibaud Michaud authored
R=gdeepti@chromium.org,clemensb@chromium.org Bug: v8:12284 Change-Id: Id003edadabb061aff074ad69602caf9322bda07e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667085Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80813}
-
Thibaud Michaud authored
R=gdeepti@chromium.org,clemensb@chromium.org Bug: v8:12284 Change-Id: Idc2fb6b2ee8453ed84b1be1b23e6bdae878989b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667504 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80812}
-
Manos Koukoutos authored
Change-Id: Ic150f990ac7329bf93b0f9c1c87c4c13be3e3c06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669252Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80811}
-
Igor Sheludko authored
... when external code space is enabled. Since we are using near jump/call instruction only for [tail]calling builtins, we can increase the code range as long as we can guarantee that the remapped builtins are always reachable. We can do that by remapping embedded builtins into the middle of the code range. Bug: v8:11880, v8:12689 Change-Id: I69901634586df3c35618ea7bd5311102e4675f6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669107Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80810}
-
Danylo Boiko authored
Change-Id: If1414fd2c01816461983d9bcebeaef5785ef355a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669694Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80809}
-
Nikolaos Papaspyrou authored
Mostly in comments, again, not much to be said... Bug: v8:12425 Change-Id: I75b4b244e6fa259a29f6cf28bd8258b035af4be6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673536Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#80808}
-
Lu Yahan authored
Change-Id: I8594ee09c127bb996811585ffe1f0eb2d567d9fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676880 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80807}
-
Clemens Backes authored
Similar to https://crrev.com/c/3634781, this switches some {BitVector}s in the regular top-tier register allocator to {SparseBitVector}. For functions with a huge amount of virtual registers, this would save a significant amount of memory, and also performance. For small number of registers though we probably introduce a slight regression, because there is one more dynamic check to be performed before accessing the bits. R=mslekova@chromium.org Bug: chromium:1313379, v8:12780 Change-Id: Ib65d22ad0a8e2c933f7178f4fefc36e500be623c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650602Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80806}
-
Andrey Kosyakov authored
... with [[nodiscard]] removed following the revert of https://crrev.com/c/v8/v8/+/3662540 Change-Id: Ie35f54af1e22a2002c10325642b980f94f666321 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669472 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#80805}
-
Danylo Boiko authored
Change-Id: Ic2c2ccbc68b95d02aed610e96c57ee5739836cc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673299Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80804}
-
Joyee Cheung authored
This simplifies the code and removes the runtime overhead of spontaneously adding strings to the cache. Bug: v8:12718 Change-Id: I2ed49bd82e3baf2563eeb8f463be72c0308c52c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616553Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#80803}
-
jameslahm authored
Bug: v8:12781 Change-Id: I01416a638abbb0f2c590f806869c00356b0fcba5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675732Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80802}
-
jameslahm authored
... strtod-unittest. Bug: v8:12781 Change-Id: I86c3a27a0197103c4ca4be111d55e60b98928758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675735Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80801}
-
jameslahm authored
... version-unittest. Bug: v8:12781 Change-Id: If5bd862533c265bb87ee21008da27e8defebe863 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675734 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80800}
-
jameslahm authored
... symbols-unittest. Bug: v8:12781 Change-Id: I14da3989b7af71886e5f8a122a9f569a9146b81e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675733 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80799}
-
jameslahm authored
... disasm-arm64-unittest. Bug: v8:12781 Change-Id: I4278eb39e9521bc49b280b22a681f6eb270b80d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675901Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80798}
-
jameslahm authored
... disasm-ia32-unittest. Bug: v8:12781 Change-Id: I7291ac23571ecb5564053ba97746c8d18fd615e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675900Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80797}
-
jameslahm authored
... disasm-x64-unittest. Bug: v8:12781 Change-Id: Ia00f626e097606cb27aaaff1841ae3b5a031b2e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675899Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80796}
-
jameslahm authored
... traced-value-unittest. Bug: v8:12781 Change-Id: I0da3b38c12a1c1f39e47ddde9b266ff0249715bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675897Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80795}
-
Lu Yahan authored
Change-Id: I30042811cec8fc2821b7a240c2f8b4e748f437e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673913Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80794}
-
- 28 May, 2022 5 commits
-
-
Frank Tang authored
Implement AO: TemporalDateTimeToString Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.tojson https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.tolocalestring https://tc39.es/proposal-temporal/#sec-temporal-temporaldatetimetostring Bug: v8:11544 Change-Id: I170fa13822d87cfd668bd4cd8df50476f00c86f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672001Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80793}
-
Frank Tang authored
Also implement AOs: ToTemporalRoundingMode, ToSmallestTemporalUnit, RoundNumberToIncrement, RoundTime, ToSecondsStringPrecision Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.tostring https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.tolocalestring https://tc39.es/proposal-temporal/#sec-temporal-totemporalroundingmode https://tc39.es/proposal-temporal/#sec-temporal-tosmallesttemporalunit https://tc39.es/proposal-temporal/#sec-temporal-roundnumbertoincrement https://tc39.es/proposal-temporal/#sec-temporal-roundtime https://tc39.es/proposal-temporal/#sec-temporal-tosecondsstringprecision Bug: v8:11544 Change-Id: I47ea27e966232e89bab48bf15a48c2c00ce5e160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665937Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80792}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/7eb8c0f..6d50251 Report large numbers in scientific notation in console reporter (#1303) (#1402) (Matthdonau) https://chromium.googlesource.com/external/github.com/google/benchmark/+/6d50251 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I7472ffb68d98ea430e907a9d542691108cbe0db1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673183 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80791}
-
Shu-yu Guo authored
This reverts commit ea9a1f1c. Reason for revert: arm64 pointer alignment issue https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8812962856609920785/+/u/Check/mutex-workers Original change's description: > [shared-struct] Add Atomics.Mutex > > This CL adds a moving GC-safe, JS-exposed mutex behind the > --harmony-struct flag. It uses a ParkingLot-inspired algorithm and > each mutex manages its own waiter queue. > > For more details, please see the design doc: https://docs.google.com/document/d/1QHkmiTF770GKxtoP-VQ1eKF42MpedLUeqiQPfCqus0Y/edit?usp=sharing > > Bug: v8:12547 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Change-Id: Ic58f8750d2e14ecd573173d17d5235a136bedef9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595460 > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80789} Bug: v8:12547 Change-Id: I226e16b743dc4b157fac33a9cbabab4d72cf290b Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673353 Owners-Override: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80790}
-
Shu-yu Guo authored
This CL adds a moving GC-safe, JS-exposed mutex behind the --harmony-struct flag. It uses a ParkingLot-inspired algorithm and each mutex manages its own waiter queue. For more details, please see the design doc: https://docs.google.com/document/d/1QHkmiTF770GKxtoP-VQ1eKF42MpedLUeqiQPfCqus0Y/edit?usp=sharing Bug: v8:12547 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: Ic58f8750d2e14ecd573173d17d5235a136bedef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595460 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80789}
-