Commits · 24651e5be8b6c1875be70e47e80831b37b7e2737 · Linshizhi / V8

25 Apr, 2014 37 commits

MIPS: Unify and simplify the FastCloneShallowArrayStub. · 24651e5b

plind44@gmail.com authored Apr 25, 2014

Port r20974 (5de4367)

Original commit message:
- Don't bake in length/capacity into full codegen calls of stubs,
allowing boilerplates to increase their capacity without regenerating
code.
- Unify all variants of the clone stub into a single,
length-independent version.
- Various tweaks to make sure that the clone stub doesn't spill and
therefore need an eager stack frame.
- Handle all lengths of array literals in the fast case.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/258813002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20991 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

24651e5b

Runtime_KeyedGetProperty handlified. · 584e90f5

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/253603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20990 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

584e90f5

ARM64: Fix LCodeGen::ToOperand32. · 486a9fdb

Jacob.Bramley@arm.com authored Apr 25, 2014

This fixes the following generated code sequence:
  movn w1, #0     // Synthesize -1.
  cmp w0, w1

With a properly-constructed Operand, the MacroAssembler can optimize it
as follows:
  cmn w0, #1

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/253513003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20989 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

486a9fdb

Expose promise status through promise mirror. · 81a10167

yangguo@chromium.org authored Apr 25, 2014

R=aandrey@chromium.org, rossberg@chromium.org, yurys@chromium.org
BUG=v8:3093
LOG=Y

Review URL: https://codereview.chromium.org/257803005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20988 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81a10167

HashTableKey::AsObject() handlified. · ce14ab97

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250773004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20987 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce14ab97

*Shape::AsObject() are no longer used - removed. · dc1fe284

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/256773002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20986 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc1fe284

Remove static CallCompletedCallback handlers · c27da0c9

jochen@chromium.org authored Apr 25, 2014

BUG=none
R=svenpanne@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/249313002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20985 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c27da0c9

Enter a description of the change. · 8795d02b

jochen@chromium.org authored Apr 25, 2014

Reland 20968 - "Merge v8utils.* and utils.*"

>  BUG=none
>  R=mstarzinger@chromium.org
>  LOG=n
>
>  Review URL: https://codereview.chromium.org/256753002

BUG=none
LOG=n
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/250733004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20984 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8795d02b

Reland 20962 "Break cyclic reference between utils and platform." · 65a983a4

jochen@chromium.org authored Apr 25, 2014

Don't use OS::MemCopy in BitCast. It's crucial that the compiler can
optimize the memcpy away.

>  Platform includes utils.h for the definition of Vector<>, so utils.h
>  can't include platform.h and has to use memcpy instead of OS::MemCopy.
>
>  We split out Vector<> into its own header to break this cycle
>  dependency.
>
>  BUG=none
>  R=mstarzinger@chromium.org
>  LOG=n
>
>  Review URL: https://codereview.chromium.org/251753002

TBR=jkummerow@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/252683004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20983 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

65a983a4

ObjectHashTable's key and WeakHashTable's key types are now Handle<Object> instead of Object*. · 3ce91203

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/257853003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20982 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ce91203

Dictionary::SetEntry() and Dictionary::AddEntry() handlified. · a5bde585

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250913003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20981 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a5bde585

HashTable::New() handlified. · fd02e122

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/257633002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20980 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd02e122

Reland r20960: "HashTable::EnsureCapacity() handlified." · 88734238

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/256743002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20979 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

88734238

Fix materialization of accessor frames with captured receivers · ff884e06

jarin@chromium.org authored Apr 25, 2014

I have fixed skipping of the receiver object to materialize captured
objects. This is done with a new DoTranslateSkip method.

We should consider unifying DoTranslateSkip, DoTranslateObject and
DoTranslateCommand as they do the almost the same thing - they only
differ in where they store the result.

The change also turns bunch of ASSERTs into CHECKs.

R=mstarzinger@chromium.org
BUG=359441
TEST=test/mjsunit/regress/regress-359441.js
LOG=N

Review URL: https://codereview.chromium.org/225283006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20978 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff884e06

Move JSON-stringify webkit test to V8. · 19aa122d

ulan@chromium.org authored Apr 25, 2014

BUG=367089
LOG=N
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/254673005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20977 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

19aa122d

Revert 20962 "Break cyclic reference between utils and platform." · 4ed16eae

jochen@chromium.org authored Apr 25, 2014

>  Platform includes utils.h for the definition of Vector<>, so utils.h
>  can't include platform.h and has to use memcpy instead of OS::MemCopy.
>
>  We split out Vector<> into its own header to break this cycle
>  dependency.
>
>  BUG=none
>  R=mstarzinger@chromium.org
>  LOG=n
>
>  Review URL: https://codereview.chromium.org/251753002

BUG=none
LOG=n
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/254823002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4ed16eae

Revert 20968 - "Merge v8utils.* and utils.*" · f2a1176f

jochen@chromium.org authored Apr 25, 2014

>  BUG=none
>  R=mstarzinger@chromium.org
>  LOG=n
>
>  Review URL: https://codereview.chromium.org/256753002

BUG=none
LOG=n
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/250823003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20975 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f2a1176f

Unify and simplify the FastCloneShallowArrayStub · 198c4769

danno@chromium.org authored Apr 25, 2014

- Don't bake in length/capacity into full codegen calls of stubs,
  allowing boilerplates to increase their capacity without regenerating
  code.
- Unify all variants of the clone stub into a single,
  length-independent version.
- Various tweaks to make sure that the clone stub doesn't spill and
  therefore need an eager stack frame.
- Handle all lengths of array literals in the fast case.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/257563004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20974 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

198c4769

Fix for potential memory leak after putting to WeakObjectToCodeDependency table. · 9a842209

ishell@chromium.org authored Apr 25, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/254723004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20973 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9a842209

Let releases script retrieve information about chromium branches. · 0516f641

machenbach@chromium.org authored Apr 25, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/238443005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20972 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0516f641

Preserve Smi representation of non-escaping fields. · d557425a

jarin@chromium.org authored Apr 25, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/251493004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20971 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d557425a

Fix compilation with clang 5.1 on OS X. · a87b6b64

svenpanne@chromium.org authored Apr 25, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/250873003

Patch from Benedikt Meurer <bmeurer@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20970 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a87b6b64

Always include debugger support. · cb2f43cb

yangguo@chromium.org authored Apr 25, 2014

Motivation: we do not have test coverage for debuggersupport=off.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/256653004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20969 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb2f43cb

Merge v8utils.* and utils.* · c0380f6a

jochen@chromium.org authored Apr 25, 2014

BUG=none
R=mstarzinger@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/256753002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20968 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c0380f6a

Don't adopt the AST id from previous if id is none, since previous may have... · d2179f20

verwaest@chromium.org authored Apr 25, 2014

Don't adopt the AST id from previous if id is none, since previous may have mismatching expected stack height.
Additionally, harden merging of simulates after instructions with side effects and ensure there's a simulate before HEnterInlined.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/252583004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20967 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d2179f20

Remove lazy sweeping. · 20107bf2

hpayer@chromium.org authored Apr 25, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/254603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20966 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

20107bf2

Parser: Introduce StatementList + NewStatementList() · 2dd4b5f9

marja@chromium.org authored Apr 25, 2014

Adds new Traits::Type::StatementList definitions both for Parser and
PreParser, and the corresponding NewStatementList() factory function.
This is needed to be able to define in ParserBase parsing functions
that return and manipulate lists of statements.

Moving and renaming PreParser::Statement to PreParserStatement is also
needed so its definition is available earlier for PreParserStatementList
to use it.

R=marja@chromium.org

Review URL: https://codereview.chromium.org/252423007

Patch from Adrian Perez de Castro <aperez@igalia.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20965 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2dd4b5f9

Add tests for generator/debugger interaction · df07a827

wingo@igalia.com authored Apr 25, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/247003004


Review URL: https://codereview.chromium.org/256733004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20964 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

df07a827

Added an Isolate* field to NoTrackDoubleFieldsForSerializerScope,... · 66f0df5a

svenpanne@chromium.org authored Apr 25, 2014

Added an Isolate* field to NoTrackDoubleFieldsForSerializerScope, PlatformFeatureScope and BinaryOpIC::State.

The serializer state and even the CPU features will be per-Isolate
later. Currently we get away with global state, because mksnapshot
runs single-threaded and has only 1 Isolate, but this will change.
Furthermore, these changes are yet another prerequisite for removing a
catch-22 at initialization time when we try to enable serialization.

This CL is similar in spirit to r20919, BTW.

BUG=359977
LOG=y
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/250553005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20963 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

66f0df5a

Break cyclic reference between utils and platform. · 79be5398

jochen@chromium.org authored Apr 25, 2014

Platform includes utils.h for the definition of Vector<>, so utils.h
can't include platform.h and has to use memcpy instead of OS::MemCopy.

We split out Vector<> into its own header to break this cycle
dependency.

BUG=none
R=mstarzinger@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/251753002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20962 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

79be5398

Revert "HashTable::EnsureCapacity() handlified." · 9bda4a29

ishell@chromium.org authored Apr 25, 2014

This reverts commit r20960 for breaking Windows build.

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250893002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20961 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9bda4a29

HashTable::EnsureCapacity() handlified. · b1a7ae6b

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250643002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20960 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b1a7ae6b

WeakHashTable::Put() and callers handlified. · 96e5434b

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/253393006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20959 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

96e5434b

Dictionary::DeleteProperty() handlified. · 6d477530

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250023002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20958 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6d477530

Dictionary::New() handlified. · c8d36c71

ishell@chromium.org authored Apr 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/246743003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20957 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c8d36c71

Trigger debug event on not yet caught exception in promises. · 28f5cf39

yangguo@chromium.org authored Apr 25, 2014

R=aandrey@chromium.org, rossberg@chromium.org, yurys@chromium.org
BUG=v8:3093
LOG=Y

Review URL: https://codereview.chromium.org/249503002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28f5cf39

Unbreak vtunejit=on. · 7f217b9d

svenpanne@chromium.org authored Apr 25, 2014

BUG=v8:3288
LOG=y
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/254793002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7f217b9d

24 Apr, 2014 3 commits

ARM64: slightly modify weight for profiling counter · 0fc9354a

m.m.capewell@googlemail.com authored Apr 24, 2014

BUG=
R=ulan@chromium.org, bmeurer@chromium.org

Review URL: https://codereview.chromium.org/252443004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20952 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0fc9354a

Fix for build issue on Mac introduced in r20948. · 95f0c064

ishell@chromium.org authored Apr 24, 2014

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/251363004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20951 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

95f0c064

Dictionary::GenerateNewEnumerationIndices() and Dictionary::EnsureCapacity() handlified. · f8623283

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20950 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f8623283