- 27 Dec, 2016 6 commits
-
-
adamk authored
The TF version of this operation was missing a ToObject coercion, so failed to do @@toStringTag lookups when passed primitive values. R=franzih@chromium.org BUG=v8:5780 Review-Url: https://codereview.chromium.org/2597323002 Cr-Commit-Position: refs/heads/master@{#41961}
-
bakkot authored
This syntax was formerly legal per ECMAScript, but has been a SyntaxError for some time now. V8 deviates from spec in that it is instead a runtime error; we'd like to know if we can get away with removing it (at least in sloppy mode) or if the spec should be changed. c.f. https://github.com/tc39/ecma262/issues/257#issuecomment-195106880 Also add self to authors file BUG=v8:4480 Review-Url: https://codereview.chromium.org/2599253002 Cr-Commit-Position: refs/heads/master@{#41960}
-
littledan authored
This patch moves the creation of the Intl constructors from JavaScript to C++ in bootstrapper.cc, to match all of the other builtins exposed to the web. BUG=v8:5751 Review-Url: https://codereview.chromium.org/2586763002 Cr-Commit-Position: refs/heads/master@{#41959}
-
littledan authored
Revert of [intl] Remove redundant type checking system (patchset #3 id:40001 of https://codereview.chromium.org/2591203002/ ) Reason for revert: Issue https://bugs.chromium.org/p/chromium/issues/detail?id=677055 . I'll send out a follow-on reland, as it should still be possible to eliminate the redundant type system. Original issue's description: > [intl] Remove redundant type checking system > > Previously, the Intl implementation tracked types two ways: > - In the intl_initialized_marker_symbol > - In various named properties of the intl_impl_object_symbol value > > As far as I can tell, these will never disagree with each other, > modulo bugs in Intl itself. This patch removes the second type > checking system. > > BUG=v8:5751 > > Review-Url: https://codereview.chromium.org/2591203002 > Cr-Commit-Position: refs/heads/master@{#41941} > Committed: https://chromium.googlesource.com/v8/v8/+/0d5561b64d34129e6546947255e543c219c61655 TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5751 Review-Url: https://codereview.chromium.org/2601783002 Cr-Commit-Position: refs/heads/master@{#41958}
-
ulan authored
BUG=chromium:675911 Review-Url: https://codereview.chromium.org/2593043002 Cr-Commit-Position: refs/heads/master@{#41957}
-
danno authored
Review-Url: https://codereview.chromium.org/2600763002 Cr-Commit-Position: refs/heads/master@{#41956}
-
- 26 Dec, 2016 2 commits
-
-
machenbach authored
BUG=chromium:677032 NOTRY=true TBR=titzer@chromium.org Review-Url: https://codereview.chromium.org/2607473002 Cr-Commit-Position: refs/heads/master@{#41955}
-
machenbach authored
BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org Review-Url: https://codereview.chromium.org/2598323002 Cr-Commit-Position: refs/heads/master@{#41954}
-
- 25 Dec, 2016 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d14a3a7..bdc04ca TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2604693002 Cr-Commit-Position: refs/heads/master@{#41953}
-
- 24 Dec, 2016 3 commits
-
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#41952}
-
machenbach authored
Revert of [heap] Report wrappers after processing the marking deque incrementally (patchset #5 id:80001 of https://codereview.chromium.org/2604583002/ ) Reason for revert: Speculative revert. Might block the roll: https://codereview.chromium.org/2606503002/ The gpu bots crash with this stack top:v88internal18IncrementalMarking25AdvanceIncrementalMarkingEdNS1_16CompletionActionENS1_21ForceCompletionActionENS0_10StepOrigin Original issue's description: > [heap] Report wrappers after processing the marking deque incrementally > > BUG=chromium:676700, chromium:468240 > > Review-Url: https://codereview.chromium.org/2604583002 > Cr-Commit-Position: refs/heads/master@{#41946} > Committed: https://chromium.googlesource.com/v8/v8/+/1344e3a9caba4206758623630e3c3dd6872879e7 TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:676700, chromium:468240 Review-Url: https://codereview.chromium.org/2604673002 Cr-Commit-Position: refs/heads/master@{#41951}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/69a30f6..d14a3a7 Rolling v8/test/test262/harness: https://chromium.googlesource.com/external/github.com/test262-utils/test262-harness-py/+log/cbd968f..0f2acdd Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/810f05a..1e8a2ca Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/68d808f..7018464 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2599293004 Cr-Commit-Position: refs/heads/master@{#41950}
-
- 23 Dec, 2016 16 commits
-
-
gsathya authored
TBR=adamk@chromium.org Review-Url: https://codereview.chromium.org/2604483005 Cr-Commit-Position: refs/heads/master@{#41949}
-
machenbach authored
Revert of Disable the CompilerDispatcher if we don't have idle time (patchset #1 id:1 of https://codereview.chromium.org/2600743002/ ) Reason for revert: [Sheriff] Speculative revert since we got persistent timeouts on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6417 Please reland if it doesn't help. Original issue's description: > Disable the CompilerDispatcher if we don't have idle time > > Since we can't do all steps on background threads, we need idle time to > work > > BUG=v8:5215 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2600743002 > Cr-Commit-Position: refs/heads/master@{#41944} > Committed: https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a2d3184cbbfd6adb243e TBR=danno@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Review-Url: https://codereview.chromium.org/2600773002 Cr-Commit-Position: refs/heads/master@{#41948}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2604483002 Cr-Commit-Position: refs/heads/master@{#41947}
-
mlippautz authored
BUG=chromium:676700, chromium:468240 Review-Url: https://codereview.chromium.org/2604583002 Cr-Commit-Position: refs/heads/master@{#41946}
-
littledan authored
Fix issue created by patch https://codereview.chromium.org/2582993002/ CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng TBR=yangguo@chromium.org BUG=v8:4360 Review-Url: https://codereview.chromium.org/2599973002 Cr-Commit-Position: refs/heads/master@{#41945}
-
jochen authored
Since we can't do all steps on background threads, we need idle time to work BUG=v8:5215 R=danno@chromium.org Review-Url: https://codereview.chromium.org/2600743002 Cr-Commit-Position: refs/heads/master@{#41944}
-
littledan authored
ECMA 402 v2 made Intl constructors more strict in terms of how they would initialize objects, refusing to initialize objects which have already been constructed. However, when Chrome tried to ship these semantics, we ran into web compatibility issues. This patch tries to square the circle and implement the simpler v2 object semantics while including a compatibility workaround to allow objects to sort of be initialized later, storing the real underlying Intl object in a symbol-named property. The new semantics are described in this PR against the ECMA 402 spec: https://github.com/tc39/ecma402/pull/84 BUG=v8:4360, v8:4870 LOG=Y Review-Url: https://codereview.chromium.org/2582993002 Cr-Commit-Position: refs/heads/master@{#41943}
-
jarin authored
BUG=v8:5756 Review-Url: https://codereview.chromium.org/2596843002 Cr-Commit-Position: refs/heads/master@{#41942}
-
littledan authored
Previously, the Intl implementation tracked types two ways: - In the intl_initialized_marker_symbol - In various named properties of the intl_impl_object_symbol value As far as I can tell, these will never disagree with each other, modulo bugs in Intl itself. This patch removes the second type checking system. BUG=v8:5751 Review-Url: https://codereview.chromium.org/2591203002 Cr-Commit-Position: refs/heads/master@{#41941}
-
mlippautz authored
1) Alternate between processing v8 and wrappers 2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers 3) After that, finalize once v8 marking deque is empty again Reland fixed: Toggle needs to be IncrementalMarking global as we need to properly alternate tracing v8 and wrappers. BUG=chromium:468240, chromium:668164 Review-Url: https://codereview.chromium.org/2599283002 Cr-Commit-Position: refs/heads/master@{#41940}
-
danno authored
LoadFieldStub is the last Crankshaft/Hydrogen stub that stands in the way of being able to run --ignition-staging --turbo without any Crankshaft support, even for ICs/stubs. Review-Url: https://codereview.chromium.org/2595343002 Cr-Commit-Position: refs/heads/master@{#41939}
-
ivica.bogosavljevic authored
Reland 0cf56232 The original patch got reverted because testing RegisterConfiguration was overwritten by turbofan RegisterConfiguration. This caused some test cases not being properly tested. The new patch uses correct RegisterConfiguration. Original commit message: Test InstructionSequenceTest has been initialized with a testing RegisterConfiguration instance defined in instruction-sequence-unittest.h, whereas class ExplicitOperand which is being tested used RegisterConfiguration from instruction.cc. In case these two instances are different, the tests would fail. The issue is fixed by using the same instance of RegisterConfiguration both for test code and code under test. Additionally, the tests in register-allocator-unittest.cc use hardcoded values for register and begin failing is the hardcoded register is not available for allocation. Fix by forcing the use of allocatable registers only. TEST=unittests.MoveOptimizerTest.RemovesRedundantExplicit,unittests.RegisterAllocatorTest.SpillPhi BUG= Review-Url: https://codereview.chromium.org/2595293002 Cr-Commit-Position: refs/heads/master@{#41938}
-
kozyatinskiy authored
Now we run nested message loop with debugger context as current one. BUG=chromium:676749 R=yangguo@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2604553002 Cr-Commit-Position: refs/heads/master@{#41937}
-
mlippautz authored
Revert of Reland "[heap] Ensure progress when incrementally marking wrappers" (patchset #8 id:140001 of https://codereview.chromium.org/2591383004/ ) Reason for revert: Breaks webkit-unit-tests. Investigating.. Original issue's description: > Reland "[heap] Ensure progress when incrementally marking wrappers" > > 1) Alternate between processing v8 and wrappers > 2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers > 3) After that, finalize once v8 marking deque is empty again > > BUG= > > Review-Url: https://codereview.chromium.org/2591383004 > Cr-Commit-Position: refs/heads/master@{#41932} > Committed: https://chromium.googlesource.com/v8/v8/+/61a55548c50e01d84ed4aefa396324cbb4039b51 TBR=hpayer@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2592393003 Cr-Commit-Position: refs/heads/master@{#41936}
-
yangguo authored
Revert of [debugger] deprecate v8::Debug:GetDebugContext. (patchset #2 id:20001 of https://codereview.chromium.org/2589203002/ ) Reason for revert: crbug/676749 Original issue's description: > [debugger] deprecate v8::Debug:GetDebugContext. > > R=jgruber@chromium.org > BUG=v8:5530 > > Review-Url: https://codereview.chromium.org/2589203002 > Cr-Commit-Position: refs/heads/master@{#41911} > Committed: https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113 TBR=jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5530, chromium:676749 Review-Url: https://codereview.chromium.org/2595413003 Cr-Commit-Position: refs/heads/master@{#41935}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5c10e06..69a30f6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/489a5bc..810f05a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f6f94f4..68d808f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2594203005 Cr-Commit-Position: refs/heads/master@{#41934}
-
- 22 Dec, 2016 12 commits
-
-
joransiu authored
Improve the S390 allocate sequence by: - Keeping allocation limit in memory, and leverage compare RX-instr. - Prefetching subsequent cache lines from allocation top. - Optimizing object tagging with LA - Optimizing increment for Fast-Allocate with ASI/AGSI R=jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2601563002 Cr-Commit-Position: refs/heads/master@{#41933}
-
mlippautz authored
1) Alternate between processing v8 and wrappers 2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers 3) After that, finalize once v8 marking deque is empty again BUG= Review-Url: https://codereview.chromium.org/2591383004 Cr-Commit-Position: refs/heads/master@{#41932}
-
wez authored
Ignoring this linker warning will enable Chromium builds to start treating all linker warnings as errors in Windows builds. BUG=676417, 659007 Review-Url: https://codereview.chromium.org/2594013004 Cr-Commit-Position: refs/heads/master@{#41931}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2595423002 Cr-Commit-Position: refs/heads/master@{#41930}
-
adamk authored
These methods now return undefined upon finding a data property in the prototype chain which shadows an accessor property, and when hitting a Proxy, call the appropriate proxy traps. R=cbruni@chromium.org, littledan@chromium.org BUG=v8:5130 Review-Url: https://codereview.chromium.org/2592013003 Cr-Commit-Position: refs/heads/master@{#41929}
-
adamk authored
Revert of Turn on icu_case_mapping by default (patchset #4 id:60001 of https://codereview.chromium.org/2588963002/ ) Reason for revert: Causes crashes on Canary: crbug.com/676643 Original issue's description: > Turn on icu_case_mapping by default > > Update string-capitalize expected result because now it > passes all the tests in the file. > Mark fast/js/string-capitalization as failing with no_i18n. > > Relanding after revert because the failure was taken care of > by Adam's CL at https://codereview.chromium.org/2597543002 . > > > BUG=v8:4477, v8:4476 > TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, > mjsunit/string-case, intl/general/case* > > Cr-Original-Commit-Position: refs/heads/master@{#41834} > Committed: https://chromium.googlesource.com/v8/v8/+/7c79e23c34ea971947eedc6e42d8a882617c0e47 > Review-Url: https://codereview.chromium.org/2588963002 > Cr-Commit-Position: refs/heads/master@{#41883} > Committed: https://chromium.googlesource.com/v8/v8/+/a42c8c67dece5328896b13d37c5c846a2a0f5b0b TBR=littledan@chromium.org,yangguo@chromium.org,jshin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4477, v8:4476, chromium:676643 Review-Url: https://codereview.chromium.org/2601553002 Cr-Commit-Position: refs/heads/master@{#41928}
-
bmeurer authored
Similar to Crankshaft use the CallIC to continue gathering feedback for uninitialized call sites instead of inserting a soft deopt. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2597173002 Cr-Commit-Position: refs/heads/master@{#41927}
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2600513002 Cr-Commit-Position: refs/heads/master@{#41926}
-
bbudge authored
LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2589283002 Cr-Commit-Position: refs/heads/master@{#41925}
-
mlippautz authored
Revert of [heap] Ensure progress when incrementally marking wrappers (patchset #3 id:60001 of https://codereview.chromium.org/2592403002/ ) Reason for revert: This won't work because the finalization still checks whether both marking deques are empty, also calling into blink. So we never proceed there. Original issue's description: > [heap] Ensure progress when incrementally marking wrappers > > The problem here is estimating the marking step size for wrapper tracing. If the > steps are too small, we cannot keep up with the mutator creating new wrappers. > The result is an endless stream of incremental marking steps, alternating v8 and > wrappers tracing, without ever finalizing in a GC. > > The mitigation here is to abort finding the fix point after 10 incremental > iterations. > > A proper solution would track newly created wrappers on the blink side during > wrapper tracing. Will give this more thought after the holidays. > > BUG=chromium:668164, chromium:468240 > > Review-Url: https://codereview.chromium.org/2592403002 > Cr-Commit-Position: refs/heads/master@{#41923} > Committed: https://chromium.googlesource.com/v8/v8/+/a47417b89373c615f9256800cfc803d84ba58378 TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:668164, chromium:468240 Review-Url: https://codereview.chromium.org/2602433002 Cr-Commit-Position: refs/heads/master@{#41924}
-
mlippautz authored
The problem here is estimating the marking step size for wrapper tracing. If the steps are too small, we cannot keep up with the mutator creating new wrappers. The result is an endless stream of incremental marking steps, alternating v8 and wrappers tracing, without ever finalizing in a GC. The mitigation here is to abort finding the fix point after 10 incremental iterations. A proper solution would track newly created wrappers on the blink side during wrapper tracing. Will give this more thought after the holidays. BUG=chromium:668164, chromium:468240 Review-Url: https://codereview.chromium.org/2592403002 Cr-Commit-Position: refs/heads/master@{#41923}
-
tebbi authored
This divergence bug is very similar to the one fixed in https://codereview.chromium.org/2522253002/, this time it is an oscillation between a cleared field and a new phi node. The page http://www.sears.com/clothing-shoes-jewelry-clothing-men-s-clothing-men-s-jeans/b-1325287370?Brand=LEE&filterList=Brand&sortOption=UNITS_HIGH_TO_LOW allows for a reliable reproduction. This fix makes sure that once a field that generated a phi gets cleared, it always stays cleared. BUG=chromium:670202 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2599793002 Cr-Commit-Position: refs/heads/master@{#41922}
-