- 24 Apr, 2015 15 commits
-
-
arv authored
This reverts commit d5565c1f. Getter and setter function names in ES6 are defined as "get foo" and "set foo". This also moves the logic for handling symbols from runtime-function.cc to v8natives.js. BUG=None LOG=N R=adamk@chromium.org Review URL: https://codereview.chromium.org/1093183006 Cr-Commit-Position: refs/heads/master@{#28050}
-
jkummerow authored
Revert of Lazily register prototype users (patchset #2 id:20001 of https://codereview.chromium.org/1104813004/) Reason for revert: Suspected of causing GC stress failures. Original issue's description: > Lazily register prototype users > > when handing out validity cells to handles; because invalidating said cells is the only time we'll need the user registrations. > Along the way, fix a corner case in WeakFixedArray, which can now be empty after the recently introduced compaction support. > > Committed: https://crrev.com/a4bb7643c076b014816431a9b85af3e2edf828e7 > Cr-Commit-Position: refs/heads/master@{#28047} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1108583002 Cr-Commit-Position: refs/heads/master@{#28049}
-
marja authored
Follow up for r28032. We don't need to store the "corresponding outer scope class variables", it's enough if we transmit the declaration group start to the inner class variable. R=rossberg@chromium.org BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1102903002 Cr-Commit-Position: refs/heads/master@{#28048}
-
jkummerow authored
when handing out validity cells to handles; because invalidating said cells is the only time we'll need the user registrations. Along the way, fix a corner case in WeakFixedArray, which can now be empty after the recently introduced compaction support. Review URL: https://codereview.chromium.org/1104813004 Cr-Commit-Position: refs/heads/master@{#28047}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1089853005 Cr-Commit-Position: refs/heads/master@{#28046}
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for binary arithmetic operations, not including the + special case. Adds some infrastructure for future implementation of the restrictions for other operators. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1092353002 Cr-Commit-Position: refs/heads/master@{#28045}
-
marja authored
ClassVariable should always have the kind CLASS, let's not pretend there are other options. R=rossberg@chromium.org BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1106483003 Cr-Commit-Position: refs/heads/master@{#28044}
-
mstarzinger authored
This introduces a bailout point for class literals right after the %DefineClass function has been called. Otherwise the FrameState after class literal evaluation might contain the literal itself. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-480819 BUG=chromium:480819 LOG=N Review URL: https://codereview.chromium.org/1104673004 Cr-Commit-Position: refs/heads/master@{#28043}
-
vogelheim authored
Lolcode candidate: Both Expression and FunctionLiteral define an accessor is_parenthesized(), which access different flags. FunctionLiteral derives from Expression. Given FunctionLiteral* a; a->is_parenthesized() const FunctionLiteral* b; b->is_parenthesized() the first accesses FunctionLiteral::IsParenthesized, the second accesses Expression::IsParenthesizedField. Since these are distinct uses, we could rename them based on their use: - Expression::is_parenthesized -> is_single_parenthesized Count # of parenthesis, for parsing & error handling: no parenthesis -> single parenthesis -> multi parenthesis - FunctionLiteral::eager_compile_hint() Hint from parser to compiler about whether the parser suggests this function for eager compilation. BUG= Review URL: https://codereview.chromium.org/1097723005 Cr-Commit-Position: refs/heads/master@{#28042}
-
bmeurer authored
BUG=chromium:480807 LOG=n R=jarin@chromium.org Review URL: https://codereview.chromium.org/1101273002 Cr-Commit-Position: refs/heads/master@{#28041}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1096243003 Cr-Commit-Position: refs/heads/master@{#28040}
-
wingo authored
R=svenpanne@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1105653002 Cr-Commit-Position: refs/heads/master@{#28039}
-
jochen authored
Revert of Reland "Remove the weak list of views from array buffers" (patchset #2 id:20001 of https://codereview.chromium.org/1093183004/) Reason for revert: still working on perf Original issue's description: > Reland "Remove the weak list of views from array buffers" > > Original description: > > Instead, views have to check their array buffer for whether > > it's neutered or not. > > > > BUG=v8:3996 > > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f > Cr-Commit-Position: refs/heads/master@{#28029} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1053203007 Cr-Commit-Position: refs/heads/master@{#28038}
-
marja authored
Revert of Eagerly declare eval scopes, even for sloppy scopes (patchset #2 id:20001 of https://codereview.chromium.org/1085263003/) Reason for revert: Regresses CodeLoad (crbug.com/480774). Original issue's description: > Eagerly declare eval scopes, even for sloppy scopes > > R=marja@chromium.org, mstarzinger@chromium.org > LOG=N > BUG=N > > Committed: https://crrev.com/fe9efc121c8cba8b6aee1a9cf36c68ee97c44d99 > Cr-Commit-Position: refs/heads/master@{#28027} TBR=mstarzinger@chromium.org,verwaest@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Review URL: https://codereview.chromium.org/1082013003 Cr-Commit-Position: refs/heads/master@{#28037}
-
v8-autoroll authored
Rolling v8/tools/clang to ed8476f8e39660d1926dddff78cc8446527f9b9c TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1079163012 Cr-Commit-Position: refs/heads/master@{#28036}
-
- 23 Apr, 2015 15 commits
-
-
arv authored
Revert of [es6] Map/Set size getter should have "get size" name (patchset #4 id:80001 of https://codereview.chromium.org/1094323005/) Reason for revert: Breaks GCMole ia32 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1685/steps/GCMole%20ia32/logs/stdio src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation order. f->shared()->set_name(*NameToFunctionName(name)); ^ src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation order. 2 warnings generated. Original issue's description: > [es6] Map/Set size getter should have "get size" name > > Getter and setter function names in ES6 are defined as "get foo" and > "set foo". > > BUG=None > LOG=N > R=adamk@chromium.org > > Committed: https://crrev.com/83c89a2e71a363afb35595f903423e650d788e42 > Cr-Commit-Position: refs/heads/master@{#28034} TBR=adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/1106713002 Cr-Commit-Position: refs/heads/master@{#28035}
-
arv authored
Getter and setter function names in ES6 are defined as "get foo" and "set foo". BUG=None LOG=N R=adamk@chromium.org Review URL: https://codereview.chromium.org/1094323005 Cr-Commit-Position: refs/heads/master@{#28034}
-
mvstanton authored
If the length of the array prototype is changed, be sure to turn off the guarantee that it's elements are empty. This case was missed in https://codereview.chromium.org/1092043002 ("Protect the emptiness of Array prototype elements with a PropertyCell") R=jkummerow@chromium.org BUG=479781 LOG=N Review URL: https://codereview.chromium.org/1099453007 Cr-Commit-Position: refs/heads/master@{#28033}
-
marja authored
Add the restriction that both classes must be declared inside the same consectutive class declaration batch. Dependency analysis not implemented yet. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1060913005 Cr-Commit-Position: refs/heads/master@{#28032}
-
wingo authored
A strict arrow function with no parameters and no variable bindings won't need a context object because it will never have any locals. (This is unlike strict normal functions, which do have "arguments" and "this" locals.) R=rossberg@chromium.org BUG=v8:4056 LOG=N Review URL: https://codereview.chromium.org/1093183003 Cr-Commit-Position: refs/heads/master@{#28031}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1087133004 Cr-Commit-Position: refs/heads/master@{#28030}
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1093183004 Cr-Commit-Position: refs/heads/master@{#28029}
-
svenpanne authored
The RawMachineAssembler now behaves like the rest of TurboFan, removing the need for some special cases. Review URL: https://codereview.chromium.org/1090393003 Cr-Commit-Position: refs/heads/master@{#28028}
-
wingo authored
R=marja@chromium.org, mstarzinger@chromium.org LOG=N BUG=N Review URL: https://codereview.chromium.org/1085263003 Cr-Commit-Position: refs/heads/master@{#28027}
-
bmeurer authored
Now all nodes that care about deoptimization always take frame state inputs no matter whether deoptimization is enabled for a particular function. In case that deoptimization is off, the AstGraphBuilder just inserts the empty frame state. This greatly simplifies the logic in various places and makes testing easier as well, and is probably the first step towards enabling --turbo-deoptimization by default. There seems to be no noticable performance impact on asm.js programs. Also fix the graph replay in order to regenerate the scheduler unittests. Review URL: https://codereview.chromium.org/1106613003 Cr-Commit-Position: refs/heads/master@{#28026}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1086563004 Cr-Commit-Position: refs/heads/master@{#28025}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1099783003 Cr-Commit-Position: refs/heads/master@{#28024}
-
v8-autoroll authored
Rolling v8/tools/clang to 39ed8f11082b1f0a226436955efcacc38aed2d5e TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1106553003 Cr-Commit-Position: refs/heads/master@{#28023}
-
jarin authored
BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/1055453006 Cr-Commit-Position: refs/heads/master@{#28022}
-
arv authored
ES6 specifies the function name property (it was not part of ES5) and it specifies the name of Function.prototype to the empty string ("" and not "Empty"). This makes us match Firefox, Safari and IE developer preview. BUG=v8:4033 LOG=N R=adamk@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1080393004 Cr-Commit-Position: refs/heads/master@{#28021}
-
- 22 Apr, 2015 10 commits
-
-
paul.lind authored
Emscripten use of typed-arrays is little-endian only. BUG= Review URL: https://codereview.chromium.org/1082723007 Cr-Commit-Position: refs/heads/master@{#28020}
-
machenbach authored
BUG=v8:3924,v8:3969,chromium:478788 NOTRY=true LOG=n Review URL: https://codereview.chromium.org/1095893004 Cr-Commit-Position: refs/heads/master@{#28019}
-
mtrofin authored
This change aims to introduce the separation of the RegisterAllocator model, using the initial prototype for GreedyAllocator as proof of concept. Summary: - new flag, turbo-greedy-regalloc, enabling the new allocator. Default false. - initial, untested implementation for the GreedyAllocator. BUG= Review URL: https://codereview.chromium.org/1061923005 Cr-Commit-Position: refs/heads/master@{#28018}
-
arv authored
Revert of Introducing the LLVM greedy register allocator. (patchset #10 id:410001 of https://codereview.chromium.org/1061923005/) Reason for revert: Breaks Static Initializers test. http://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/3210/steps/Static-Initializers/logs/stdio Original issue's description: > Introducing the LLVM greedy register allocator. > > This change aims to introduce the separation of the RegisterAllocator model, > using the initial prototype for RegisterAllocatorGreedy as proof of concept. > > Summary: > - new flag, turbo-greedy-regalloc, enabling the new allocator. Default > false. > - separated RegisterAllocator into a base type and two derived, > RegisterAllocatorLinear (the one currently used in TurboFan) and > RegisterAllocatorGreedy (the new one). > - initial, untested impementation for the greedy allocator. > > BUG= > > Committed: https://crrev.com/ec542dea6b6a0cb82d1578a389569d019a59121d > Cr-Commit-Position: refs/heads/master@{#28015} TBR=dcarney@chromium.org,titzer@chromium.org,jarin@chromium.org,jvoung@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1080953006 Cr-Commit-Position: refs/heads/master@{#28017}
-
arv authored
BUG=v8:4009 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/1101543002 Cr-Commit-Position: refs/heads/master@{#28016}
-
mtrofin authored
This change aims to introduce the separation of the RegisterAllocator model, using the initial prototype for RegisterAllocatorGreedy as proof of concept. Summary: - new flag, turbo-greedy-regalloc, enabling the new allocator. Default false. - separated RegisterAllocator into a base type and two derived, RegisterAllocatorLinear (the one currently used in TurboFan) and RegisterAllocatorGreedy (the new one). - initial, untested impementation for the greedy allocator. BUG= Review URL: https://codereview.chromium.org/1061923005 Cr-Commit-Position: refs/heads/master@{#28015}
-
jochen authored
Revert of Remove the weak list of views from array buffers (patchset #6 id:100001 of https://codereview.chromium.org/1094863002/) Reason for revert: I'm reverting this while working on the regression fix Original issue's description: > Remove the weak list of views from array buffers > > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c > Cr-Commit-Position: refs/heads/master@{#27995} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1061753008 Cr-Commit-Position: refs/heads/master@{#28014}
-
titzer authored
R=jarin@chromium.org,mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1100113002 Cr-Commit-Position: refs/heads/master@{#28013}
-
yangguo authored
TBR=mstarzinger@chromium.org NOTRY=true BUG=v8:4055 LOG=N Review URL: https://codereview.chromium.org/1098293002 Cr-Commit-Position: refs/heads/master@{#28012}
-
yangguo authored
Revert of Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/1098223004/) Reason for revert: Test failure was not due to this. Original issue's description: > Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/1094383004/) > > Reason for revert: > GC stress failure (custom snapshot) > > Original issue's description: > > Always optimize for adding properties to native objects. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/c715098e85b93def76c0b3f54290c811dea04f01 > > Cr-Commit-Position: refs/heads/master@{#28003} > > TBR=jkummerow@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/bb6958ceff221e66adbc4581471a8ce1b41a4684 > Cr-Commit-Position: refs/heads/master@{#28009} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1100123002 Cr-Commit-Position: refs/heads/master@{#28011}
-