- 26 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This way, we can also check the return code of d8. We currently have a bug (6981) which makes failing tests not being detected, even though the failure message is (sometimes) being printed. After this refactoring, we can write tests for our mjsunit test functions. R=machenbach@chromium.org Bug: v8:6981 Change-Id: I0aa0abcb0f9a4f622a1e1d1a4d826da1e6eb4f07 Reviewed-on: https://chromium-review.googlesource.com/737991Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48951}
-
- 18 Aug, 2017 1 commit
-
-
Adam Klein authored
Currently, Declaration stores a Scope pointer to whichever Scope the declaration appeared in. This is used to disallow var declarations being hoisted over lexical declarations. For example: { let x; { var x; } } But in fact this is the only sort of case where storing the scope is required: for lexical declarations (including function declarations appearing in blocks), Declaration::scope() was always identical to Declaration::proxy()->var()->scope(). That is, only var declarations end up "nested" in this way. This patch adds a subclass of VariableDeclaration to store the Scope. Since the only thing that cares about that data is Scope analysis, this isn't treated as a distinct AstNode::NodeType from VariableDeclaration, leaving all AstVisitors untouched in the process. Also reworked the logic in Scope::CheckConflictingVarDeclarations() for clarity after making changes to accomodate the new code. Change-Id: I6ee4298700508ab9e28a76ddb8504bae68bc473f Reviewed-on: https://chromium-review.googlesource.com/619595 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47441}
-
- 30 Sep, 2015 1 commit
-
-
adamk authored
Arrow functions have been enabled by default since the 4.5 branch. Review URL: https://codereview.chromium.org/1373633002 Cr-Commit-Position: refs/heads/master@{#31031}
-
- 14 Jul, 2015 1 commit
-
-
littledan authored
Duplicate parameters are banned both overall in strict mode and also in arrow functions. Our error message for both cases blamed strict mode, which is confusing. This patch fixes the message to point to arrow functions as a possible source as well. R=wingo, adamk LOG=N Review URL: https://codereview.chromium.org/1236863008 Cr-Commit-Position: refs/heads/master@{#29662}
-
- 24 Jun, 2015 1 commit
-
-
wingo authored
Some tokens need special messages because their token corresponds to many names. R=arv@chromium.org BUG=v8:4213 LOG=N Review URL: https://codereview.chromium.org/1207743004 Cr-Commit-Position: refs/heads/master@{#29262}
-
- 10 Jun, 2015 1 commit
-
-
wingo authored
R=dslomov@chromium.org, rossberg@chromium.org LOG=Y BUG=v8:2700 Review URL: https://codereview.chromium.org/1178523002 Cr-Commit-Position: refs/heads/master@{#28908}
-
- 01 Jun, 2015 1 commit
-
-
conradw authored
A mistake in a recent CL has messed up the error messages for strong object semantics. BUG= LOG=N Review URL: https://codereview.chromium.org/1166433007 Cr-Commit-Position: refs/heads/master@{#28741}
-
- 02 Mar, 2015 1 commit
-
-
Jaroslav Sevcik authored
Deferred replacement must also replace in the pending node vector. BUG=chromium:463056 LOG=n R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/966423002 Cr-Commit-Position: refs/heads/master@{#26938}
-
- 27 Jan, 2015 1 commit
-
-
jarin authored
BUG=chromium:451012 LOG=n R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/874983002 Cr-Commit-Position: refs/heads/master@{#26281}
-
- 22 Jan, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-450642 BUG=chromium:450642 LOG=N Review URL: https://codereview.chromium.org/865833002 Cr-Commit-Position: refs/heads/master@{#26218}
-
- 07 Jan, 2015 1 commit
-
-
ishell authored
BUG=chromium:444805 LOG=Y Review URL: https://codereview.chromium.org/793333003 Cr-Commit-Position: refs/heads/master@{#25978}
-
- 05 Jan, 2015 1 commit
-
-
jarin authored
TEST=mjsunit/compiler/regress-445876 BUG=chromium:445876 LOG=N Review URL: https://codereview.chromium.org/830293003 Cr-Commit-Position: refs/heads/master@{#25959}
-
- 03 Jan, 2015 1 commit
-
-
jarin authored
This prevents eliminating effectful statements before the loop. BUG= Review URL: https://codereview.chromium.org/830923002 Cr-Commit-Position: refs/heads/master@{#25953}
-
- 24 Jun, 2014 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org, danno@chromium.org BUG=387636 LOG=Y Review URL: https://codereview.chromium.org/331863015 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21959 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Jun, 2014 1 commit
-
-
bmeurer@chromium.org authored
BUG=380512 LOG=y R=jarin@chromium.org Review URL: https://codereview.chromium.org/313073003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Apr, 2014 1 commit
-
-
jarin@chromium.org authored
This is to avoid triggering an assertion from Smi::FromInt. The generated code is unreachable, so it is not a real bug. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/221743005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=verwaest@chromium.org, bmeurer@chromium.org BUG=chromium:357330 LOG=Y Review URL: https://codereview.chromium.org/219333003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20366 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Feb, 2014 3 commits
-
-
hpayer@chromium.org authored
BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/184393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG=347904 LOG=y R=hpayer@chromium.org Review URL: https://codereview.chromium.org/184303003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
LOG=y BUG=347542 R=yangguo@chromium.org Review URL: https://codereview.chromium.org/183763007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19592 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Feb, 2014 1 commit
-
-
rossberg@chromium.org authored
R=arv@chromium.org, mstarzinger@chromium.org BUG=346141 LOG=Y Review URL: https://codereview.chromium.org/177883002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Feb, 2014 1 commit
-
-
verwaest@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/165743003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Feb, 2014 1 commit
-
-
yangguo@chromium.org authored
R=dslomov@chromium.org BUG=v8:3159 LOG=N Review URL: https://codereview.chromium.org/163293002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-