- 08 Jan, 2020 30 commits
-
-
Joshua Litt authored
This reverts commit 766aeb99. Reason for revert: clusterfuzz Bug: chromium:1040238 Original change's description: > Reland "[promises] Port Promise.race to Torque." > > Fixes clusterfuzz bug. > > This is a reland of 15ec4a09 > > Original change's description: > > [promises] Port Promise.race to Torque. > > > > Bug: v8:9838 > > Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919 > > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65562} > > Bug: v8:9838 > Change-Id: Id295a12023195511289d92517936733ab22cdf4b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988542 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65613} TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org Bug: v8:9838 Change-Id: I1d14eae04ee228806f69b489ab2d86e87fec1ae5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991808Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Auto-Submit: Joshua Litt <joshualitt@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65649}
-
Johannes Henkel authored
E.g. see https://chromium.googlesource.com/deps/inspector_protocol/+log Change-Id: I0b38d2813bbe99be2bcce12390369e57125e728d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991804Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65648}
-
Santiago Aboy Solanes authored
We were missing some possible load compressions due to not having these bitcasts as cases. Bug: v8:7703 Change-Id: I866196c4fd09d313d3a461cb7f8f80bc92278e13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989830Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65647}
-
Deepti Gandluri authored
These are already enabled by default on Chrome, but disabled on platforms without site isolation. Moving to staging to get some fuzzer coverage. Bug: v8:10065 Change-Id: I11309926109441083ca39406dfbcc9108e6dd6fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972406Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65646}
-
Johannes Henkel authored
Upstream PR: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1989575 Remove support for emitting cbor into an std::string. New Revision: b29d8a5d2bb56b3e555bb27a0e035a9d571c5f28 Change-Id: I6bf63822c4c6551db30f5902d1f27f6933b209a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989973 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65645}
-
Milad Farazmand authored
Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65644}
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: I2259e72829c0ad688284dcecef8aaf418ad53022 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980503Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65643}
-
Ng Zhi An authored
For I16x8Splat and I8x16Splat, the arguments takes I32, which can hold a value larger than what should be splatted. We add tests to check that the splatted values is the truncated I32 value (top bits masked off). See https://github.com/WebAssembly/simd/pull/151 for the updated to proposal text. Change-Id: Ib32770872e70c7cde2028130d2b44b416594610e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986200Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: If2cbae09eb0628cd4d29bb1768d1ef7d1659e683 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1990128 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Dominik Inführ authored
So far creating scripts always grew the script_list without ever reusing cleared slots or shrinking. While this is probably not a problem with script_list in practice, this is still a memory leak. Fix this leak by using WeakArrayList::Append instead of AddToEnd. Append adds to the end of the array, but potentially compacts and shrinks the list as well. Other WeakArrayLists can use this method as well, as long as they are not using indices into this array. Bug: v8:10031 Change-Id: If743c4cc3f8d67ab735522f0ded038b2fb43e437 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967385 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65640}
-
Leszek Swirski authored
Clean up isolate inference and non-allocating/allocating parts of SharedFunctionInfo::InitFromFunctionLiteral, so that it can more easily be refactored for off-thread allocation in the future. Also, make SharedFunctionInfo::SetScript a member function, to acknowledge that it is non-allocating. Bug: chromium:1011762 Change-Id: I26624fceb642dfdf257ec3d96aab31ea90e48870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991482 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 7a0ae73b. Reason for revert: Not useful after all, no tests, we can reland if we do end up needing it. Original change's description: > [ast] Add a Flatten method for AstConsString > > This allows off-thread flattening. > > Bug: chromium:1011762 > Change-Id: If83f7bbcbf74165987a4c157184f5b92dc554971 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924437 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65075} TBR=leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1011762 Change-Id: Ia72e5abdc9b6149a337565576806427dcd1d11c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991484Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65638}
-
Milad Farazmand authored
Port cb4ff11d R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I830f055201e8fe873b3e7721d4c117715f620f14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991321Reviewed-by:
-
Jakob Kummerow authored
Add jkummerow, thibaudm, zhin; drop titzer. Also make src/wasm/OWNERS the source of truth and let test-specific OWNERS files refer to that. No-Try: true Change-Id: I9862ae452970e20b7842269721ad6a7953f275fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989827 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Backes authored
For finching Liftoff on mobile, we want to support Liftoff-only, TurboFan-only, and Liftoff with tier-up to TurboFan. Hence, chrome needs to be able to set the liftoff flag separately from the tier-up flag, and there should not be an implication, since that implication would be applied before all flags have been set to their final state. See https://crrev.com/c/1988360 for the chromium-side change. Note that this CL does not change any defaults. After this change, Liftoff can be disabled by passing '--no-liftoff', independent of the tier-up flag (this would be a TurboFan-only configuration). A Liftoff-only version would specify --liftoff and --no-wasm-tier-up. The default on Desktop (--liftoff and --wasm-tier-up) compiles with Liftoff first, and tiers up to TurboFan. R=ahaas@chromium.org Bug: chromium:1040061 Change-Id: I0291ec20f5a29f3a9e23c25c93907d1d8ffabd51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988548Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65635}
-
Santiago Aboy Solanes authored
The only one remaining was the one in CSA. Once that was removed, we can simplify the pipeline. In order to remove it, we have to update the machine graph verifer so that Word32Equal can accept Tagged values as well. Bug: v8:7703 Change-Id: Ia3c4d872babc2005be1b402b4614a6039c59dbf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1987254 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Clemens Backes authored
It has been deprecated in v7.9, but needed to be changed again for v8.0 by providing a default implementation. This allowed embedders to remove all overrides. We can now remove the definitions in v8.1. R=ulan@chromium.org CC=ahaas@chromium.org Bug: v8:9810 Change-Id: I9d303bf8a01d863bce3522abccdd3ded5e551818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868620Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65633}
-
Nico Hartmann authored
The optimized code for String.charCodeAt(BigInt.asUintN(64, 10n)) did not throw a TypeError due to how lowering of CheckBounds triggers RepresentationChanger. Bug: chromium:1038573 Change-Id: Ie0f9ca95de5af5fd3701841ab169e11ccc77216c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986003 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65632}
-
Mythri A authored
Reland after disabling flaky test-cpu-profiler tests Reland the cl with fixes to TSAN failures. This reverts commit 03c9de73. Original change's description: > Revert "[TurboFan] Don't serialize read-only heap objects" > > This reverts commit 9f18e55f. > > Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/29660 > > Original change's description: > > [TurboFan] Don't serialize read-only heap objects > > > > Read-only heap objects are immutable and immovable. It is safe to access > > these objects directly from the heap. Not having to serialize them > > reduces the time we spend on main thread especially for TurboProp. > > > > Bug: v8:9684 > > Change-Id: Ibabb7076af50c9007d2a8ed57fe257406958fb6a > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955596 > > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > > Reviewed-by: Maya Lekova <mslekova@chromium.org> > > Commit-Queue: Mythri Alle <mythria@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65490} > > TBR=mvstanton@chromium.org,neis@chromium.org,mythria@chromium.org,mslekova@chromium.org > > Change-Id: If2d8649cdc083f7d064684352501320a96a1ba2c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:9684 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973732 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65492} TBR=mvstanton@chromium.org,neis@chromium.org,mythria@chromium.org,mslekova@chromium.org,nicohartmann@chromium.org Bug: v8:9684 Change-Id: I71fb438b9387f7fef8b36629bb947335065474f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980573Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Maya Lekova authored
Put the nesting limit of the serializer back to 25. Bug: chromium:1034768 Change-Id: I7ea827d27241ea930bae40142069bab1962e4133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981156 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Remove the explicit script handle from ParseInfo, and make it either a Handle that is passed around where needed, or one inferred from the SharedFunctionInfo. This will be useful for compilation finalization using the off-thread factory, which will not generate real Handles since it has no access to the Isolate. Bug: chromium:1011762 Change-Id: I5d9564009ec83bb9fc74191b4aa69735d132c2f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977861Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65629}
-
jing.bao authored
Currently, the code does not take hint register in preference. This CL initializes current_free according to initial reg (which maybe hint_reg), to ensure that any candidate that equals this one won't replace hint register. Contributed by yolanda.chen@intel.com Change-Id: I6acc1d031e6b130e69d650667dbf98551c52ff7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973671 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65628}
-
Mythri A authored
Skip test-cpu-profiler/Inlining2 and test-cpu-profiler/CrossScriptInliningCallerLineNumbers2 on win debug build. Bug: v8:10107 Change-Id: If4382db8ae79d6f59dcafefc4ba3c4e93bb2fa22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981158Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: v8:8170 Change-Id: I4b4a2919f6cf613779eeabc6c2cec1b08fa4d80f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981152Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65626}
-
Tobias Tebbi authored
The code in TurboAssembler::LoadFromConstantsTable uses special code to avoid clobbering the scratch register ip by giving different argument registers to ldr. This used to be motivated by DirectCEntryStub::GenerateCall relying on LookupConstant not clobbering ip (see https://crrev.com/c/1070980). Now that this code is gone, there is no more reason for preserving ip and it's fragile, so it's better to remove this special handling. Bug: v8:10077 Change-Id: I683d7c63e2a3c8ba554cd99299206ed9e5df835d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981160Reviewed-by:
-
Clemens Backes authored
Background threads are not supposed to use any handles, so this handle scope is not needed. R=ahaas@chromium.org Change-Id: I2f4776b897256684205c35633fbe1e1365abab91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981151Reviewed-by:
-
Leszek Swirski authored
AllocateScopeInfos should only be called for not-yet unallocated scopes, so we can DCHECK for nullness rather than having a branch for it. Change-Id: I65767c22d6fd7b12c4564c5ecc52f9486229affa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981159Reviewed-by:
-
Leszek Swirski authored
Most dead variable warnings in GCMole are false positives, either from failing to detect that TryEvacuateObject returning false means it didn't allocate, or a regex error thinking that GarbageCollectionReasonToString causes garbage collection (because the mangled version is something like GarbageCollectionReasonToString[...]GarbageCollectionReason, and that matches /Collect.*Garbage/). Update the whitelist and fix the "Collect.*Garbage" regex to only look at the function name. Bug: v8:9985 Change-Id: I62284e97e4975a6a87616d1d535b2ac7958d17bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989829 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ddd521..6e49eef Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3543506..a209c4d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a814502..3a797af TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8644df0de721110e89df0df1dd474bf9861e5f74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65621}
-
Frank Tang authored
I2S https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/vE4i42C2MUs/Sb804J3fBQAJ I2I https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/muRQBwyzzPw/FgdwgcbnAgAJ Design Doc: https://shorturl.at/emEHW Chrome Status: https://www.chromestatus.com/feature/4965112605573120 Latest spec: https://tc39.es/proposal-intl-displaynames/ Spec Github: https://github.com/tc39/proposal-intl-displaynames LGTMs: bratell.d@gmail.com / chrishtr@chromium.org / yoav@yoav.ws Bug: v8:8703 Change-Id: Iaf4f94d813fa742989ab149420d07f6f6f523443 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1982802 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 07 Jan, 2020 10 commits
-
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Iffa5613f0d4226a25519feab8c2246be8e462cc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981073 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10039 Change-Id: I3568bd3d01508e8bca81959341c75369c5bdf700 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958051Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: Ie3231038312495c2d8f77062ee5b81b2b55ab4d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980502Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9415 Bug: v8:10021 Change-Id: I77c24b58f575b612e5422bfcb9bb7ab83986659a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986249Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10039 Change-Id: If7c9668821a1cdfd5968f1533c3412247567bf3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955550Reviewed-by:
-
Z Nguyen-Huu authored
This is reland of 6ce3046e Skip the test in multi-isolates config. Bug: v8:9654 Change-Id: I035c867c99219bbf8d4fa25b58c734306e25fa63 Original change's description: > [wasm] Add support to tier down/up Wasm NativeModule > > This is the first part of switching between Liftoff and Turbofan in > debugging Wasm. In this CL, we implemented the logic to tier down/up all > functions in module. > > Bug: v8:9654 > Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65529} Change-Id: I035c867c99219bbf8d4fa25b58c734306e25fa63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985032 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Joshua Litt authored
Fixes clusterfuzz bug. This is a reland of 15ec4a09 Original change's description: > [promises] Port Promise.race to Torque. > > Bug: v8:9838 > Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919 > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65562} Bug: v8:9838 Change-Id: Id295a12023195511289d92517936733ab22cdf4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988542Reviewed-by:
-
Leszek Swirski authored
PerformSideEffectCheckAtBytecode calls Isolate::TerminateExecution on failure, which can allocate. We can avoid Handles by only accessing the frame's function object after the side effect check. Bug: v8:9991 Change-Id: Iac74f8cf5ff0840a18c59faab4c256a3fa9d5b25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989825 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Backes authored
Instead of having both a templatized and a parameter-based method, just have the parameter-based one, but make it constexpr. DCHECKs in these constexpr methods need to be guarded because GCC 5 does not support them yet. R=thibaudm@chromium.org Bug: v8:10021 Change-Id: If362de42f1a4c2cda4435fce63beb9244795d008 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986001Reviewed-by:
-
Seth Brenith authored
This change updates GetObjectProperties to list all of the bitfields within a class field, if that class field's type is a bitfield struct. The representation of bitfields in the GetObjectProperties response is very similar to the representation of struct fields, but with two extra bytes of data specifying the shift and size of the bitfield. Bug: v8:9376 Change-Id: I40a22169f3d01652a7f2db8cface43c2a1e30cfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960835Reviewed-by:
-
