- 18 Feb, 2020 21 commits
-
-
Shu-yu Guo authored
When running microtasks, the auto policy currently only invokes MicrotasksCompletedCallbacks when the microtask queue is non-empty, while all other policies unconditionally invokes the callbacks. Make the auto mode also unconditionally invoke the callbacks. Bug: v8:10213 Change-Id: I2f608459960b84e6f506646712ac935130646b9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2057813Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66320}
-
Seth Brenith authored
Please take a look at tools/v8windbg/README.md for an overview of what v8windbg can do and how it's structured. This platform-specific debugging plugin makes use of the data provided by the V8 postmortem debugging API in tools/debug_helper. Note: This code began as https://github.com/billti/v8dbg and then moved into the Edge repository, where I added features gradually and got code reviews for individual changes. Now, taken in its entirety, it's an obnoxiously large CL. I'm open to breaking it up into a few chunks if that would be preferable. Bug: v8:9376 Change-Id: I3e503de00bb1aea870ae83e9bd99e4e2eab9ef98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2031700Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66319}
-
Seth Brenith authored
This allows CoverageInfo to be distinguished from other kinds of FixedArray at runtime. I also updated it to use untagged data since it only stores ints, since that seems like the generally right thing to do (even though I doubt anybody allocates enough of these to notice the reduced GC work). Related Torque changes: - Allow structs containing untagged data to be used as class fields. This requires classifying them into the tagged or untagged sections of the class layout, and checking that their alignment requirements are met when stored in a packed array. - Generate a struct containing struct field offsets, so we can ensure that the layouts defined in Torque and C++ code match. Of course it would be nice to generate a lot more (indexed accessors, synchronized accessors, GC visitors, etc.), but we can't do it all at once. Change-Id: I29e2a2afe37e4805cd80e3a84ef9edfe7ca7bb6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2047399Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66318}
-
Michael Lippautz authored
Change-Id: I582af41a8b10957b8fc7acb388871b1d51783a8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062395Reviewed-by:
-
Michael Lippautz authored
The marking speed is computed from incremental marking steps reported. In case of embedder tracing, such steps should not include time spent processing embedder memory. Bug: chromium:1044630, chromium:1049084 Change-Id: Ie7b5af569b4114dd8dffd2d85eaf28ece9dfa18c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062394 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Frank Tang authored
Fix the gc_stress problem in Original by moving the NewStringFromAsciiChecked before the cast. This is a reland of a872c393 Original change's description: > [Intl] Fix RelativeTimeFormat fatal > > Intl.RelativeTimeFormat constructor crash while the locale or > numberingSystem contains an "algorithmic" numberingSystem. > Fix by fallback to the locale without the nu > > Bug: chromium:1041319 > Change-Id: Ica520e8dec6ace21264504274b92cb2c3d16286f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055970 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66276} Bug: chromium:1041319 Change-Id: I97563c5dbac1842a4e740e2450070471ea2681a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2057761Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66315}
-
Michael Lippautz authored
V8 is capped by a maximum. Since the embedder step is computed from V8's speeds using concurrent marking it may be too aggressive. Cap the embedder step to the same maximum as V8 to workaround that issue. Bug: chromium:1044630 Change-Id: Idcd84cacf2f3fa4dd8df2a03aa3ae6ffb6cb36a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062393Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8088 Change-Id: Ie92499a43e2286e9bb1c64b0d553a515d74d5aa2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2059989Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66313}
-
Milad Farazmand authored
Change-Id: I847d01568f07da0a73e364a25e3e33e3875f3518 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061229Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66312}
-
Omer Katz authored
Use 1 less task for concurrent marking to allow Oilpan's concurrent marking a chance to run as well. Change-Id: I236f78925324dc4d21a38233d75dc101cc477930 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062389 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 59e96890 R=zhiguo.zhou@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I01be626d6017d0d76daffc281f64352e3b8ead2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062248Reviewed-by:
-
Andreas Haas authored
R=jkummerow@chromium.org Change-Id: If8978ab9cac24cd650553013ac7d41f501ea243d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061554 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 820faa6e Original Commit Message: The arm/arm64 simulators debugger has a command "mem" that prints the content of the memory. It also prints a short summary for JS objects (SMI, Array, JSFunction, ...). That is very handy, but when trying to print incomplete initialized memory, it could raise an exception. It is useful to have a command that prints the content of the memory for non-initialized or bogus values without the risk of raising an exception. This CL adds the command "dump". R=victorgomes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie3931af0cf34052706618774ba95bf0057cfcabf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062159Reviewed-by:
-
Michael Achenbach authored
Bug: v8:9098 Change-Id: I8200b60605228e6974cd76443ad9d2f93bff56ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061552Reviewed-by:
-
Georg Neis authored
... in favor of CodeAssembler's ScopedExceptionHandler. Also remove unused exception arguments from some iterator related methods. Bug: v8:10187 Change-Id: I8eb7dfd4eb339e4f566970efa5757c3771926ba6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060496 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
R=machenbach@chromium.org Bug: v8:10220 Change-Id: I541adfd7d02ecbd68474acaf8e672c1838fc318f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061551Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#66305}
-
Michael Achenbach authored
This adds tests for the mock logic used in differential fuzzing. The tests uncovered a couple of issues in the mock files that are also fixed. This also does some minor code clean up in the mock code. Bug: chromium:1044942 Change-Id: I5b67f70f8b104bb681548f742ab863395a88360f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2043843 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#66304}
-
Gus Caplan authored
This CL reinstates the old pow implementation which calls out to the system implementation of pow. Bug: v8:9622 Change-Id: I3df997888ced3fb8b5bd4b810098e967649aaa55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1774898Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
Wasm stack traces now show the url to the wasm script. Bug: v8:9762 Change-Id: Ie7feda499ec76bf001dea093efb720ffd691edad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051946 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#66302}
-
Simon Zünd authored
REPL 'let' declared variables use VariableLocation::REPL_GLOBAL which was not handled by a switch in the bytecode generator. The default case ran into an UNREACHABLE. This CL fixes this by properly handling VariableLocation::REPL_GLOBAL for delete. Drive-by: Replaced the default case with an explicit case for VariableLocation::MODULE. Bug: chromium:1052721 Change-Id: I1330ff2f2c6f042a596a8298599a5d58769894f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060488 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#66301}
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: Ia74282eab46335235cf4f0e55589af3fcc836d9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2036739Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Cr-Commit-Position: refs/heads/master@{#66300}
-
- 17 Feb, 2020 19 commits
-
-
Jakob Kummerow authored
By replacing usage of the IsNotArrayIndex bit with IsNotIntegerIndex, we get back one bit that we can use to increase the number of hash bits stored. The price is that strings that represent array/integer indices beyond the cacheable range will have to be scanned more often, but these strings should be rare, and we expect that the additional hash bit is more worthwhile to have. Bug: v8:9904 Change-Id: I33f74b0a73f4754aee85805d4b7c409177668439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051947Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This also changes Heap::AllocateExternalBackingStore to avoid GC inside AlwaysAllocateScope. Bug: chromium:1042566 Change-Id: Ifa8fe8227af2d6492dbb4f9c52f43754d44926fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060295 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Emanuel Ziegler authored
Implement the latest spec changes: - Allow declarative segments to behave like passive & dropped segments. - Enforce that only declared functions may be returned or used in globals as funcref. - Ensure that table fill does not modify any entries if OOB. Spec tests for select and br_table are still failing due to proposal issue Bug: v8:10156 R=ahaas@chromium.org Change-Id: I5b95be36a67bc7482a84b848908cc4cbdf94af03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2027458Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#66297}
-
Shu-yu Guo authored
Currently dirty FinalizationGroups are processed by the cleanup task in LIFO order. This results in starvation when FinalizationGroups are added to the dirty list faster than the cleanup task is run. R=ulan@chromium.org Bug: v8:8179 Change-Id: I6e4a5bbd490396120b07ca6053176beded7cef6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051619Reviewed-by:
-
Z Nguyen-Huu authored
This is to fix the hang (rarely happen). The potential root cause is that before initialing recompilation, the recompilation callback is added and then already cleared out by other running threads from initial compilation. Bug: v8:10086, v8:9654 Change-Id: I769bac621cce4611ccde1f0998b0f2bc0e9c04cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2053248 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Michael Achenbach authored
Bug: v8:10204, v8:10219 Change-Id: Ie08692121811bf23b9e8ea2c3fc38f38a8705fbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060489 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
There is a copy of the pointer decompression logic in TypedArrayBuiltinsAssembler::SetJSTypedArrayOnHeapDataPtr, which was not updated for the new ("smi-corrupting") pointer compression scheme: it erroneously used a sign-extending cast from compressed to full representation. This causes incorrect values to be computed when the heap size can grow beyond 2GB. Bug: v8:9706, chromium:1051005 Change-Id: I2220ce759df1147f255ffca93428888858929fd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060494Reviewed-by:Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66293}
-
Michael Achenbach authored
Otherwise we report a spurious difference after OOM. Bug: chromium:1052849 Change-Id: I795f7393a8061ff41178295d49bdaea411d3c461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060307Reviewed-by:
-
Michael Achenbach authored
This adds 3 flags to the numfuzz fuzzer depending on a probability: --budget-for-feedback-vector-allocation=0 --interrupt-budget=100 --no-lazy-feedback-allocation No-Try: true Bug: v8:10204 Change-Id: I83dabcd0e3ca80bebe596d65d03b3e99d8ecbf03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060490 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reduces the pointer-compression experiment by 3% as it is in production since a while. This also uses turbofan when comparing across architectures as tests run faster and likely find the same or more relevant bugs. No-Try: true Change-Id: I35ec97188a101a7cb43454903f7bf9765e57893c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2059995 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Pass --no-lazy-feedback-allocation in all second runs depending on a probability. Also combine with --interrupt-budget=100. This also allows adding several extra flags behind one probability. The tests are improved to ensure valid flags and configs. No-Try: true Bug: v8:10215 Change-Id: I2766ef5044cd8c7096f6b76f39b60b568f550bde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2059991 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Make it explicit that AddShadowingKeys might allocate. Bug: chromium:1049013 Change-Id: I938531a0324fa581422b74813518f3e85c9b3fbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2046888 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Clemens Backes authored
This again improves readability and makes the code much shorter. It might also allow us to generate a scheduled graph directly in the future, for improved wrapper compile times. R=jkummerow@chromium.org Bug: v8:10123 Change-Id: I0225d685a0660adb265eedcd160dfac6b4b23c87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060001Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: I0113efe2d4d3a462533c306a87ebee851b1cb85c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056853Reviewed-by:
-
Georgia Kouveli authored
... instead of first claiming space on the stack and then storing it, which was sometimes causing the profiler to read the uninitialised frame type slot right after it was claimed, but before it was written to. Bug: v8:9907 Change-Id: I33318aec44b6083488317ec5e226a06e59c7560c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056473Reviewed-by:
-
Victor Gomes authored
The arm/arm64 simulators debugger has a command "mem" that prints the content of the memory. It also prints a short summary for JS objects (SMI, Array, JSFunction, ...). That is very handy, but when trying to print incomplete initialized memory, it could raise an exception. It is useful to have a command that prints the content of the memory for non-initialized or bogus values without the risk of raising an exception. This CL adds the command "dump". Change-Id: I682f97afa30a8d9dc572fe5e9dd256eeebf79de9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056468Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: I5f5b78cb57776d1022f206f09242768b3dd8d9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056848Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: Iafd6b8172a67fa1b778d163259fe8d1400b004f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056847Reviewed-by:
-
Zhao Jiazhong authored
port 9d3dc6f2 https://crrev.com/c/1914218 Original Commit Message: FunctionEntry StackChecks is one of the two cases where we generate a StackCheck bytecode. In these cases, we do stack check against the js limit (not to be confused with the real js limit). Their purpose is to be able to interrupt the running code. We can omit the FunctionEntry StackCheck by embedding its code into the InterpreterEntryTrampoline builtin. We save one bytecode per interpreted function. This change has rippling effects for optimized code, as well as the deoptimizer. Change-Id: I2ad985959a3f55dfe80fabeffee3d344c1817c88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050055 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
