- 13 Nov, 2017 9 commits
-
-
Ulan Degenbaev authored
If there is a WeakMap in a retaining path of an object, then we have two choices: 1) use the WeakMap backing store as the retainer. 2) use the key in the WeakMap as the retainer. Both cases can be useful for debugging memory leaks. This patch adds a second parameter to %DebugTrackRetainingPath(). If this parameter is "track-ephemeral-path", then the retaining path printer will use the key in the WeakMap as a retainer. Otherwise, the WeakMap backing store will be reported as the retainer. Bug: v8:6987 Change-Id: I9feae25bc734c3abed501b9f901a36d2248a105c Reviewed-on: https://chromium-review.googlesource.com/753343 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49324}
-
Michael Lippautz authored
Bug: chromium:780749 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ifd7da70dd9adffe5de7f126539c4780799d55673 Reviewed-on: https://chromium-review.googlesource.com/763528Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49323}
-
Michael Achenbach authored
NOTRY=true NOTREECHECKS=true TBR=sergiyb@chromium.org Bug: chromium:782226 Change-Id: I108616ea7c94040b29e5522fdd6bded420771414 Reviewed-on: https://chromium-review.googlesource.com/758266 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49322}
-
Leszek Swirski authored
The consume code cache code path was only taken in the case where the isolate cache lookup failed, making the "hit isolate cache when consume code cache" histogram sample never work. Bug: chromium:769203 Change-Id: I15398f9ce4fc53602b323b8efb8ac9787440dd85 Reviewed-on: https://chromium-review.googlesource.com/765455Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#49321}
-
Daniel Clifford authored
Bug: chromium:783119 Change-Id: I617db4f6740fb2cfe036ccf162a12aa2bac28e86 Reviewed-on: https://chromium-review.googlesource.com/763460Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#49320}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: I200c088d3cf1c3c1a16040b1395b534ccd9d9268 Reviewed-on: https://chromium-review.googlesource.com/765471Reviewed-by:
-
Camillo Bruni authored
The only empty PropertyArray is the empty_property_array object on the isolate. Allowing empty PropertyArrays causes the turbofan to ignore the existing hash when growing the backing store again. We currently only end up with the empty PropertyArray when following back transitions. Bug: chromium:781218, chromium:783713 Change-Id: If41dd09b965cdc8d957b9ca50ba3c8a7f4254769 Reviewed-on: https://chromium-review.googlesource.com/763230 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49318}
-
Michael Achenbach authored
Bug: Change-Id: I1fbe94b3f874e24abc8ce2a6387ffe9d31dbb7b0 Reviewed-on: https://chromium-review.googlesource.com/765659 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This patch adds a missing V8_EXPORT to Context::BackupIncumbentScope. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic4146ee1dad2f84222671fc54b4a463282356417 Reviewed-on: https://chromium-review.googlesource.com/762834Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#49316}
-
- 11 Nov, 2017 5 commits
-
-
Jakob Gruber authored
Revert this and its follow-up as suspect for current canary OOM crasher. This reverts commit 4899bcb6. This reverts commit b73ee334. TBR=adamk@chromium.org,hpayer@chromium.org Bug: chromium:783708 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I4c00582e7ab2df22216ad6732e2843e9958db0c0 Reviewed-on: https://chromium-review.googlesource.com/765447Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49315}
-
🔥 Mathias Bynens authoredThis is a reland of 6f890fd5 Original change's description: > Ship RegExp Unicode property escapes > > Intent to ship: > https://groups.google.com/d/msg/v8-users/isa2JrstEbE/i6UvFO7RBwAJ > > BUG=v8:4743 > > Change-Id: I62cdc6fa1f114fc8be26c5cf354c45a15ce49ab7 > Reviewed-on: https://chromium-review.googlesource.com/761776 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49312} Bug: v8:4743 Change-Id: I6618242b147472a9a083573299ed3b3dda5ac6ed Reviewed-on: https://chromium-review.googlesource.com/764908Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#49314}
-
Michael Achenbach authored
This reverts commit 6f890fd5. Reason for revert: Breaks layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/19671 https://github.com/v8/v8/wiki/Blink-layout-tests Original change's description: > Ship RegExp Unicode property escapes > > Intent to ship: > https://groups.google.com/d/msg/v8-users/isa2JrstEbE/i6UvFO7RBwAJ > > BUG=v8:4743 > > Change-Id: I62cdc6fa1f114fc8be26c5cf354c45a15ce49ab7 > Reviewed-on: https://chromium-review.googlesource.com/761776 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49312} TBR=adamk@chromium.org,yangguo@chromium.org,mathias@chromium.org Change-Id: I5e09070582cf247f61429a1d45ae5faa3d21518e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:4743 Reviewed-on: https://chromium-review.googlesource.com/765348Reviewed-by:
-
Mathias Bynens authored
Intent to ship: https://groups.google.com/d/msg/v8-users/isa2JrstEbE/i6UvFO7RBwAJ BUG=v8:4743 Change-Id: I62cdc6fa1f114fc8be26c5cf354c45a15ce49ab7 Reviewed-on: https://chromium-review.googlesource.com/761776Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3dd2b5f..98bbbff Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/4a9623a..9914c57 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f83c79a..aee17a9 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie699606b3a50ce4bb49d2aa10f0238834d4fb355 Reviewed-on: https://chromium-review.googlesource.com/764672Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49311}
-
- 10 Nov, 2017 26 commits
-
-
Mircea Trofin authored
This is meant to be used from the native wasm datastructures Bug: v8:6876 Change-Id: Ie865cf3277b24f25e1845bf32837be1a24047472 Reviewed-on: https://chromium-review.googlesource.com/764502 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49310}
-
Adam Klein authored
And add a watchlist for the C++ API. Change-Id: Id82d7191153afe701fc11958ba36ce7a8b29bef2 Reviewed-on: https://chromium-review.googlesource.com/764548Reviewed-by:
-
Josh Wolfe authored
R=littledan@chromium.org, adamk@chromium.org Bug: v8:5244 Change-Id: I1186601bc05bd5348acb4b0e1242d7d074020ad9 Reviewed-on: https://chromium-review.googlesource.com/757564Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Josh Wolfe <jwolfe@igalia.com> Cr-Commit-Position: refs/heads/master@{#49308}
-
Mircea Trofin authored
This allows SafepointTables to be reused by the upcoming WasmCode (wasm out of the GC heap), and integrate with the stack iterator. Bug: v8:6876 Change-Id: I24ff78a073fa99aeabe12a0c5a12709f5b1461a2 Reviewed-on: https://chromium-review.googlesource.com/764370Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49307}
-
Pierre Langlois authored
Turn cases where we are multiplying with a power of two into a left shift. We hit this optimisation roughly 500 times in the snapshot. Bug: Change-Id: Ibd3104a3dbe49f247a2d84db94891f6e3a897026 Reviewed-on: https://chromium-review.googlesource.com/763229Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#49306}
-
Bill Budge authored
- Eliminates OS::ReleaseRegion, replacing with calls to OS::Free. - Adds bool return value to OS::Free. - Cleans up types of flags, protection on Windows and Cygwin. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6a642374e33876966a5552fb0cdf552dc6d79aaa Reviewed-on: https://chromium-review.googlesource.com/762345 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Benjamin authored
Adds block-level coverage tracking for binary && and || expressions. Introduces a BinaryOperation source-range for tracking the operations themselves and an Expression source-range, used for tracking NaryLogical expressions. This builds on work by jgruber@chromium.org in the issue. TBR=marja@chromium.org R=jgruber@chromium.org, rmcilroy@chromium.org Bug: v8:6660 Change-Id: I83a81f13a3514a734c06948b2d3e91138fb00e18 Reviewed-on: https://chromium-review.googlesource.com/754564 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 22932d6b. Reason for revert: TSAN https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/18232 Original change's description: > Reland "[runtime] Slightly optimize creation of class literals." > > Bug: v8:5799 > Change-Id: I782ec131c7194aef20942a19750168a974913c3f > Reviewed-on: https://chromium-review.googlesource.com/757337 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49291} TBR=ulan@chromium.org,rmcilroy@chromium.org,jarin@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I0742d25b0e2364efc696d19492ba20614a3821fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5799 Reviewed-on: https://chromium-review.googlesource.com/763458Reviewed-by:
-
Mike Stanton authored
We introduce nodes with control output during intrinsic IsInstanceType lowering, and must carefully connect them to subsequent control inputs. Bug: v8:7002 Change-Id: I2e3066943b8f7e36652438ae6ca560932188203e Reviewed-on: https://chromium-review.googlesource.com/763633Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49302}
-
Daniel Clifford authored
Bug: chromium:778668 Change-Id: Ie75f2ecb9e6134b6eb57c7d7fb6ea33cbb2fc2bf Reviewed-on: https://chromium-review.googlesource.com/753324 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Mike Stanton authored
This is a reland of ba76ad68 Original change's description: > [Turbofan] Introduce AllocateRaw node > > In order to simplify and verify the TurboFan graph, we > need to wire allocations into the control chain after > effect control linearization. > > Bug: v8:7002 > Change-Id: I4c5956c8d16773d721482d46a0b407bee01a9597 > Reviewed-on: https://chromium-review.googlesource.com/738139 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49209} TBR=jarin@chromium.org Bug: v8:7002 Change-Id: Iba588c498bb5de113abfba7f9e40cfe4325dea4a Reviewed-on: https://chromium-review.googlesource.com/758436 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49300}
-
Ivica Bogosavljevic authored
MIPS team has recently migrated to @mips.com e-mail address. Dusan Simicic is no longer part of MIPS V8 team, therefore his name is removed from OWNERS. TBR=mstarzinger@chromium.org NOTRY=true Bug: Change-Id: I67fde24a5b9214fa3fca05c0399888b8d18fc699 Reviewed-on: https://chromium-review.googlesource.com/758639 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=petermarshall@chromium.org Change-Id: I6901ddcd1ca1fda474e8d2766fbfc60d2f5a9bec Reviewed-on: https://chromium-review.googlesource.com/763628Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49298}
-
Michael Achenbach authored
We'll use one generic isolate for all number fuzzers. The previous deopt isolate will be deleted, once the infra hooks have changed. Bug: v8:6917 Change-Id: I809613548cd935a0208febb002572cc063697324 Reviewed-on: https://chromium-review.googlesource.com/763534Reviewed-by:
-
Michal Majewski authored
Temporary implementation of GC fuzzer based on the deopt fuzzer. It will be merged with the deopt fuzzer to create more general numfuzzer. Webkit test suite updated to ignore trace_incremental_marking flag output. Bug: v8:6917 Change-Id: I053ae32f3cd3f74ba8b71fc5bdfc7264f54dca11 Reviewed-on: https://chromium-review.googlesource.com/758437 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: v8:7012 Change-Id: I5895fcda768696c90f3f766d4beef6f75ec9f79f Reviewed-on: https://chromium-review.googlesource.com/763530 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
jgruber authored
Speculative revert due to canary crashes. I'll begin relanding these one-by-one next week. This bundles two reverts: Revert "[snapshot] Lazy-deserialize bytecode handlers" This reverts commit b4587369. Revert "[interpreter] Remove mechanism for bytecode handler reuse" This reverts commit 07fc87a2. TBR: rmcilroy@chromium.org,mlippautz@chromium.org,yangguo@chromium.org Bug: chromium:783708 Change-Id: I6f8314b9eeafd9412a1c69843bc242e7da240eee Reviewed-on: https://chromium-review.googlesource.com/763428 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Keep separate track of isolate cache hits that conflict with producing/consuming the code cache, so that we can see how many code cache hits are "stolen" by the isolate cache, and how many isolate cache entries are "wasted" by recompiling for cache production. Bug: chromium:769203 Change-Id: I3d8dbfc6a8981b779eb073176454ad43dfbcbaaf Reviewed-on: https://chromium-review.googlesource.com/763368Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 6c613288 Original change's description: > [Liftoff] Implement parallel register moves > > This was not implemented so far, leading to lots of clusterfuzz issues. > Testing this feature would require complicating the interface a lot and > exposing more implementation details in the header file, hence we just > go with regression tests for now. > > R=ahaas@chromium.org, titzer@chromium.org > > Bug: v8:6600, chromium:782280 > Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee > Reviewed-on: https://chromium-review.googlesource.com/758772 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49286} Bug: v8:6600, chromium:782280 Change-Id: I82a75bfeaf83dc63a2917da3ccdc4721c5d689e7 Reviewed-on: https://chromium-review.googlesource.com/763387Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49292}
-
Igor Sheludko authored
Bug: v8:5799 Change-Id: I782ec131c7194aef20942a19750168a974913c3f Reviewed-on: https://chromium-review.googlesource.com/757337 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 9664d017. Reason for revert: Planned revert, this is on Canary 3264 and V8 branch 6.4.245. Original change's description: > [snapshot] Flip --lazy-handler-deserialization > > Flip this for a day or two to gather perf bot results & stability > issues. Results will be collected in https://crbug.com/782637. > > TBR=hablich@chromium.org > > Bug: v8:6624, chromium:782637 > Change-Id: I70eb5d6287d4723f935715ef80d9ba129dc282f0 > Reviewed-on: https://chromium-review.googlesource.com/758375 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49222} TBR=hablich@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6624, chromium:782637 Change-Id: I2a6ee63f7191d186810d7352ee63b6b664e74157 Reviewed-on: https://chromium-review.googlesource.com/763427 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 6c613288. Reason for revert: breaks compilation on win64 bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/69 Original change's description: > [Liftoff] Implement parallel register moves > > This was not implemented so far, leading to lots of clusterfuzz issues. > Testing this feature would require complicating the interface a lot and > exposing more implementation details in the header file, hence we just > go with regression tests for now. > > R=ahaas@chromium.org, titzer@chromium.org > > Bug: v8:6600, chromium:782280 > Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee > Reviewed-on: https://chromium-review.googlesource.com/758772 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49286} TBR=titzer@chromium.org,ahaas@chromium.org,clemensh@chromium.org Change-Id: I386983da7f9f03d54cef2190b01fd2cc5785966e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:782280 Reviewed-on: https://chromium-review.googlesource.com/763367Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49289}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1c66ba1..3dd2b5f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I345def7a1ade64accc9570b8c8af6f0514058da1 Reviewed-on: https://chromium-review.googlesource.com/763130Reviewed-by:
-
Michael Starzinger authored
R=hpayer@chromium.org BUG=v8:6792 Change-Id: Iba360a83c8c1d929c29c0a4e0c5f32cef8755c85 Reviewed-on: https://chromium-review.googlesource.com/758650Reviewed-by:
-
Clemens Hammacher authored
This was not implemented so far, leading to lots of clusterfuzz issues. Testing this feature would require complicating the interface a lot and exposing more implementation details in the header file, hence we just go with regression tests for now. R=ahaas@chromium.org, titzer@chromium.org Bug: v8:6600, chromium:782280 Change-Id: I12863f3eb59a8dffdcc7d3bfb8e1f0ae0eec15ee Reviewed-on: https://chromium-review.googlesource.com/758772Reviewed-by:
-
Camillo Bruni authored
- Implement exchangeable timer clock for RuntimeCallStats for testing - Rewrite RuntimeCAllStatsTest to overwrite the default RCS timer This gets rid of the previous flakiness for these tests due to using the real platform timer. Bug: v8:5677 Change-Id: Iff312c7f79ab97407ba1c0c2c72fb0b35a5efdf1 Reviewed-on: https://chromium-review.googlesource.com/760416Reviewed-by:
-
