- 05 Aug, 2021 22 commits
-
-
Victor Gomes authored
If no GC happens when we grow the assembler buffer (this could happen since we allocate a new Code object), we do not need to fix references to full-embedded-objects. Bug: v8:11872 Change-Id: I11fb1abcb4c53e124bb7659c9f9995ccb18cf296 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3073741 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76122}
-
Junliang Yan authored
Change-Id: Ic2576da8adff6935758ecae14ce5441d8af6428b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3075123Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#76121}
-
Junliang Yan authored
Change-Id: I3d75f2e5fdb9c43b4795dee80377725318ee271f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3075122Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: Ia5903364a774bd49db1a646b3066b9972deac725 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074465 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76119}
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: I299678102254ffb7d68be3d5cad11b4a4161492f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3068947 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Forgot to do this in crrev.com/c/3067226. Bug: v8:7790,v8:12030 Change-Id: Ic6fbf3feb07e8d08f0fd83d76d54535387c7a27c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074464 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL limits the amount of address space we reserve for shared WebAssembly memory. Up until now we just reserved either the defined maximum size of the memory or the V8-defined maximum memory size, depending on whether the maximum size is defined or not. This could cause OOMs easily on 32-bit systems due to address space exhaustion. With this CL we limit the amount of address space we reserve for shared WebAssembly memory. 1) We try to reserve at least the initial size; 2) If no maximum size is defined, we reserve 1GB by default; 3) If a maximum size is defined, then we reserve that maximum size but at most 1GB. Note that the handling of shared memory here is different than the handling of not-shared memory because for shared memory it is not possible to grow with realloc. R=clemensb@chromium.org Bug: v8:12038 Change-Id: I00493b330ee00588d65cbffa6f042e039106736e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071206Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#76116}
-
Mythri A authored
There was a DCHECK to ensure tests don't miss enabling either bytecode or baseline code flushing along with stress-flush-code. Fuzzers use different combination of flags so there we should allow stress-flush-code without bytecode / baseline code flushing. Bug: chromium:1236614,v8:11947 Change-Id: I86190b6336015e37288cffffc05de2fa21f496ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074462 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76115}
-
Jakob Gruber authored
Optimizing compilation can no longer collect source positions on demand since it may now run concurrently without serialization. Instead, we now collect full source positions when any component that needs them is enabled (profiler, debugger). Bug: v8:7790,v8:12030 Change-Id: I6a2a82eb2b0d3e92121e101b4d9bf330c1f6c065 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067226Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#76114}
-
Jakob Gruber authored
ObjectDataKind::kSerializedHeapObject is no longer in use. Remove the CreateDataFunctors since creation code is now simple and uniform enough to inline. Bug: v8:7790 Change-Id: I90009373b4f6b5e1b0ed90c7ccff323dc9821ed8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3073740 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Skip over SFIs that already have source position available. Bug: v8:7790 Change-Id: Iaea51fe1e4cec9e3291a258a1c60b2354afa8525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074239Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#76112}
-
Camillo Bruni authored
This CL fixes a long standing issue where reentering TimedHistograms scopes would cause spurious measurements. Only the non-nested scopes yielded correct results. Due to the changed numbers, the V8.Execute histogram is renamed to V8.ExecuteMicroSeconds. Note that this histogram is also guarded behind the --slow-histograms flag due to the additional overhead. Unlike before, it does no longer include time for external callbacks and only measures self time. The following example illustrates the new behaviour: 1. Enter V8: |--+.......+--| self-time: 4 units (reported) 2. Exit V8 (callback): |-+...+-| self-time: 2 units (ignored) 3. Re-enter V8: |---| self-time: 3 units (reported) This would result in 2 histogram entries with 4 time units for the first V8 slice and 3 units for the nested part. Note that the callback time itself is ignored. This CL attempts to clean up how TimedHistograms work: - Histogram: the base class - TimedHistograms: used for time-related histograms that are not nested - NestedTimeHistograms: Extends TimedHistograms and is used for nested histograms This CL changes Histograms to not measure time themselves. Measurements happen in the *HistogramScopes: - BaseTimedHistogramScope: Base functionality - TimedHistogramScope: For non-nested measurements - NestedTimedHistogramScope: For nested measurements - PauseNestedTimedHistogramScope: Ignore time during a given scope. This is used to pause timers during callbacks. Additional changes: - ExternalCallbackScope now contains a PauseNestedTimedHistogramScope and always sets VMState<EXTERNAL> Bug: v8:11946 Change-Id: I45e4b7ff77b5948b605dd50539044cb26222fa21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001345Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
It was missing an AssumeMemoryFence. Bug: v8:7790,chromium:1236612 Change-Id: Icd3ed9f9979b0ba287c9dff7f4f8722ac06e859a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3073739 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=jkummerow@chromium.org Bug: v8:11992 Change-Id: I4229a6fff8d956a5baa9ab9d5028f9abc20d4039 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071405Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#76109}
-
Thibaud Michaud authored
Just re-use the error constructor's initial map for the WebAssembly.Exception constructor, instead of creating a new one. R=jkummerow@chromium.org Bug: v8:11992 Change-Id: If1ee53a1e9492c9ab4b59e363b388260ff097cf5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071211Reviewed-by:
-
Liu Yu authored
Port 9e0e2c15 Bug: v8:12017 Change-Id: Ie722834291a3e23a391da741b17f84f3179bcdaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3070386 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#76107}
-
Liu Yu authored
Port f7de8c80 Bug: v8:12017 Change-Id: I5099254936e2402d4dcf19a52c8ca8726d07f621 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3070384 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
Liu Yu authored
Port fb4f89ae Bug: v8:11872 Change-Id: I662394f7bc0e7f7563b6a8939e5badfa2895f37e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3072323 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
Jakob Gruber authored
For streaming compilation, scripts don't have a source string attached until finalization, but the Script and SharedFunctionInfo objects are already on the heap and may be picked up by heap walks. This happens e.g. in CollectSourcePositionsForAllBytecodeArrays, where we then try to reparse and recompile the SFI. This is invalid, since the source string is not yet set. Avoid this by checking for the empty source string (and leaving a TODO for a nicer future solution). Bug: v8:12051 Change-Id: Ib4f40cd218151120e5aff8558dd5df5c8834412e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071403 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/1067dfc..4124223 Change the default value of `--benchmark_filter` from "." to <empty> (#1207) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/4124223 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I3d4874758a667ef41ad05d7faeaacee8ad71e2ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071615Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76103}
-
Omer Katz authored
Change-Id: I64c06cad84e613ecfb3c582c1ac8a97f6d4e6692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071215 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#76102}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cff8a26..e360729 Rolling v8/third_party/aemu-linux-x64: DxCnfY154Xn-UYrZ-GF8FewyGfo29cYHkKdDMgpEHJkC..Nw0OOp4j9l4Sj0WpOmaRhNeJ137UfsLg0P1YrF8uzKwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/61f0e50..cb61e19 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a806594..0a4dd41 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/2a822c5..75e34bc Rolling v8/tools/luci-go: git_revision:db421da12bad8e57f97ee45b24147e34ec882007..git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b Rolling v8/tools/luci-go: git_revision:db421da12bad8e57f97ee45b24147e34ec882007..git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b Rolling v8/tools/luci-go: git_revision:db421da12bad8e57f97ee45b24147e34ec882007..git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4006df2bfd8824d5a680d0c24b39f5b4a29f11b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071613Reviewed-by:
-
- 04 Aug, 2021 18 commits
-
-
Shu-yu Guo authored
Bug: v8:12052 Change-Id: I2169d06340e49b014c1c24dbc3d5cf3e213b36c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071903 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#76100}
-
Milad Fa authored
Port 6e474ae9 Original Commit Message: This CL is a port of https://crrev.com/c/3045349 for ia32 and arm, adding helper methods to drop arguments from the stack. R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I7099bd98285eb22cc1cbf3abd634b3479fe9e9d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3072539Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76099}
-
Clemens Backes authored
The number of arguments for the LiftoffCompiler has grown significantly since its initial implementation, and it becomes hard to keep track of all options at the call sites. This CL refactors all optional parameters into a {LiftoffOptions} struct which has a factory-like interface. This will allow us to add more options in the future, e.g. for dynamic tiering. R=thibaudm@chromium.org Change-Id: I66697bb2f99b676a84c158304cc3a285e1b077d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069148 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Benedikt Meurer authored
For inline scripts that have a `// #sourceURL=foo.js` annotation, the V8 inspector (and by extension `Error.stack`) currently operates in terms of the `foo.js`, i.e. doesn't give any hint about the actual source, except for the line/column offsets reported upon scriptParsed. However in case of stack frames (i.e. as part of `Error.stack` or as part of the call frames reported via CDP), the line/column offsets are relative to the actual source instead of relative to the `foo.js` part, which - besides other things - makes post-processing of recorded stack traces tricky (sometimes impossible). This change adjusts the source positions reported for (inline) scripts with sourceURL annotations to be relative to the (inline) script instead of the surrounding document. Bug: chromium:1183990 Fixed: chromium:578269 Change-Id: I74f2b93c22ec43ca796b6b51faa9df5b99cf03f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069289 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#76097}
-
Thibaud Michaud authored
R=jkummerow@chromium.org Bug: v8:11992 Change-Id: I9fd1eabf70408f6abc4480c999ac26bf5d8ccd8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067321 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Patrick Thier authored
This CL is a port of https://crrev.com/c/3045349 for ia32 and arm, adding helper methods to drop arguments from the stack. Drive-by: Add RootAsOperand to ia32. Bug: v8:11112 Change-Id: I07b753d51b9fc9fc91bf09618b1315d146827123 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069157Reviewed-by:
-
Omer Katz authored
crrev.com/c/3069146 fixed a write barrier issue leading to a null dereference on Windows that was triggered by having the stack allocated at address below 4GB. Turns out the same can happen on Fuchsia. Bug: chromium:1230763, chromium:1056170 Change-Id: I74ba0b465c3230b4274f2c23d279c4f73183eddb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071402 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: Ib5e44e60c60afdc3c3527c882056610d72ed5e7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071518Reviewed-by:
-
Victor Gomes authored
Bug: v8:11872 Change-Id: I6d133ee33b48fa1f02442564b6a30d56986758eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071401Reviewed-by:
-
Clemens Backes authored
For some reason, the "ret" instruction goes missing on Mac release builds, probably because the compiler decides to split the inline assembly block and move the "v8_probe_memory_continuation" block somewhere else. This CL fixes that by adding another explicit "ret" at the end of "ProbeMemory". Also, we remove the "v8_probe_memory_address" symbol (which is identical to just "ProbeMemory"), to prevent the compiler from splitting "ProbeMemory" and "v8_probe_memory_address". R=ahaas@chromium.org Bug: v8:11955 Change-Id: I2e63b2db94206e329be214ab7b553ab502d6ecc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071202Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#76091}
-
Patrick Thier authored
Maximum frame size (in bytes) is used to check for stack overflows in the prologue. The maximum number of call arguments is pre-calculated and included in this check. However the count was added to the frame size wihout converting the count to bytes, resulting in inaccurate stack overflow checks. Bug: chromium:1235182 Change-Id: I21bca4e183fccfd055f2f1d5a40b71651c14b911 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071399Reviewed-by:
-
Jakob Gruber authored
Convert more raw Handle<Map> uses to MapRef. Bug: v8:7790 Change-Id: Id638b70607aa5a73404ee37dfda5e038018be525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067337 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76089}
-
Omer Katz authored
In crrev.com/c/3056970 I merged reporting allocated bytes from CppHeap to v8 with reporting from cppgc to CppHeap. The reporting handler assumed in_no_gc_scope() is false. Unfortunately this breaks. On heap termination, cppgc will report to CppHeap but CppHeap will have entered a no gc scope when it detached from the isolate. We could adjust the DCHECK, but I think it's simpler to revert to the previous unmerged state and simply port the bug fix from crrev.com/c/3056970 (i.e. lines 484-486 in cpp-heap.cc in this CL). Bug: chromium:1056170 Change-Id: I5aa953c31388f7b3bb3326ff10d5a33961be2aa1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067227Reviewed-by:
-
Jakob Kummerow authored
The merge values of a block have to be initialized to their static types, even if the actual values on the stack have subtypes of the loop's static type. Drive-by cleanup: drop some unneeded manual {TestModuleBuilder} instantiations from existing tests. The test fixture provides one anyway. Bug: chromium:1234453 Change-Id: I39c7eae4b6a6d5124f29be92da5ee92ff7e20e57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3068948Reviewed-by: -
Georg Neis authored
Bug: chromium:1234974 Change-Id: I4227853b9e6f232b7e17037cdac01c4f80320464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069281 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:1232620 Change-Id: Ie19fe8839966a1abb3d0a01fee1fb4b105fb6bf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3070702 Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This is a reland of ce8cef36 Original change's description: > [inspector] Consistently format all native accessors as own properties. > > Previously the V8 inspector would only turn embedder accessors on the > prototype chain into data properties, but would not do the same for > ECMAScript builtins, which is kind of inconsistent and weird behavior. > > This leaves in the hack that the inspector reports native accessor > properties as (own) data properties, but now at least the very least > does so consistently. In the absence of a better solution, we'll go > with this for now. > > Bug: chromium:1076820, chromium:1199247 > Change-Id: I593f909a46cb714dbec629a2944eeb892881ba6f > Before: https://imgur.com/kPuSldj.png > After: https://imgur.com/eFau45m.png > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067319 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76059} Bug: chromium:1076820, chromium:1199247 Change-Id: I11987194b0d0b8b250eda4f8ce0ae5fc743eb27c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3070701 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#76084}
-
Camillo Bruni authored
Bug: v8:10284 Change-Id: If199cbe09964f66aa7346eedefb8ad57fe945c9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069152 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
