- 05 Aug, 2022 4 commits
-
-
Al Muthanna Athamina authored
Bug: v8:13058 Change-Id: If9d500f46f02ed3588d2b0e3904567c61aaddd12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810184Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#82213}
-
Dominik Inführ authored
Factory::CopyCode was using ProcessBlackAllocatedObject and WriteBarrierForCode(Code) to handle write barriers for that newly created code object. But even when used in tandem with each other they would miss OLD_TO_NEW references in the code object header. This CL simplifies Factory::CopyCode by letting WriteBarrierForCode(Code) handle all outgoing pointers of that code object (not just a subset of RelocInfos) by implementing an ObjectVisitor. This removes the need for ProcessBlackAllocatedObject. Since Factory::CopyCode was the only user of ProcessBlackAllocatedObject, we can also remove all the object revisiting logic in the main thread marker. Bug: v8:11708 Change-Id: I7d9b12eb0a76ba41a38efc147f44556ddc941a96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810186Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82212}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/d115b03..2ba7a48 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0ad6539..664331e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ba74bc7..5a9c565 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9110def860f4ac6e6bebc3dea81e24254498d3a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812269 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82211}
-
Hao Xu authored
Add "k <= (x >> n) to (k << n) <= x" reduction to Word64Comparisons. This can help to reduce the below codes: 45: Int64Constant[164] 39: Load[kRepTaggedSigned|kTypeInt32](...) 40: BitcastTaggedToWordForTagAndSmiBits(39) 41: TruncateInt64ToInt32(40) 42: ChangeInt32ToInt64(41) 43: Word64Sar[ShiftOutZeros](42, 29) 46: Uint64LessThan(45, 43) into: 4530: Int32Constant[328] 39: Load[kRepTaggedSigned|kTypeInt32](...) 40: BitcastTaggedToWordForTagAndSmiBits(39) 41: TruncateInt64ToInt32(40) 46: Uint32LessThan(4530, 41) Change-Id: I6ca802c9bb3c941c689ebbcb4ae3072501555266 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3793464 Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82210}
-
- 04 Aug, 2022 24 commits
-
-
Milad Fa authored
Port dc2d69d8 Original Commit Message: Pass WriteBarrierMode to the code object write barrier and DCHECK WriteBarrier::IsRequired when using SKIP_WRITE_BARRIER. R=dinfuehr@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I356379e0d682e855d1c43f35a7a0d06734f8408b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812036 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/main@{#82209}
-
Dominik Inführ authored
While it is not required to invoke the full barrier in this case, we can invoke the full write barrier which improves verification but also makes the code easier to understand by relying less on GC implementation details. Bug: v8:11708 Change-Id: I4d2f6640bc0efb5b763ccd5ca99e573421be3a06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807592Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82208}
-
Andreas Haas authored
R=ecmziegler@chromium.org Bug: v8:12852 Change-Id: I69fc153aefa9711fce22a1330b9d24910a467b3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3809812Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#82207}
-
Camillo Bruni authored
- Update parse processor to use new async log-reader functions - Fix some typos - Add more desciptions to the output - Update bytes and time formatting to use common helper.mjs functions Bug: v8:13146 Change-Id: Idf58a394aa493b7f50ad5282533c1b6d326117be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810233Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82206}
-
Nikolaos Papaspyrou authored
When calculating the GC collection rate, we assume that the start object size (before GC) is non zero. It appears that this is not always the case, not only because of tests that explicitly trigger GC, but also in Chrome, when the --gc-interval flag is used with a small interval value. Furthermore, efficiency calculation (freed bytes over GC duration) assumes that the duration of the GC is non zero. However, if the clock resolution is not small enough and the entire GC is very short, the timed value appears to be zero. This again leads to NaN values showing in metrics and CHECKs failing and has already been fixed for Oilpan (crrev.com/c/3723499). This CL fixes these two issues. Change-Id: I902b2e9740d9750a2b6463a00289625500c4c0d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810393Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#82205}
-
Victor Gomes authored
It introduces GetSecondReturnedValue node, which must be added immediately after a node that calls a builtin that expects 2 returned values. It simply binds kReturnRegister1 to a value node. Since the previous node must have been a builtin call, kReturnRegister1 is free in the register allocator. No gap moves will be emitted between these two nodes. Bug: v8:7700 Change-Id: Iddd81ef534a6397bad5682fa1430a94d2075b746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810183 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82204}
-
Leszek Swirski authored
Resolve the TODO to avoid the push/pop of the cycle break temporary value, by keeping track of whether the scratch register currently holds the temporary value and spill it if the register is needed for stack slot moves instead. Bug: v8:7700 Change-Id: If4119e63312bdc2b89987f92328ae646a46543ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810185 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82203}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I17f0df4e8ddf835af8231c5e06a6ecc416b3bc97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810181 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82202}
-
Dominik Inführ authored
Pass WriteBarrierMode to the code object write barrier and DCHECK WriteBarrier::IsRequired when using SKIP_WRITE_BARRIER. Bug: v8:11708 Change-Id: I457d0fa07e830d6831fb95a4ae9311f6066215e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810171Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82201}
-
Clemens Backes authored
Memory limits are difference on 32-bit and 64-bit systems, so foozzie finds differences in Wasm execution. This can be avoided by always setting the same (lower) limit. R=machenbach@chromium.org Bug: chromium:1348335 Change-Id: I452d257fd78730b4113bfe67120dbed2e8ba5878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804696Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82200}
-
Milad Fa authored
Change-Id: Ie78370bd2fb99df62a195da1d0070fd4da8d879a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807853Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82199}
-
Lu Yahan authored
This is a reland of commit 491de34b co-authors: Ji Qiu <qiuji@iscas.ac.cn> Alvise De Faveri Tron <elvisilde@gmail.com> Usman Zain <uszain@gmail.com> Zheng Quan <vitalyankh@gmail.com> Original change's description: > [riscv32] Add RISCV32 backend > > This very large changeset adds support for RISCV32. > > Bug: v8:13025 > Change-Id: Ieacc857131e6620f0fcfd7daa88a0f8d77056aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736732 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> > Reviewed-by: ji qiu <qiuji@iscas.ac.cn> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82053} Bug: v8:13025 Change-Id: I220fae4b8e2679bdc111724e08817b079b373bd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807124 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#82198}
-
Omer Katz authored
As part of revising MinorMC, it would soon be broken and bots should not be red because of it. Bug: v8:12612 Change-Id: I0551d0a115ac2f4fa7fc32190458850f80b84cf5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810353 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#82197}
-
Peter Kasting authored
Fixes a C++20 build break. Bug: chromium:1284275 Change-Id: I67ee8c94a4ecd0d53101a643ff37c1d1ce0bd512 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3803132Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#82196}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I4cb5636acd38319f13d91cbad7d04486346ba74d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805882 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82195}
-
Victor Gomes authored
Change-Id: Ic4266909eef21398377372a18b004e2ba37567e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810192Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82194}
-
Al Muthanna Athamina authored
Bug: v8:13116 Change-Id: I76b5e7dfa5e99107fc54722b794bd07ada91152c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810231Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#82193}
-
Michael Achenbach authored
Revert "[infra] Enable sandbox for x64 and arm64 builders and add a set of builders with Sandbox off" This reverts commit 161d7f92. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20-%20release%20builder/29779/overview Original change's description: > [infra] Enable sandbox for x64 and arm64 builders and add a set of builders with Sandbox off > > Bug: v8:13058 > Change-Id: Ie3d4f87080fd1076edff1ee75cb03ee8ea4db505 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788096 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82191} Bug: v8:13058 Change-Id: I68a4097074150f2cf7cca9c776054dca19597fcc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810611 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82192}
-
Al Muthanna Athamina authored
Bug: v8:13058 Change-Id: Ie3d4f87080fd1076edff1ee75cb03ee8ea4db505 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788096Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#82191}
-
Simon Zünd authored
This is a reland of commit 4bab7a8e The reland changes the way how we install the async stack tagging API on the console object. Instead of using `v8::Object::Set`, we use `createDataProperty` which is sufficient. With `Set`, arbitrary JS could run via accessors, which might not be allowed depending on when the API is installed. Original change's description: > [inspector] Enable async stack tagging API by default > > R=bmeurer@chromium.org > > Fixed: chromium:1334585 > Change-Id: Id79a60bac1731ea9c60654ff15c8e23f958c6e57 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3799431 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82161} Change-Id: I9b8c8e643705f8f043acac5af14307f2dbdb5a68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3809692Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#82190}
-
Jakob Linke authored
Change-Id: I67b6594d7ec5226d54f09954210fe4f6ec4d47b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810172Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82189}
-
Michael Lippautz authored
v8::TracedReference is supposed to be used from objects allocated on CppHeap. Such objects can be in construction during garbage collection, meaning that they are unable to invoke Trace(v8::TraceReference) as they have not been properly set up. It is thus necessary to use conservative tracing to find v8::TracedReference (backed by TracedNode in GlobalHandle) in in-construction objects. Change-Id: I5b4ac6e7805ff7ded33f63a405db65ea08d809ad Bug: v8:13141, chromium:1322114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3806439 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#82188}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b1d3dce..0ad6539 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b11b8b4..ba74bc7 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5bdd2fa04c54f6c0bcad868651d5d424e6aea1b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3808973 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82187}
-
QiuJi authored
Port 4e329f8c Also fix 64-bit addressed stores on riscv64 Bug: v8:12852 Bug: v8:10949 Change-Id: Ibc0d4efe04da5b4ca3c3e6c2997655b8d3795004 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3806593 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: ji qiu <qiuji@iscas.ac.cn> Reviewed-by: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#82186}
-
- 03 Aug, 2022 12 commits
-
-
Frank Tang authored
1. fix year value between 100 and 9999 should use 4 digit padding without '+' prefix to sync with the latest spec in mjsunit/temporal/plain-date-time-to-json 2. Change the the toPlainDateTime to accept object with partial time fields to sync with current spect in test/mjsunit/temporal/plain-date-to-plain-date-time.js 3. Change the test to accept input parameter type to Number instead of BigInt for Instant fromEpochSeconds and from EpochMilliseconds in test/mjsunit/temporal/instant-from-epoch-milliseconds.js and test/mjsunit/temporal/instant-from-epoch-seconds.js Throw TypeError if the type is BigInt. 4. Change the return type of Instant epochSeconds and epochMilliseconds from BigInt to Number to sync with the spec in test/mjsunit/temporal/instant-constructor.js Spec text https://tc39.es/proposal-temporal/#sec-temporal-padisoyear https://tc39.es/proposal-temporal/#sec-temporal-totemporaltimerecord https://tc39.es/proposal-temporal/#sec-temporal.instant.fromepochmilliseconds https://tc39.es/proposal-temporal/#sec-temporal.instant.fromepochseconds https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.epochmilliseconds https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.epochseconds Bug: v8:11544 Change-Id: Icd290905b65fdabbedece27e59c785635c212ec2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807122Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82185}
-
Frank Tang authored
Correct the wrong parameter passing in the 3rd PrepareTemporalFields calls Spec text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.prototype.with Bug: v8:11544 Change-Id: I8acd7059cedf6924eee36ed5cb7892b636c8c72a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807905Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82184}
-
Thibaud Michaud authored
Implement the WebAssembly.Function-based API. With the old API, wrapping an import and export with JS Promise Integration looked like: WebAssembly.returnPromiseOnSuspend(<wasm_export>); WebAssembly.suspendOnReturnedPromise( new WebAssembly.Function(<sig>, <js_import>)); With the new API: new WebAssembly.Function(<sig>, <wasm_export>, {promising: 'first'}) new WebAssembly.Function(<sig>, <js_import>, {suspending: 'first'}) For details, see https://github.com/WebAssembly/js-promise-integration/pull/8/files R=ahaas@chromium.org Bug: v8:12191 Change-Id: Iaefaac5304a038fc39283db165b637af7e48b009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804669Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#82183}
-
Clemens Backes authored
This reverts commit 4bab7a8e. Reason for revert: Breaks chromium integration, blocking the roll: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Linux%20Debug/15697/overview Original change's description: > [inspector] Enable async stack tagging API by default > > R=bmeurer@chromium.org > > Fixed: chromium:1334585 > Change-Id: Id79a60bac1731ea9c60654ff15c8e23f958c6e57 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3799431 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82161} Change-Id: I1918c5c14d17d724b7836e04eb4a64d034c2af9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804697 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82182}
-
Andreas Haas authored
With streaming compilation we delay the generation of errors until after all bytes are received, so that potentially better error messages get generated. With this CL we also delay the generation of errors in the combination of lazy compilation and streaming compilation. In particular, this CL does the following: * It avoids the creation of a `DecodeFail` task in `FinishAsyncCompileJobWithError`, which would create an error immediately before a potential name section arrived. * It calls `CompilationStateImpl::SetError()` so that an error is created once the stream finishes. * It removes the return value of `ProcessFunctionBody` so that wire bytes continue to be received even after a validation error. * It adds an early exit to `ProcessFunctionBody` if `CompilationStateImpl::failed()` is true, so that we don't continue validation after the first detected error. R=clemensb@chromium.org Bug: v8:12852 Change-Id: Ie8c6be243a257ef62cbb29fea6b8e0c205060680 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3802691Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#82181}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:12852 Change-Id: I3fbae50b164cca4ad1c0fefb856070ae2e472ff5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805059Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#82180}
-
Dominik Inführ authored
The String might be in the shared heap which is not collected during client GCs. Bug: v8:11708 Change-Id: I0958c46996a2aeba3a046263350617e8d177deca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805883Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82179}
-
Clemens Backes authored
If DefaultJobState::Join is called before any worker tasks were spawned (e.g. right after Platform::CreateJob), it should spawn the required number of worker tasks (mimicing what Platform::PostJob followed by Join would do, but with less context switches). This fixes regressions we got from switching from Platform::PostJob to Platform::CreateJob. R=mlippautz@chromium.org CC=etiennep@chromium.org Bug: chromium:1348512 Change-Id: Ic7984d12a28fc67f4b2f51ddc2ba5a406e43c127 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804600Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82178}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Ifc1008dce56e8f7e628a0ee0012f13403c40170b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804668 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82177}
-
Michael Achenbach authored
This reverts commit 5592bad9. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/45109/overview Original change's description: > [d8] Dump stack trace on d8 tests timeouts on posix systems > > - Add a SIGTERM handler in d8 that dupms the stack trace > - Send SIGTERM before SIGKILL in the test runner > > Bug: v8:13115 > Change-Id: I75285f33caabab61ff6ae83c1fbc6faf45cf595a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791906 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82173} Bug: v8:13115 Change-Id: I29f72d67036f76f93043f06841e4236864623bbe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805885Reviewed-by: Michael Achenbach <machenbach@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Owners-Override: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82176}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I4d74ca2d063869978226586c81fc45e0fd45dffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804665 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82175}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Ifad20bcccea2b87cb2119dcbaa5f16bf2dba2f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804666Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82174}
-