- 17 Jan, 2020 11 commits
-
-
Michael Achenbach authored
The contructor arguments were omitted for Android in a previous CL, which broke the Android builder. TBR=tmrts@chromium.org Bug: v8:8292 Change-Id: I266826e2531ba421161d6cd2241eae34b07e7521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007494Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65839}
-
Georgia Kouveli authored
Memory access offsets are unsigned. Sign-extending them incorrectly treats some large offsets as negative numbers and results in out-of-bounds errors for in-bounds accesses. This caused a failure in test/mjsunit/wasm/huge-memory.js for arm64, and for x64 with --nowasm_trap_handler. Change-Id: If58fead1d115f16ba4a6c3680252111fba6843d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002821 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65838}
-
Michael Achenbach authored
This prints the same details about a process when attempting to kill it as when termination fails with an exception. This will make it easier to correlate the two and to see which might be hanging. Bug: v8:8292 Change-Id: I4b6a50386d4e9d84ded55cf262f19529138654a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006092Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65837}
-
Jakob Kummerow authored
Not just the large virtual allocation but *all* memory operations should handle resource exhaustion gracefully. Bug: chromium:1042943 Change-Id: I8d36a3d7fa267b588b35b927172bfe56f64fffd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007489 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Peter Marshall authored
Previously these would silently fail unless the caller checked the .error property of the return value. There are no tests that check iteractions with non-existent methods so this should always be an error at the test runner level, rather than relying on clients to check the error. 1. Fix the tests that accidentally call methods that don't exist. 2. Change the test runner so that it prints an error and ends the test. 3. Add a test that the test runner does #2. Bug: v8:10134 Change-Id: Idd619950a057290c565d58fba6db3ddbcaf2c5eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006093 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65835}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: chromium:1041841 Change-Id: I4a5010fbf58a812e724ab95f2552dd4b6887113f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004612 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Bill Ticehurst authored
The change at https://chromium-review.googlesource.com/c/v8/v8/+/1993971 introduced some new exports, but it appears the wrong macro was used for the component being built (V8_BASE_EXPORT rather than V8_EXPORT_PRIVATE) This breaks DLL builds (at least on MSVC, which I just fixed via https://chromium-review.googlesource.com/c/v8/v8/+/1996157). Adding Leszek who made the change, and Ulan and Toon as area OWNERS. Bug: v8:8791 Change-Id: I916553992f7d42cba0f4d8ae46b014df6c5ef633 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2005528 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65833}
-
Toon Verwaest authored
That way we don't need to generate bytecode for it. Change-Id: Ie7e17f283cf5a096ab98c4fd01fd346b56b83576 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004611Reviewed-by:
-
Clemens Backes authored
This was used for debugging only. The DevTools frontend now receives the raw wasm bytes, and disassembles the functions it needed. The inspector change was done in https://crrev.com/c/1991481. This CL removes all code which is now dead in v8. R=ahaas@chromium.org, bmeurer@chromium.org Change-Id: I2d433613f1270a1ddac9af0bae8d990ef190712a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2005072Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65831}
-
Michael Achenbach authored
TBR=nicohartmann@chromium.org No-Try: true Change-Id: I4a0e07c3f45868fbfbb233349292e137769f6f51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006091Reviewed-by:
-
Ng Zhi An authored
Add a cctest that contains a function with a SIMD parameter, and calls that function. This will exercise two cases in Liftoff which involves preparing to call the function, and processing the SIMD parameters of the function. The tricky case here is ARM, which requires an FP pair. Most of the logic added is to check the RegClass/type and construct the right type of LiftoffRegister to use. As a drive-by, added SIMD case to the various backends' Move implementation. This is not exercised by the test case, requires more complicated function setup. Bug: v8:9909 Change-Id: I1d01e8c3bee0cf336d1a8ff537317c77aedfdac0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004369 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 16 Jan, 2020 29 commits
-
-
Santiago Aboy Solanes authored
Since: 1) The Int32Add will only look at the lower bits 2) The output of this instruction will clear the top bits (in the same way that the movl does) then the truncation is not needed. Change-Id: Ic611ce435ff6216ce8b75bb7316af4372e3290e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2000747Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65828}
-
Z Nguyen-Huu authored
Re-use set breakpoint logic for wasm script to set breakpoint to first breakable position of given wasm function. Bug: v8:9724 Change-Id: Ibd6b59d5b93c6895f71f0114291bf78db03aee0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2001564 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Pierre Langlois authored
We had a --log-instruction-stats option which would count executed instructions, splitting them into categories. We haven't used this for some years so we're proposing to just remove the code so it doesn't bitrot and allows further cleanups. Change-Id: If24d11608823e24689ea02f09f5e93b4a5acd636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002819Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#65826}
-
Ng Zhi An authored
Add 64-bit data size support to SHL and SHR, add simulator logic to support new data size, and fix disasm. For the disasm fix, casting size / 16 to NeonSize no longer works when given a size of 64, it is 4, but should be 3. Change-Id: I5bd1ce254cd3ff4b86159837087f22b2ed06703e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1994180Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65825}
-
Ng Zhi An authored
Bug: v8:10082 Change-Id: Ieabb0ebeec14091844b3d30b9b1684a249db7bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980949Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Previously, V8 was just relinking nodes which broke when a move involves an on-stack reference as such nodes have different semantics. The solution is to create new internal nodes when necessary. Bug: chromium:1040038 Change-Id: Ia5b3866ae68d014beb30972c4266aa5bae6559fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002546 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Bill Ticehurst authored
Add the necessary V8_EXPORT_PRIVATE attributes and a few other minor changes to make building DLLs with MSVC happy. (Note: Debug builds still seem to be failing in Torque, but this fixes Release builds). Bug: v8:8791 Change-Id: Ia4d5372fd1cb961e6268a2b5c089bcd17822f1e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1996157Reviewed-by:
-
Clemens Backes authored
This makes Liftoff inspection (scope reporting) also use the decoded names of locals, which are now stored in a C++ data structure (see https://crrev.com/c/2002541). The call to {SetOwnPropertyIgnoreAttributes} had to be replaced by a proper lookup first, to handle integer names and duplicate names correctly. The test already covered these cases. The test was extended by another unnamed local to also test the generation of default names in case no name is provided. R=thibaudm@chromium.org Bug: v8:10019 Change-Id: I475bb4db9a32c39203180e9c8d3f8181c3882138 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002544 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65821}
-
Sigurd Schneider authored
TimeTicks cannot convert to other timeunits, only TimeDelta can do that. Chrome's version of TimeBase introduced a `since_origin` helper that essentially converts a TimeTicks object in to a TimeDelta with the corresponding duration. This CL ports that helper to V8 and cleans up a couple of places where we used `timestamp - 0` to convert a TimeTicks object to a TimeDelta. Change-Id: I540ced876ac3e727dfdedf7b838a272cc40d6954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993282 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65820}
-
Clemens Backes authored
We were decoding the names of locals into a C++ data structure, and then generated a FixedArray out of that, stored in the on-heap WasmDebugInfo. In order to support name lookup for debugging with Liftoff, where no WasmDebugInfo will be present, this CL refactors the C++ data structure to allow direct lookups and stores it in the C++ DebugInfo structure. With this CL, the names are still only used from the old interpreter-based debugging path. A follow-up CL will then also use it from Liftoff. R=thibaudm@chromium.org Bug: v8:10019 Change-Id: I1397021b5d69b9346fc26f5e83653360f428c5e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002541 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Ib7af793218d005883b0ab5423714fdf43664cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972611 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
When buildin an array boilerplate description, we currently walk the array literal as if it had tagged pointers, and post-hoc copy it to a FixedDoubleArray if it had double elements kind. Now, we calculate the elements kind during the InitDepthAndFlags walk, and if the elements kind is Double, we allocate a FixedDoubleArray to start with, and convert the elements of the array literal directly to unboxed doubles in the array. Change-Id: I56561e0af2236e785498eb70cb37eddcb09a56ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002529 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Add support for internalizing an AstValueFactory using the off-thread factory. Includes adding ConsString support to OffThreadFactory. This introduces a Handle union wrapper, which is used in locations that can store a Handle or an OffThreadHandle. This is used in this patch for the internalized "string" field of AST strings, and will be able to be used for other similar fields in other classes (e.g. the ScopeInfo handle in Scope, object boilerplate descriptor handles, the inferred name handle on FunctionLiterals, etc.). It has a Factory-templated getter which returns the appropriate handle for the factory, and a debug-only tag to make sure the right getter is used at runtime. This union wrapper currently decomposes implicitly to a Handle if the getter is not called, to minimise code changes, but this implicit conversion will likely be removed for clarity. Bug: chromium:1011762 Change-Id: I5dd3a7bbdc483b66f5ff687e0079c545b636dc13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993971 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
When an overall timeout is reached, swarming sends a SIGTERM to terminate the test runner. The test runner has a signal handler on the main process to terminate all workers gracefully. Additionally, every worker process installs a signal handler for terminating ongoing tests wrapped by command.Command. Also, command.Command is used on the main process to list tests for cctest and gtest executables, which led to overriding the test runner's main signal handler. This CL disables using signal handlers in commands by default and only explicitly enables it in safe source locations. Bug: v8:8292 Change-Id: Ifceadaff75bdd2b77e761498bccbe00b6a3e265c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002528Reviewed-by:
-
Jakob Gruber authored
Function calls can push arguments onto the stack. The consumed stack slots are not considered by the function-entry stack check, since initial frame setup only reserves space for local slots, not call arguments. This CL adds such logic by tracking the maximum pushed argument count during instruction selection, and adding these slots to the (existing) stack check offset logic in code generation. Bug: chromium:1030167 Change-Id: I26a9407cf38009839b1dda2ff0c8ec297c15ed8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002540 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65814}
-
Leszek Swirski authored
Fixed: v8:10129 Bug: chromium:1011762 Change-Id: I2b2398178a56c5378c95fccac57040a6eddda560 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004609 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I8334a97033ebfa4bbd6bba27eb75c6ae129deab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995384 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65812}
-
Bartek Nowierski authored
This reverts commits - 63dc5556 Add a debug v8 API SetDetachedWindowReason - 96458105 Introduce and emit "function calls in detached window" use counters. - db18e495 PPC/s390: Add a debug v8 API SetDetachedWindowReason Note, macro-assembler-x64.cc isn't reverted b/c DCHECK_NE is currently in a better place. Reason for revert: No longer needed. It was intended for only 1 milestone. Bug: chromium:1018156,chromium:1023293 Change-Id: Ic1c19e6e12bb4ac967cf8e687a77c58edc405833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004133 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This way we don't need to generate bytecodes to push the context. This drops the stack trace for redeclaration SyntaxErrors but keeps the message location. This is in line with what we do for other SyntaxErrors. Change-Id: Id8e3cc348b4d56a8196753baf51cfd810f07512b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997439 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Jakob Gruber authored
The advance-by parameter can contain negative numbers, but until this CL was treated as unsigned. Bug: v8:10072,v8:9330 Change-Id: Ib9a9c2d47ba71fa819e89502d14871af6dfc9693 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002543 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I4fc039711eb9aa9d551144ea6fccc926d4803349 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993290 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65808}
-
Hannes Payer authored
Change-Id: I6eb3c9c6ff25a58b2c7d0d233926514606e7ff5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995395 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Georg Neis authored
These safepoints weren't needed and weren't even valid (e.g. pointing to the wrong instruction). The exception are Wasm C API functions, where we do need a safepoint (and can work around the invalid address). Bug: v8:10037 Change-Id: I597c33dbd542394990fbd006ba8c16ccff7e260e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002530 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
... and remove a related, unused function. Bug: v8:7790 Change-Id: I803f4b747220a1722e096ef77fcc6c8a9e18fe1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002534Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65805}
-
Leszek Swirski authored
Bug: v8:10129 Bug: chromium:1011762 Change-Id: I1c2cc16326e2efb9f126ddcc0cc232229a94d0ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002545 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Dan Elphick authored
Changes FastCheck failures to just call Unreachable (which in turn calls DebugBreak) instead of DebugBreak and then returning to just after the check. FastCheck is only called in release builds so this does not affect debug builds. This reduces the embedded instruction size from 1249720 to 1246812 (2908 bytes) for ARM. Change-Id: If4b9b6810a53d64262a0fa9c2a1903e022748a22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002538Reviewed-by:
-
Andreas Haas authored
DebugBreak allows you to put break points into generated code. When executed in gdb, the execution will stop in the generated code at the break point. R=clemensb@chromium.org Change-Id: I5607d7ec45d4910412c7adff5ae9bea2c9498909 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002536 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit e04fbec1. Reason for revert: Innocent. Original change's description: > Revert "Make NoSideEffectsToString gracefully handle huge msgs on error objects" > > This reverts commit b0ebfabc. > > Reason for revert: Speculative revert for nvidia bot failure: https://ci.chromium.org/p/v8/builders/ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/7953 > > Original change's description: > > Make NoSideEffectsToString gracefully handle huge msgs on error objects > > > > Bug: chromium:1032512 > > Change-Id: I323981a08e316ebc10c729f2f04b7832373937b0 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962865 > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Commit-Queue: Georg Neis <neis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65782} > > TBR=neis@chromium.org,jgruber@chromium.org > > Change-Id: Ibdc1efccab3edcd05dd1df99ad0263ea4bce9989 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1032512 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002532 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65793} TBR=neis@chromium.org,jgruber@chromium.org,clemensb@chromium.org Change-Id: I9b2f745b15495e21c21c3198f2362437dc4376c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1032512 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002539Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6e49eef..1bee638 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/8d21328..1f38b43 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7431e17..f7d73bb Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/9a6352a..19c8ac5 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/4dca59c..bb3f180 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/814da1f..94485d9 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/86eb804..42fbdfe TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Iaed275fcaffbd4af7cf87bc8047d5f5c17c4fcfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004229Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65800}
-
