- 10 Feb, 2017 13 commits
-
-
rmcilroy authored
In order to allow parallel compilation of eager inner functions, we need to seperate the zone used for parsing (which will be shared between all the parallel compile jobs) and the zone used for compilation. This CL changes CompilationInfo to require a zone (which can be different from the zone in ParseInfo). We then seal the ParseInfo zone after parsing and analysis is done to prevent any further allocation in that zone, so that it can be shared (read-only) with the parallel compile jobs. BUG=v8:5203 Review-Url: https://codereview.chromium.org/2645403002 Cr-Commit-Position: refs/heads/master@{#43089}
-
jgruber authored
This was broken by https://codereview.chromium.org/2663803002. BUG= Review-Url: https://codereview.chromium.org/2686253003 Cr-Commit-Position: refs/heads/master@{#43088}
-
Peter Marshall authored
Add a simple benchmark for a TypedArray constructor. Run once with the default pipeline and once with turbofan so that we can compare the performance. Also fixes a typo in the Regex for the result of the CopyWithin benchmark which stopped the results showing up in the perf dashboard. BUG= Change-Id: Ic2eb0bd1e02b458c1163e97130abd0e7531c2e1c Reviewed-on: https://chromium-review.googlesource.com/440225Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#43087}
-
Marja Hölttä authored
This CL covers only the very simple cases. BUG=v8:5516 R=vogelheim@chromium.org Change-Id: Ib6ddc90cbcf1c923a7b72493cfd029cfa835462b Reviewed-on: https://chromium-review.googlesource.com/440246Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43086}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2682143002 Cr-Original-Commit-Position: refs/heads/master@{#43065} Committed: https://chromium.googlesource.com/v8/v8/+/193a0c118845d068ab386b5c90d04daaa64e1e86 Review-Url: https://codereview.chromium.org/2682143002 Cr-Commit-Position: refs/heads/master@{#43085}
-
Jochen Eisinger authored
R=mlippautz@chromium.org BUG= Change-Id: I4b25bcc1accd652e28a1fe4fc9776265afa1b75b Reviewed-on: https://chromium-review.googlesource.com/440944Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43084}
-
yangguo authored
Sometimes we do want to include objects that are already dead. R=hpayer@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2687113002 Cr-Commit-Position: refs/heads/master@{#43083}
-
yangguo authored
Collecting precise invocation counts need to be explicitly enabled. Once enabled, we disable optimization (optimized code does not increment invocation count, and may inline callees), and make sure feedback vectors interesting for code coverage is not garbage-collected. R=hpayer@chromium.org, jgruber@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2686063002 Cr-Commit-Position: refs/heads/master@{#43082}
-
ishell authored
This CL includes runtime and IC parts of the tracking. It is controlled by compile-time flag FLAG_constant_field_tracking and currently disabled. Transition from kConst to kMutable still involves map deprecation. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2598543003 Cr-Commit-Position: refs/heads/master@{#43081}
-
yukishiino authored
http://www.ecma-international.org/ecma-262/7.0/#sec-validateandapplypropertydescriptor says that [[DefineProperty]] should return false if the property is already defined and it's unconfigurable (exactly speaking, the condition in the spec is more complicated, but roughly speaking, it's when the property is unconfigurable). BUG=chromium:670651 Review-Url: https://codereview.chromium.org/2680353004 Cr-Commit-Position: refs/heads/master@{#43080}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e62b61f..9d467bb Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/5c71aac..df42e55 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ia85a5ca11321e0bea3f0b58989e5c18fa344a8c7 Reviewed-on: https://chromium-review.googlesource.com/440804Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43079}
-
jkummerow authored
And use it to avoid runtime calls when there are too many properties for linear searching. The threshold of 32 was chosen by experimentation. Review-Url: https://codereview.chromium.org/2680973002 Cr-Commit-Position: refs/heads/master@{#43078}
-
titzer authored
R=bradnelson@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2682943007 Cr-Commit-Position: refs/heads/master@{#43077}
-
- 09 Feb, 2017 27 commits
-
-
jkummerow authored
DescriptorArray::kDescriptorFoo was renamed to DescriptorArray::kEntryFooIndex in https://codereview.chromium.org/2688573003 TBR=ishell@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2687083003 Cr-Commit-Position: refs/heads/master@{#43076}
-
jkummerow authored
TBR=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2688573003 Cr-Commit-Position: refs/heads/master@{#43075}
-
jkummerow authored
BUG=v8:5269 Review-Url: https://codereview.chromium.org/2686723004 Cr-Commit-Position: refs/heads/master@{#43074}
-
bjaideep authored
Port e425079b Minor fix to the s390 port. Original Commit Message: arguments.h is one of the headers including objects-inl.h. Files needing objects-inl.h used to innocently pull in debug.h, so that needs to be fixed now too. R=marja@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5294 LOG=N Review-Url: https://codereview.chromium.org/2687103002 Cr-Commit-Position: refs/heads/master@{#43073}
-
yangguo authored
Collect code coverage from the available invocation counts. The granularity is at function level, and invocation counts may be lost to GC. Coverage::Collect returns a std::vector of Coverage::ScriptData. Each ScriptData contains a script ID and a std::vector of Coverage::RangeEntry. Each RangeEntry consists of a end position and the invocation count. The start position is implicit from the end position of the previous RangeEntry, or 0 if it's the first RangeEntry. R=jgruber@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2689493002 Cr-Commit-Position: refs/heads/master@{#43072}
-
jkummerow authored
BUG=v8:5269 Review-Url: https://codereview.chromium.org/2682153003 Cr-Commit-Position: refs/heads/master@{#43071}
-
machenbach authored
Revert of [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation (patchset #3 id:40001 of https://codereview.chromium.org/2682143002/ ) Reason for revert: cfi failure: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/8635 Original issue's description: > [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation > > BUG= > > Review-Url: https://codereview.chromium.org/2682143002 > Cr-Commit-Position: refs/heads/master@{#43065} > Committed: https://chromium.googlesource.com/v8/v8/+/193a0c118845d068ab386b5c90d04daaa64e1e86 TBR=jarin@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2683203002 Cr-Commit-Position: refs/heads/master@{#43070}
-
Leszek Swirski authored
Cleans up the internalization. Also, clean up no-longer-used ast symbols, iterator and hasInstance, which were left behind after other refactors. Having an enum here should keep this clean in the future. Change-Id: Id526784b0361c7a2242b21ecf2af72b0403c6ad8 Reviewed-on: https://chromium-review.googlesource.com/440204Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#43069}
-
mstarzinger authored
R=ishell@chromium.org TEST=mjsunit/regress/regress-5902 BUG=chromium:688837 Review-Url: https://codereview.chromium.org/2682203003 Cr-Commit-Position: refs/heads/master@{#43068}
-
ishell@chromium.org authored
BUG=chromium:680995 Change-Id: Ib567c88df357dea77cba802cbc0e567ee4097235 Reviewed-on: https://chromium-review.googlesource.com/440124 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#43067}
-
bmeurer authored
R=danno@chromium.org Review-Url: https://codereview.chromium.org/2684263002 Cr-Commit-Position: refs/heads/master@{#43066}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2682143002 Cr-Commit-Position: refs/heads/master@{#43065}
-
Michael Lippautz authored
BUG=chromium:651354 Change-Id: I8d74133ca9b21ce9e0612efc1e5ace41d1002dae Reviewed-on: https://chromium-review.googlesource.com/440304Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43064}
-
bmeurer authored
These intrinsics are heavily used in typedarray.js and are part of the reason why the typed array constructors are more than twice as slow in TurboFan compared to Crankshaft. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2684193003 Cr-Commit-Position: refs/heads/master@{#43063}
-
jgruber authored
Updated according to the recent spec change at https://github.com/tc39/ecma262/pull/798. BUG=v8:5949 Review-Url: https://codereview.chromium.org/2681323002 Cr-Commit-Position: refs/heads/master@{#43062}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2680163005 Cr-Commit-Position: refs/heads/master@{#43061}
-
machenbach authored
Revert of [debugger] expose side-effect free evaluate to inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2685483002/ ) Reason for revert: Speculative revert. Seems to block the roll: https://codereview.chromium.org/2685933005/ Original issue's description: > [debugger] expose side-effect free evaluate to inspector. > > R=jgruber@chromium.org, kozyatinskiy@chromium.org > BUG=v8:5821 > > Review-Url: https://codereview.chromium.org/2685483002 > Cr-Commit-Position: refs/heads/master@{#43049} > Committed: https://chromium.googlesource.com/v8/v8/+/1a989bdeefdc679745215ae547007773edb3d29e TBR=jgruber@chromium.org,kozyatinskiy@chromium.org,pfeldman@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5821 Review-Url: https://codereview.chromium.org/2687013003 Cr-Commit-Position: refs/heads/master@{#43060}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2682593003 Cr-Commit-Position: refs/heads/master@{#43059}
-
jgruber authored
BUG=v8:5943 Review-Url: https://codereview.chromium.org/2681123002 Cr-Commit-Position: refs/heads/master@{#43058}
-
Michael Achenbach authored
On bots we don't sort due to not being able to store the duration DB. But we should still run the tests marked as slow first. BUG=v8:5861 Change-Id: Ifa812b3eef15f48e3d3c752c14c3f546b5dd87d1 Reviewed-on: https://chromium-review.googlesource.com/439284Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43057}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7968040..e62b61f Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/df67b47..5c71aac Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/426ef62..404d542 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I59c076ae3fa6b6d495011268d6d791173a1ffa8e Reviewed-on: https://chromium-review.googlesource.com/439745Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43056}
-
jgruber authored
LoadGlobalIC will be inlined into ignition's LdaGlobal family of bytecode handlers. This CL splits up LoadGlobalIC into three distinct cases (property cell, handler, and miss) and introduces the ExitPoint abstraction in order to make inlining easier. BUG=v8:5917 Review-Url: https://codereview.chromium.org/2688503002 Cr-Commit-Position: refs/heads/master@{#43055}
-
Marja Hölttä authored
arguments.h is one of the headers including objects-inl.h. Files needing objects-inl.h used to innocently pull in debug.h, so that needs to be fixed now too. BUG=v8:5294 R=mstarzinger@chromium.org Change-Id: I8ce671c533ed757103ef9a3b0bf0a0509230fdd8 Reviewed-on: https://chromium-review.googlesource.com/439287Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#43054}
-
Michael Achenbach authored
BUG=chromium:688159 NOTRY=true TBR=bmeurer@chromium.org,mstarzinger@chromium.org Change-Id: I9b5c0c531af31534a0dd33e078a148b822834448 Reviewed-on: https://chromium-review.googlesource.com/439184Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43053}
-
Michael Achenbach authored
BUG=chromium:688856,chromium:664068 NOTRY=true Change-Id: Icf0e7a51693b6d399c8395eb0bbed9a3c373eb0a Reviewed-on: https://chromium-review.googlesource.com/439164Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#43052}
-
Jochen Eisinger authored
BUG=v8:5830 R=yangguo@chromium.org Change-Id: Ic4f41e0afa32de17615f9f1e9c9b9f05f265b7fe Reviewed-on: https://chromium-review.googlesource.com/439151 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#43051}
-
bmeurer authored
Since the empty string is canonical HeapObject now, we can use this fact to optimize - strict equality comparisons with the empty string to a simple ReferenceEqual operation, and - optimize ToBoolean to avoid instance type checks completely. Drive-by-fix: Allow InternalizedString for Type::HeapConstant in the type system. This is safe, since InternalizedStrings can be compared to other heap constants by reference (except for non-InternalizedStrings, which are excluded from the HeapConstant type). BUG=v8:5267 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2681273002 Cr-Commit-Position: refs/heads/master@{#43050}
-