- 11 Jun, 2015 29 commits
-
-
martyn.capewell authored
Merge a following arithmetic or logical right shift into the existing shift of ARM64's Int32MulHigh or Uint32MulHigh code. BUG= Review URL: https://codereview.chromium.org/1179503003 Cr-Commit-Position: refs/heads/master@{#28945}
-
jacob.bramley authored
Revert of [arm64][turbofan]: Handle any immediate shift. (patchset #1 id:1 of https://codereview.chromium.org/1179733004/) Reason for revert: Breaks InstructionSelectorTest.Word64ShrWithWord64AndWithImmediate on debug builds (but not optdebug builds). I'll investigate. Original issue's description: > [arm64][turbofan]: Handle any immediate shift. > > With this patch, we can generate simple immediate-shift instructions for > immediates outside the range "0 <= imm < width". Several related > instruction selectors have also been updated accordingly. > > Example of generated code: > > ---- Before --- ---- After ---- > movz w0, #33 lsr w0, w1, #1 > lsr w0, w1, w0 > > BUG= > > Committed: https://crrev.com/36d771bbfa4af5efcc1c1dcf5b234445cb7ee722 > Cr-Commit-Position: refs/heads/master@{#28943} TBR=bmeurer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1176393002 Cr-Commit-Position: refs/heads/master@{#28944}
-
jacob.bramley authored
With this patch, we can generate simple immediate-shift instructions for immediates outside the range "0 <= imm < width". Several related instruction selectors have also been updated accordingly. Example of generated code: ---- Before --- ---- After ---- movz w0, #33 lsr w0, w1, #1 lsr w0, w1, w0 BUG= Review URL: https://codereview.chromium.org/1179733004 Cr-Commit-Position: refs/heads/master@{#28943}
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1175113005 Cr-Commit-Position: refs/heads/master@{#28942}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1179693005 Cr-Commit-Position: refs/heads/master@{#28941}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1178103002 Cr-Commit-Position: refs/heads/master@{#28940}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1173243003 Cr-Commit-Position: refs/heads/master@{#28939}
-
yangguo authored
The alternative of passing an object template at context creation is unfeasible because we need a context to instantiate the template. At the time we create the context from snapshot or bootstrap from scratch, we would already need that template instance, leading to a chicken-and-egg problem. This is an alternative that is simpler and less intrusive. R=domenic@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/1182443002 Cr-Commit-Position: refs/heads/master@{#28938}
-
mstarzinger authored
TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1178123002 Cr-Commit-Position: refs/heads/master@{#28937}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1180473003 Cr-Commit-Position: refs/heads/master@{#28936}
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:4131 LOG=N Review URL: https://codereview.chromium.org/1177743002 Cr-Commit-Position: refs/heads/master@{#28935}
-
machenbach authored
Revert of [heap] Unify the immortal immovable root detection mechanism. (patchset #3 id:40001 of https://codereview.chromium.org/1178853002/) Reason for revert: [Sheriff] tsan failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4240 Original issue's description: > [heap] Unify the immortal immovable root detection mechanism. > > Uniformly use the Heap::GetRootListIndex() and > Heap::RootIsImmortalImmovable() methods to detect immortal immovable > roots in the optimizing compilers. > > R=jarin@chromium.org > > Committed: https://crrev.com/84e83da99a72edc169367bf88588b1a2f10c2e08 > Cr-Commit-Position: refs/heads/master@{#28933} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1178083003 Cr-Commit-Position: refs/heads/master@{#28934}
-
bmeurer authored
Uniformly use the Heap::GetRootListIndex() and Heap::RootIsImmortalImmovable() methods to detect immortal immovable roots in the optimizing compilers. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1178853002 Cr-Commit-Position: refs/heads/master@{#28933}
-
jochen authored
Revert of Add CHECKs to verify that we never finalize stale copies of external strings (patchset #1 id:1 of https://codereview.chromium.org/1160253010/) Reason for revert: not needed anymore Original issue's description: > Add CHECKs to verify that we never finalize stale copies of external strings > > BUG=none > R=ulan@chromium.org > LOG=n > > Committed: https://crrev.com/ca2f8d811ca08783e38ce5dd42d38a6b6a7b876f > Cr-Commit-Position: refs/heads/master@{#28811} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1178703008 Cr-Commit-Position: refs/heads/master@{#28932}
-
machenbach authored
Revert of Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/1181533006/) Reason for revert: [Sheriff] Changes/breaks layout tests. Please land upstream needsmanualrebaseline requests first or fix the tests. E.g. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/400 One test fails, one times out. See e.g. expectations changes: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/400/layout-test-results/inspector/sources/debugger-async/async-callstack-promises-diff.txt On linux debug theses tests crash: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/346 https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/346/layout-test-results/results.html Original issue's description: > Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/1176163004/) > > Reason for revert: > Test failures are bogus. Snapshot blob and natives blob are out of sync due to build being weird. > > Original issue's description: > > Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/1098663002/) > > > > Reason for revert: > > Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829 > > > > Original issue's description: > > > Promise assimilation fix. > > > > > > Let x be a fulfilled promise and y be another promise. |x.then(() => y)| > > > should call |y.then|, but the current implementation calls PromiseChain. > > > We can see the difference when we set a custom function to |y.then|. > > > > > > This CL fixes the spec violation, but as a result |then| is no longer > > > a wrapper of |chain| and in some cases it does not work well with > > > |accept| or |chain|. That is not a problem for ES6 promise users because > > > ES6 promise doesn't have them. > > > > > > LOG=N > > > BUG=477921 > > > > > > Committed: https://crrev.com/2f57dff3ea0c45e1a61b334fda962460f89d71bc > > > Cr-Commit-Position: refs/heads/master@{#28926} > > > > TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=477921 > > > > Committed: https://crrev.com/5bb75f514027f79303396dba823c2d78c6add83b > > Cr-Commit-Position: refs/heads/master@{#28927} > > TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=477921 > > Committed: https://crrev.com/6f214bdd8bcdc76d48bd85c3bd897f0e2427ff95 > Cr-Commit-Position: refs/heads/master@{#28928} TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477921 Review URL: https://codereview.chromium.org/1181603003 Cr-Commit-Position: refs/heads/master@{#28931}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#28930}
-
vogelheim authored
Revert of Re-land: Enable external startup by default on Linux. (patchset #3 id:40001 of https://codereview.chromium.org/1041683002/) Reason for revert: Revert, due to problems with stale build artefacts uncovered by this. Details: https://code.google.com/p/v8/issues/detail?id=4171 Original issue's description: > Re-land: Enable external startup by default on Linux. > > crrev.com/1016603004 should have fixed the issues that broke this last time. > > Notes: > - The current functionality is meant to stay. If you prefer the old way, > just set v8_use_external_startup_data=0. > - You might notice this if you call d8 via PATH. Either explicitly tell d8 > where your external snapshot/built-ins are, or change the build options > as above. > - This follows Chromium practice, that mostly uses this feature these days. > - Other platforms to follow later. > > BUG= > > Committed: https://crrev.com/bb9c774c164c3552b67b4f1b60809852a44f2ecd > Cr-Commit-Position: refs/heads/master@{#28858} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1177883003 Cr-Commit-Position: refs/heads/master@{#28929}
-
yangguo authored
Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/1176163004/) Reason for revert: Test failures are bogus. Snapshot blob and natives blob are out of sync due to build being weird. Original issue's description: > Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/1098663002/) > > Reason for revert: > Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829 > > Original issue's description: > > Promise assimilation fix. > > > > Let x be a fulfilled promise and y be another promise. |x.then(() => y)| > > should call |y.then|, but the current implementation calls PromiseChain. > > We can see the difference when we set a custom function to |y.then|. > > > > This CL fixes the spec violation, but as a result |then| is no longer > > a wrapper of |chain| and in some cases it does not work well with > > |accept| or |chain|. That is not a problem for ES6 promise users because > > ES6 promise doesn't have them. > > > > LOG=N > > BUG=477921 > > > > Committed: https://crrev.com/2f57dff3ea0c45e1a61b334fda962460f89d71bc > > Cr-Commit-Position: refs/heads/master@{#28926} > > TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=477921 > > Committed: https://crrev.com/5bb75f514027f79303396dba823c2d78c6add83b > Cr-Commit-Position: refs/heads/master@{#28927} TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477921 Review URL: https://codereview.chromium.org/1181533006 Cr-Commit-Position: refs/heads/master@{#28928}
-
yangguo authored
Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/1098663002/) Reason for revert: Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829 Original issue's description: > Promise assimilation fix. > > Let x be a fulfilled promise and y be another promise. |x.then(() => y)| > should call |y.then|, but the current implementation calls PromiseChain. > We can see the difference when we set a custom function to |y.then|. > > This CL fixes the spec violation, but as a result |then| is no longer > a wrapper of |chain| and in some cases it does not work well with > |accept| or |chain|. That is not a problem for ES6 promise users because > ES6 promise doesn't have them. > > LOG=N > BUG=477921 > > Committed: https://crrev.com/2f57dff3ea0c45e1a61b334fda962460f89d71bc > Cr-Commit-Position: refs/heads/master@{#28926} TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477921 Review URL: https://codereview.chromium.org/1176163004 Cr-Commit-Position: refs/heads/master@{#28927}
-
yhirano authored
Let x be a fulfilled promise and y be another promise. |x.then(() => y)| should call |y.then|, but the current implementation calls PromiseChain. We can see the difference when we set a custom function to |y.then|. This CL fixes the spec violation, but as a result |then| is no longer a wrapper of |chain| and in some cases it does not work well with |accept| or |chain|. That is not a problem for ES6 promise users because ES6 promise doesn't have them. LOG=N BUG=477921 Review URL: https://codereview.chromium.org/1098663002 Cr-Commit-Position: refs/heads/master@{#28926}
-
hpayer authored
Make sure we do not start incremental marking in idle notification when incremental marking is turned off via flags. BUG=chromium:498315 LOG=n Review URL: https://codereview.chromium.org/1177953002 Cr-Commit-Position: refs/heads/master@{#28925}
-
mbrandy authored
This fixes a failure in test/mjsunit/regress/regress-crbug-491062.js. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com, svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/1174693002 Cr-Commit-Position: refs/heads/master@{#28924}
-
jarin authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1175963002 Cr-Commit-Position: refs/heads/master@{#28923}
-
bmeurer authored
Previously we only recorded the SharedFunctionInfo of inlined functions that had at least one (lazy) deopt point left at code generation time. R=mstarzinger@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/ffa0b4007cd7de0cfd6d37079ef360e3beeb5686 Review URL: https://codereview.chromium.org/1175953002 Cr-Commit-Position: refs/heads/master@{#28922}
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1179763002 Cr-Commit-Position: refs/heads/master@{#28921}
-
bmeurer authored
Revert of [turbofan] Record the SharedFunctionInfo of ALL inlined functions. (patchset #2 id:20001 of https://codereview.chromium.org/1175953002/) Reason for revert: Breaks Windows debug. Original issue's description: > [turbofan] Record the SharedFunctionInfo of ALL inlined functions. > > Previously we only recorded the SharedFunctionInfo of inlined functions > that had at least one (lazy) deopt point left at code generation time. > > R=mstarzinger@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/ffa0b4007cd7de0cfd6d37079ef360e3beeb5686 TBR=mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1178683004 Cr-Commit-Position: refs/heads/master@{#28920}
-
Benedikt Meurer authored
Previously we only recorded the SharedFunctionInfo of inlined functions that had at least one (lazy) deopt point left at code generation time. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1175953002. Cr-Commit-Position: refs/heads/master@{#28919}
-
mstarzinger authored
This is needed in order to allow expansion of a throwing node into a set of nodes that produce different effects for the successful and the exceptional continuation. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1179543002 Cr-Commit-Position: refs/heads/master@{#28918}
-
v8-autoroll authored
Rolling v8/third_party/icu to a05f412f70489b77da0ddeb8baa31c68e3eff2c6 Rolling v8/tools/clang to 69fd1b485a2b24c872bfa4759342076751c9d490 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1176273002 Cr-Commit-Position: refs/heads/master@{#28917}
-
- 10 Jun, 2015 11 commits
-
-
machenbach authored
BUG=chromium:498689 LOG=n NOTRY=true TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1169813010 Cr-Commit-Position: refs/heads/master@{#28916}
-
machenbach authored
BUG=chromium:498689 LOG=n NOTRY=true TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1179573003 Cr-Commit-Position: refs/heads/master@{#28915}
-
machenbach authored
BUG=chromium:498689 LOG=n NOTRY=true TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1180523002 Cr-Commit-Position: refs/heads/master@{#28914}
-
paul.lind authored
After https://codereview.chromium.org/1180433003 the code-size exceeeds the limit for MIPS. We have some optimizations in place for MIPS64 that will be ported back to MIPS, and will investigate other code-size improvements so we can re-enable this test. BUG= Review URL: https://codereview.chromium.org/1166353005 Cr-Commit-Position: refs/heads/master@{#28913}
-
adamk authored
Two changes: - In ReportBootstrappingException, if all we have is a string, it seems better to print that than nothing. - In Factory::NewError, there's no use trying to call into the builtins if compilation of the builtins is causing the exception (this currently results in a cryptic segfault if we trigger, say, a ReferenceError when executing builtins script during bootstrapping). Review URL: https://codereview.chromium.org/1158013003 Cr-Commit-Position: refs/heads/master@{#28912}
-
weiliang.lin authored
Frame Elider requires a sane CFG which should have such dummy end block. BUG= Review URL: https://codereview.chromium.org/1166293004 Cr-Commit-Position: refs/heads/master@{#28911}
-
machenbach authored
BUG=chromium:498689 LOG=n NOTRY=true TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1173033003 Cr-Commit-Position: refs/heads/master@{#28910}
-
mbrandy authored
Port cf21da7e Original commit message: Up until now we can only inline based on JSFunction, because of the way the deoptimization works. With this change we will be able to inline based on the SharedFunctionInfo and materialize the JSFunction from a literal or a stack slot when necessary. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1174963004 Cr-Commit-Position: refs/heads/master@{#28909}
-
wingo authored
R=dslomov@chromium.org, rossberg@chromium.org LOG=Y BUG=v8:2700 Review URL: https://codereview.chromium.org/1178523002 Cr-Commit-Position: refs/heads/master@{#28908}
-
balazs.kilvady authored
On Mac for the requested minimal version (10.5) only old stl (from gcc 4.2.1) can be used so unfortunately we can't use numeric_limits<>::lowest() which were added in 874c54e0 BUG= TEST=cctest/test-assembler-mips64, cctest/test-assembler-mips Review URL: https://codereview.chromium.org/1175463003 Cr-Commit-Position: refs/heads/master@{#28907}
-
bmeurer authored
Up until now we can only inline based on JSFunction, because of the way the deoptimization works. With this change we will be able to inline based on the SharedFunctionInfo and materialize the JSFunction from a literal or a stack slot when necessary. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1169103004 Cr-Commit-Position: refs/heads/master@{#28906}
-