- 21 Jan, 2019 12 commits
-
-
Peter Marshall authored
Simplify the internal state of Sampler a bit. There are basically two users of Sampler - the CpuSampler used by the CpuProfiler and the Ticker used by log.cc. Ticker calls Start/Stop to manage the Sampler lifetime, but CpuProfiler does not. This leads to much confusion and overlap of functionality. Fix that here by removing the distinction between active, registered and isProfiling states. These are now all the same thing and are represented by IsActive(). The state is set to active when Start is called, and set inactive when Stop is called. Both users of Sampler now call Start and Stop at appropriate times. The concept of profiling depth was not used - each Sampler would only ever have a sampling depth of 1. We still need to call SignalHandler::IncreaseSamplerCount(), so we do that in Start and the corresponding DecreaseSamplerCount() in Stop. Change-Id: I16a9435d26169a7dd00b1c7876e66af45f12e4b0 Reviewed-on: https://chromium-review.googlesource.com/c/1424337 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58955}
-
Toon Verwaest authored
Use variable tracking from ExpressionScopes rather than the PatternRewriter and PreParserExpression::variables_ to declare variables. We only figure out that variables are non-simple parameters once we see the first non-simple parameter. This still uses the pattern rewriter to make variables non-simple (kLet instead of kVar). Change-Id: I4a4ee4852d667c26806bb24896722cfea3e093f2 Reviewed-on: https://chromium-review.googlesource.com/c/1417630Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58954}
-
Camillo Bruni authored
Since the PreparseData now directly contains the byte data inline it can grow very large as well. Bug: chromium:923264 Change-Id: I456d5bcbfb40587b283584f726d9e084061fd30f Reviewed-on: https://chromium-review.googlesource.com/c/1421321Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58953}
-
Simon Zünd authored
This CL adds a stack check to the TFS builtin "FlattenIntoArray" as it is called recursively and can cause a SEGV with a large enough "depth" argument. R=jgruber@chromium.org Bug: v8:8708 Change-Id: I833506531bcff1c4703b9a21678028cf0e63638d Reviewed-on: https://chromium-review.googlesource.com/c/1424858 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58952}
-
Tamer Tas authored
With and without infra_staging flag testrunner behaves the same for old features. This CL removes duplicate tests testing the same behavior. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: v8:8174 Change-Id: Icf7bea15b2343b90697016d050fa0d918a99997d Reviewed-on: https://chromium-review.googlesource.com/c/1424859Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#58951}
-
Peter Marshall authored
There's no reason to use our self-baked atomics anymore. Also - Changes two boolean values to use a boolean instead of an int - Uses a unique ptr for data_ - Removes has_processing_thread_ which is not used - Moves most initialization inline into the class - Removes SetUp/TearDown which weren't needed Change-Id: I8f50133636961502d56351abd2fb17196603a01a Reviewed-on: https://chromium-review.googlesource.com/c/1422918 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58950}
-
Toon Verwaest authored
Bug: chromium:923723 Change-Id: Ic397642c2e803b2ada95fa87ece31032eb104782 Reviewed-on: https://chromium-review.googlesource.com/c/1424857 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58949}
-
Stephan Herhut authored
With this change, we use the same heuristics for picking free registers and for picking a blocked register to spill. This is mostly cleanup to make results less surprising. Change-Id: I09d031c758ffbd02798d573bc9e68a474e916418 Reviewed-on: https://chromium-review.googlesource.com/c/1411607 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58948}
-
peterwmwong authored
This is part of an effort to improve the performance of TA#subarray. Bug: v8:7161 Change-Id: Iae84d16a037386bebfeaa7e8fb0648da295653b4 Reviewed-on: https://chromium-review.googlesource.com/c/1419225 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58947}
-
Peter Marshall authored
Moved class definitions into header Change-Id: I2d3e5ec6f8f5068284cdbaa6900797950fc7e01a Reviewed-on: https://chromium-review.googlesource.com/c/1422739 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58946}
-
Peter Marshall authored
There is no reason to use the custom map here anymore. This lets us get rid of the custom hash and a lot of casts. We can also store the SamplerList by value in the map rather than a pointer, then we don't have to manage the lifetime explicitly. Also move the SamplerList typedef inside of SamplerManager because it's an internal detail. Remove the include for <map> because we aren't using this anywhere anyway. Change-Id: I787a1b6c3ffc331ec3f36e66d5e07bd115c4cbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1419317Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58945}
-
Tamer Tas authored
Moving to a lazy test loading approach makes counting the total number of tests non-trivial. For CI runs, we output the total number of tests after the run. For users, progress indicator signals the status of the run. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I0731964515aac60a3629acee6c7243433a2b4e04 Reviewed-on: https://chromium-review.googlesource.com/c/1420677 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58944}
-
- 20 Jan, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/213e0a3..402bc6d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If20446c4127d59fd9e7c5055c9594f4fae164d27 Reviewed-on: https://chromium-review.googlesource.com/c/1424278Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58943}
-
- 19 Jan, 2019 5 commits
-
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:922125 Change-Id: I58e6e2f3525293df0a6513611e16cd21b65e3985 Reviewed-on: https://chromium-review.googlesource.com/c/1418191 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58942}
-
Sven Sauleau authored
Fix WebAssembly's table/get-set js-api. The argument is a unsigned long, this change refactors most of arithmetic and bounds checks type from int64 to uint32_t, according to the spec. Bug: v8:8319 Change-Id: I088f631c6805b0e5ba29089b08ea15e78fe5852d Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/1414914Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Cr-Commit-Position: refs/heads/master@{#58941}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/43021de..213e0a3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/40194ab..2f02e1f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a0e5e33..fab27df Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/deab113..f797143 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d653014..07e7295 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9f413ce..3a16568 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia3a87da427e0efd4cc1fa4f43bd8672754f75d2f Reviewed-on: https://chromium-review.googlesource.com/c/1423326Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58940}
-
Frank Tang authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/af984c0..4f1155 Bug: v8:7834 Change-Id: I6eeff251b9a3a773b386d7963981dc72f48d6e44 Reviewed-on: https://chromium-review.googlesource.com/c/1423096Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58939}
-
Frank Tang authored
See https://github.com/tc39/proposal-intl-list-format/pull/36 Bug: v8:8614 Change-Id: Ifa9bebf27163420562c0d62867b9a240b5c4c502 Reviewed-on: https://chromium-review.googlesource.com/c/1386324 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58938}
-
- 18 Jan, 2019 22 commits
-
-
Peter Marshall authored
Use more idiomatic c++ and add slightly better comments. Change-Id: Id6397a25851915eb10a0370d23dc41ca7fce3c2e Reviewed-on: https://chromium-review.googlesource.com/c/1418194Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58937}
-
Sven Sauleau authored
Fix WebAssembly's table/grow js-api. The argument is a unsigned long, this change refactors most of arithmetic and bounds checks type from int64 to uint32_t, according to the spec. Bug: v8:8319 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: Ia29121c930d7fb930668e54a5a769dae25234f2c Reviewed-on: https://chromium-review.googlesource.com/c/1351006 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58936}
-
Adam Klein authored
Though I'm not (yet) a much of a wasm code expert, I have made and reviewed a number of changes to this file, and feel pretty comfortable with it, so I figured it might be reasonable starting place. Change-Id: I8d5d0b219def6adeba52e752467bb0405554ee01 Reviewed-on: https://chromium-review.googlesource.com/c/1418593Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58935}
-
Caitlin Potter authored
v8::Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy and v8::Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict are no longer incremented. BUG=v8:8175 R=gsathya@chromium.org, littledan@chromium.org Change-Id: Ia5f8f9226a54d88c15a3c3b4a5941d774eb1834a Reviewed-on: https://chromium-review.googlesource.com/c/1417381Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#58934}
-
Caitlin Potter authored
Turns on --harmony-hashbang when experimental JS features are enabled. BUG=v8:8523 R=gsathya@chromium.org, adamk@chromium.org Change-Id: I2b1e6c146d900cb8a998060b4b93127f907b6728 Reviewed-on: https://chromium-review.googlesource.com/c/1417382Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#58933}
-
Michael Achenbach authored
This reverts commit 4e1d7c87. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/14986 Original change's description: > [wasm] Split compilation in three stages > > In order to refactor ownership between objects in wasm compilation, the > compilation (executed by background tasks) is split in three stages: > getting a compilation unit (while holding a mutex), executing the work > (without any mutex and without keeping the NativeModule alive), and > submitting the work (with a mutex again). > > This CL prepares this design by splitting compilation from submission. > Both steps are still executed right after each other. This will be > changed in a follow-up CL. > > R=titzer@chromium.org > CC=mstarzinger@chromium.org > > Bug: v8:8689 > Change-Id: I2f92aee8e2f2d45470d8c63314ed026341630902 > Reviewed-on: https://chromium-review.googlesource.com/c/1414920 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58929} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: Ic3d0287b354ef5f834b76bc2cdc096d2231f4477 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8689 Reviewed-on: https://chromium-review.googlesource.com/c/1422917Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58932}
-
Michael Lippautz authored
- Introduce NodeSpace that holds allocation related logic. - Provide std compatible iterator for node iteration. This allows for creating a different internal node type. The change is just a refactoring without functional changes. Bug: chromium:923361 Change-Id: I424f821d96b3a82f64024aedff6c289d3eec11a2 Reviewed-on: https://chromium-review.googlesource.com/c/1418192 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58931}
-
tzik authored
As builtins no longer uses default_microtask_queue after https://crrev.com/c/1369906, Isolate's default_microtask_queue_address() is no longer needed. Bug: v8:8124 Change-Id: I1f51e58ada1a62f71f19f6c15b2330dfed176839 Reviewed-on: https://chromium-review.googlesource.com/c/1420178Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#58930}
-
Clemens Hammacher authored
In order to refactor ownership between objects in wasm compilation, the compilation (executed by background tasks) is split in three stages: getting a compilation unit (while holding a mutex), executing the work (without any mutex and without keeping the NativeModule alive), and submitting the work (with a mutex again). This CL prepares this design by splitting compilation from submission. Both steps are still executed right after each other. This will be changed in a follow-up CL. R=titzer@chromium.org CC=mstarzinger@chromium.org Bug: v8:8689 Change-Id: I2f92aee8e2f2d45470d8c63314ed026341630902 Reviewed-on: https://chromium-review.googlesource.com/c/1414920Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58929}
-
Tamer Tas authored
testrunner has tests asserting about the implementation details, assertions about the behavior of the testrunner (already in-place) provides robust coverage already. This cl remove the brittle assertions. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I6583c971b7cf7eb2eb7dfa2b6737d6aa67957feb Reviewed-on: https://chromium-review.googlesource.com/c/1421359 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58928}
-
Predrag Rudic authored
MIPS32 doesn't have constraint for maximum code range or maximum PC relative code range, and allocation of kMaxPCRelativeCodeRangeInMB memory results in OOM failure from allocator. This patch also skips verifying transitive builtins for 64-bit MIPS because it doesn't have implemented pc-relative calls and jumps yet. Change-Id: I7cad154827c2a9fd274901895a5a54c5ce176b03 Reviewed-on: https://chromium-review.googlesource.com/c/1414853Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#58927}
-
Camillo Bruni authored
By using a shared byte buffer on the preparser we can drastically reduce the number of ZoneChunkLists. Each PreparseDataBuilder now explicitly keeps track of all inner builders/functions and writes out the data in consecutive order. Change-Id: I0aada118d869b150108c1f633d9960474ad2f9a1 Reviewed-on: https://chromium-review.googlesource.com/c/1411600 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58926}
-
Clemens Hammacher authored
This reverts commit d5e63b03. Reason for revert: Fails gc-stress: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/5312 Original change's description: > Reland "[GC] Ensure JSFunctions with flushed bytecode are flushed during GC." > > This is a reland of f5729f1c > > TBR=ulan@chromium.org > > Original change's description: > > [GC] Ensure JSFunctions with flushed bytecode are flushed during GC. > > > > When bytecode is flushed from a SFI, the JSFunctions still retain their > > FeedbackVector's and point to the interpreter entry trampoline. They are > > reset if re-executed, however if not they could hold onto the feedback > > vector indefinetly. This CL adds a pass the GC to detect JSFunctions that > > need to be reset, and performs the reset at the end of GC. > > > > BUG=v8:8395 > > > > Change-Id: I3de8655aff9ff80f912b4fd51dee43eb98cfd519 > > Reviewed-on: https://chromium-review.googlesource.com/c/1393292 > > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58775} > > Bug: v8:8395 > Change-Id: I9bc84b62332575a080561c51f08b699b91e41e4a > Reviewed-on: https://chromium-review.googlesource.com/c/1414859 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58924} TBR=ulan@chromium.org,rmcilroy@chromium.org Change-Id: I5d3012d4c7277ae792b0488780ff426d51dd602f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8395 Reviewed-on: https://chromium-review.googlesource.com/c/1421838Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58925}
-
Ross McIlroy authored
This is a reland of f5729f1c TBR=ulan@chromium.org Original change's description: > [GC] Ensure JSFunctions with flushed bytecode are flushed during GC. > > When bytecode is flushed from a SFI, the JSFunctions still retain their > FeedbackVector's and point to the interpreter entry trampoline. They are > reset if re-executed, however if not they could hold onto the feedback > vector indefinetly. This CL adds a pass the GC to detect JSFunctions that > need to be reset, and performs the reset at the end of GC. > > BUG=v8:8395 > > Change-Id: I3de8655aff9ff80f912b4fd51dee43eb98cfd519 > Reviewed-on: https://chromium-review.googlesource.com/c/1393292 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58775} Bug: v8:8395 Change-Id: I9bc84b62332575a080561c51f08b699b91e41e4a Reviewed-on: https://chromium-review.googlesource.com/c/1414859 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58924}
-
Peter Marshall authored
We found the nexus 5x flake so this is no longer needed. Leave the printing functions themselves as they will still be useful for local debugging. Bug: v8:8649 Change-Id: Ie0af2bc9b0fc7fb8ac00ec0039b6898553865189 Reviewed-on: https://chromium-review.googlesource.com/c/1420957Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58923}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: Ieb677e0989f77ed207567d468faec0bf92752967 Reviewed-on: https://chromium-review.googlesource.com/c/1388529Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58922}
-
Ross McIlroy authored
If a function is classed as an IIFE it will be have different bytecode generated to reduce feedback vector overhead for run-once code. As a result, we need to retain this information if we are going to lazily compile the bytecode later in order to get the same result. This is necessary for lazy bytecode flushing and lazy source positions, both of which need to recompile functions which were previously compiled. BUG=v8:8395,v8:8510 Change-Id: Ib898868102610216315faa20c9da682f6c523390 Reviewed-on: https://chromium-review.googlesource.com/c/1417636 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#58921}
-
Georg Neis authored
Change-Id: I807581b0c058c304769d4ba1b4f9bc8a9739536f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1417633Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58920}
-
Ross McIlroy authored
BUG=v8:8395,v8:8510 Change-Id: I1571877d709d6cc37966ace9014fa327e0820a80 Reviewed-on: https://chromium-review.googlesource.com/c/1417634 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58919}
-
Michael Achenbach authored
The tests were skipped due to problems with the previous test setup. Now the setup is the same as in Chromium and those tests should pass. NOTRY=true Bug: chromium:828847 Change-Id: Ibfbb931031176add90a340ca79c71e89f05e3045 Reviewed-on: https://chromium-review.googlesource.com/c/1421318Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58918}
-
Andreas Haas authored
This test checks that the ModuleCompiledCallback is called eventually. R=clemensh@chromium.org CC=adamk@chromium.org Bug: v8:8677 Change-Id: I360f88064f870dd4a12db019e3c9f72154abf13b Reviewed-on: https://chromium-review.googlesource.com/c/1420759Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#58917}
-
Clemens Hammacher authored
The AsyncCompileJob should not cancel compilation if baseline compilation already finished. At that point, we might still be tiering up, and the module might even already be shared across isolates. R=titzer@chromium.org CC=ahaas@chromium.org Bug: v8:8677, v8:8689 Change-Id: Ia2192a1985bf4a3b7125ce5a713c83bbcc1bf6b7 Reviewed-on: https://chromium-review.googlesource.com/c/1417931 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#58916}
-