- 17 Dec, 2018 10 commits
-
-
Jakob Gruber authored
Compiled irregexp code should be cleared unless FunctionCodeHandling::kKeep is passed. Bug: v8:8572 Change-Id: Icb74cc6e0f39a69f8383b05f1638cf0e3be1807c Reviewed-on: https://chromium-review.googlesource.com/c/1373773 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58272}
-
Mythri authored
Bug: v8:8394 Change-Id: I3db77f090249251b9765ce869fd8268d43d8347c Reviewed-on: https://chromium-review.googlesource.com/c/1375663Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#58271}
-
Yang Guo authored
R=jgruber@chromium.org Bug: chromium:915435 Change-Id: Ic5535adb2aa09ffc72bf4e50ff8ec624dea1909e Reviewed-on: https://chromium-review.googlesource.com/c/1379932Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58270}
-
Jakob Kummerow authored
BreakPoint, BreakPointInfo, DebugInfo Bug: v8:3770 Change-Id: Ibad956b0933b5e994407475faaf4a8770e455318 Reviewed-on: https://chromium-review.googlesource.com/c/1377458 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 3ad101f5. Reason for revert: Broken Android Arm64 debug builder - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20debug%20builder/3089 Original change's description: > [assembler] Split out CPUFeatures into its own file > > This reduces the preprocessor expanded source size by 84,675 LoC: > > gen ( 20 files): 71,349 to 1,523,934 ( 21x) > src ( 624 files): 367,410 to 53,253,894 ( 145x) > test ( 392 files): 490,503 to 37,436,176 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,031 to 102,736,424 ( 87x) > > to > > gen ( 20 files): 71,349 to 1,523,794 ( 21x) > src ( 624 files): 367,411 to 53,186,896 ( 145x) > test ( 392 files): 490,504 to 37,418,639 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,033 to 102,651,749 ( 87x) > > > Change-Id: Ia8a79092051a42815b65e86a0784297915368c9b > Reviewed-on: https://chromium-review.googlesource.com/c/1291471 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58266} TBR=ulan@chromium.org,marja@chromium.org,sigurds@chromium.org,clemensh@chromium.org Change-Id: I111f9bbef9e66cd1ee7f4206b6af1097f7c50e66 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1379933Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58268}
-
Sigurd Schneider authored
Change-Id: I3530c3f50fdb805d68099108dc33d93abe6bdb39 Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1379931Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58267}
-
Sigurd Schneider authored
This reduces the preprocessor expanded source size by 84,675 LoC: gen ( 20 files): 71,349 to 1,523,934 ( 21x) src ( 624 files): 367,410 to 53,253,894 ( 145x) test ( 392 files): 490,503 to 37,436,176 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1520 files): 1,183,031 to 102,736,424 ( 87x) to gen ( 20 files): 71,349 to 1,523,794 ( 21x) src ( 624 files): 367,411 to 53,186,896 ( 145x) test ( 392 files): 490,504 to 37,418,639 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1520 files): 1,183,033 to 102,651,749 ( 87x) Change-Id: Ia8a79092051a42815b65e86a0784297915368c9b Reviewed-on: https://chromium-review.googlesource.com/c/1291471Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58266}
-
Yang Guo authored
This reverts commit dde25872. Reason for revert: GC-Stress failures https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23168 Original change's description: > [esnext] ship Object.fromEntries > > Enable --harmony-object-from-entries by default. > > Object.fromEntries is a new standard library method, whose proposal > (https://tc39.github.io/proposal-object-from-entries/) is currently > at stage 3. > > It simply creates a JSObject from an iterable collection of key/value > pairs, such that `Object.fromEntries([ [ "a", "b" ] ]) -> { a: "b" }` > > BUG=v8:8021 > R=gsathya@chromium.org, adamk@chromium.org > > Change-Id: Ib55bb6ca43727d66b471c0fd14845735c1ca2894 > Reviewed-on: https://chromium-review.googlesource.com/c/1373918 > Commit-Queue: Caitlin Potter <caitp@igalia.com> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58262} TBR=adamk@chromium.org,gsathya@chromium.org,caitp@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8021 Change-Id: Id9582e2710ee6b46be3fbac1cbafefd5c0151cd0 Reviewed-on: https://chromium-review.googlesource.com/c/1379871Reviewed-by:
-
Marja Hölttä authored
New API is here: https://github.com/tc39/proposal-weakrefs/issues/55 The WeakCell parts stay in the old API, resulting in temporary code duplication in some parts. Those parts will go away once the WeakCell-related parts are migrated to the new API (but the spec needs some work first). BUG=v8:8179 Change-Id: I81ca824a14d830e3c5fa515d5ad7e5f78c10e19d Reviewed-on: https://chromium-review.googlesource.com/c/1378171 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58264}
-
Sigurd Schneider authored
- Detect errors during generation of compile_commands.json and building the target 'v8_generated_cc_files'. - Change format of JSON output to have files as keys, which makes programmatic lookup by filename easier on the consumer side. Change-Id: Ibc3d9cff64f82df7a3dbb76cb8d914b29460a48c Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1362041Reviewed-by:
-
- 15 Dec, 2018 3 commits
-
-
Caitlin Potter authored
Enable --harmony-object-from-entries by default. Object.fromEntries is a new standard library method, whose proposal (https://tc39.github.io/proposal-object-from-entries/) is currently at stage 3. It simply creates a JSObject from an iterable collection of key/value pairs, such that `Object.fromEntries([ [ "a", "b" ] ]) -> { a: "b" }` BUG=v8:8021 R=gsathya@chromium.org, adamk@chromium.org Change-Id: Ib55bb6ca43727d66b471c0fd14845735c1ca2894 Reviewed-on: https://chromium-review.googlesource.com/c/1373918 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
-
Frank Tang authored
This reverts commit 7b744e3a. Reason for revert: Break V8 Linux64 ASAN Original change's description: > [Intl] Replace uloc_(to|for)Language w/ Locale API > > Bug: v8:8468 > Change-Id: Id2f8d165e5f29f429821b44def2512fe760c0a51 > Reviewed-on: https://chromium-review.googlesource.com/c/1377989 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58260} TBR=jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org Change-Id: I5d6069245f468f7ca5d99f2973bd53524e2d4782 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8468 Reviewed-on: https://chromium-review.googlesource.com/c/1378657Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58261}
-
Frank Tang authored
Bug: v8:8468 Change-Id: Id2f8d165e5f29f429821b44def2512fe760c0a51 Reviewed-on: https://chromium-review.googlesource.com/c/1377989Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
- 14 Dec, 2018 27 commits
-
-
Jakob Kummerow authored
AsyncGeneratorRequest, DataHandler, LoadHandler, StoreHandler Bug: v8:3770 Change-Id: I71198f9af116d2ca37bbe47131ae73b6ae643e01 Reviewed-on: https://chromium-review.googlesource.com/c/1377457 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58259}
-
Frank Tang authored
Bug: v8:7482 Change-Id: Icd3383e350555907c01ec65d2620477973117ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1368864Reviewed-by:
-
Jakob Kummerow authored
https://chromium-review.googlesource.com/c/v8/v8/+/1377455 and https://chromium-review.googlesource.com/c/v8/v8/+/1363143 passed the commit queue individually, but need a one-line adaptation in order to work together. TBR=jgruber@chromium.org No-Tree-Checks: true No-Try: true Change-Id: Id04344f1440ffa797ca852aff63acbbcbe57065c Reviewed-on: https://chromium-review.googlesource.com/c/1378690 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58257}
-
Jakob Kummerow authored
AsmWasmData, WasmDebugInfo, WasmExceptionTag, WasmExportedFunctionData Bug: v8:3770 Change-Id: I0343daaa10bdb9dfaba07f28051821077703a106 Reviewed-on: https://chromium-review.googlesource.com/c/1377456 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#58256}
-
Jakob Kummerow authored
AllocationMemento, AllocationSite, ArrayBoilerplateDescription Bug: v8:3770 Change-Id: I0081d222c73d9d66ba35ae28e73b6388e4e58ac0 Reviewed-on: https://chromium-review.googlesource.com/c/1377455 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
AccessCheckInfo, AccessorInfo, AccessorPair, AliasedArgumentsEntry Bug: v8:3770 Change-Id: I4bc3aebae2637daa4b0066d3946f1bfae8055f84 Reviewed-on: https://chromium-review.googlesource.com/c/1377454 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Daniel Clifford authored
In the process, add the bint type (which stands for Best-INTeger), which implements Torque's idea of CSA's ParameterMode. It maps to a different type on 32-bit (Smi) and 64-bit (intptr). There are convert operators that are either no-ops or conversions to-and-from Smi and intptrs on the each platform, depending on the underlying type for bint. This allows Torque code to git most of the benefits of ParameterMode without having to explicitly pass around the mode, since it is almost always OptimalMode anyways. Change-Id: I92e08adc1d79cb3e24576c96f9734aec1af54162 Reviewed-on: https://chromium-review.googlesource.com/c/1361160 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58253}
-
Jakob Kummerow authored
in preparation for incrementally transitioning their subclasses. Bug: v8:3770 Change-Id: I5ed6adb1969bc1ec7125571fea443834ca255c22 Reviewed-on: https://chromium-review.googlesource.com/c/1377453 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58252}
-
Jakob Kummerow authored
along with subclasses: Tuple2, Tuple3, FeedbackCell, AccessorPair. The latter two can be separated out later if desired. Bug: v8:5402 Change-Id: I4e1a6d2621cc6f96b5da208cff0da7cd5de91672 Reviewed-on: https://chromium-review.googlesource.com/c/1371038Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58251}
-
peterwmwong authored
Enable --harmony-string-matchall by default. String.prototype.matchAll behaves similarly to String.prototype.match, but returns a full regexp result object for each match in a global or sticky regexp. This offers a simple way to iterate over matches when access to e.g. capture groups is needed. const string = 'a b c'; const regex = /[ac]/g; for (const match of string.matchAll(regex)) { console.log(`${match[0]} at ${match.index}`); } // a at 0 // c at 4 More information can be found here: https://github.com/tc39/proposal-string-matchall Drive-by: Update debug evaluate side effect expectations to handle String.p.matchAll and RegExp.p[@@matchAll] Bug: v8:6890 Change-Id: Ie3e712af66689936b7d2a15df705b792ccf06bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1377774Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
tzik authored
For builtins-mips64.cc, add a static cast to resolve the ambiguity of "0" around Operand(int64_t) and Operand(const char*). For mips{,64}/macro-assembler-mips{,64}.cc, remove extra references to masm. Change-Id: I9ce94c682c64b48501386029a912b0f5e32e268d Reviewed-on: https://chromium-review.googlesource.com/c/1378365Reviewed-by: -
Jeremy Roman authored
Also fail early if we detect that we've previously run out of memory and thus corrupted the buffer. Add a unit test for this kind of case. Bug: chromium:914731 Change-Id: Iaaf3927209bffeab6fe8ba462d9dd9dad8cbbe2f Reviewed-on: https://chromium-review.googlesource.com/c/1377449Reviewed-by:
-
Predrag Rudic authored
Compiler didn't know whether to choose definition of Operand method with pointer argument or integer argument defined in src/mips64/assembler-mips64.h Change-Id: I0887df6ce7aa6ba6be166d415b1b5574368b3a4a Reviewed-on: https://chromium-review.googlesource.com/c/1378180Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#58247}
-
Ross McIlroy authored
BUG=v8:8293 Change-Id: Ic2424d55ad04f5a92953c2c6d639ed8178a628b4 Reviewed-on: https://chromium-review.googlesource.com/c/1373779Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58246}
-
Jakob Gruber authored
In preparation for upcoming work on Torque function pointers. This table will be used to look up the entry address in order to call there directly without going through the (on-heap) trampoline. Bug: v8:7777 Change-Id: If713430c843e85371a5aaef8a3bfb5da9e0ea903 Reviewed-on: https://chromium-review.googlesource.com/c/1378172Reviewed-by:
-
Clemens Hammacher authored
The vector of callbacks can only be accessed from main threads. Otherwise we get flaky data races. Those showed up after removing the finisher task (https://crrev.com/c/1335553/2). R=mstarzinger@chromium.org Bug: v8:7921 Change-Id: I0429ae87427601952723f6e3ad1e02eb0e59a6e1 Reviewed-on: https://chromium-review.googlesource.com/c/1378174 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tamer Tas authored
R=machenbach@chromium.org CC=yangguo@chromium.org Bug: v8:8491 Change-Id: I8379825c194e588da582a3000201eea75b59140a Reviewed-on: https://chromium-review.googlesource.com/c/1371826 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58243}
-
Yang Guo authored
This ensures that we have a clean slate when updating to newer V8. TBR=machenbach@chromium.org Bug: v8:8584 Change-Id: I37f6e4a42738e5e9ea5bfdca5465d6a3e984fe65 Reviewed-on: https://chromium-review.googlesource.com/c/1378169Reviewed-by:
-
Clemens Hammacher authored
Avoid the indirection via the signature, instead specialize per signature. On a microbenchmark run locally, this speeds up Liftoff by ~5% and validation by ~15%. R=titzer@chromium.org Bug: v8:8423 Change-Id: Ia0e9ab0dcaa759e4ed4dcd46d2e6f16e65790915 Reviewed-on: https://chromium-review.googlesource.com/c/1373778Reviewed-by:
-
peterwmwong authored
Incremental step towards the removal of JS Natives. This CL Moves the initialization of InternalPackedArray functions and prototype out of prologue.js and into bootstrapper. Bug: v8:7624 Change-Id: I7a2a1afbd1721ddc9bc9ac677c03f0817e4f1418 Reviewed-on: https://chromium-review.googlesource.com/c/1374995Reviewed-by:
-
Camillo Bruni authored
Do not set the name property on any function or classes. This is not required as per spec #sec-__proto__-property-names-in-object-initializers. Bug: v8:7773 Change-Id: Iade96573690e5b14b60434c37683f782cf9cb2cb Reviewed-on: https://chromium-review.googlesource.com/c/1375912Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58239}
-
Clemens Hammacher authored
When selecting the frame above the V8_Dcheck method (at the DCHECK location), it helps enormously to immediately see the error message generated by the DCHECK. This extends the dcheck_stop_handler to find and print this message. Drive-by: Speed up the handler by stopping after the first V8_Dcheck frame. R=mstarzinger@chromium.org Bug: v8:8562 Change-Id: If3a8f3aaab6a0014006ccac7260f37d5d90363c5 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1378170Reviewed-by:
-
Alessandro Pignotti authored
ProtectedLoad/ProtectedStore opcodes are used in WebAssembly to represent memory accesses. Since they are not part of the allowed opcodes in OwnedByAddressingOperand it is not possible to take advantage of addressing modes to encode common patterns for the pointer input value. R=jarin@chromium.org Bug: v8:8508 Change-Id: Ic62bf13fed7b1d86afb112d9aa59cd7073a28e72 Reviewed-on: https://chromium-review.googlesource.com/c/1354458 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Maya Lekova authored
Remove a DCHECK that got triggered in the rare condition that GC kicks in during CompilationDependencies::Commit, changing the pretenuring decision, thus leading to deoptimization. To make sure this rare case is properly handled, add a new FLAG_pretenure_during_compilation and a cctest that simulates it predictably. R=jarin@chromium.org,mvstanton@chromium.org Bug: v8:8520 Change-Id: If83f8a3d4659a694357b3869c931c7d7c164fd1a Reviewed-on: https://chromium-review.googlesource.com/c/1363143 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#58236}
-
Stephan Herhut authored
Now, we also print the fixed ranges, which are used to model fixed register constraints. Change-Id: Ife25529c911eaf950a33a4c099636a8f8925308e Reviewed-on: https://chromium-review.googlesource.com/c/1375913Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#58235}
-
Jakob Kummerow authored
The new ObjectPtr design makes non-inlined helper functions a little more expensive because "this" is always a pointer where pass-by-value would be more efficient, which is an issue for functions whose size puts them right at the threshold of getting inlined or not. String::Get falls into this category when called from RegExpFlagsFromString. In this case, we can do even better than restoring inlineability by fine-tuning the control flow a bit. This should repair the regression in crbug.com/910573 Bug: chromium:910573 Change-Id: Ie6b68ef01cd978ec502d8d6c1da788c77422dce7 Reviewed-on: https://chromium-review.googlesource.com/c/1369087 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Frank Tang authored
Add bit flags to remember hourCycle Reorder the code in JSDateTimeFormat::Initialize Implement the hourCycle option resolutions Fix intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle in test262 Bug: v8:7482 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Idc136276da89b95df6ae864161b114e34f9dcae8 Reviewed-on: https://chromium-review.googlesource.com/c/1253101 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
