- 29 Mar, 2019 3 commits
-
-
Jaroslav Sevcik authored
In reducers, we should avoid reductions of the form ReduceWithValue(node, replacement) return Replace(node) because such reduction does not kill the original node, so it may become subject to resurrection from some side table (in the bug referenced below it was load elimination's side table). Instead, we should use ReduceWithValue(node, replacement) return Replace(replacement) Bug: chromium:945644 Change-Id: Id210efe0d214a53241392d30b7f0eee8e7515e2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545229Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60517}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/adf96bc..a525b65 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/466efc7..eda23ac Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6d6a48a..aab7e31 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/51c0f38..803c869 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/b66b4e0..40cc341 Rolling v8/third_party/protobuf: https://chromium.googlesource.com/external/github.com/google/protobuf/+log/bdeb215..b68a347 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/39afd62..adc6ac4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia3bc8391b9cc96488e21bbd5482ac2c983578f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545091Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60516}
-
Frank Tang authored
For intl_datetime_style DesignDoc: https://goo.gl/v7n7zV Test: test/intl/date-format/constructor-date-time-style.js test/intl/date-format/constructor-date-time-style-order.js test/intl/date-format/property-override-date-time-style.js test/intl/date-format/constructor-date-style-order.js test/intl/date-format/property-override-date-style.js test/intl/date-format/constructor-time-style-order.js test/intl/date-format/property-override-time-style.js For intl_bigint Test: test/intl/bigint/tolocalestring.js https://www.chromestatus.com/feature/5742274625404928 chromium src/v8/test/intl/date-format/constructor-no-style-order.js Bug: v8:8699,v8:8702 Change-Id: Ide331e3571d5f6c230fe29b24bf6cced351cba49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541449Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60515}
-
- 28 Mar, 2019 18 commits
-
-
Maciej Goszczycki authored
Change-Id: I6c1a2edcee54993cd73e211de8271ea6b6c42ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543732 Auto-Submit: Maciej Goszczycki <goszczycki@google.com> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#60514}
-
Simon Zünd authored
This reverts commit 3bd49f9b. Reason for revert: Build failure on Win Bot Original change's description: > [torque] Throw exception instead of aborting if something goes wrong > > This CL enables exceptions for the Torque compiler and Torque language > server. Instead of aborting when something goes wrong during > compilation, a TorqueError is thrown, containing the error message > and a source position. The compiler executable still prints the error > and aborts, while the language server will pass this information > along to the client (not included in this CL). > > R=danno@chromium.org > > Bug: v8:8880 > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003 > Reviewed-by: Daniel Clifford <danno@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60512} TBR=danno@chromium.org,mvstanton@chromium.org,szuend@chromium.org Change-Id: Iac253da404eaf6e534267f59a42ca93667c205e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8880 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543849Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60513}
-
Simon Zünd authored
This CL enables exceptions for the Torque compiler and Torque language server. Instead of aborting when something goes wrong during compilation, a TorqueError is thrown, containing the error message and a source position. The compiler executable still prints the error and aborts, while the language server will pass this information along to the client (not included in this CL). R=danno@chromium.org Bug: v8:8880 Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60512}
-
Andreas Haas authored
R=clemensh@chromium.org Change-Id: I3bcac024578eeb556a5422d10c86843be17f5782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543355Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60511}
-
Sven Sauleau authored
This CL splits a specific test out the bigint.js test suite in order to be, eventually, ignored by the wasm-bigint proposal 32-bit support CL. Change-Id: I8ab673abfb53bac95952b11716fe4f29a4a7feaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543352 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60510}
-
Clemens Hammacher authored
Instead of reporting kB/s as documented, we were computing bytes/us, i.e. MB/s, hence mostly reporting 0. This CL fixes this and renames the variables to make the units more obvious. R=titzer@chromium.org Bug: v8:8975 Change-Id: I0177a8631cc600ab1369657318944f9a215486ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543351Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60509}
-
Clemens Hammacher authored
This reverts commit e3be96d6. Reason for revert: Fails on ia32: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/31041 Original change's description: > [liftoff] Introduce emit_{i64,i32}_add with immediate > > This allows immediates to be encoded directly into instructions, rather than > mov-ing constants to registers first. > > This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once > this approach has been approved. > > Bug: v8:9038 > > Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60506} TBR=clemensh@chromium.org,martyn.capewell@arm.com,joey.gouly@arm.com Change-Id: I131b13dc7178e31919fc2fffacec72c0697d93a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543354Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60508}
-
Pierre Langlois authored
This is a reland of 93716b9e Original change's description: > [snapshot] Add support for native counters. > > Counters in generated code, as enabled with --native-code-counters, do not work > in the snapshot. This adds a `v8_enable_snapshot_code_counters` build option > enabled by defaut in debug mode that allows code from the snapshot to increment > the current isolate's set of counters. > > For this to work, we need to add native code counters in the external reference > table. > > To keep the no snapshot configuration similar, we've also enabled the > --native-code-counters flag by default for debug builds. > > Change-Id: I4478b79858c9b04f57e06e7ec67449e9e3a76f53 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528998 > Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60495} Change-Id: Ib6427caf068ca196a032e3f3b97d9f9219e0fe60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543349Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#60507}
-
Joey Gouly authored
This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Bug: v8:9038 Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60506}
-
Clemens Hammacher authored
When switching from atomicops to std::atomic, I introduced a bug that makes us miss the actual peak memory consumption, and only report the second-highest memory usage in each zone. This CL fixes that. R=petermarshall@chromium.org Bug: chromium:939724 Change-Id: I3db8eeb9719eb026cf6b4a9690c702cbc4c11bd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541227Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60505}
-
Dan Elphick authored
Previously when lazy source positions were enabled, source positions were immediately collected whenever an exception was thrown for every frame in the stack trace. This change makes source position collection trigger only when the source positions of a stack frame are actually accessed with the exception of the top frame which is still eagerly collected for now. Additionally when stack overflows occur during source position collection, the bytecode is marked with exception in the source_position_table field so it can be distinguished from the case where source position collection has never been attempted (undefined) or is not desired because the bytecode is for natives (empty_byte_array). Bug: v8:8510 Change-Id: If7ee68edbacc9e2adadf00fe5ec822a8dbe1c79a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520721Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#60504}
-
Mythri A authored
test/mjsunit/elements-kind.js calls %NeverOptimizeFunction followed by %OptimizeFunctionOnNextCall later. If NeverOptimize marker is set, the funciton would not be optimized even when requested through %OptimizeFunctionOnNextCall Change-Id: I37307fee7afd083953699026a82bbf12c85581ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533865 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#60503}
-
Peter Marshall authored
This adds dependencies on Perfetto and Protobuf and the required configs to build them. The build configs are behind a gn flag (v8_use_perfetto) and are disabled by default. Actual implementation of Perfetto will follow. Based on Primiano's prototype: https://chromium-review.googlesource.com/c/v8/v8/+/1290549 Bug: v8:8339 TBR: yangguo@chromium.org Change-Id: I2b7462d567bfb0a5a3ffbbb8b6fcbf41c824e285 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1517876Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60502}
-
Jaroslav Sevcik authored
Currently, we are flushing current allocation group state on loop entry. With this CL, we only flush the state for loops that can allocate. Non-allocating loop will preserve the state. This enables more optimization opportunities for write barrier elimination and allocation folding. Unforutnately, the optimization will only trigger for compiler-introduced loops - user loops always contain stack check (which can allocate). Bug: v8:8984 Change-Id: I5a47accec92455f4aabb0129800773596712029a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541043Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60501}
-
Michael Achenbach authored
This reverts commit 93716b9e. Reason for revert: Breaks asan debug: https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Mac64%20ASAN%20-%20debug%20builder/7872 https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20ASAN%20-%20debug%20builder/7874 Original change's description: > [snapshot] Add support for native counters. > > Counters in generated code, as enabled with --native-code-counters, do not work > in the snapshot. This adds a `v8_enable_snapshot_code_counters` build option > enabled by defaut in debug mode that allows code from the snapshot to increment > the current isolate's set of counters. > > For this to work, we need to add native code counters in the external reference > table. > > To keep the no snapshot configuration similar, we've also enabled the > --native-code-counters flag by default for debug builds. > > Change-Id: I4478b79858c9b04f57e06e7ec67449e9e3a76f53 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528998 > Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60495} TBR=sigurds@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,pierre.langlois@arm.com Change-Id: I93f1ed714e3dcd309f3100685e4bd282db471d46 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543209Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60500}
-
tzik authored
A microtask requires a non-detached Context to trigger, and the Context is usually pulled from the primary handler. On an example below, |on_rejected| is primary, as the attached promise is rejected and |on_rejected| will be called as the reaction. Promise.reject().then(on_fulfilled, on_rejected); If the primary handler is undefined or invalid, we used to use the promise's context as the fallback. E.g. the primary handler is undefined on the examlpe below, and the context of |promise| was used. let promise = Promise.reject(); promise.then(on_fulfilled); However, that causes a non-intuitive behavior around a detached context: let DeadPromise = iframe.contentWindow.Promise; iframe.src = "http://example.com"; // navigate away. // DeadPromise's Context is detached state now. let p = DeadPromise.reject(); // |on_rejected| is called, as the context is pulled from |on_rejected|. p.then(on_fulfilled, on_rejected); // |on_rejected| was NOT called, as a microtask to settle |q| does not // run due to the detached context. let q = p.then(on_fulfilled); q.catch(on_rejected); After this CL, we use non-primary handler as a source of fallback context. On the last example above, the Context is pulled from |on_fullfilled|, so that |q| is settled using that context. Bug: chromium:941271 Change-Id: Iff71acf7c3617f3493d100abcd2c5c36bd1bbfd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535916Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#60499}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/d51ec1b..4406612 [test] Check for "unreachable" consistently (#992) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/4406612 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ib25b56bc297e47a8a35ba868707d9c689f71d79c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541451Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60498}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5256fba..adf96bc Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/d09c967..466efc7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2b058ca..6d6a48a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c74cce1..51c0f38 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e0abf7a..39afd62 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1b59b6b9931362db3ab9600dbd9b795f2363cacc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541450Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60497}
-
- 27 Mar, 2019 18 commits
-
-
Z Duong Nguyen-Huu authored
Bug: v8:8952 Change-Id: I74eaa1148116dfc8d6720e8be4f59ce90c8df164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524664Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60496}
-
Pierre Langlois authored
Counters in generated code, as enabled with --native-code-counters, do not work in the snapshot. This adds a `v8_enable_snapshot_code_counters` build option enabled by defaut in debug mode that allows code from the snapshot to increment the current isolate's set of counters. For this to work, we need to add native code counters in the external reference table. To keep the no snapshot configuration similar, we've also enabled the --native-code-counters flag by default for debug builds. Change-Id: I4478b79858c9b04f57e06e7ec67449e9e3a76f53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528998 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60495}
-
Ben L. Titzer authored
R=mstarzinger@chromium.org BUG=chromium:944945 Change-Id: I9cd83118fd27556197bfd5c4597b4678fc97ee32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541479Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60494}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I2fe68c54e59fd452ee724ce7fbd80eca6ab5e096 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541106 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60493}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I3a939d65ec8468f034d4670d9b14a911e5ef5a61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541044Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60492}
-
Clemens Hammacher authored
{WasmInstanceObject} is a {JSObject}, so it can have user-defined properties and elements. DebugPrint should include them. R=titzer@chromium.org Change-Id: Id787fc2d40c256a0287aea69353066c6fd920a56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541236Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60491}
-
Igor Sheludko authored
Tbr: jgruber@chromium.org Bug: chromium:944971 Change-Id: I2dcbfae638848c11eac4e262c3d636f33c3f24a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541477 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60490}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ib775ce8ab450ad42a342a40c660230c091e4f41d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541053 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60489}
-
Clemens Hammacher authored
The elements of a {WasmInstanceObject} were not visited during GC, leading to crashes when using them later. This CL fixes this by visiting the whole {JSObject} header, consisting of properties and elements. R=titzer@chromium.org Bug: chromium:839919, chromium:946350 Change-Id: I070fb3e6a7fd87a7288fc68b284100a2f9c72e9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541237 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60488}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I851e9a18eab0812e009d323cd98814bebc83f003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541047 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60487}
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ia789e21ac9324fca77f559a88180fadd97491a91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541050 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60486}
-
Junliang Yan authored
regress-crbug-178790 test can cause overflow on debug mode Drive-by: clean up simulator skiped tests Change-Id: Iec6151518fe1814e8eefcaaf09439782a2d29426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539791 Auto-Submit: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60485}
-
Z Duong Nguyen-Huu authored
This cover all test files under mjsunit/compiler/array-* Bug: v8:6831 Change-Id: I7a5632ccb3895a6e23ebfb92598dd1939de133b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1531030 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60484}
-
Tomasz Moniuszko authored
Windows.h defines GetMessage macro which clashes with MessageHandler::GetMessage. The problem arises when icu_util.cc is included before messages.cc in the same jumbo file. win32-headers.h defines NOUSER before including windows.h. This prevents GetMessage from being defined. Bug: v8:9042 Change-Id: I174eae5036ed2134b210d628fd2a97718db816d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539838Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#60483}
-
Michael Achenbach authored
NOTRY=true Change-Id: I40ef00c7c2886f356de9f0caa667f453b63b7637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539837Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60482}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/aee5bb4..5256fba Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/31e0bb5..d09c967 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/4daecde..955113d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/85ead57..2b058ca Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e17d1ed..c74cce1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/23688af..e0abf7a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5a9ea4b5f86dddf8cbee9cdc9dd6460409065f33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1540381Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60481}
-
Bill Budge authored
- Fixes a bug where signaling NaNs are converted to Infinities rather than quiet NaNs. Bug: v8:6020,v8:8639 Change-Id: I2601378f06f1987983f2b93e8970f401333073be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536911 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60480}
-
Milad Farazmand authored
Port: 7629afdb Original Commit Message: Allocate feedback vectors lazily when the function's interrupt budget has reached a specified threshold. This cl introduces a new field in the ClosureFeedbackCellArray to track the interrupt budget for allocating feedback vectors. Using the interrupt budget on the bytecode array could cause problems when there are closures across native contexts and we may delay allocating feedback vectors in one of them causing unexpected performance cliffs. In the long term we may want to remove interrupt budget from bytecode array and use context specific budget for tiering up decisions as well. Change-Id: I261a7f7cedbdaa3be2d0cf22bfa701598f749fd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539794Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60479}
-
- 26 Mar, 2019 1 commit
-
-
Deepti Gandluri authored
Change-Id: Ibe60c5025a25b353e6661576872a8fda1aeef5de Bug: v8:9014 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536986Reviewed-by: Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60478}
-