- 28 Aug, 2018 11 commits
-
-
Ross McIlroy authored
Creating a runtime call stats table for each worker thread task is expensive. Instead we create a single table per thread, and use TLS to get the correct one when starting a worker thread task. In order to correctly initialize the parser, scanner and parse-info's runtime call stats fields, we move creation of the scanner and parser onto the background tasks for BackgroundCompileTask and UnoptimizedCompilationJob. Change-Id: I36064c7fb43290968620b1985cc02637b16f4232 Reviewed-on: https://chromium-review.googlesource.com/1187522Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55448}
-
Hai Dang authored
This fixes the wrong JSON data that was not updated by CL 1188572. Change-Id: I8cf1a040fa7faa95b967f8dc995b8222304f5514 Reviewed-on: https://chromium-review.googlesource.com/1193244Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#55447}
-
Michael Achenbach authored
TBR=delphick@chromium.org NOTRY=true Bug: v8:8058 Change-Id: I7ae59067672a295fb61195ac65226c8cd138d7b9 Reviewed-on: https://chromium-review.googlesource.com/1193284Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55446}
-
Toon Verwaest authored
Change-Id: I331ff09ee06db39e2ca051db0a91823f5b8fb402 Reviewed-on: https://chromium-review.googlesource.com/1193262Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#55445}
-
Ross McIlroy authored
Currently chunked and streaming character streams don't have cloning support as this requires additional changes on the Blink side. BUG=v8:8041 Change-Id: I167b3b1cd5ae1ac4038f3715b6a679d3e65d9a85 Reviewed-on: https://chromium-review.googlesource.com/1183429Reviewed-by:
-
Georg Neis authored
Change-Id: Ib967337b140594e70307348e6989b1324a62d71e Reviewed-on: https://chromium-review.googlesource.com/1186641Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions BUG=v8:8091 Change-Id: If811fdffe31df3ca94c70ff910603fab8d7e1ad4 Reviewed-on: https://chromium-review.googlesource.com/1190303 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55442}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I9642f37f3dae3f9c07661ddca1a981e223148e49 Reviewed-on: https://chromium-review.googlesource.com/1192842Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55441}
-
Maya Lekova authored
This change allows passing no context to NewConsString, since it's not used anyway. Change-Id: I125e1dca90ff1b8d1c8695d5b688e8ff4e075044 Reviewed-on: https://chromium-review.googlesource.com/1190602 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55440}
-
Lei Zhang authored
In the logic to run tests on Android, the path is currently relative. This only works when V8 is standalone. When V8 is checkout in another project, the path is wrong. The build_with_chromium check only helps with Chromium, but there are other V8 embedders. Change-Id: I52640a664deb39e5959ed3cc9dc79fd7b6d68758 Reviewed-on: https://chromium-review.googlesource.com/1189096Reviewed-by:
-
Junliang Yan authored
Change-Id: I14a3a1d1da983528601fcd595d7e9ea820ae9d12 Reviewed-on: https://chromium-review.googlesource.com/1191822Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55438}
-
- 27 Aug, 2018 17 commits
-
-
Sathya Gunasekaran authored
The spec specifies that search and standard can not be valid values for the collation extension keyword. Instead users are expected to use the options bag to set the correct usage options. But, ICU expects the usage option to be set through the collation extension value. In this patch, we set the usage option using the collation extension value in ICU. For resolvedOptions, we filter out this extension value using ICU to be spec compatible. Previously, we stored the usage option on the JSCollator instance. But this patch changes the logic to just look it up from the icu::Collator when required. This saves one word of memory. This fails a test262 that was incorrectly fixed. A follow on patch will fix the test262 test. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8c66c6286287e686f4cd152fa1301f9d51c38654 Reviewed-on: https://chromium-review.googlesource.com/1180488Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55437}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I67e15208bc2954957275e3283eb746c1c12f10f0 Reviewed-on: https://chromium-review.googlesource.com/1191362Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#55436}
-
Junliang Yan authored
This reverts commit b8705eb6. Reason for revert: bf1e47e6 is reverted. Original change's description: > PPC64/s390x: move smi to lower 32-bit > > Change-Id: Id203bb297547002a41e18d621b59ce4237f88e5a > Reviewed-on: https://chromium-review.googlesource.com/1183976 > Reviewed-by: Muntasir Mallick <mmallick@ca.ibm.com> > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#55320} TBR=jyan@ca.ibm.com,joransiu@ca.ibm.com,mmallick@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ied4e7b0cd0659b5429906d1d90c91397fa268416 Reviewed-on: https://chromium-review.googlesource.com/1191162Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55435}
-
Brian Stell authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5f6adec8857398f82598295e86d2559c96363647 Bug: v8:7955, v8:7869, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5f6adec8857398f82598295e86d2559c96363647 Reviewed-on: https://chromium-review.googlesource.com/1184046 Commit-Queue: Brian Stell <bstell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#55434}
-
Toon Verwaest authored
Change-Id: I1551da2cbd5cbd6e0cdf86837a01c84217a648b6 Reviewed-on: https://chromium-review.googlesource.com/1190783Reviewed-by:
-
Benoît Lizé authored
"short" external strings are not short, they mean that the external data pointer is not cached. Rename the various classes and objects to align with the actual meaning. Bug: chromium:877044 Change-Id: Ie3d5baa9ad352ac6ca89f5ba1d066760825e4beb Reviewed-on: https://chromium-review.googlesource.com/1185192Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55432}
-
Toon Verwaest authored
Change-Id: I254c2d911af5f389a68dd0f349d5a27a4a8cca54 Reviewed-on: https://chromium-review.googlesource.com/1190742Reviewed-by:
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: chromium:877964 Change-Id: Ia7ea1094ea339f6e956cb7241f7d35913b7821b2 Reviewed-on: https://chromium-review.googlesource.com/1190502Reviewed-by:
-
Andreas Haas authored
{Isolate::Deinit} waits for all created {OptimizingCompiler::CompileTask}s to finish. However, these CompileTasks run in the background and can be blocked by other tasks which run in the background, e.g. WebAssembly compilation tasks. With this CL we stop WebAssembly compilation tasks before we wait for the {optimizingCompiler:::CompileTask}s. R=mstarzinger@chromium.org CC=jarin@chromium.org Change-Id: I1549c1babdebc2e951aef5e48d0aa8130884fb7d Reviewed-on: https://chromium-review.googlesource.com/1190302Reviewed-by: -
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: v8:5918 Change-Id: I6fc16e3c6415246072b7626bdfd13ea0b7ce2dc2 Reviewed-on: https://chromium-review.googlesource.com/1189983Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55428}
-
Peter Marshall authored
This reverts commit 133a6815. Reason for revert: Regresses parsing time Original change's description: > [cleanup] Replace ZoneList with ZoneVector for parser reported_errors_ > > We use a ZoneVector because we do a fair amount of random access e.g. > in ExpressionClassifier::Accumulate() so the vector is better suited > than ZoneChunkList as it has constant time random access. > > Bug: v8:6333 > Change-Id: I83e1de60ee8fe319cfa5ce77fc5f5f86beb5307d > Reviewed-on: https://chromium-review.googlesource.com/1054672 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55315} TBR=neis@chromium.org,petermarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6333 Change-Id: Ib89f0aa1f27b7d6dbbf21af60ed7d1bcd2c0b7d3 Reviewed-on: https://chromium-review.googlesource.com/1189803Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55427}
-
Bret Sepulveda authored
This patch disables the conditions that cause the test to flake, but as a band-aid that doesn't fix the underlying issue. Bug: v8:8084 Change-Id: I46380d0ce4f450c176583330ed760bc3b57b9edc Reviewed-on: https://chromium-review.googlesource.com/1189822Reviewed-by:
-
Michael Achenbach authored
This is for temporarily testing if those bots work as expected on V8 CQ. They'll be afterwards added only on demand on presubmit for API changes. NOTRY=true TBR=delphick@chromium.org Bug: v8:8058 Change-Id: I841539a899f2987914588b2f84d402e3403bb41e Reviewed-on: https://chromium-review.googlesource.com/1189942 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org Change-Id: I904de575c8c049de64111c12b940c48a50090668 Reviewed-on: https://chromium-review.googlesource.com/1186338 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL changes a constant pool test to include tests for the marker and the encoded pool size. Change-Id: Ia5cfd173e5d523a02252fd3b14f302e5c8994881 Reviewed-on: https://chromium-review.googlesource.com/1186626Reviewed-by:
-
Hai Dang authored
With warmup and/or longer runs, the benchmark results are more reliable. This CL also splits the benchmark into smaller ones for easier management. Change-Id: Ieba0734bef841d131b3184938109ca179994e173 Reviewed-on: https://chromium-review.googlesource.com/1188572Reviewed-by:
-
Ujjwal Sharma authored
https://chromium-review.googlesource.com/c/v8/v8/+/1178763 added DateTimeFormat.prototype.format to the C++ side of things, removing the need for the runtime function, but the function wasn't removed. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie73fefb5477dfb7f04a4f8852e086a92332c05fc Reviewed-on: https://chromium-review.googlesource.com/1189502 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
- 26 Aug, 2018 2 commits
-
-
Sigurd Schneider authored
NOTRY=true NOTREECHECKS=true TBR=mslekova@chromium.org Change-Id: I92373d44389d34e3249757639a9f0c4f1c8ce03f Reviewed-on: https://chromium-review.googlesource.com/1189362 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/03bbc87..dd6b994 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7b7eb88..2d0e03c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6a9b88a4fe1b419fdca0f57848b680aea861a1e7 Reviewed-on: https://chromium-review.googlesource.com/1189423 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55419}
-
- 25 Aug, 2018 3 commits
-
-
Ujjwal Sharma authored
This increases the size of a V8BreakIterator instance by a word to store the adopt text function. The instance to be bound is stored on the context of this builtin function. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I466ead6c8fc9d531d2213cfdd488fa1484496f69 Reviewed-on: https://chromium-review.googlesource.com/1186925 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f4d0db4..03bbc87 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1e44d06..bc2c0a9 Rolling v8/third_party/proguard: https://chromium.googlesource.com/chromium/src/third_party/proguard/+log/67ad7bd..a3729be Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b31d680..bb4146f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic17addf2ee4ca056eae0c741edbe5483c9de8e8a Reviewed-on: https://chromium-review.googlesource.com/1189092Reviewed-by:
-
Deepti Gandluri authored
- Implement all the I64Atomic operations on ARM - Change assembler methods to use Registers instead of memory operands - Move atomics64 test up be tested on all archs, disable tests on MIPS BUG:v8:6532 Change-Id: I91bd42fa819f194be15c719266c36230f9c65db8 Reviewed-on: https://chromium-review.googlesource.com/1180211 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#55416}
-
- 24 Aug, 2018 7 commits
-
-
Frank Tang authored
This is a reland of 2dc505a4 Original change's description: > [Intl] remove unused js > > Bug: v8:8066 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9d86577540cf227e038354d9661c60fcdc644b3f > Reviewed-on: https://chromium-review.googlesource.com/1179467 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55200} Bug: v8:8066 Change-Id: Id1f63c2e9c855250a7af01c1e0877296c0320d20 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1185762 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Georg Neis authored
If maxLength is larger than String::kMaxLength, we used to throw immediately. However, we must first look at the filler argument, which is observable. Moreover, if the filler is empty, we must return the input unchanged. Bug: v8:8078 Change-Id: Ic3d135f9e25da56df45b059144e45e19dda9c3d8 Reviewed-on: https://chromium-review.googlesource.com/1188313 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cbc08db..f4d0db4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f62079a..1e44d06 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd765da..7b7eb88 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/454f3b2..3ec92c8 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/297a4dd..a191af9 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/323cf32..d8cf40c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/45de59d..b31d680 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If5e7643d5977ee2c837677dc8fa73b1c0608be36 Reviewed-on: https://chromium-review.googlesource.com/1188526 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Ali Ijaz Sheikh authored
ASAN complained about this on another commit: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20ASAN/26688 causing revert: https://chromium-review.googlesource.com/c/v8/v8/+/1162122 Change-Id: I3bb16177be9d49496db024ce92fd4354b12d8cc3 Reviewed-on: https://chromium-review.googlesource.com/1187832Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#55412}
-
Dan Elphick authored
This doubles the size of the snapshot since it creates all of the handlers twice (and it doesn't use any of these new ones). However it's all behind a flag. For now all bytecode handlers are marked as being not Isolate independent to prevent snapshot creation failures. Bug: v8:8068 Change-Id: Id49f521445643d9fc6b141353f0a29b585160e10 Reviewed-on: https://chromium-review.googlesource.com/1185100 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55411}
-
Michael Starzinger authored
R=sigurds@chromium.org TEST=mjsunit/wasm/module-memory Change-Id: I30b52a09d8655340199dc449aaa91e6a351e2111 Reviewed-on: https://chromium-review.googlesource.com/1188567Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55410}
-
Hai Dang authored
In the case where the array is a fast packed array, the CSA no longer needs to check whether the prototype has elements. This only needed when the array is holey. This is a follow-up of CL #1183671. Change-Id: I0087b827200995c741141f3183bf9a2c748d3b55 Reviewed-on: https://chromium-review.googlesource.com/1188315Reviewed-by:
-
