- 01 Apr, 2021 18 commits
-
-
Ng Zhi An authored
Bug: v8:11589 Change-Id: I3d5c72105d682913e192bcec340f16267b5707d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797543Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73778}
-
Ng Zhi An authored
Mostly a port of changes from chromium to support building from directories other than out/Release or out/Debug. Also moved tools/ninja/ninja_output.py to tools/vim/ninja_output.py to be more consistent with chromium's layout. Change-Id: I73199f10e48b6d9a229bef6af14b84b1ae6be1c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797536Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73777}
-
Milad Fa authored
Change-Id: If3bcdafa9be33065b96bb5737b69a095ccdba559 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799932Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73776}
-
Igor Sheludko authored
... in CallBoundFunction builtin. Bug: chromium:1194358 Change-Id: I8ddd4fff39cf399d4af332cff8eddc40e217cfdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2800111 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73775}
-
Junliang Yan authored
Change-Id: I92cb514b6ed09d1e691b78abe64066f95f5394ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797285 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73774}
-
Jakob Gruber authored
It's locked exclusively in the MapUpdater API methods, and locked shared in ComputePropertyAccessInfo (CPAI). This lock is a step towards running CPAI on background threads. The simple lock portion is landed separately in this CL to get an early signal on potential lock overhead perf impact. The lock is implemented and used very conservatively at the moment: - it's a single global lock (and not e.g. per-map). - it's locked for the entire method call duration (instead of only in relevant parts). Both points can potentially be improved in the future. Bug: v8:7790 Change-Id: I073423497e01b4901101973387a19962f953a576 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797286Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73773}
-
Jakob Gruber authored
This fixes a bug introduced in crrev.com/c/2660995. String.prototype.indexOf must clamp the `position` argument as per step: 7. Let start be the result of clamping pos between 0 and len. Source: tc39.es/ecma262/#sec-string.prototype.indexof Previously, this was done in the StringIndexOf builtin, but the recent refactor changed builtin implementations to match the spec more closely (i.e. to clamp in String.prototype.indexOf, not StringIndexOf). This means we now have to clamp in JSCallReducer::ReduceStringPrototypeIndexOf. Tbr: neis@chromium.org Bug: chromium:1194869 Change-Id: I5af8d41b50f4905453f03079e3ee6d46186536db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799359Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Main change: Remove CALL_INTERFACE macro. Use CALL_INTERFACE_IF_REACHABLE or invoke interface directly instead. Reasoning: Interfaces assume the Decoder is in a non-error state, therefore CALL_INTERFACE invoked DCHECK(this->ok()). However, CALL_INTERFACE (1) was sometimes erroneously called with an error in the decoder, especially in cases where the error occurred inside immediate argument parsing, (2) was always called in contexts where the current control was guaranteed to be reachable. Due to (1) and (2), CALL_INTERFACE is equivalent to CALL_INTERFACE_IF_REACHABLE (there are a few exceptions where we can call the interface directly). Additional change: - Rename current_code_reachable_ to current_code_reachable_and_ok_ to make its name reflect its meaning better. Bug: chromium:1194784 Change-Id: I52055161a802e6981506b2a8dc8bb8233198aa2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799351 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73771}
-
Jakob Gruber authored
.. and enable it on fyi bots. Skip one test in this variant due to incompatible flags. Bug: v8:7790 Change-Id: I5b8fdd8572435c6f4474c505464ff1a22c830757 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797287 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73770}
-
Igor Sheludko authored
... for primitive receivers. We should use initial map taken from constructor function as a prototype chain lookup root instead of the receiver map. Bug: v8:11248 Change-Id: I91fde2f1102029654c7fdd8890d265ae8bad2791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797281Reviewed-by:
-
Georg Neis authored
It printed the pointer instead of the block and when run from gdb the output was swallowed because there was no newline. Change-Id: I55cdd3c791ff639d5b81e480aef77ac211490f77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799357 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#73768}
-
Georg Neis authored
Bug: v8:11604 Change-Id: Ic4aa3ae64aa9c9a60aceade9072a5ead1c894b7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799356 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Backes authored
That test is already slow on non-tsan bots, and we do not need TSan coverage here. Thus keep it skipped, but update the comment. R=mslekova@chromium.org Fixed: v8:11610 No-Try: true Change-Id: I1dedcc7b4d5736aca7c4cc0dc0526e4df7502440 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797290Reviewed-by:
-
Sam Parker authored
Introduce two machine nodes for FABD and fold Float32/64 Abs,Sub during instruction selection. This gives ~1% speed improvement of the Bullet physics engine compiled as wasm. Change-Id: Ifd985538e6ebb280bc0eaf11b0ebfc687891cf91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786854Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#73765}
-
Thibaud Michaud authored
Check directly whether there is runtime support for traps instead of encoding this in the trap ID. For OOB traps we always use the actual trap ID, so we always emitted the code that assumes runtime support, which is not true in some cctests. R=ahaas@chromium.org Bug: v8:11587 Change-Id: I29df463561bcfb3452e75b209a70c4f4d9941044 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797289Reviewed-by:
-
Leszek Swirski authored
This is a reland of e70cbb83 Moved the ConsString comparison logic out-of-line, both to make gcc happy, and to reduce the size of the fast-path in IsEqualToImpl. Original change's description: > [string] Fix non-SeqStrings in IsEqualTo > > Bug: chromium:1193903 > Change-Id: I80704dd3cba5754779432356b20bd3ea99630291 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794426 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73746} Bug: chromium:1193903 Change-Id: Iae6f078853438427e86d3ac68bcfed0712a85bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797288 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Assembler::EmitVeneers has potential quadratic behavior, which appears as hangs on chromecrash (see the linked bug). We iterate a list of branches (unresolved_branches_), and for each branch iterate yet another list of branches (the label link list in RemoveBranchFromLabelLinkChain). Ordering decisions increase the problem, by iterating in the outer loop in ascending pc offset order, and in the inner loop (which removes the branch from the linked list) in descending order. This CL mostly refactors the outer loop: - Instead of iterating over the whole unresolved_branches_ list, iterate only the relevant part. - Call RemoveBranchFromLabelLinkChain in descending pc offset order. - Keep veneer emission in ascending pc offset order. Bug: chromium:1162080 Change-Id: I77bb3d961c1b19ef1c31e777b640b213869bc1d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794435 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d01f8cf..b962cf8 Rolling v8/third_party/aemu-linux-x64: 2zvSiyDoNIOA05-NfIzaaqrW2-5iI24Lkw3TJ8uGtFAC..WdwDIQC1_Ug_YFwjZ39W0oe0J4kXmVVQJba0vkkqNmsC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1178627..da171bf Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f2cfd3d..053a717 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ddfad9c..15a4172 Rolling v8/tools/luci-go: git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a..git_revision:34ae8f13bb2156451655ec53b360942a502469df Rolling v8/tools/luci-go: git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a..git_revision:34ae8f13bb2156451655ec53b360942a502469df Rolling v8/tools/luci-go: git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a..git_revision:34ae8f13bb2156451655ec53b360942a502469df TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d229d890ade0268e5e37fd2b61635d8dcad3a46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2798974Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73761}
-
- 31 Mar, 2021 22 commits
-
-
Marja Hölttä authored
Bug: chromium:1194026 Change-Id: I3f92b6b36279cc71b97df20ce5a8b4c8ec2b6b8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794436Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#73760}
-
Shu-yu Guo authored
This is a reland of de5f8614 Original change's description: > [atomics] Fix critical section for Atomics.waitAsync > > Loading the value at the index for the futex wait should be protected by > the waiterlist mutex for both sync and async waits. > TBR=marja@chromium.org Bug: chromium:1194026 Change-Id: Id495a7778adf23a7d9dcd80f58179fe8d22fde2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2798511Reviewed-by:
-
Milad Fa authored
Change-Id: Icec47ff9263368a0f061e71648e99ffbe5f1a0ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2798214Reviewed-by:
-
Junliang Yan authored
Change-Id: I1cd09c6743d1b94686140bf3cfe942fc87df2ee0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2798213Reviewed-by:
-
Camillo Bruni authored
Bug: v8:11263 Change-Id: I2261d31c491c809599c787e7edbc18ba55c0f14e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797282Reviewed-by:
-
Shu-yu Guo authored
This reverts commit de5f8614. Reason for revert: TSAN https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/b8851216731882090320/overview Original change's description: > [atomics] Fix critical section for Atomics.waitAsync > > Loading the value at the index for the futex wait should be protected by > the waiterlist mutex for both sync and async waits. > > Bug: chromium:1194026 > Change-Id: Ie9896cab6828763ebb963f5ad96f264d57c9377f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796159 > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73753} Bug: chromium:1194026 Change-Id: I63d5e224f11a35fd9c36d62d08ce642d3e6f64bf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797550 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73755}
-
Camillo Bruni authored
Bug: v8:11263 Change-Id: Ia98fc29c52e68ba3a7dcdcdc1a06ce1192b10f93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2787487Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73754}
-
Shu-yu Guo authored
Loading the value at the index for the futex wait should be protected by the waiterlist mutex for both sync and async waits. Bug: chromium:1194026 Change-Id: Ie9896cab6828763ebb963f5ad96f264d57c9377f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796159 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73753}
-
Junliang Yan authored
Change-Id: I26d6aae68a66c7d21dce91354e8288cde7cf73d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797279Reviewed-by:
-
Suraj Sharma authored
This CL replicates the logic in chromium.src to support timestampcounter. Based on: https://chromium-review.googlesource.com/c/chromium/src/+/1413055 Change-Id: I3a64d53f64d3850831ac3ff983daa8ebef1cb29c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2789013Reviewed-by:
-
Ng Zhi An authored
Move the helper class and some function definitions into SharedTurboAssembler. We leave most of the other function definitions inside of macro-assembler-x64, and will move them later. Also move i16x8.ext_mul high as a check that this code movement works. Bug: v8:11589 Change-Id: I8ec1fa24cb93b4c4c8bd936a9df06cbf5328374f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2792080Reviewed-by:
-
Bill Budge authored
This reverts commit e70cbb83. Reason for revert: Breaks compile on gcc. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20gcc/11148 Original change's description: > [string] Fix non-SeqStrings in IsEqualTo > > Bug: chromium:1193903 > Change-Id: I80704dd3cba5754779432356b20bd3ea99630291 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794426 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73746} Bug: chromium:1193903 Change-Id: If700cdc7cf8b50a9430d17489485769cb524efd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797539 Auto-Submit: Bill Budge <bbudge@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73749}
-
Sami Kyostila authored
The trace_event_common.h header file isn't used with Perfetto any longer, so avoid adding a dependency to it from cppgc. Additionally v8_tracing should be a public dependency so that any public headers exposed from the target can also include tracing-related headers. Bug: chromium:1006541 Change-Id: Ia3d48a8dad83df2ff3ea1ce36344dbb70ea83709 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797278 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73748}
-
Junliang Yan authored
Change-Id: I530bd6fc7bf6db32e209b8d180ed1dc8254e6812 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794429 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:1193903 Change-Id: I80704dd3cba5754779432356b20bd3ea99630291 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794426 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Frank Emrich authored
This CL is part of a series that implements Turbofan support for property accesses satisfying the following conditions: 1. The holder is a dictionary mode object. 2. The holder is a prototype. 3. The access is a load. This feature will only be enabled if the build flag v8_dict_property_const_tracking is set. This particular CL modifies existing mjsunit tests whose assumptions don't hold if v8_dict_property_const_tracking is enabled. This is done by adding special handling for the case that %IsDictPropertyConstTrackingEnabled() holds. Bug: v8:11248 Change-Id: Ia36be73e4659a988b2471f0c8151b0442f3a98f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2780292 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Tianping Yang authored
Bug: v8:11607 Change-Id: If997ed1ec6a250b197ed994a6d0e6013fbec4b2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796911Reviewed-by:
-
Manos Koukoutos authored
Due to immutable loads being placed earlier during scheduling and subsequently being spilled, the safepoint table of a function may grow significantly. Until we implement an optimization to avoid spilling in such cases, we disable immutable loads for tagged values. Bug: chromium:1191540, v8:11510 Change-Id: Ia5c5d274e6d4b9145cd028828f9a328a65bed17f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796953 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
We need to exit before FallThruTo invokes DCHECK(this->ok()). Bug: chromium:1194316 Change-Id: I77eb58cbe232277cc8fc3cc0d1c327d7eba8bfb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796954Reviewed-by:
-
Junliang Yan authored
Change-Id: Ie55b1100f58f50d6361773e969ac91862e1f26fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2797251Reviewed-by:
-
Igor Sheludko authored
This is a reland of 856e8577 The diff compared to the first attempt is that the tests that require SSSE3/AVX are not run when these CPU features are not available. Original change's description: > [dict-proto] SIMD support for SwissNameDictionary in Torque > > This CL adds a Torque-counterpart for swiss_table::GroupSse2Impl in > Torque. This allows the Torque version of SwissNameDictionary to use > SSE for lookups, rather than needing to bailout to the runtime on > x64/ia32. > > Bug: v8:11330 > Change-Id: I74e3f97c460a8b89031016967ec0e545265016a9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2787485 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73727} Bug: v8:11330 Cq-Include-Trybots: luci.v8.try:v8_linux_optional_rel_ng Change-Id: Ibfa5ae5a39333778ea0d0406d5ea4ad683ad0dbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794431Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
We didn't have enough scratch registers for a suspend generator whose field write offsets exceeded the immediate value range. Bug: v8:11420, chromium:1193493 Change-Id: Iee90db4ef1ec00924bcc4791a8e6ffb9138bb388 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794424 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73739}
-
