- 18 Mar, 2019 37 commits
-
-
Sathya Gunasekaran authored
This implements the behavior discussed and specified here: https://github.com/tc39/ecma262/issues/1461 https://github.com/tc39/ecma262/pull/1470 As part of making this change, I realized that we didn't actually toggle the behavior between the optimized and unoptimized version based on the --harmony-await-optimization flag at all and just the unoptimized version by default. This patch removes the unoptimized version and uses the optimized version as the default. The other builtins that use this flag are not touched as part of this CL, they will be updated separately. Bug: v8:8998 Change-Id: I315e1b39dda91d0127b5e567986485d713eaa78d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525872 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60310}
-
Andrew Comminos authored
Consumers can use this to derive the full stack from sampled leaf nodes without having to flatten the tree. Bug: v8:8999 Change-Id: I42c638dd2c757837b0c03514c204be0182653291 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525877Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60309}
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: I9fd2353a3120c6d1566c1f74a581d005fd34ddae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528438Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60308}
-
Z Duong Nguyen-Huu authored
Bug: v8:8952 Change-Id: I07b3491e644634f9712e89d1566718084a3686d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518812Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60307}
-
Pierre Langlois authored
Bug: v8:7327 Change-Id: I2a140cf79d3be83a34401f5e4a8033fd9d89568b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526011 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60306}
-
Sigurd Schneider authored
Change-Id: I8fee653d2e331c2e796115b4cb88a2138e456177 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528730Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60305}
-
Sigurd Schneider authored
This helper can lower a parallel move a,b <- c,d for registers where the sets {a,b} and {c,d} overlap. Change-Id: I3c6ab20c075847d43628c5fd77851a3e614849c5 Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528533 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: -
Michael Lippautz authored
Bug: chromium:923361, v8:8834 Change-Id: I46b6ad9eaa86476963a4e2cb3a5712447f180c20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528235 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60303}
-
Clemens Hammacher authored
Even in streaming mode we want to generate deterministic compile errors, in particular they should contain the function name. This CL adds a test to check that the name is present in the error message even if the blob containing the function names is not present at the time the compile error is detected. R=ahaas@chromium.org Bug: v8:8814 Change-Id: I17eb1b3bca48ee2b58b462089c140c30a3511be8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526001 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60302}
-
Georg Neis authored
There were four places where we did essentially the same steps in order to extract the initial map for inlining a JSCreate operation. This CL creates a function on NodeProperties for this task. As a side effect, this fixes a bug in ReduceJSCreateArray, where has_initial_map could get called when it wasn't permissible to do so. Notes: For simplicity, in one or two places where we used to get the target/newtarget constants from the types we now get them from HeapConstant nodes. Cosmetic change: rename "receiver_map" to the more accurate "root_map" in JSNativeContextSpecialization::ExtractReceiverMaps. Bug: chromium:939316 Change-Id: I8fd9eb50993be3d839ab9b18eeea28184c53eabf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528435 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60301}
-
Mike Stanton authored
Caused by CL: "[TurboFan] Array.prototype.map wrong ElementsKind for output array." NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: Ibaedc9f91e3fbac4900eda6277c98a094daf90b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528532 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#60300}
-
Frederik Gossen authored
Implements decoding of compilation hints section in {ModuleDecoderImpl}. The {wasm-module-builder.js} supports the creation of that section. The feature can be enabled with {--experimental-wasm-compilation-hints}. Bug: v8:9003 Change-Id: Ic87e19d916f2ce316de453ea8c7c48c236a6d673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521115Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Frederik Gossen <frgossen@google.com> Cr-Commit-Position: refs/heads/master@{#60299}
-
Ulan Degenbaev authored
This reverts commit 8f1c985c. Reason for revert: breaks mkgrokdump Original change's description: > [heap] Reduce page size to 256KB > > The page size of PPC is kept unchanged because PPC has larger > physical pages (64KB). > > Bug: chromium:852420 > > Change-Id: Ib888ea00a476ff103e00211dbb439186148ef81e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1481631 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#60296} TBR=ulan@chromium.org,hpayer@chromium.org,jyan@ca.ibm.com Change-Id: I16175bea8845ac5d16dd43af1add4f2d9e94debc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528247Reviewed-by:
-
Simon Zünd authored
The serialize set of microbenchmarks serializes Error.stack of a prepared set of error objects. When all objects have been serialized, the benchmark then wrapped around and only accessed the resulting string properties. This, of course, is a lot faster and benchmark results are heavily fluctuating when the end is reached. This CL fixes this by introducing a payload that should be similiar to the specific workload, which is executed after the end is reached. R=petermarshall@chromium.org Bug: v8:8742 Change-Id: I7183d04e7c06af0c16fe3412e902f0d33605bc25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524485Reviewed-by:
-
Ulan Degenbaev authored
The page size of PPC is kept unchanged because PPC has larger physical pages (64KB). Bug: chromium:852420 Change-Id: Ib888ea00a476ff103e00211dbb439186148ef81e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1481631 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60296}
-
Michael Achenbach authored
Change-Id: I49aecc92054bb959278c46393ea2e5a4da262064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528241Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60295}
-
Milad Farazmand authored
The next built-in function throws a "StopIteration" when iterator is exhausted which will crash and stop the test runner. Asking it to return a "None" instead will fix the issue. Change-Id: I3ca4ff8f28f359798c9faf6f1ffbbaa6bb95f156 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524719 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Maciej Goszczycki authored
Change-Id: I626340e61e9c1a46e0d1c882cc4fa86454d93e8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526013 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60293}
-
peterwmwong authored
Bug: v8:8996 Change-Id: I035c380768c324d8912aa8bc414d533dbf7f3e5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524640 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:939316 Change-Id: I2a132b6cce208e110fe30de8d75743ac7534fc94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525942 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:8834 Change-Id: Ib6f8e8fbc571b51fdfbb389d9fc7a38c60208c1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528432Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:923361, v8:8834 Change-Id: I6ec42aeb74bea5c0629fcdc3f95c125f5de534a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526195 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Matheus Marchini authored
On LoadCodeObjectEntry check for IsOffHeapTrampoline instead of BuiltinIndexOffset so LoadCodeObjectEntry can correctly jump to the on-heap trampoline when we use --interpreted-frames-native-stack. R=jgruber@chromium.org, yangguo@google.com Bug: v8:8911 Change-Id: I172d4735671726d32328de246990b513106e3a7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516692 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Async compilation introduces nondeterminism, thus disable it for foozzie. R=ahaas@chromium.org, machenbach@chromium.org Bug: v8:8949, chromium:942941 Change-Id: Ieeb92c530de299cdd34f0d9cc3a1293b2dc5e139 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526194Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Andreas Haas authored
Clients of the code-assembler.h shouldn't depend on lots of compiler internals. Do not include anything from src/compiler there! R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Ie6f66af47153fad0b95c53d4d9cb03b95d3501fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526196Reviewed-by:
-
Simon Zünd authored
Bug: v8:8834 Change-Id: I8e53e9288491a5eb50e9f27e95a6b40747e718ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526198Reviewed-by:
-
Yu Yin authored
Change-Id: I1a30de8d889c60c59b6ef38a13f19f1fb7268622 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524756Reviewed-by:
-
Igor Sheludko authored
This reverts commit 68612784. Reason for revert: I'll follow Jakob's suggestion and fix unaligned accesses in C++ with ReadUnalignedValue(). Original change's description: > [build] Suppress UBSan alignment checks in pointer compression > > It is a design decision of pointer compression to allow unaligned pointers, > so disable this check in UBSan. > > Bug: v8:7703 > Change-Id: I3fab34e77ad755cdef3cd385a3615e3d0e350c16 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523346 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60235} TBR=jkummerow@chromium.org,machenbach@chromium.org,leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: I17e669e7b5e2dea8f0686911730d27f3d2732b85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526200Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60283}
-
Mike Stanton authored
Bug: chromium:941743 Change-Id: Ic8f72bb39be43096373407ef0ec99391bbee217f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526018Reviewed-by:
-
Andreas Haas authored
Anyfunc globals are very similar to anyref globals. This CL is mostly about extending the conditions which guard the anyref globals code. R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ia92ac4560102cc3ed0060342f92758db28f415ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526004Reviewed-by:
-
Andreas Haas authored
R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ica85ba80c29d6d5c5b9163df8cf743c0f1da7f4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520715 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit acadb202. Reason for revert: chromium:941952 Original change's description: > [turbofan] add fast path for String.p.startsWith > > Add a fast path for String.p.startsWith(str) when length of str is 1. > > Bug: v8:8400 > Change-Id: I65e657549902dc3ad064a213d815dd098ce6455f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491872 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60091} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400 Change-Id: Iabd66b8db0d6958686ea15a042d8567955700c9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524205 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This was always the intended behavior: when --embedded-variant is not passed, we should assume "Default". What actually happened in this case was that we'd initialize to nullptr. This CL adds the missing nullptr check. Bug: v8:6666 Change-Id: I87247c6c6cfec20da86d2714732a2f6044bb9b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526193 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 6d209c9b. Reason for revert: chromium:941952 Original change's description: > [turbofan] add CheckSmi call to String.p.startsWith > > Add a CheckSmi call to the value of the position argument to > String.prototype.startsWith(search, [position]). > > Bug: v8:8400, chromium:939746 > Change-Id: I7462bebe0d3fde605a4c27a34c0d9bb3f0cc1c20 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514198 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60216} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400, chromium:939746 Change-Id: Ifee58b9e57313bbf93bca293e92d88af279a0261 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524204 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 4925495c. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20nosnap%20-%20shared/32627 https://ci.chromium.org/p/v8/builders/ci/V8%20Win64/29699 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..c899486 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..efe902b > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I439f9415dd63820d8f665550a5ff89372e8620c3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527555 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60274} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I62fa43fc614c1b1dffd841aa22a7a590c3a63cd1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528232Reviewed-by:
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: I8569f99d498b79d943c1c178eafea48629d68fc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526017Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..c899486 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..efe902b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I439f9415dd63820d8f665550a5ff89372e8620c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60274}
-
- 16 Mar, 2019 3 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ae9325..e8b8ab7 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c79f348..a14f996 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8e2315..4e9bccd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/04600b4..24b5f90 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icfe9aaa08e5ab196c1ce375a9fbfc753a44ccc8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526729Reviewed-by:
-
Michael Achenbach authored
This ports: https://crrev.com/c/1519726 TBR=tmrts@chromium.org Bug: chromium:930050 Change-Id: I3afcfd28e8fdd5b97946e327997a58a488d4f1a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526014Reviewed-by:
-
Alexei Filippov authored
This is a reland of 5a61630d Original change's description: > [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > BUG=v8:8988 > > Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60227} TBR=dgozman@chromium.org Bug: v8:8988 Change-Id: I9b1db01856a43636c1eb8ad2ec36e3727353228d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524668 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60271}
-
